hash_mapper 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4ccb1b38f4a738cf5b7f1a147cc998463f14246e
-  data.tar.gz: bb40000c4e4f03cc7cda222bea3f9182189e7faf
+  metadata.gz: 29ee490afe5327d30e8b443a75e6d53350bd0aa3
+  data.tar.gz: 41d646013d75a9c396d2c85bb3b81f81fe334c21
 SHA512:
-  metadata.gz: 71dc27f23fae5c544caa5389fd7a31c1ae0bd04cfa84b007dfc18197f4dbee1349cbd7d677d59e8420505dcd2fa4c981f4c792429580fe05b656f9fad2046dc5
-  data.tar.gz: 68946b78bc3dc7dd2d0b7d287649125b63bb0ffb5f357fddac4cbd48fd1c944b1b7f3880813d0cce8d73b05605e49c8e19e47cec72acb6c9513a8cdf2b5ee596
+  metadata.gz: eae5a131bb3b95cbd4e98c771cac9ccaabb0c418356af67600f3135963add58bb8500d733db5c4b8ae74aea8035734e4c052eabb8c621a2cb09bd634669c267f
+  data.tar.gz: 55bbbfa2ab380e946631bbe2a58253e3d762fdea0ed737ea771cde35a72844aa06ef4015d161e762c9da19730652eb003cbc92aa1e38a5c4a8c0d1c2bdee5954

data/README.md

@@ -1,3 +1,5 @@
+[ ![Codeship Status for ismasan/hash_mapper](https://www.codeship.io/projects/85d172c0-4668-0132-e925-7a7d3d72b19b/status)](https://www.codeship.io/projects/45296)
+
 # hash_mapper
 
 * http://ismasan.github.com/hash_mapper/
@@ -146,7 +148,7 @@ Do this:
 
 ```ruby
 map from('/names'), to('/user') do |names|
-  "Mr. #{names[1]}, #{names[0]}"
+  "Mr. #{names[:last]}, #{names[:first]}"
 end
 ```
 
@@ -282,6 +284,8 @@ end
 Important: note that for before filters, you need to return the (modified) input, and for after filters, you need to return the output.
 Note also that 'output' is correct at the time of the filter, i.e. before_normalize yields 'output' as an empty hash, while after_normalize yields it as an already normalized hash.
 
+It is possible to define multiple filters of a given type. These are run in the order in which they are defined. A common use case might be to define a `before_normalize` filter in a parent class and a child class. The output from the previous invocation of the filter is passed as the input of the next invocation.
+
    
 ## REQUIREMENTS:
 

data/lib/hash_mapper/version.rb

@@ -1,3 +1,3 @@
 module HashMapper
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/hash_mapper.rb

@@ -42,8 +42,15 @@ module HashMapper
 
   def self.extended(base)
     base.class_eval do
-      class_attribute :maps
+      class_attribute :maps, :before_normalize_filters,
+        :before_denormalize_filters, :after_normalize_filters,
+        :after_denormalize_filters
+
       self.maps = []
+      self.before_normalize_filters = []
+      self.before_denormalize_filters = []
+      self.after_normalize_filters = []
+      self.after_denormalize_filters = []
     end
   end
 
@@ -75,38 +82,40 @@ module HashMapper
   end
 
   def before_normalize(&blk)
-    @before_normalize = blk
+    self.before_normalize_filters = self.before_normalize_filters + [blk]
   end
 
   def before_denormalize(&blk)
-    @before_denormalize = blk
+    self.before_denormalize_filters = self.before_denormalize_filters + [blk]
   end
 
   def after_normalize(&blk)
-    @after_normalize = blk
+    self.after_normalize_filters = self.after_normalize_filters + [blk]
   end
 
   def after_denormalize(&blk)
-    @after_denormalize = blk
+    self.after_denormalize_filters = self.after_denormalize_filters + [blk]
   end
 
   protected
 
-
   def perform_hash_mapping(a_hash, meth)
     output = {}
-    # Before filter
-    before_filter = instance_eval "@before_#{meth}"
-    a_hash = before_filter.call(a_hash, output) if before_filter
+
+    # Before filters
+    a_hash = self.send(:"before_#{meth}_filters").inject(a_hash) do |memo, filter|
+      filter.call(memo, output)
+    end
+
     # Do the mapping
     self.maps.each do |m|
       m.process_into(output, a_hash, meth)
     end
-    # After filter
-    after_filter = instance_eval "@after_#{meth}"
-    output = after_filter.call(a_hash, output) if after_filter
-    # Return
-    output
+
+    # After filters
+    self.send(:"after_#{meth}_filters").inject(output) do |memo, filter|
+      filter.call(a_hash, memo)
+    end
   end
 
   # Contains PathMaps

data/spec/hash_mapper_spec.rb

@@ -447,3 +447,119 @@ describe "default values" do
       }).should == { not_defaulted: 'some_value', defaulted: false }
   end
 end
+
+class MultiBeforeFilter
+  extend HashMapper
+
+  before_normalize do |input, output|
+    input[:foo] << 'Y'
+    input
+  end
+
+  before_normalize do |input, output|
+    input[:foo] << 'Z'
+    input
+  end
+
+  before_denormalize do |input, output|
+    input[:bar].prepend('A')
+    input
+  end
+
+  before_denormalize do |input, output|
+    input[:bar].prepend('B')
+    input
+  end
+
+  map from('/foo'), to('bar')
+end
+
+class MultiBeforeFilterSubclass < MultiBeforeFilter
+  before_normalize do |input, output|
+    input[:foo] << '!'
+    input
+  end
+
+  before_denormalize do |input, output|
+    input[:bar].prepend('C')
+    input
+  end
+end
+
+describe 'multiple before filters' do
+  it 'runs before_normalize filters in the order they are defined' do
+    MultiBeforeFilter.normalize({ foo: 'X' }).should == { bar: 'XYZ' }
+  end
+
+  it 'runs before_denormalize filters in the order they are defined' do
+    MultiBeforeFilter.denormalize({ bar: 'X' }).should == { foo: 'BAX' }
+  end
+
+  context 'when the filters are spread across classes' do
+    it 'runs before_normalize filters in the order they are defined' do
+      MultiBeforeFilterSubclass.normalize({ foo: 'X' }).should == { bar: 'XYZ!' }
+    end
+
+    it 'runs before_denormalize filters in the order they are defined' do
+      MultiBeforeFilterSubclass.denormalize({ bar: 'X' }).should == { foo: 'CBAX' }
+    end
+  end
+end
+
+class MultiAfterFilter
+  extend HashMapper
+
+  map from('/baz'), to('bat')
+
+  after_normalize do |input, output|
+    output[:bat] << '1'
+    output
+  end
+
+  after_normalize do |input, output|
+    output[:bat] << '2'
+    output
+  end
+
+  after_denormalize do |input, output|
+    output[:baz].prepend('9')
+    output
+  end
+
+  after_denormalize do |input, output|
+    output[:baz].prepend('8')
+    output
+  end
+end
+
+class MultiAfterFilterSubclass < MultiAfterFilter
+  after_normalize do |input, output|
+    output[:bat] << '3'
+    output
+  end
+
+  after_denormalize do |input, output|
+    output[:baz].prepend('7')
+    output
+  end
+end
+
+describe 'multiple after filters' do
+  it 'runs after_normalize filters in the order they are defined' do
+    MultiAfterFilter.normalize({ baz: '0' }).should == { bat: '012' }
+  end
+
+  it 'runs after_denormalize filters in the order they are defined' do
+    MultiAfterFilter.denormalize({ bat: '0' }).should == { baz: '890' }
+  end
+
+  context 'when the filters are spread across classes' do
+    it 'runs after_normalize filters in the order they are defined' do
+      MultiAfterFilterSubclass.normalize({ baz: '0' }).should == { bat: '0123' }
+    end
+
+    it 'runs after_denormalize filters in the order they are defined' do
+      MultiAfterFilterSubclass.denormalize({ bat: '0' }).should == { baz: '7890' }
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hash_mapper
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Ismael Celis
@@ -14,42 +14,42 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Tiny module that allows you to easily adapt from one hash structure to
@@ -59,7 +59,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - History.txt
 - README.md
@@ -74,25 +74,26 @@ licenses: []
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --charset=UTF-8
+- "--charset=UTF-8"
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Maps input hashes to a normalized format
 test_files:
 - spec/hash_mapper_spec.rb
 - spec/spec_helper.rb
+has_rdoc: