hash_accessor 1.0.4 → 1.0.5

data/README.rdoc

@@ -58,7 +58,7 @@ Here is an example:
 
 == Contributing & Reporting Issues
 
-While I can't promise the most speedy response, I do plan to continue to maintain this gem. Please feel free to report any issues, provide feedback, or make suggestions on the {Issue Tracker}[http://github.com/forrest/hash_accessor/issues]
+While I can't promise the most speedy response, I do plan to continue to maintain this gem. Please feel free to report any issues, provide feedback, or make suggestions on the {Issue Tracker}[http://github.com/GetJobber/hash_accessor/issues]
 
 
 ---

data/hash_accessor.gemspec

@@ -3,13 +3,12 @@ require File.expand_path("../lib/hash_accessor", __FILE__)
 Gem::Specification.new do |s|
   s.name = "hash_accessor"
   s.version = HashAccessor::VERSION
-  s.author = ["Forrest"]
-  s.email = ["development@forrestzeisler.com"]
+  s.author = ["Jobber", "Forrest Zeisler"]
+  s.email = ["forrest@getjobber.com"]
   s.date = Time.now.utc.strftime("%Y-%m-%d")
 
-
   s.description = 'This gem provides accessor methods to hash keys.'
-  s.summary = "This gem provides extended functionality to serialized hashed in rails. It allows you to define accessor methods for variable that rest "+
+  s.summary = "This gem provides extended functionality to serialized hashed in rails similary to rails' active_attr. It allows you to define accessor methods for variable that rest "+
               "inside a serialized hash. This is very useful if you have a large list of often changing DB variables on a model which don't get queried against."
 
   s.required_rubygems_version = ">= 1.3.6"

data/lib/hash_accessor.rb

@@ -4,7 +4,7 @@ $:.include?(File.dirname(__FILE__)) || $:.include?(File.expand_path(File.dirname
 require 'hash_accessor/railtie' if defined?(Rails)
 
 module HashAccessor
-  VERSION = "1.0.4"
+  VERSION = "1.0.5"
 
   autoload :ClassMethods, 'hash_accessor/class_methods'
 

data/lib/hash_accessor/class_methods.rb

@@ -16,27 +16,26 @@ module HashAccessor
     # :reject_blanks - removes all blank elements after the collect method
     def hash_accessor(hash_name, method_name, options = {})
       begin
-        method_modifier = hash_accessor_method_modifier(method_name, options)
-        default = hash_accessor_default(options)
+        method_name = method_name.to_sym
 
         # Define getter
         define_method(method_name) do
           send("#{hash_name}=", {}) if send(hash_name).blank?
-          if self.send(hash_name)[method_name].nil?
-            self.send(hash_name)[method_name] = default
+          if send(hash_name)[method_name].nil?
+            send(hash_name)[method_name] = hash_accessor_default(options)
           end
-          self.send(hash_name)[method_name]
+          send(hash_name)[method_name]
         end
 
         # Define setter
-        define_method("#{method_name}=") do |*args|
-          new_val = args[0]
-          self.send("#{hash_name}=", {}) if send(hash_name).blank?
+        define_method("#{method_name}=") do |new_val|
+          send("#{hash_name}=", {}) if send(hash_name).blank?
+          method_modifier = hash_accessor_method_modifier(method_name, options)
           new_val = method_modifier.call(new_val)
-          if self.send(hash_name)[method_name] != new_val
+          if send(hash_name)[method_name] != new_val
             instance_variable_set("@#{method_name}_changed", true)
           end
-          self.send(hash_name)[method_name] = new_val
+          send(hash_name)[method_name] = new_val
         end
 
         # Define changed?
@@ -55,47 +54,47 @@ module HashAccessor
         puts "\n\nError adding hash_accessor:\n#{e.message}\n#{e.backtrace}\n\n"
       end
     end
+  end
 
-    private
+  private
 
-    def hash_accessor_method_modifier(method_name, options)
-      case options[:type]
-      when :integer
-        lambda {|new_val| new_val.try(:to_i) }
-      when :float
-        lambda {|new_val| new_val.try(:to_f) }
-      when :decimal
-        lambda {|new_val| new_val.try(:to_d) }
-      when :boolean, :bool
-        lambda {|new_val| (new_val.is_a?(TrueClass) or (new_val.is_a?(String) and (new_val=~/true|1/i).present?) or (new_val.is_a?(Fixnum) and new_val==1)) }
-      when :array
-        lambda {|new_val|
-          new_val = Array.wrap(new_val)
+  def hash_accessor_method_modifier(method_name, options)
+    case options[:type]
+    when :integer
+      lambda {|new_val| new_val.try(:to_i) }
+    when :float
+      lambda {|new_val| new_val.try(:to_f) }
+    when :decimal
+      lambda {|new_val| new_val.try(:to_d) }
+    when :boolean, :bool
+      lambda {|new_val| (new_val.is_a?(TrueClass) or (new_val.is_a?(String) and (new_val=~/true|1/i).present?) or (new_val.is_a?(Fixnum) and new_val==1)) }
+    when :array
+      lambda {|new_val|
+        new_val = Array.wrap(new_val)
 
-          if options[:collects]
-            new_val = new_val.collect(&options[:collects])
-          end
+        if options[:collects]
+          new_val = new_val.collect(&options[:collects])
+        end
 
-          if options[:reject_blanks]
-            new_val.reject!(&:blank?)
-          end
+        if options[:reject_blanks]
+          new_val.reject!(&:blank?)
+        end
 
-          new_val
-        }
-      else lambda {|new_val| new_val}
-      end
+        new_val
+      }
+    else lambda {|new_val| new_val}
     end
+  end
 
-    def hash_accessor_default(options)
-      if options[:default].is_a?(String)
-        default = options[:default]
-      elsif options[:default].nil? and options[:type]==:array
-        default = []
-      elsif options[:default].nil?
-        default = nil
-      else
-        default = options[:default]
-      end
+  def hash_accessor_default(options)
+    if options[:default].is_a?(String)
+      default = options[:default]
+    elsif options[:default].nil? and options[:type]==:array
+      default = []
+    elsif options[:default].nil?
+      default = nil
+    else
+      default = options[:default]
     end
   end
 

data/test/hash_accessor_test.rb

@@ -33,6 +33,19 @@ class HashAccessorTest < Test::Unit::TestCase
     assert_equal "some test", @tester.unspecified_variable
   end
 
+  def test_no_sharing_of_variables
+    t1 = TestClassWithHash.new
+    t2 = TestClassWithHash.new
+
+    t1.unspecified_variable = "some test"
+    t1.test_array_2 << :blah
+
+    assert_equal "some test", t1.unspecified_variable
+    assert_equal [:blah], t1.test_array_2
+    assert_equal nil, t2.unspecified_variable
+    assert_equal [], t2.test_array_2
+  end
+
   def test_accessors_being_casted_correctly
     @tester.test_integer = "3"
     @tester.test_decimal = "3"

metadata

@@ -1,11 +1,12 @@
 --- !ruby/object:Gem::Specification
 name: hash_accessor
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
   prerelease: 
 platform: ruby
 authors:
-- Forrest
+- Jobber
+- Forrest Zeisler
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -29,7 +30,7 @@ dependencies:
         version: 3.2.0
 description: This gem provides accessor methods to hash keys.
 email:
-- development@forrestzeisler.com
+- forrest@getjobber.com
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -68,10 +69,10 @@ rubyforge_project:
 rubygems_version: 1.8.22
 signing_key: 
 specification_version: 3
-summary: This gem provides extended functionality to serialized hashed in rails. It
-  allows you to define accessor methods for variable that rest inside a serialized
-  hash. This is very useful if you have a large list of often changing DB variables
-  on a model which don't get queried against.
+summary: This gem provides extended functionality to serialized hashed in rails similary
+  to rails' active_attr. It allows you to define accessor methods for variable that
+  rest inside a serialized hash. This is very useful if you have a large list of often
+  changing DB variables on a model which don't get queried against.
 test_files:
 - test/hash_accessor_test.rb
 has_rdoc: true