hash19 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2690fb2383e0fb03cf39844a44cee0f8761af48c
-  data.tar.gz: 430b9b351c64625827b3f4994a8cfed9ca2002ea
+  metadata.gz: 8e3af7ef38c2b83b16643922fdb0b9e4f17e9a02
+  data.tar.gz: 1ce1e8d0f3355773c09d224ec1e6f8de21afb184
 SHA512:
-  metadata.gz: 662633e7af29b3d2eb31dba44e4cc11c2bc615b95dad1b20fa7e566bee0f512180ee1c83bae39d1166fc15d6f7506fd3827a8a7daccd469aca1af9aa07e2976c
-  data.tar.gz: 7531bcbd9375ccca4fc60fca9b74862192c49296bbedd6bd083ec4c50d1c195357cc354dc5c7f89a6fcd794fc0dcb5e1e2c15e0176f0fe3ce785125b62a1b0bc
+  metadata.gz: 5ceb2cc897448d847ab762fd5e63b355962f9b52bd3788c12d5a0451c26bf7b2c30b80d354f08fcbd682a239e84c1282905796dfd950e7e4b9eefa92f50db929
+  data.tar.gz: 76740b66f18d888d6630faaa9f5eebf4ce9786f395eece15e87caa09fdee1ab3619e86dc97e6aa628938662e0db810d252165c2a07c8827a0861684d6fe5c431

data/.gitignore

@@ -13,3 +13,6 @@
 *.a
 mkmf.log
 .idea
+.gemtags
+.tags
+.tags_sorted_by_file

data/lib/hash19/core.rb

@@ -11,7 +11,7 @@ module Hash19
 
     module Initializer
       def initialize(payload={})
-        if self.class.contains_klass
+        if payload.is_a? Array
           @hash19 = payload.map do |el|
             klass = resolve_class(self.class.contains_klass.to_s.camelize.singularize)
             klass.send(:new, el).to_h(lazy: true)

data/lib/hash19/resolvers.rb

@@ -21,8 +21,11 @@ module Hash19
                                             association.map { |hash| klass.send(:new, hash).to_h(lazy: true) }
                                           end
         else
-          # raise "Key:<#{name}> is not present in #{self.class.name}. Possible specify a trigger" unless
-          @hash19[opts[:alias] || name] = LazyValue.new(-> { opts[:trigger].call(@hash19.delete(opts[:using])) }) if opts[:trigger]
+          puts "warning: Association:<#{name}> is not present in #{self.class.name}. Possible specify a trigger" unless opts[:trigger]
+          puts "warning: Key:<#{opts[:using]}> not present in #{self.class.name}. Cannot map association:<#{name}>" unless @hash19.has_key? opts[:using]
+          if opts[:trigger] and @hash19.has_key? opts[:using]
+            @hash19[opts[:alias] || name] = LazyValue.new(-> { opts[:trigger].call(@hash19.delete(opts[:using])) }) if opts[:trigger]
+          end
         end
       end
     end
@@ -38,11 +41,13 @@ module Hash19
         self.class.injections.each do |opts|
           async do
             entries = JsonPath.new(opts[:at]).on(hash).flatten
-            ids = entries.map { |el| el[opts[:using]] }
+            ids = entries.map { |el| el[opts[:using]] }.compact
+            next unless ids.present?
             to_inject = opts[:trigger].call(ids).map(&:with_indifferent_access)
             key = opts[:as] || opts[:using].to_s.gsub(/_id$|Id$/, '')
             entries.each do |entry|
               id = entry.delete(opts[:using])
+              next unless id.present?
               target = to_inject.find { |el| el[opts[:reference] || opts[:using]] == id }
               entry[key] = target
             end
@@ -51,12 +56,15 @@ module Hash19
       end
     end
 
-
     def resolve_class(assoc_name)
       full_class_name = self.class.name
       new_class = full_class_name.gsub(full_class_name.demodulize, assoc_name)
       new_class.split('::').inject(Object) do |mod, class_name|
-        mod.const_get(class_name)
+        if mod.const_defined?(class_name)
+          mod.const_get(class_name)
+        else
+          raise("Class:<#{new_class}> not defined! Unable to resolve association:<#{assoc_name.downcase}>")
+        end
       end
     end
 

data/lib/hash19/version.rb

@@ -1,3 +1,3 @@
 module Hash19
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/hash19/access_spec.rb

@@ -2,27 +2,30 @@ require 'spec_helper'
 
 describe 'Access Patterns for Hash19' do
 
-  class Hash1
-    include Hash19
-    attributes :a, :b, :c
-  end
-
   it 'should be able to access hash keys using dot notation' do
+
+    class Hash1
+      include Hash19
+      attributes :a, :b, :c
+    end
+
     hash1 = Hash1.new({a: 1, b: 2, c: 3})
     expect(hash1[:a]).to eq(1)
     expect(hash1[:b]).to eq(2)
     expect(hash1[:c]).to eq(3)
   end
 
-  class Hash11
-    include Hash19
-    attributes :x, :y
-    has_one :hash1, alias: :h
-  end
+  it 'should be able to access keys recursively' do
+
+    class Hash11
+      include Hash19
+      attributes :x, :y
+      has_one :hash1, alias: :h
+    end
 
-  it 'should be able to work recursively' do
     hash11 = Hash11.new(hash1: {a: 1, b: 2, c: 3}, x: -1, y: -2)
     expect(hash11[:h][:a]).to eq(1)
+    expect(hash11[:y]).to eq(-2)
   end
 
 end

data/spec/hash19/associations_spec.rb

@@ -21,7 +21,19 @@ describe 'Associations' do
       expect(parent.to_h).to eq('p' => 1, 'q' => 2, 'child' => {'x' => 1})
     end
 
-    it 'should support key for has_one' do
+    it 'should flag error when target class not present' do
+      module Computer
+        class Laptop < Testable
+          attributes :model, :year
+          has_one :keyboard
+        end
+      end
+
+      expect { Computer::Laptop.new(model: 'MacBook Pro', year: 2013, keyboard: {keys: 101}) }.
+      to raise_error('Class:<Computer::Keyboard> not defined! Unable to resolve association:<keyboard>')
+    end
+
+    it 'should support alternate key in payload for has_one' do
       class OtherParent < Testable
         attributes :x
         has_one :child, key: :offspring, class: 'Child'
@@ -31,7 +43,7 @@ describe 'Associations' do
       expect(parent.to_h).to eq('x' => true, 'child' => {'x' => 1})
     end
 
-    it 'should support alias for has_one' do
+    it 'should support association alias for has_one' do
       class AnotherParent < Testable
         attributes :x
         has_one :child, key: :offspring, alias: :junior
@@ -57,7 +69,7 @@ describe 'Associations' do
       expect(bike.to_h).to eq('cc' => 150, 'wheels' => [{'flat' => false}, {'flat' => true}])
     end
 
-    it 'should support key for has_many' do
+    it 'should support alternate key in payload for has_many' do
       class OtherBike < Testable
         attributes :cc
         has_many :wheels, key: :discs
@@ -67,7 +79,7 @@ describe 'Associations' do
       expect(bike.to_h).to eq('cc' => 150, 'wheels' => [{'flat' => false}, {'flat' => true}])
     end
 
-    it 'should support alias for has_many' do
+    it 'should support association alias for has_many' do
       class AnotherBike < Testable
         attributes :cc
         has_many :wheels, key: :discs, alias: :rings
@@ -91,8 +103,8 @@ describe 'Associations' do
     end
 
     it 'should be able to resolve has_many relationship within modules' do
-      duck = Bird::Duck.new(quack: true, feathers: [{light: true}, {light: true}])
-      expect(duck.to_h).to eq('quack' => true, 'feathers' => [{'light' => true}, {'light' => true}])
+      duck = Bird::Duck.new(quack: true, feathers: [{light: true}, {light: false}])
+      expect(duck.to_h).to eq('quack' => true, 'feathers' => [{'light' => true}, {'light' => false}])
     end
   end
 
@@ -132,10 +144,21 @@ describe 'Associations' do
     it 'should be able to call the trigger on has_one association' do
       packet = UDPPacket.new(code: 500, error_id: 500)
       expect(packet.to_h).to eq('code' => 500, 'error_id' => 500, 'all_errors' => [{'error_id' => 500, 'desc' => 'fatal error'},
-                                                                           {'error_id' => 404, 'desc' => 'not found'}])
+       {'error_id' => 404, 'desc' => 'not found'}])
     end
 
   end
 
+  context 'no id to lookup' do
+    it 'should not fail if association key is not present' do
+      class Jedi < Testable
+        attributes :name
+        has_one :padawan, using: :padawan_id, trigger: ->(id) { Padawan.find }
+      end
+
+      jedi = Jedi.new(name: 'Obi Wan Kenobi')
+      expect(jedi.to_h).to eq({"name" => 'Obi Wan Kenobi'})
+    end
+  end
 
 end

data/spec/hash19/contains_spec.rb

@@ -37,5 +37,10 @@ describe 'Containers' do
                                        {'name' => 'hulk', 'power' => 'bulk', 'weapon' => {'name' => 'hands', 'id' => 3}}])
     end
 
+    it 'should not fail when container is empty' do
+      super_heroes = SuperHeroes.new([])
+      expect(super_heroes.to_h).to eq([])
+    end
+
   end
 end

data/spec/hash19/core_spec.rb

@@ -12,7 +12,6 @@ describe Hash19::Core do
       attributes :a, :b, :c
     end
 
-
     it 'should be able to assign whitelisted attributes' do
       test = Test1.new(a: 1, b: 2, d: 4)
       expect(test.to_h).to eq('a' => 1, 'b' => 2)
@@ -23,32 +22,40 @@ describe Hash19::Core do
       expect(test.to_h).to eq({})
     end
 
-  end
-
-  context 'Single attribute and aliases' do
-
-    class Test2 < Testable
-      attributes :a, :b, :c
-      attribute :fake, key: :actual
-      attribute :d
+    it 'should not break when an empty hash is passed' do
+      test = Test1.new({})
+      expect(test.to_h).to eq({})
     end
 
-    it 'should be able to assign attributes based on alias' do
-      test = Test2.new(actual: 1)
-      expect(test.to_h).to eq('fake' => 1)
+    it 'should not break when an empty array is passed' do
+      test = Test1.new([])
+      expect(test.to_h).to eq([])
     end
 
-    it 'should be able to use both attribute and attributes constructs' do
-      test = Test2.new(actual: 1, a: 2, d: 3)
-      expect(test.to_h).to eq('fake' => 1, 'a' => 2, 'd' => 3)
-    end
+  end
 
-    it 'should ignore alias if key not present' do
-      test = Test2.new(a: 2)
-      expect(test.to_h).to eq('a' => 2)
-    end
+  context 'Single attribute and aliases' do
+
+    class Test2 < Testable
+     attributes :a, :b, :c
+     attribute :fake, key: :actual
+     attribute :d
+   end
+
+   it 'should be able to assign attributes based on alias' do
+    test = Test2.new(actual: 1)
+    expect(test.to_h).to eq('fake' => 1)
   end
 
+  it 'should be able to use both attribute and attributes constructs' do
+    test = Test2.new(actual: 1, a: 2, d: 3)
+    expect(test.to_h).to eq('fake' => 1, 'a' => 2, 'd' => 3)
+  end
 
+  it 'should ignore alias if key not present' do
+    test = Test2.new(a: 2)
+    expect(test.to_h).to eq('a' => 2)
+  end
+end
 
 end

data/spec/hash19/injection_spec.rb

@@ -36,6 +36,27 @@ describe 'Injections' do
                                                                  {'name' => 'Kanpai', 'eats' => {'id' => 3, 'name' => 'orange'}}
                                                  ])
     end
+
+    it "should not fail when no keys for injection present" do
+      gru_team = SuperVillain.new(name: 'Gru', minions: [{name: 'Poppadom'},
+                                                         {name: 'Gelato'},
+                                                         {name: 'Kanpai'}])
+      expect(gru_team.to_h).to eq('name' => 'Gru', 'minions' => [{'name' => 'Poppadom'},
+                                                                 {'name' => 'Gelato'},
+                                                                 {'name' => 'Kanpai'}
+                                                 ])
+    end
+
+    it "should only map associations with keys" do
+      gru_team = SuperVillain.new(name: 'Gru', minions: [{name: 'Poppadom', fruit_id: 1},
+                                                         {name: 'Gelato'},
+                                                         {name: 'Kanpai'}])
+      expect(gru_team.to_h).to eq('name' => 'Gru', 'minions' => [{'name' => 'Poppadom', 'eats' => {'id' => 1, 'name' => 'banana'}},
+                                                                 {'name' => 'Gelato'},
+                                                                 {'name' => 'Kanpai'}
+                                                 ])
+    end
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hash19
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - RC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-12 00:00:00.000000000 Z
+date: 2014-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler