has_validated_attributes 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 741eb33221db68169066b003a3d7dd9c8346a828
-  data.tar.gz: 342b40509353c02c89ae0b6f855b950bbb0cd2a6
+  metadata.gz: c761c309029c68a341e56752666b57328813b3d1
+  data.tar.gz: 2c738c7475c92be1b079b0dfa793eb2b0332551c
 SHA512:
-  metadata.gz: c688e4f0763bf87e07b4454ceb991b896293905bf55b470d39c3caad04a20e7042a48a9796b4cd8d494af7653abd207868daad9692e57394411113ba7370c312
-  data.tar.gz: 2d4a952ff3ec7d9194120f1300b32f057271910f8166e0ede5ec88cdb1d0d50f3a012546ba6e60f219e8fb99df43744fbc596b915e5c8c274af67a49cda996aa
+  metadata.gz: f9584b22066a04733b72b7152bf5376b651b14edb8a73d500ee515447e57cd99dbad0d3b9eef4cb34da58c3fc08afba2d553f7780252ff04991a669f6e745ea9
+  data.tar.gz: 9032cd2eb87d20c991ce5e7d74ac63397bd7d35e8aa6829b1184f8c197b57715a24276d7a7852320b840e5e3100065bc0b0574992f5382253dfe04280bff07a2

data/README.rdoc

@@ -24,7 +24,7 @@ for example:
                                :positive_dollar_attr => {:format => :positive_dollar}, :percent_attr => {:format => :percent},
                                :positive_percent_attr => {:format => :positive_percent}, :url_attr => {:format => :url}, :ssn_attr => {:format => :ssn},
                                :taxid_attr => {:format => :taxid}, :age_attr => {:format => :age}, :number_attr => {:format => :number}
-  end  
+  end
 
 == Extra Options
   You can pass extra options like
@@ -36,6 +36,8 @@ for example:
   :zipcode, :dollar, :percent, :positive_percent, :middle_initial, :url,
   :positive_dollar, :domain, :ssn, :taxid, :age, :number
 
+== RSpec
+Add `require "has_validated_attributes/rspec"` to your specs to include shared examples for validated fields.
 
 == COPYRIGHT
 

data/has_validated_attributes.gemspec

@@ -18,8 +18,9 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
   s.add_development_dependency "rspec"
-  s.add_development_dependency("activerecord", ['>= 3.1.0'])
-  s.add_development_dependency("sqlite3")
-  s.add_development_dependency('database_cleaner')
+  s.add_development_dependency "shoulda-matchers"
+  s.add_development_dependency "has_normalized_attributes",  "~> 0.0", ">= 0.0.8"
+  s.add_development_dependency "activerecord",               ">= 3.1.0"
+  s.add_development_dependency "sqlite3"
+  s.add_development_dependency "database_cleaner"
 end
-

data/lib/has_validated_attributes.rb

@@ -1,8 +1,9 @@
 # encoding: utf-8
+require 'active_record'
 
 module HasValidatedAttributes
   extend ActiveSupport::Concern
-  NO_CONTROL_CHARS_REGEX = /\A[^[:cntrl:]]*\Z/
+  NO_CONTROL_CHARS_REGEX = /\A[^[:cntrl:]]*\z/
   NO_CONTROL_CHARS_ERROR_MSG = "avoid non-printing characters"
 
   #instance methods
@@ -41,8 +42,8 @@ module HasValidatedAttributes
               :middle_initial => {:format => {:with => /\A[a-zA-Z]{0,1}\z/u, :message => "accepts only one letter"}},
               :dollar => {:format => {:with => /\A-?[0-9]{0,12}(\.[0-9]{0,2})?\z/, :message => "accepts only numeric characters, period, and negative sign"}, :numericality => {:greater_than => -1000000000000, :less_than => 1000000000000}, :allow_nil => true},
               :positive_dollar => {:format => {:with => /\A[0-9]{0,12}(\.[0-9]{0,2})?\z/, :message => "accepts only numeric characters, period"}, :numericality => {:greater_than_or_equal_to => 0, :less_than => 1000000000000}, :allow_nil => true},
-              :percent => {:format => {:with => /\A-?[0-9]{0,3}(\.[0-9]{0,3})?\z/, :message => "accepts only numeric characters, period, negative sign, and must be equal/less/greater than +/- 100"}},
-              :positive_percent => {:format => {:with => /\A[0-9]{0,3}(\.[0-9]{0,3})?\z/, :message => "accepts only numeric characters, period, and must be less than 100"}, :numericality => {:greater_than_or_equal_to => 0, :less_than_or_equal_to => 100}, :allow_nil => true},
+              :percent => {:format => {:with => /\A-?[0-9]{0,3}(\.[0-9]{0,3})?\z/, :message => "accepts only numeric characters, period, negative sign, and must be equal/less/greater than +/- 100"}, :numericality => {:greater_than_or_equal_to => -100, :less_than_or_equal_to => 100} },
+              :positive_percent => {:format => {:with => /\A[0-9]{0,3}(\.[0-9]{0,3})?\z/, :message => "accepts only numeric characters, period, and must be equal/less than 100"}, :numericality => {:greater_than_or_equal_to => 0, :less_than_or_equal_to => 100}, :allow_nil => true},
               :url => {:length => {:maximum => 255}, :format => {:with => /\A(http|https|ftp):\/\/[A-Z0-9]+([\.]{1}[a-z0-9-]{1,63})*\.[a-zA-Z]{2,5}(:[0-9]{1,5})?(\/.*)?\z/ix, :message => "web address isnt valid"}, :has_if? => true},
               :social_security_number => {:length => {:is => 9}, :numericality => {:greater_than_or_equal_to => 0, :less_than => 1000000000, :message => "must be in the format 111-11-1111"}, :has_if? => true},
               :taxid => {:length => {:is => 9}, :numericality => {:greater_than_or_equal_to => 9999999, :less_than => 1000000000, :message => "must be in the format 11-1111111"}, :has_if? => true},

data/lib/has_validated_attributes/rspec.rb

@@ -0,0 +1,282 @@
+begin
+  require 'rspec'
+  require 'shoulda-matchers'
+rescue LoadError => e
+  raise <<-ERROR_MSG
+#{ e.path } is not loaded but is required when loading "has_validated_attributes/rspec"!
+
+Do you need to `gem install #{ e.path }`?
+ERROR_MSG
+end
+
+RSpec.configure do |config|
+  config.extend Module.new {
+    def has_validated_attribute(type, attr, *args, &block)
+      it_behaves_like "#{ type.gsub('_', ' ') } attribute", attr, *args, &block
+    end
+
+    # Provide dynamic methods wrappers to shared behaviors.
+    #
+    #=== Examples
+    #  has_validated_name_field(:first_name)      # Same as `it_behaves_like "name attribute", :first_name`
+    #  has_validated_zip_code_field(:first_name)  # Same as `it_behaves_like "zip code field", :first_name`
+    def method_missing(name, *args, &block)
+      if /\Ahas_validated_(?<type>\w*)_attribute\Z/ =~ name
+        has_validated_attribute(type, *args, &block)
+      else
+        super
+      end
+    end
+  }
+end
+
+#= Load shared examples
+#   it_behaves_like "name attribute", :first_name
+#   it_behaves_like "name attribute", :first_name, 10
+RSpec.shared_examples_for "name attribute" do |attr, length: HasValidatedAttributes.name_format[:maximum_length]|
+  it { should validate_length_of(attr).is_at_least(0) }
+  it { should validate_length_of(attr).is_at_most(length) }
+
+  [
+    "A", "z", "!", "@", "#", "$", "%", "^", "&", "*", "(", ")",
+    "{", "}", "?", "+", "[", "]", "/", "\\", "-", "_", "<", ">",
+    "k c", "- H-", " t", "& u", "21 ", "brok", ">*", "< test"
+  ].
+    select { |str| str.length <= length }.
+    each do |str|
+      it { should allow_value(str).for(attr) }
+    end
+
+  ["\e1B", "\cF", "Hello\nWorld", "\eHey", "Oh\cFNo, it's a control char!"].
+    select { |str| str.length <= length }.
+    each do |str|
+      it { should_not allow_value(str).for(attr).with_message(HasValidatedAttributes.name_format[:format][:message]) }
+    end
+end
+
+RSpec.shared_examples_for "username attribute" do |attr|
+  it { should validate_length_of(attr).is_at_least(HasValidatedAttributes.username_format[:length][:within].min) }
+  it { should validate_length_of(attr).is_at_most(HasValidatedAttributes.username_format[:length][:within].max) }
+
+  ["kansascity", "kansascity@org1", "kansas.city@org1", "kansas_city@org1", "kansas-city", "1kc.-_@"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  [">*,.<><", "<<< test", "Kansas City", "-- Hey --", "& youuuu", "21 Jump"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.username_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "email attribute" do |attr|
+  it { should validate_length_of(attr).is_at_most(HasValidatedAttributes.email_format[:length][:maximum]) }
+
+  ["abc@example.com", "Abc@example.com", "aBC@example.com", "abc.123@example.com", "mo’reilly@example.com", "ro'sullivan@example.com"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["Abc.example.com", "A@b@c@example.com", "()[]\;:,<>@example.com", "abc@example.comar"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.email_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "domain attribute" do |attr|
+  it { should validate_length_of(attr).is_at_most(HasValidatedAttributes.domain_format[:length][:maximum]) }
+
+  ["test.com", "hey.com", "dynamicadvisorsgroup.com", "advisorsexcel.com"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  [">*", "<test", "test-er"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.domain_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "middle initial attribute" do |attr|
+  ["a", "A"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["k c", "55555", "55555-5555", "55555 5555", "55555.5555", "(888)88-9999", " ,-99999"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.middle_initial_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "zipcode attribute" do |attr|
+  ["11111", "333333333"].each do |zip|
+    it { should allow_value(zip).for(attr) }
+  end
+
+  ["5555", "5555555555","-99999"].each do |zip|
+    it { should_not allow_value(zip).for(attr).with_message(HasValidatedAttributes.zipcode_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "phone number attribute" do |attr, normalized: false|
+  ["9134456677", "5444456677", "9134466677 ", " 2134456677 "].each do |phone|
+    it { should allow_value(phone).for(attr) }
+  end
+
+  [">*", "< test", "www.test..com", "www.test.c", "www-test.com", "abc", "123", "&*()", "www.test-com"].each do |phone|
+    it { should_not allow_value(phone).for(attr).with_message(HasValidatedAttributes.phone_number_format[:numericality][:message]) }
+  end
+
+  ["913 345 6677", "613-445-6677", "983445-6677", " 913-4256677", "(888)8888888", "903-445 6627", "913-4556677", "513.445-6677", "555.555.8888"].each do |phone|
+    it { send(normalized ? :should : :should_not, allow_value(phone).for(attr).with_message(HasValidatedAttributes.phone_number_format[:numericality][:message])) }
+  end
+end
+
+RSpec.shared_examples_for "phone extension attribute" do |attr|
+  ["123", "123456"].each do |ext|
+    it { should allow_value(ext).for(attr) }
+  end
+
+  ["-1", "qwert"].each do |ext|
+    it { should_not allow_value(ext).for(attr).with_message(HasValidatedAttributes.phone_extension_format[:numericality][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "url attribute" do |attr, allowed: nil, disallowed: nil|
+  (allowed || [
+    "http://www.example.com", "http://www.example.com:8001", "http://www.exmple.com/1/abc?test=test",
+    "http://finane.example.com", "http://www.example.com/1/abc?test=test", "http://fiance.example.com", "http://finance.example.com.ag"
+  ]).each do |url|
+    it { should allow_value(url).for(attr) }
+  end
+
+  (disallowed || [
+    "finance.example.com", "www.example.com", "www.example.com:8001", ">*", "< test",
+    "www.test..com", "www.test.c", "www-test.com", "abc", "123", "&*()", "www.test-com"
+  ]).each do |url|
+    it { should_not allow_value(url).for(attr).with_message(HasValidatedAttributes.url_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "positive percent attribute" do |attr|
+  ["100", "99", "1", "44", "99.999", "0.001"].each do |percent|
+    it { should allow_value(percent).for(attr) }
+  end
+
+  ["100.001", "0.2222", "abc", "&", "-44", "-44.4", "-44.4444"].each do |percent|
+    it { should_not allow_value(percent).for(attr) }
+  end
+end
+
+RSpec.shared_examples_for "percent attribute" do |attr|
+  ["100", "99", "1", "44", "99.999", "0.001", "-100", "-99", "-1", "-44", "-99.999", "-0.001"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["100.001", "0.2222", "-100.001", "-0.2222", "abc", "&"].each do |value|
+    it { should_not allow_value(value).for(attr) }
+  end
+end
+
+RSpec.shared_examples_for "age attribute" do |attr|
+  ["100", "99", "1 ", "44", "110", "0"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+
+  ["111", "-1", "abc", "&"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.age_format[:numericality][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "positive dollar attribute" do |attr, normalized: false|
+  ["0", "1", "100", "1000", "1000.99"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["-1", "0.2222", "ewrt"].each do |value|
+    it { should_not allow_value(value).for(attr) }
+  end
+
+  ["1,000,00", "$1,000.00", "1,000,000", "1 000 000.01"].each do |value|
+    it { send(normalized ? :should : :should_not, allow_value(value).for(attr)) }
+  end
+end
+
+RSpec.shared_examples_for "dollar attribute" do |attr, normalized: false|
+  ["0", "1", "100", "1000", "1000.99", "-0", "-1", "-100", "-1000", "-1000.99"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["0.2222", "ewrt"].each do |value|
+    it { should_not allow_value(value).for(attr) }
+  end
+
+  [
+    "1,000,00", "$1,000.00", "1,000,000", "1 000 000.01",
+    "-1,000,00", "-$1,000.00", "-1,000,000", "-1 000 000.01"  # has_normalized_attributes may be used in concert with has_validated_attributes to cover these cases.
+  ].each do |value|
+    it { send(normalized ? :should : :should_not, allow_value(value).for(attr)) }
+  end
+end
+
+RSpec.shared_examples_for "number attribute" do |attr, length: nil, normalized: false|
+  ["0", "1", "100", "1000", "-1"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["werq"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.number_format[:numericality][:message]) }
+  end
+
+  [
+    "1,000,00", "1,000.00", "1,000,000", "1 000 000",  # has_normalized_attributes may be used in concert with has_validated_attributes to cover these cases.
+  ].each do |value|
+    it { send(normalized ? :should : :should_not, allow_value(value).for(attr).with_message(HasValidatedAttributes.number_format[:numericality][:message])) }
+  end
+end
+
+RSpec.shared_examples_for "rails name attribute" do |attr|
+  ["kc_s", "hey", "yo_", "_jmp", "kc_star_what", "hey", "yo_sucka", "_jump_street"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  [">*", "< test", "test-er", "yo dude"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.rails_name_format[:format][:message]) }
+  end
+end
+
+RSpec.shared_examples_for "taxid attribute" do |attr, normalized: false|
+  ["010000000", " ", "545998888"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["ab-cdefgh", "001000000", "abc", "<", "&"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.taxid_format[:numericality][:message]) }
+  end
+
+  ["51-5998888", "51 5998858", "44.5559999",].each do |value|
+    it { send(normalized ? :should : :should_not, allow_value(value).for(attr).with_message(HasValidatedAttributes.taxid_format[:numericality][:message])) }
+  end
+
+  it { send(normalized ? :should : :should_not, allow_value(" 514998888 ").for(attr).with_message(/is the wrong length \(should be 9 characters\)/)) }
+end
+
+RSpec.shared_examples_for "ssn attribute" do |attr, normalized: false|
+  ["515998488", " "].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["ab-444fgh", "abc", "56599858>", "33445<", "3456356&", "/23452"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes.social_security_number_format[:numericality][:message]) }
+  end
+
+  ["515-99-8888", "544.99 8888", "515 99 8858", "444.33.6666"].each do |value|
+    it { send(normalized ? :should : :should_not, allow_value(value).for(attr).with_message(HasValidatedAttributes.social_security_number_format[:numericality][:message])) }
+  end
+
+  it { send(normalized ? :should : :should_not, allow_value(" 514998888 ").for(attr).with_message(/is the wrong length \(should be 9 characters\)/)) }
+end
+
+RSpec.shared_examples_for "safe text attribute" do |attr|
+  [">*", "< test", "Hey\tWorld", "new\nline", "new\r\nline"].each do |value|
+    it { should allow_value(value).for(attr) }
+  end
+
+  ["\eHey", "Oh\cFNo, it's a control char!"].each do |value|
+    it { should_not allow_value(value).for(attr).with_message(HasValidatedAttributes::NO_CONTROL_CHARS_ERROR_MSG) }
+  end
+end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module HasValidatedAttributes
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/db/schema.rb

@@ -19,6 +19,7 @@ ActiveRecord::Schema.define(:version => 0) do
     t.string   "url_attr"
     t.string   "age_attr"
     t.string   "number_attr"
+    t.string   "rails_name_attr"
   end
 
 end

data/spec/has_validate_fields_spec.rb

@@ -3,372 +3,81 @@
 require 'spec_helper'
 
 class Resource < ActiveRecord::Base
-  has_validated_attributes :name_attr => {:format => :name, :maximum_length => 10}, :safe_text_attr => { :format => :safe_text }, :username_attr => {:format => :username}, :email_attr => {:format => :email},
-                           :phone_number_attr => {:format => :phone_number}, :phone_extension_attr => {:format => :phone_extension},
-                           :domain_attr => {:format => :domain}, :zipcode_attr => {:format => :zipcode},
-                           :middle_initial_attr => {:format => :middle_initial}, :dollar_attr => {:format => :dollar},
-                           :positive_dollar_attr => {:format => :positive_dollar}, :percent_attr => {:format => :percent},
-                           :positive_percent_attr => {:format => :positive_percent}, :url_attr => {:format => :url}, :ssn_attr => {:format => :social_security_number},
-                           :taxid_attr => {:format => :taxid}, :age_attr => {:format => :age}, :number_attr => {:format => :number}
+  has_validated_attributes :name_attr => {:format => :name, :maximum_length => 10},
+                           :safe_text_attr => { :format => :safe_text },
+                           :username_attr => {:format => :username},
+                           :email_attr => {:format => :email},
+                           :phone_number_attr => {:format => :phone_number},
+                           :phone_extension_attr => {:format => :phone_extension},
+                           :domain_attr => {:format => :domain},
+                           :zipcode_attr => {:format => :zipcode},
+                           :middle_initial_attr => {:format => :middle_initial},
+                           :dollar_attr => {:format => :dollar},
+                           :positive_dollar_attr => {:format => :positive_dollar},
+                           :percent_attr => {:format => :percent},
+                           :positive_percent_attr => {:format => :positive_percent},
+                           :url_attr => {:format => :url},
+                           :ssn_attr => {:format => :social_security_number},
+                           :taxid_attr => {:format => :taxid},
+                           :age_attr => {:format => :age},
+                           :number_attr => {:format => :number},
+                           :rails_name_attr => {:format => :rails_name}
 end
 
-describe "HasValidatedAttributes" do
-  before(:each) do
-    @resource = Resource.create(:username_attr => "testusername", :name_attr => "testname", :email_attr => "test@example.com",
-      :phone_number_attr => "1111111111", :phone_extension_attr => "111111", :domain_attr => "www.test.com", :zipcode_attr => "11111",
-      :middle_initial_attr => "A", :dollar_attr => "-11", :positive_dollar_attr => "1", :percent_attr => "12",
-      :positive_percent_attr => "99", :url_attr => "http://www.google.com", :ssn_attr => "111111111", :taxid_attr => "111111111",
-      :number_attr => "1", :age_attr => 28)
-  end
-
-  describe "#username" do
-    it "should return error" do
-      [">*,.<><", "<<< test", "Kansas City", "-- Hey --", "& youuuu", "21 Jump"].each do |value|
-        @resource.username_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Username attr use only letters, numbers, and .-_@ please."]
-      end
-    end
-
-    it "should return error with less than 5 chars" do
-      @resource.username_attr = "test"
-      @resource.valid?.should be_falsey
-      @resource.errors.full_messages.should == ["Username attr is too short (minimum is 5 characters)"]
-    end
-
-    it "should return error with more than 127 chars" do
-      @resource.username_attr = "test" * 128
-      @resource.valid?.should be_falsey
-      @resource.errors.full_messages.should == ["Username attr is too long (maximum is 127 characters)"]
-    end
-
-    it "should return ok" do
-      ["kansascity", "kansascity@org1", "kansas.city@org1", "kansas_city@org1", "kansas-city", "1kc.-_@"].each do |value|
-        @resource.username_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#name" do
-    [">*", "< test"].each do |value|
-      it "should return error setting name to \"#{ value }\"" do
-        @resource.name_attr = value
-        expect(@resource.valid?).to be_truthy
-      end
-    end
-
-    ["Hello\nWorld", "\eHey", "Oh\cFNo, it's a control char!"].each do |value|
-      it "should return error setting name to \"#{ value }\"" do
-        @resource.name_attr = value
-        expect(@resource.valid?).to be_falsey
-        expect(@resource.errors.full_messages).to include("Name attr avoid non-printing characters")
-      end
-    end
-
-    it "should return error with more than 10 chars" do
-      @resource.name_attr = "test" * 6
-      expect(@resource.valid?).to be_falsey
-      expect(@resource.errors.full_messages).to include("Name attr is too long (maximum is 10 characters)")
-    end
-
-    ["k c", "- H-", " t", "& u", "21 ", "brok", nil].each do |value|
-      it "should return ok setting name to \"#{ value }\"" do
-        @resource.name_attr = value
-        expect(@resource.valid?).to be_truthy
-      end
-    end
-  end
-
-  describe "#safe_text" do
-    [">*", "< test", "Hey\tWorld", "new\nline", "new\r\nline"].each do |value|
-      it "should allow value to be set to \"#{ value.gsub("\r", "\\r").gsub("\n", "\\n") }\"" do
-        @resource.safe_text_attr = value
-        expect(@resource.valid?).to be_truthy
-      end
-    end
-
-    ["\eHey", "Oh\cFNo, it's a control char!"].each do |value|
-      it "should return error setting value to \"#{ value }\"" do
-        @resource.safe_text_attr = value
-        expect(@resource.valid?).to be_falsey
-        expect(@resource.errors.full_messages).to include("Safe text attr avoid non-printing characters")
-      end
-    end
-  end
-
-  describe "#email" do
-    it "should return error" do
-      ["Abc.example.com", "A@b@c@example.com", "()[]\;:,<>@example.com", "abc@example.comar"].each do |value|
-        @resource.email_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Email attr should look like an email address."]
-      end
-    end
-
-    it "should return error with more than 63 chars" do
-      @resource.email_attr = "test@example.com" * 64
-      @resource.valid?.should be_falsey
-      @resource.errors.full_messages.should == ["Email attr is too long (maximum is 63 characters)", "Email attr should look like an email address."]
-    end
-
-    ["abc@example.com", "Abc@example.com", "aBC@example.com", "abc.123@example.com", "mo’reilly@example.com", "ro'sullivan@example.com"].each do |value|
-      it "should return ok for `#{ value }`" do
-        @resource.email_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#phone_number" do
-    it "should return error" do
-      [">*", "< test", "www.test..com", "www.test.c", "www-test.com", "abc", "123", "&*()", "www.test-com"].each do |value|
-        @resource.phone_number_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Phone number attr accepts only 10 numbers and (),.- characters and must not be all 0s"]
-      end
-    end
-
-    it "should return ok" do
-      ["9134456677", "5444456677"].each do |value|
-        @resource.phone_number_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#phone_extension" do
-    it "should return error" do
-      ["-1", "qwert"].each do |value|
-        @resource.phone_extension_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Phone extension attr accepts only numbers (0-9)"]
-      end
-    end
-
-    it "should return ok" do
-      ["123", "123456"].each do |value|
-        @resource.phone_extension_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-
-  describe "#domain" do
-    it "should return error" do
-      [">*", "<test", "test-er"].each do |value|
-        @resource.domain_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Domain attr should look like a domain name."]
-      end
-    end
-
-    it "should return error with more than 63 chars" do
-        @resource.domain_attr = "a" * 64 + ".com"
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Domain attr is too long (maximum is 63 characters)"]
-    end
-
-
-    it "should return ok" do
-      ["test.com", "hey.com", "dynamicadvisorsgroup.com", "advisorsexcel.com"].each do |value|
-        @resource.domain_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#zipcode" do
-    it "should return error" do
-      ["5555", "5555555555","-99999"].each do |value|
-        @resource.zipcode_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Zipcode attr must contain 5 or 9 numbers"]
-      end
-    end
-
-    it "should return ok" do
-      ["11111", "333333333"].each do |value|
-        @resource.zipcode_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-
-  describe "#middle_initial" do
-    it "should return error" do
-      ["k c", "55555", "55555-5555", "55555 5555", "55555.5555", "(888)88-9999", " ,-99999"].each do |value|
-        @resource.middle_initial_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Middle initial attr accepts only one letter"]
-      end
-    end
-
-    it "should return ok" do
-      ["a", "A"].each do |value|
-        @resource.middle_initial_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#dollar" do
-    it "should return error" do
-      ["0.2222"].each do |value|
-        @resource.dollar_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Dollar attr accepts only numeric characters, period, and negative sign"]
-      end
-    end
-
-    it "should return ok" do
-      ["0", "1", "100", "1000", "-1000.99"].each do |value|
-        @resource.dollar_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-
-  describe "#positive dollar" do
-    it "should return error" do
-      ["-0.2", "-1"].each do |value|
-        @resource.positive_dollar_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Positive dollar attr accepts only numeric characters, period", "Positive dollar attr must be greater than or equal to 0"]
-      end
-    end
-
-    it "should return ok" do
-      ["1", "100", "1000", "1000.99"].each do |value|
-        @resource.positive_dollar_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#percent" do
-    it "should return error" do
-      ["ewqr", "&"].each do |value|
-        @resource.percent_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Percent attr accepts only numeric characters, period, negative sign, and must be equal/less/greater than +/- 100"]
-      end
-    end
-
-    it "should return ok" do
-      ["99.999", "0.001", "99"].each do |value|
-        @resource.percent_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-
-  describe "#positive_percent" do
-    it "should return error" do
-      ["-100"].each do |value|
-        @resource.positive_percent_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Positive percent attr accepts only numeric characters, period, and must be less than 100", "Positive percent attr must be greater than or equal to 0"]
-      end
-    end
-
-    it "should return ok" do
-      ["99.999", "0.001", "99"].each do |value|
-        @resource.positive_percent_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#url" do
-    it "should return error" do
-      ["ewqr", "&", "test.c", "www.test", "test.", "www-test.com"].each do |value|
-        @resource.url_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Url attr web address isnt valid"]
-      end
-    end
-
-    it "should return ok" do
-      ["http://www.example.com", "http://fiance.example.com"].each do |value|
-        @resource.url_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#ssn" do
-    it "should return error" do
-      ["111-111-111"].each do |value|
-        @resource.ssn_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Ssn attr is the wrong length (should be 9 characters)", "Ssn attr must be in the format 111-11-1111"]
-      end
-    end
-
-    it "should return ok" do
-      ["111111111"].each do |value|
-        @resource.ssn_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#taxid" do
-    it "should return error" do
-      @resource.taxid_attr = "ab-cdefgh"
-      @resource.valid?.should be_falsey
-      @resource.errors.full_messages.should == ["Taxid attr must be in the format 11-1111111"]
-    end
-
-    it "should return error is is less or more than 9 chars" do
-      ["111", "1111111111"].each do |value|
-        @resource.taxid_attr = value
-        @resource.valid?.should be_falsey
-        @resource.errors.full_messages.should == ["Taxid attr is the wrong length (should be 9 characters)", "Taxid attr must be in the format 11-1111111"]
-      end
-    end
-
-    it "should return ok" do
-      ["111111111"].each do |value|
-        @resource.taxid_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-
-  describe "#age" do
-    it "should return error" do
-      @resource.age_attr = "111"
-      @resource.valid?.should be_falsey
-      @resource.errors.full_messages.should == ["Age attr must contain only 3 numbers and less than 110"]
-    end
-
-    it "should return ok" do
-      ["1", "10", "100"].each do |value|
-        @resource.age_attr = value
-        @resource.valid?.should be_truthy
-      end
-    end
-  end
-
-  describe "#number" do
-    it "should return error" do
-      @resource.number_attr = "aaa"
-      @resource.valid?.should be_falsey
-      @resource.errors.full_messages.should == ["Number attr accepts only numbers (0-9)"]
-    end
+class NormalizedResource < Resource
+  has_normalized_attributes :name_attr => :strip,
+                            :safe_text_attr => :strip,
+                            :username_attr => :strip,
+                            :email_attr => :strip,
+                            :phone_number_attr => :phone,
+                            :phone_extension_attr => :strip,
+                            :domain_attr => :strip,
+                            :zipcode_attr => :strip,
+                            :middle_initial_attr => :strip,
+                            :dollar_attr => :dollar,
+                            :positive_dollar_attr => :dollar,
+                            :percent_attr => :percent,
+                            :positive_percent_attr => :percent,
+                            :url_attr => :strip,
+                            :ssn_attr => :ssn,
+                            :taxid_attr => :taxid,
+                            :age_attr => :number,
+                            :number_attr => :number,
+                            :rails_name_attr => :strip
+end
 
-    it "should return ok" do
-      ["1", "10", "100"].each do |value|
-        @resource.number_attr = value
-        @resource.valid?.should be_truthy
-      end
+describe "HasValidatedAttributes" do
+  context "unnormalized attributes" do
+    describe Resource do
+      has_validated_name_attribute(:name_attr, length: 10)
+      has_validated_username_attribute(:username_attr)
+      has_validated_email_attribute(:email_attr)
+      has_validated_zipcode_attribute(:zipcode_attr)
+      has_validated_phone_number_attribute(:phone_number_attr)
+      has_validated_phone_extension_attribute(:phone_extension_attr)
+      has_validated_url_attribute(:url_attr)
+      has_validated_positive_percent_attribute(:positive_percent_attr)
+      has_validated_percent_attribute(:percent_attr)
+      has_validated_age_attribute(:age_attr)
+      has_validated_positive_dollar_attribute(:positive_dollar_attr)
+      has_validated_dollar_attribute(:dollar_attr)
+      has_validated_number_attribute(:number_attr)
+      has_validated_rails_name_attribute(:rails_name_attr)
+      has_validated_taxid_attribute(:taxid_attr)
+      has_validated_ssn_attribute(:ssn_attr)
+      has_validated_safe_text_attribute(:safe_text_attr)
+      has_validated_domain_attribute(:domain_attr)
+    end
+  end
+
+  context "normalized attributes" do
+    describe NormalizedResource do
+      has_validated_phone_number_attribute(:phone_number_attr, normalized: true)
+      has_validated_positive_dollar_attribute(:positive_dollar_attr, normalized: true)
+      has_validated_dollar_attribute(:dollar_attr, normalized: true)
+      has_validated_number_attribute(:number_attr, normalized: true)
+      has_validated_taxid_attribute(:taxid_attr, normalized: true)
+      has_validated_ssn_attribute(:ssn_attr, normalized: true)
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require "active_support"
 require "active_record"
+require "has_normalized_attributes"
 require "database_cleaner"
 require "yaml"
 
@@ -16,7 +17,9 @@ load(File.dirname(__FILE__) + "/db/schema.rb")
 # Load in our code
 $LOAD_PATH.unshift "#{File.dirname(__FILE__)}/../lib"
 
+require 'shoulda-matchers'
 require 'has_validated_attributes'
+require 'has_validated_attributes/rspec'
 
 RSpec.configure do |config|
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_validated_attributes
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Kyle Ginavan
@@ -24,6 +24,40 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: shoulda-matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: has_normalized_attributes
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.0'
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.0.8
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.0'
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.0.8
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -81,6 +115,7 @@ files:
 - Rakefile
 - has_validated_attributes.gemspec
 - lib/has_validated_attributes.rb
+- lib/has_validated_attributes/rspec.rb
 - lib/version.rb
 - spec/db/database.yml
 - spec/db/schema.rb