has_stimulus_attrs 0.3.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d92df61326364a67fd89516850b87e5dfe9e85cbbc1982f6f5815978f033c18
-  data.tar.gz: d7cfcb016ff83d8aa53c43527cb6753b587958e075f071f0261cf16044365ac1
+  metadata.gz: 238aa5e7d35e278fce195e7fe5cd224f3577b1f23f42eb1ae73004fb8ea7bcd5
+  data.tar.gz: 4cd400602a164201ef84d0e69abf124fcd9afba82e8d3e30871e3bcd6df68fa1
 SHA512:
-  metadata.gz: eb72b769b5aa0ed1eadb3bb7dfaac561c987ff2d11acc9273fa80ec71284fcd790ec42bf7a78c82b607561062981b97b1fad3c611e6e57dd3662b439b584cb8d
-  data.tar.gz: 58afec2f65b664ce1a424931e7b987e0bf210343f6d782407f04514df651995107a22e8f09d9a5e9b21950caf27390f3eb88a23a8702274009a6041567ef960d
+  metadata.gz: 3db6f7a6c2b9e665061fa2daa9c21b75afafc3bc125744ee36ab19af78a47a47fad2df37ecf45e61acfd6963bd13933a5f8d1e9302f2db07a9aa6daf01556984
+  data.tar.gz: 03135bbc513eb5fd81576ef6aa6a6bd5da878fa06b49aa121ddbc037c6719d9fef015b298791834d4836c7c8d2e4b1ff08a2908f48e7ac2bd23ea4b2088d9cb0

data/.rubocop.yml

@@ -1,6 +1,8 @@
-inherit_gem:
-  rubocop-rails_config:
-    - config/rails.yml
+inherit_gem: { rubocop-rails-omakase: rubocop.yml }
+
+Style/HashSyntax:
+  EnforcedShorthandSyntax: always
 
 AllCops:
-  TargetRubyVersion: 3.1
+  NewCops: enable
+  TargetRubyVersion: 4.0.1

data/.ruby-version

@@ -1 +1 @@
-3.3.5
+4.0.1

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [0.5.0](https://github.com/tomasc/has_stimulus_attrs/compare/v0.4.1...v0.5.0) (2026-04-18)
+
+### Bug Fixes
+
+* **Non-mutating prepend pattern**: `prepend___has_stimulus___method` now builds a new Hash via `super().merge(k => v)` instead of mutating the Hash returned by super via `.tap { |d| d[k] = v }`. Required for compatibility with has_dom_attrs ≥ 0.3 (tomasc/has_dom_attrs#2), where `HasDomAttrs#dom_data` returns a shared frozen `EMPTY_HASH` constant to cut allocations. No behavioral change for existing consumers; works against both old-mutable and new-frozen bases.
+
+## [0.4.1](https://github.com/tomasc/has_stimulus_attrs/compare/v0.3.0...v0.4.1) (2025-02-13)
+
+### Bug Fixes
+
+* **Defer Proc controller evaluation to runtime**: Fixed `controller:` option with Proc values in `has_stimulus_action`, `has_stimulus_class`, `has_stimulus_outlet`, `has_stimulus_param`, `has_stimulus_target`, and `has_stimulus_value` — Procs were incorrectly evaluated at class definition time via `instance_exec`, causing failures when referencing instance methods. Controller Procs are now resolved inside runtime lambdas, matching the existing behavior of `has_stimulus_controller`.
+
 ## [0.3.0](https://github.com/tomasc/has_stimulus_attrs/compare/v0.2.2...v0.3.0) (2025-01-02)
 
 ### Performance

data/has_stimulus_attrs.gemspec

@@ -5,8 +5,8 @@ require_relative "lib/has_stimulus_attrs/version"
 Gem::Specification.new do |spec|
   spec.name = "has_stimulus_attrs"
   spec.version = HasStimulusAttrs::VERSION
-  spec.authors = ["Tomas Celizna", "Asger Behncke Jacobsen"]
-  spec.email = ["tomas.celizna@gmail.com", "a@asgerbehnckejacobsen.dk"]
+  spec.authors = [ "Tomas Celizna", "Asger Behncke Jacobsen" ]
+  spec.email = [ "tomas.celizna@gmail.com", "a@asgerbehnckejacobsen.dk" ]
 
   spec.summary = "Helper methods for dealing with stimulus attributes."
   spec.description = "Helper methods for dealing with stimulus attributes."
@@ -24,16 +24,17 @@ Gem::Specification.new do |spec|
   end
   spec.bindir = "exe"
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = [ "lib" ]
 
   spec.add_dependency "stimulus_helpers", "~> 0.1"
-  spec.add_dependency "has_dom_attrs", "~> 0.1"
+  spec.add_dependency "has_dom_attrs", "~> 0.3"
   spec.add_dependency "activesupport", ">= 7.0"
 
+  spec.add_development_dependency "benchmark"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "minitest", "~> 6.0"
 
   spec.add_development_dependency "lefthook"
-  spec.add_development_dependency "rubocop-rails_config"
+  spec.add_development_dependency "rubocop-rails-omakase"
 end

data/lib/has_stimulus_attrs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HasStimulusAttrs
-  VERSION = "0.3.0"
+  VERSION = "0.5.0"
 end

data/lib/has_stimulus_attrs.rb

@@ -33,106 +33,99 @@ module HasStimulusAttrs
     end
 
     def has_stimulus_action(event, action, controller: nil, **options)
-      controller = case controller
-                  when Proc then instance_exec(&controller)
-                  else controller
-                  end
-
       key = :action
       val = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
         a = case action
-            when Proc then instance_exec(&action)
-            else action.to_s
+        when Proc then instance_exec(&action)
+        else action.to_s
         end
-        stimulus_action((controller || controller_name), event, a).values.first
+        stimulus_action((c || controller_name), event, a).values.first
       }
 
       prepend___has_stimulus___method(key, val, **options)
     end
 
     def has_stimulus_class(name, value, controller: nil, **options)
-      controller = case controller
-                  when Proc then instance_exec(&controller)
-                  else controller
-      end
-
-      key = -> { stimulus_class((controller || controller_name), name, "N/A").keys.first }
+      key = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
+        stimulus_class((c || controller_name), name, "N/A").keys.first
+      }
       val = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
         v = case value
-            when Proc then instance_exec(&value)
-            else value.to_s
+        when Proc then instance_exec(&value)
+        else value.to_s
         end
-        stimulus_class((controller || controller_name), name, v).values.first
+        stimulus_class((c || controller_name), name, v).values.first
       }
 
       prepend___has_stimulus___method(key, val, **options)
     end
 
     def has_stimulus_outlet(name, value, controller: nil, **options)
-      controller = case controller
-                  when Proc then instance_exec(&controller)
-                  else controller
-      end
-
-      key = -> { stimulus_outlet((controller || controller_name), name, "N/A").keys.first }
+      key = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
+        stimulus_outlet((c || controller_name), name, "N/A").keys.first
+      }
       val = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
         v = case value
-            when Proc then instance_exec(&value)
-            when Symbol then send(value)
-            else value
+        when Proc then instance_exec(&value)
+        when Symbol then send(value)
+        else value
         end
-        stimulus_outlet((controller || controller_name), name, v).values.first
+        stimulus_outlet((c || controller_name), name, v).values.first
       }
 
       prepend___has_stimulus___method(key, val, **options)
     end
 
     def has_stimulus_param(name, value, controller: nil, **options)
-      controller = case controller
-                  when Proc then instance_exec(&controller)
-                  else controller
-      end
-
-      key = -> { stimulus_param((controller || controller_name), name, "N/A").keys.first }
+      key = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
+        stimulus_param((c || controller_name), name, "N/A").keys.first
+      }
       val = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
         v = case value
-            when Proc then instance_exec(&value)
-            when Symbol then send(value)
-            else value
+        when Proc then instance_exec(&value)
+        when Symbol then send(value)
+        else value
         end
-        stimulus_param((controller || controller_name), name, v).values.first
+        stimulus_param((c || controller_name), name, v).values.first
       }
 
       prepend___has_stimulus___method(key, val, **options)
     end
 
     def has_stimulus_target(name, controller: nil, **options)
-      controller = case controller
-                  when Proc then instance_exec(&controller)
-                  else controller
-      end
-
-      key = -> { stimulus_target((controller || controller_name), name).keys.first }
-      val = -> { stimulus_target((controller || controller_name), name).values.first }
+      key = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
+        stimulus_target((c || controller_name), name).keys.first
+      }
+      val = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
+        stimulus_target((c || controller_name), name).values.first
+      }
 
       prepend___has_stimulus___method(key, val, **options)
     end
 
     def has_stimulus_value(name, value = nil, controller: nil, **options)
-      controller = case controller
-                  when Proc then instance_exec(&controller)
-                  else controller
-      end
-
-      key = -> { stimulus_value((controller || controller_name), name, "N/A").keys.first }
+      key = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
+        stimulus_value((c || controller_name), name, "N/A").keys.first
+      }
       val = -> {
+        c = controller.is_a?(Proc) ? instance_exec(&controller) : controller
         v = case value
-            when Proc then instance_exec(&value)
-            when Symbol then send(value)
-            when NilClass then send(name)
-            else value
+        when Proc then instance_exec(&value)
+        when Symbol then send(value)
+        when NilClass then send(name)
+        else value
         end
-        stimulus_value((controller || controller_name), name, v).values.first
+        stimulus_value((c || controller_name), name, v).values.first
       }
 
       prepend___has_stimulus___method(key, val, **options)
@@ -148,64 +141,64 @@ module HasStimulusAttrs
               if options.key?(:if)
                 cond = options[:if]
                 cond_value = case cond
-                           when Proc then instance_exec(&cond)
-                           when Symbol, String then send(cond)
-                           else cond
-                           end
+                when Proc then instance_exec(&cond)
+                when Symbol, String then send(cond)
+                else cond
+                end
                 return super() unless cond_value
               end
 
               if options.key?(:unless)
                 cond = options[:unless]
                 cond_value = case cond
-                           when Proc then instance_exec(&cond)
-                           when Symbol, String then send(cond)
-                           else cond
-                           end
+                when Proc then instance_exec(&cond)
+                when Symbol, String then send(cond)
+                else cond
+                end
                 return super() if cond_value
               end
 
               # Only evaluate key and value if conditions pass
               k = case key
-                  when Proc then instance_exec(&key)
-                  else key
+              when Proc then instance_exec(&key)
+              else key
               end
 
               v = case value
-                  when Proc then instance_exec(&value)
-                  else value
+              when Proc then instance_exec(&value)
+              else value
               end
 
-              super().tap do |data|
-                data[k] = [data[k], v].reject(&:blank?).uniq.join(" ")
-              end
+              current = super()
+              merged_value = [ current[k], v ].reject(&:blank?).uniq.join(" ")
+              current.merge(k => merged_value)
             end
           end
         )
-        
+
         # Then, ensure memoization is always at the top
         ensure_memoization_at_top
       end
-      
+
       def ensure_memoization_at_top
         # Remove any existing memoization module
         if const_defined?(:StimulusMemoization, false)
           remove_const(:StimulusMemoization)
         end
-        
+
         # Create a new memoization module at the top
         memoization_module = Module.new do
           def dom_data
             return @_stimulus_dom_data if defined?(@_stimulus_dom_data)
             @_stimulus_dom_data = super
           end
-          
+
           def reset_dom_data_cache!
             remove_instance_variable(:@_stimulus_dom_data) if defined?(@_stimulus_dom_data)
             super if defined?(super)
           end
         end
-        
+
         const_set(:StimulusMemoization, memoization_module)
         prepend(memoization_module)
       end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: has_stimulus_attrs
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Tomas Celizna
 - Asger Behncke Jacobsen
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-06-02 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stimulus_helpers
@@ -31,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -53,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
+- !ruby/object:Gem::Dependency
+  name: benchmark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -87,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: lefthook
   requirement: !ruby/object:Gem::Requirement
@@ -110,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rails_config
+  name: rubocop-rails-omakase
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -150,7 +163,6 @@ metadata:
   homepage_uri: https://github.com/tomasc/has_stimulus_attrs
   source_code_uri: https://github.com/tomasc/has_stimulus_attrs
   changelog_uri: https://github.com/tomasc/has_stimulus_attrs/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -165,8 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 4.0.5
 specification_version: 4
 summary: Helper methods for dealing with stimulus attributes.
 test_files: []