has_state_machine 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94b18269b2a7ac5e0b6ca2aedf9591a78111e30089dfe8a000190bad02725d71
-  data.tar.gz: 93ce1793915219f7b00725c2faf977cdbd62f40d20fefa21b680b281378ed242
+  metadata.gz: 67cb6cdd8b2615f9ca486802de5ef3bd55d5cc3f935ec069a9c888adf509a844
+  data.tar.gz: ae0d204c60f82cab7656633e562d49b7ee0501e4b15a65c9daa3b19cb9b5e92a
 SHA512:
-  metadata.gz: 82344021e6dd63dde02dbfcb261b39b8773b51cff31ab37846441e655d420dfa9ba63128a893d9c7a11a83c15371320575871bd0e2f32f6c6061c84a8fe72984
-  data.tar.gz: a2cef6e05f4eb1c63fd2002478c0d2fc9a673cbc1b6be9ec2c13288eee5d0d12b7438514489fc6dc75e9fa257f7571f6f67b3694351be33fe041c5095b115dc3
+  metadata.gz: a5863cd591499b89b2fbd77140b665c795bc552d686040faa7ebf3dad26f1b19ae3c4dd7f88a88e1aea31a3fb49168f35b3ff11a9d5e3294cea0fd1aa26ada26
+  data.tar.gz: 399f43970999929b7f50735479e598271d2c3d831c744cb83d12317cca01d09169535088dbdbeb8e7fd7e668d1b2a48be11528fe084802524cbe2dffa374ae6a

data/README.md

@@ -292,7 +292,7 @@ end
 `after_transition_commit` callbacks run after the outermost database transaction commits. In detail:
 
 - If no transaction is open when `transition_to` is called, they run immediately after the transition commits.
-- If the transition happens inside an open transaction — an app-level `ActiveRecord::Base.transaction`, or a nested transition triggered from another state's `before_transition`/`after_transition` — they are deferred until that outermost transaction commits.
+- If the transition happens inside an open transaction — an app-level `ActiveRecord::Base.transaction`, or a nested transition triggered from another state's `before_transition`/`after_transition` — they are deferred until that outermost transaction commits, however deeply nested, including through `requires_new` savepoints and `joinable: false` blocks.
 - They never run if the transition fails, if `rollback_transition` is raised, or if a surrounding transaction rolls back after the transition. Multiple transitions inside one transaction each fire their callbacks after commit, in transition order.
 
 This makes `after_transition_commit` the safe place to enqueue background jobs, call external APIs, etc.: the work only happens once the new state is actually visible to other database connections.

data/lib/has_state_machine/state.rb

@@ -130,15 +130,20 @@ module HasStateMachine
       true
     end
 
-    # Use the current transaction: after_all_transactions_commit ignores our
-    # non-joinable transactions and would run callbacks before commit.
     def enqueue_transition_commit_callbacks
-      current_transaction = object.class.connection.current_transaction
+      after_outermost_commit { run_callbacks(:transition_commit) { true } }
+    end
+
+    # Walk up to the real COMMIT: Rails runs after_commit early under a
+    # non-joinable parent, and after_all_transactions_commit skips those.
+    def after_outermost_commit(&block)
+      transaction = object.class.connection.current_transaction
+      return yield unless transaction.open?
 
-      # Rails < 7.2 has no Transaction#after_commit; run callbacks immediately.
-      return run_callbacks(:transition_commit) { true } unless current_transaction.respond_to?(:after_commit)
+      # Rails < 7.2 has no Transaction#after_commit.
+      return yield unless transaction.respond_to?(:after_commit)
 
-      current_transaction.after_commit { run_callbacks(:transition_commit) { true } }
+      transaction.after_commit { after_outermost_commit(&block) }
     end
 
     def rollback_transition

data/lib/has_state_machine/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HasStateMachine
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_state_machine
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Benjamin Hargett