has_setting 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fcd273ff228a9458fcbf258477f6bf309a67b1d8
-  data.tar.gz: d04409c08792279490a8e2df7b42a9b8a4be874e
+  metadata.gz: c320931c608eaeac7b2134bd75561e57932a6cf8
+  data.tar.gz: 8b7b9a8993158a8b1ef7e584f5b63471c71a7649
 SHA512:
-  metadata.gz: dff3dd2c4471a1fa7d3106d09348c2ac93de4ae2cc089ff07138e942bba08d4700f4732a195f3b528499af5894a3146cc3ba7321887ee9b21ae3bae41d17ceb7
-  data.tar.gz: f6d45f3ea98d6a69c10301b7dc8d9581e9e4ba88dfb56139dc85dcc0a6b1cafa7a23f8dfe52473ab12b8a5f65a66ad3535ddbaeb3f6c9d49f0062fe6816db5af
+  metadata.gz: e83389a8001fd0906c1c0e53f8a4ed605115a29998d3f6c6d9f21075137f2a733707495c47fde702ce21683e0b0edfbdfa21c7bcf859ae7f12f7493c4da33f36
+  data.tar.gz: 602429b6032d14d649ac29f87f3885c4c678fdc4f7853e2460ec21aaa47344ac593f5963cbec60ea37f8fed8d6dd88a4a080c5b880334bb7530f67f1bef36813

data/lib/has_setting/ar_extensions.rb

@@ -59,6 +59,9 @@ module HasSetting
     setting = self.settings.detect() {|item| item.name == name and item.locale.to_s == locale.to_s }
     setting = self.settings.build(:name => name, locale: locale) if setting.blank?
     setting.value = value
+    # mark model as changed to make sure model is saved so that after_save is triggered even if only settings change
+    # maybe there is a better way of doing this.
+    self.updated_at = Time.now if self.respond_to?(:updated_at)
   end
 
   def read_setting(name)

data/lib/has_setting/version.rb

@@ -1,3 +1,3 @@
 module HasSetting
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

data/test/unit/has_setting_test.rb

@@ -6,19 +6,13 @@ class HasSettingTest < Test::Unit::TestCase
     @bar = Bar.create!
     @baz = Baz.create!
   end
-  
-  
+
+
   def test_setting_has_accessors
     assert @foo.respond_to?(:setting_1)
     assert @foo.respond_to?(:setting_1=)
   end
-  
-  
-  def test_has_many
-    assert @foo.respond_to?(:settings)
-    assert @foo.settings.is_a?(Array)
-  end
-  
+
   def test_settings_are_destroyed
     count_before = HasSetting::Setting.count
     @foo.setting_1 = 10
@@ -26,9 +20,9 @@ class HasSettingTest < Test::Unit::TestCase
     assert_equal(count_before + 1, HasSetting::Setting.count)
     @foo.destroy
     assert_equal(count_before, HasSetting::Setting.count)
-    
+
   end
-  
+
   def test_write_setting
     count_before = HasSetting::Setting.count
     @foo.write_setting('name', 'value1')
@@ -37,14 +31,14 @@ class HasSettingTest < Test::Unit::TestCase
     setting = @foo.read_setting('name')
     assert setting
     assert_equal('value1', setting.value)
-    
+
     @foo.write_setting('name', 'value2')
-    assert_equal(count_before + 1, HasSetting::Setting.count) 
+    assert_equal(count_before + 1, HasSetting::Setting.count)
     setting = @foo.read_setting('name')
     assert setting
     assert_equal('value2', setting.value)
   end
-  
+
   def test_setting_accessors
     count_before = HasSetting::Setting.count
     assert(!@foo.setting_1)
@@ -55,7 +49,7 @@ class HasSettingTest < Test::Unit::TestCase
     @foo.setting_1 = 'bla'
     assert_equal('bla', @foo.setting_1)
   end
-  
+
   def test_different_classes_do_not_share_setting
     count_before = HasSetting::Setting.count
     @foo.setting_1 = 'foo'
@@ -63,43 +57,43 @@ class HasSettingTest < Test::Unit::TestCase
     @bar.setting_1 = 'bar'
     @bar.save!
     assert_equal(count_before + 2, HasSetting::Setting.count)
-    
+
     assert_equal('foo', @foo.setting_1)
     assert_equal('bar', @bar.setting_1)
   end
 
-  
+
   def test_has_nil_setting
     @foo.setting_1 = nil
     assert(@foo.read_setting('setting_1'))
     assert(!@foo.setting_1)
   end
-  
+
   def test_options_on_getter
     @foo.setting_1 = '12.3'
     assert_equal('12.3', @foo.setting_1)
     assert_equal(12, @foo.setting_1(:type => :int))
     assert_equal(12.3, @foo.setting_1(:type => :float))
-    
+
     # Foo.setting_2 is a float setting. Override and get as string
     @foo.setting_2 = 12.3
     assert_equal('12.3', @foo.setting_2(:type => :string))
   end
-  
+
   def test_different_classes_do_not_share_options()
     @foo.setting_2 = 12.3
     assert_equal(12.3, @foo.setting_2)
     @bar.setting_2 = 12.3
     assert_equal(12, @bar.setting_2)
   end
-  
+
   def test_default_values()
     assert_equal('def', @foo.with_default)
     assert_equal('override def', @foo.with_default(:default => 'override def'))
     @foo.with_default = 'not def'
     assert_equal('not def', @foo.with_default)
   end
-  
+
   def test_write_settings_without_saved_parent
     my_foo = Foo.new
     count_before = HasSetting::Setting.count
@@ -110,19 +104,19 @@ class HasSettingTest < Test::Unit::TestCase
     assert_equal(count_before + 1, HasSetting::Setting.count)
     assert_equal('radabumm', my_foo.with_default)
   end
-  
+
   def test_not_everyone_has_settings_association
     assert_equal(true, @foo.respond_to?(:settings))
     assert_equal(true, @bar.respond_to?(:settings))
     assert_equal(false, @baz.respond_to?(:settings))
   end
-  
-  
+
+
   def test_boolean_setting_without_default
     assert_equal nil, @foo.setting_3
     @foo.setting_3 = true
     @foo.save!
-    
+
     @foo = Foo.find @foo.id
     assert_equal true, @foo.setting_3
   end
@@ -133,7 +127,7 @@ class HasSettingTest < Test::Unit::TestCase
     @foo = Foo.find @foo.id
     assert_equal true, @foo.setting_4
   end
-  
+
   def test_boolean_setting_with_default_and_no_saving
     assert_equal false, @foo.setting_4
     @foo.setting_4 = true
@@ -153,6 +147,6 @@ class HasSettingTest < Test::Unit::TestCase
     I18n.locale = :de
     assert_equal 'setting de', @bar.setting_1
   end
-  
-  
+
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_setting
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Simplificator GmbH
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-19 00:00:00.000000000 Z
+date: 2013-06-20 00:00:00.000000000 Z
 dependencies: []
 description: Stores settings as key/value pairs in a settings table and provides accessors
   for them on the owning object