has_seo_fields 0.0.3 → 0.0.4

data/lib/has_seo_fields.rb

@@ -9,25 +9,33 @@ module HasSeoFields
   end
 
   module ClassMethods
-    def has_seo_fields *args
+    def has_seo_fields options
+      @@seo_names = {}
 
-      args.map! do |field|
-        getter_name = "seo_#{field}"
+      options.each do |key, v|
+        getter_name = :"seo_#{key}"
 
+        # @city.seo_h1_tag
         define_method getter_name do
-          field.value if (field = seo_fields.find_by_name getter_name)
+          if field = seo_fields.find_by_name(getter_name)
+            field.value
+          else
+            @@seo_names[getter_name]
+          end
         end
 
+        # @city.seo_h1_tag=
         define_method "#{getter_name}=" do |value|
-          if (field = seo_fields.find_by_name getter_name)
-            field.update_attribute :value, value
-          elsif value.present?
-            seo_fields.create :name => getter_name, :value => value
-          end
+          field = seo_fields.find_or_initialize_by_name getter_name
+          return field.destroy if value.empty? || value == @@seo_names[getter_name]
+
+          field.update_attribute(:value, value)
         end
-        getter_name
+
+        @@seo_names[getter_name] = v
       end
-      const_set "SEO_NAMES", args
+
+      const_set "SEO_NAMES", @@seo_names
     end
   end
 end

data/lib/has_seo_fields/version.rb

@@ -1,3 +1,3 @@
 module HasSeoFields
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/lib/has_seo_fields_spec.rb

@@ -9,7 +9,7 @@ describe HasSeoFields do
   end
 
   it "sets SEO_NAMES" do
-    subject.class::SEO_NAMES.should eql(['seo_h1_tag', 'seo_title'])
+    subject.class::SEO_NAMES.should eql({ :seo_h1_tag => 'It is your city!', :seo_title => 'Clubs, bars, etc.' })
   end
 
   context "getters" do
@@ -19,8 +19,8 @@ describe HasSeoFields do
       subject.seo_h1_tag.should eql('Cool!')
     end
 
-    it "returns nil if nothing founded" do
-      subject.seo_title.should be_nil
+    it "returns the default value if nothing founded" do
+      subject.seo_title.should eql('Clubs, bars, etc.')
     end
   end
 
@@ -38,9 +38,26 @@ describe HasSeoFields do
         subject.seo_fields.find_by_name('seo_h1_tag').value.should eql('Cool city')
       end
 
-      it "does not creates entries with empty strings as values" do
-        subject.seo_h1_tag=''
-        subject.seo_fields.should have(0).items
+      it "does note creates seo field if given value equals the default one" do
+        subject.seo_title = 'Clubs, bars, etc.'
+        subject.seo_fields.should have(0).item
+      end
+
+      describe "when empty string given" do
+
+        it "does not creates entries with empty strings as values" do
+          subject.seo_h1_tag = ''
+          subject.seo_fields.should have(0).items
+        end
+
+        it "removes existing record if present" do
+          subject.seo_fields.create :name => 'seo_h1_tag', :value => 'Cool!'
+          seo_title = subject.seo_fields.create :name => 'seo_title', :value => 'Best city ever!'
+          subject.seo_h1_tag = ''
+          subject.reload
+
+          subject.seo_fields.should eql([seo_title])
+        end
       end
     end
 

data/spec/support/models.rb

@@ -1,5 +1,5 @@
 class City < ActiveRecord::Base
-  has_seo_fields :h1_tag, :title
+  has_seo_fields :h1_tag => 'It is your city!', :title => 'Clubs, bars, etc.'
 end
 
 class SeoField < ActiveRecord::Base

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: has_seo_fields
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Nick Erlikh
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-12-09 00:00:00 Z
+date: 2011-12-14 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord