has_seo_fields 0.0.1 → 0.0.2

data/lib/has_seo_fields/version.rb

@@ -1,3 +1,3 @@
 module HasSeoFields
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/has_seo_fields.rb

@@ -10,22 +10,24 @@ module HasSeoFields
 
   module ClassMethods
     def has_seo_fields *args
-      const_set "SEO_NAMES", args
 
-      args.each do |field|
+      args.map! do |field|
         getter_name = "seo_#{field}"
 
         define_method getter_name do
+          field.value if (field = seo_fields.find_by_name getter_name)
         end
 
         define_method "#{getter_name}=" do |value|
-          if (field = seo_fields.find_by_name(getter_name))
+          if (field = seo_fields.find_by_name getter_name)
             field.update_attribute :value, value
           else
             seo_fields.create :name => getter_name, :value => value
           end
         end
+        getter_name
       end
+      const_set "SEO_NAMES", args
     end
   end
 

data/spec/lib/has_seo_fields_spec.rb

@@ -9,7 +9,20 @@ describe HasSeoFields do
   end
 
   it "sets SEO_NAMES" do
-    subject.class::SEO_NAMES.should eql([:h1_tag, :title])
+    subject.class::SEO_NAMES.should eql(['seo_h1_tag', 'seo_title'])
+  end
+
+  context "getters" do
+
+    it "finds existing record by the name" do
+      subject.seo_fields.create :name => 'seo_h1_tag', :value => 'Cool!'
+      subject.seo_h1_tag.should eql('Cool!')
+    end
+
+    it "returns nil if nothing founded" do
+      subject.seo_title.should be_nil
+    end
+
   end
 
   context "setters" do
@@ -18,11 +31,12 @@ describe HasSeoFields do
       subject.should respond_to('seo_h1_tag=', 'seo_title=')
     end
 
-    describe "seo field with that name does not exists" do
+    describe "seo field with name that does not exists" do
 
-      it "create needed seo field with given value" do
+      it "creates needed seo field with given value" do
         subject.seo_h1_tag='Cool city'
-        subject.seo_fields.where(:name => 'seo_h1_tag').should have(1).item
+        subject.seo_fields.should have(1).item
+        subject.seo_fields.find_by_name('seo_h1_tag').value.should eql('Cool city')
       end
     end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: has_seo_fields
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - Nick Erlikh