has_secure_attribute 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 407ec97a134d4ff2d2ecc448a0c2b538b51945f9
-  data.tar.gz: 26c2a1fef2541a2954e468714effe93cf6fbe8cd
+  metadata.gz: 21d52ef0208b3210f48d7968e7f28b608039353f
+  data.tar.gz: 283b78f054f1610670abebc05b7a280a42c693bd
 SHA512:
-  metadata.gz: 3851f367a95043922611cf6f73589e1ddcb5f0e14c4eefe64425ed243ebea0633af5571ce6d830862032746daef3352812a36a20818bd917cf694b1ae0448aab
-  data.tar.gz: e22119c5300c2128acaa8dc803dec34e0f0b417770d595d89087ea83fbebed59d4a71a999fb15da96f48a55f073475c1e3badd57d611ee0ac45726df373a89e1
+  metadata.gz: 427ce061b78c731ade3192481bde53975f5fffd3f88d0dac299ae99e4de2fc6d409c5aa5faafd82392055369c6b7cee693d8cffe73f532f2070d1b11eb820fce
+  data.tar.gz: 687b7590e7250bad4ca8214c42834073e21703249625f41279bd90c9cafec56f36e9ec4b98a27a3d9cc5d0276093382a5df0859cd407868e5ecfebe394b90ea8

data/README.md

@@ -1,7 +1,7 @@
 `has_secure_attribute`
 ======================
 
-Why have `has_secure_password` and not any attribute that you want. I believe that, quite often, we want to one-way encrypt one attribute and authenticate against its value, and this is not only the `password` case.
+Why have `has_secure_password` and not any attribute that you want? I believe that, quite often, we want to one-way encrypt one attribute and authenticate against its value, and this is not only the `password` case.
 
 Requires
 --------
@@ -36,6 +36,8 @@ In the above example:
   * It raises an exception if `security_answer_digest` is empty on create.
 * It defines the method `authenticate_security_answer(answer_to_authenticate)` which returns `false` if the answer given does not correspond to the saved digest, or returns the object instance itself if it does.
 
+__Case Insensitive Values__: you can pass `case_insensitive => false` if you want to handle values that match even if they differ on case. Then, `answer` will match `Answer`, for example.
+
 Do you want to test it?
 ------------------------
 

data/lib/active_model/secure_attribute/has_secure_attribute.rb

@@ -21,7 +21,7 @@ module ActiveModel
       def has_secure_attribute(meth, *args, &block)
         attribute_sym = meth.to_sym
         attr_reader attribute_sym # setter is defined later on
-        options = {:validations => true, :protect_setter_for_digest => false}
+        options = {validations: true, protect_setter_for_digest: false, case_sensitive: true}
         options.merge! args[0] unless args.blank?
         if options[:validations]
           validates attribute_sym,                          confirmation: true, if: lambda { |m| m.send(attribute_sym).present? }
@@ -30,18 +30,18 @@ module ActiveModel
           before_create { raise "#{attribute_sym}_digest missing on new record" if send("#{attribute_sym}_digest").blank? }
         end
 
-        define_setter(attribute_sym)
+        define_setter(attribute_sym, options)
         protect_setter_for_digest(attribute_sym) if options[:protect_setter_for_digest]
 
-        define_authenticate_method(attribute_sym)
+        define_authenticate_method(attribute_sym, options)
       end
 
-      def define_setter(attribute_sym)
+      def define_setter(attribute_sym, options)
         define_method "#{attribute_sym.to_s}=" do |unencrypted_value|
           unless unencrypted_value.blank?
             instance_variable_set("@#{attribute_sym.to_s}".to_sym, unencrypted_value)
             cost = ActiveModel::SecureAttribute.min_cost ? BCrypt::Engine::MIN_COST : BCrypt::Engine::DEFAULT_COST
-            send("#{attribute_sym.to_s}_digest=".to_sym, BCrypt::Password.create(unencrypted_value, cost: cost))
+            send("#{attribute_sym.to_s}_digest=".to_sym, BCrypt::Password.create(options[:case_sensitive] ? unencrypted_value : unencrypted_value.downcase, cost: cost))
           end
         end
       end
@@ -53,9 +53,9 @@ module ActiveModel
         protected "#{attribute_sym}_digest=".to_sym
       end
 
-      def define_authenticate_method(attribute_sym)
+      def define_authenticate_method(attribute_sym, options)
         define_method "authenticate_#{attribute_sym}" do |value|
-          BCrypt::Password.new(send("#{attribute_sym}_digest")) == value && self
+          BCrypt::Password.new(send("#{attribute_sym}_digest")) == (options[:case_sensitive] ? value : value.downcase) && self
         end
       end
 

data/lib/has_secure_attribute/version.rb

@@ -1,3 +1,3 @@
 module HasSecureAttribute
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/spec/factories/test_model_with_attributes.rb

@@ -24,4 +24,13 @@ FactoryGirl.define do
     security_answer 'answer'
     security_answer_confirmation 'answer'
   end
+
+  factory :test_model_with_attribute_with_case_sensitive do
+    username 'username_protect'
+    password 'password'
+    password_confirmation 'password'
+    security_question 'question'
+    security_answer 'answer'
+    security_answer_confirmation 'answer'
+  end
 end

data/spec/models/has_secure_attribute_spec.rb

@@ -163,3 +163,11 @@ describe TestModelWithAttributeProtectSetterForDigest do
     end.should raise_error NoMethodError
   end
 end
+
+describe TestModelWithAttributeWithCaseSensitive do
+  it 'should authenticate even if answer is of different case' do
+    t = FactoryGirl.create :test_model_with_attribute_with_case_sensitive, security_answer: 'Answer', security_answer_confirmation: 'Answer'
+
+    t.authenticate_security_answer('answer').should eq t
+  end
+end

data/spec/models/test_model_with_attribute_with_case_sensitive.rb

@@ -0,0 +1,8 @@
+class TestModelWithAttributeWithCaseSensitive < ActiveRecord::Base
+  self.table_name = "test_model_with_attributes"
+  has_secure_password
+  has_secure_security_answer :case_sensitive => false
+
+  validates :username,          :presence => true, :uniqueness => {:case_sensitive => false}
+  validates :security_question, :presence => true
+end

data/spec/spec_helper.rb

@@ -7,6 +7,7 @@ require File.expand_path("../../lib/active_model/secure_attribute/has_secure_att
 require File.expand_path("../models/test_model_with_attribute", __FILE__)
 require File.expand_path("../models/test_model_with_attribute_no_validation", __FILE__)
 require File.expand_path("../models/test_model_with_attribute_protect_setter_for_digest", __FILE__)
+require File.expand_path("../models/test_model_with_attribute_with_case_sensitive", __FILE__)
 
 require 'factory_girl'
 FactoryGirl.find_definitions

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_secure_attribute
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Panayotis Matsinopoulos
@@ -126,6 +126,7 @@ files:
 - spec/models/test_model_with_attribute_no_validation.rb
 - spec/models/test_model_with_attribute_protect_setter_for_digest.rb
 - spec/models/test_model_with_attribute.rb
+- spec/models/test_model_with_attribute_with_case_sensitive.rb
 - spec/db/migrate/db_helper.rb
 - spec/db/migrate/create_test_model_with_attributes.rb
 - README.md