has_normalized_attributes 0.0.6 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e37778b8ae93697c06b768b3f52735fe2b64897
-  data.tar.gz: 8e03c4140fb42e08d54fc997163b521ec2efbc68
+  metadata.gz: 91dc221ce7007d6265c70324eb766a71b7d094a0
+  data.tar.gz: f3d16b28f11791f70d98356f950b2fe346c8db2f
 SHA512:
-  metadata.gz: e4e44f282445e6d70d068b823fe24428db232622d2df8a3c96546a3e727493e5c39b30ca8225516246d8268f6b48f5635d08b9c9ac8a2ba87cd581186afc7f8b
-  data.tar.gz: b20e70e100b07c2b797037dae4d53372f33d3a4e19a126c88d88937bda337f190842733ec5f033568cfebd63c957951b742fa63c502d1836384c1af5f494639c
+  metadata.gz: d1fe3bacd965a7ef3880ccb64d38081413c5ccba78d3448a8babffd0be09219992d58f8dc619ab11d0cef93df74e5af3e3fa42257bd38946465adac08c7dbfc3
+  data.tar.gz: 211acf70d9871c0d78bdaa4c053d347970370256580831a84a3df63a7588016788d016475774057855a8a3afb0d9b1b458e3a02fff198eb3c5e8f25964822b95

data/.travis.yml

@@ -1,5 +1,2 @@
-rvm:
-  - 1.9.3
-  - 1.9.2
-  
+rvm: "2.1.2"
 script: rake spec

data/lib/has_normalized_attributes.rb

@@ -10,9 +10,8 @@ module HasNormalizedAttributes
         # E.g. `normalize_dollar` will first call the original `normalize_dollar` method (super)
         # and then use the result from that to check for parentheses.
         define_method "normalize_#{ arg }" do
-          super().tap do |result|
-            result.sub! /\A\((.*)\)\Z/, '-\1' if result.respond_to?(:sub!)
-          end
+          result = super()
+          result.is_a?(String) ? result.sub(/\A\((.*)\)\Z/, '-\1') : result
         end
       end
     end
@@ -35,10 +34,10 @@ module HasNormalizedAttributes
     args.each do |arg|
       define_method "normalize_#{arg}" do
         if arg == :strip
-          self ? self.strip! : self
+          self ? self.strip : self
         else
           reg_exp = HasNormalizedAttributes.const_get(arg.upcase)
-          self && is_a?(String) && match(reg_exp) ? gsub!(reg_exp,'') : self
+          self && is_a?(String) && match(reg_exp) ? gsub(reg_exp,'') : self
         end
       end
     end
@@ -58,9 +57,11 @@ module HasNormalizedAttributes
       args.each do |field, normalization_type|
         define_method "#{field.to_s}=" do |value|
           if value.present?
-            value.send("normalize_#{normalization_type.downcase}".to_sym)
+            normalized_value = value.send("normalize_#{normalization_type.downcase}".to_sym)
+          else
+            normalized_value = value
           end
-          super value
+          super normalized_value
         end
       end
 

data/lib/version.rb

@@ -1,3 +1,3 @@
 module HasNormalizedAttributes
-  VERSION = "0.0.6"
+  VERSION = "0.0.8"
 end

data/spec/has_normalized_fields_spec.rb

@@ -97,6 +97,7 @@ describe "HasNormalizedAttributes" do
     it{@resource.dollar_attr = "(321.45)";@resource.dollar_attr.should == "-321.45"}
     it{@resource.dollar_attr = "$(321.45)";@resource.dollar_attr.should == "-321.45"}
     it{@resource.dollar_attr = "($321.45)";@resource.dollar_attr.should == "-321.45"}
+    it{@resource.dollar_attr = BigDecimal("321.45");@resource.dollar_attr.should == "321.45"}
   end
 
   describe "#number" do
@@ -105,9 +106,10 @@ describe "HasNormalizedAttributes" do
     it{@resource.number_attr = "1\t23\t";@resource.number_attr.should == "123"}
     it{@resource.number_attr = "";@resource.number_attr.should == ""}
     it{@resource.number_attr = nil;@resource.number_attr.should == nil}
-    it{@resource.dollar_attr = 111111.51;@resource.dollar_attr.should == "111111.51"}
-    it{@resource.dollar_attr = "(321.45)";@resource.dollar_attr.should == "-321.45"}
-    it{@resource.dollar_attr = "-321.45";@resource.dollar_attr.should == "-321.45"}
+    it{@resource.number_attr = 111111.51;@resource.number_attr.should == "111111.51"}
+    it{@resource.number_attr = "(321.45)";@resource.number_attr.should == "-321.45"}
+    it{@resource.number_attr = "-321.45";@resource.number_attr.should == "-321.45"}
+    it{@resource.number_attr = BigDecimal("321.45");@resource.number_attr.should == "321.45"}
   end
 
   describe "#percent" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_normalized_attributes
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.8
 platform: ruby
 authors:
 - Kyle Ginavan