has_moderated 1.2.2 → 1.2.3

data/spec/has_moderated/has_one_spec.rb

@@ -0,0 +1,119 @@
+require 'spec_helper'
+
+describe "has_one" do
+  context "has_one association:" do
+    before do
+      dynamic_models.task {
+        has_one :renamed_subtask, :class_name => "Subtask", :foreign_key => "task_id"
+        has_moderated_association :renamed_subtask
+      }.subtask {
+        belongs_to :task
+      }
+    end
+
+    it "creates and associates subtask (= new, task save)" do
+      task = Task.create! :title => "Task 1"
+      Moderation.count.should eq(0)
+      task.renamed_subtask = Subtask.new :title => "Subtask 1"
+      task.save
+
+      task = Task.first
+      task.renamed_subtask.should be_nil
+      Subtask.count.should eq(0)
+
+      Moderation.count.should eq(1)
+      Moderation.last.accept
+      Moderation.count.should eq(0)
+
+      subtask = Task.first.renamed_subtask
+      subtask.title.should eq("Subtask 1")
+    end
+
+    it "creates and associates subtask (= create, task save)" do
+      task = Task.create! :title => "Task 1"
+      Moderation.count.should eq(0)
+      task.renamed_subtask = Subtask.create! :title => "Subtask 1"
+      task.save
+
+      task = Task.first
+      task.renamed_subtask.should be_nil
+
+      Moderation.count.should eq(1)
+      Moderation.last.accept
+      Moderation.count.should eq(0)
+
+      subtask = Task.first.renamed_subtask
+      subtask.title.should eq("Subtask 1")
+    end
+
+    it "set subtask to nil (delete)" do
+      task = Task.create! :title => "Task 1"
+      task.renamed_subtask = Subtask.new :title => "Subtask 1"
+      task.save
+      Moderation.last.accept
+
+      Moderation.count.should eq(0)
+      Task.first.renamed_subtask.should_not be_nil
+
+      Task.first.renamed_subtask = nil
+      Task.first.renamed_subtask.should_not be_nil
+
+      Moderation.last.accept
+      Task.first.renamed_subtask.should be_nil
+    end
+  end
+
+  context "has_one association (create moderation):" do
+    before :each do
+      dynamic_models.task {
+        has_one :renamed_subtask, :class_name => "Subtask", :foreign_key => "task_id"
+        has_moderated_create :with_associations => [:renamed_subtask]
+      }.subtask {
+        belongs_to :task
+      }
+    end
+
+    it "associates an existing subtask on create 1" do
+      Task.has_moderated_association :renamed_subtask
+      Subtask.create! :title => "Subtask 1"
+      Subtask.count.should eq(1)
+      Moderation.count.should eq(0)
+
+      task = Task.new :title => "Task 1"
+      task.renamed_subtask = Subtask.first
+      task.save
+
+      Subtask.first.task_id.should be_nil
+
+      Task.count.should eq(0)
+      Moderation.count.should eq(1)
+      Moderation.last.accept
+      Moderation.count.should eq(0)
+      Subtask.first.task_id.should_not be_nil
+
+      subtask = Task.first.renamed_subtask
+      subtask.title.should eq("Subtask 1")
+    end
+
+    it "associates an existing subtask on create 2" do
+      Subtask.create! :title => "Subtask 1"
+      Subtask.count.should eq(1)
+      Moderation.count.should eq(0)
+
+      task = Task.new :title => "Task 1"
+      task.renamed_subtask = Subtask.first
+      task.save
+
+      Subtask.first.task_id.should be_nil
+
+      Task.count.should eq(0)
+      Moderation.count.should eq(1)
+      Moderation.last.accept
+      Moderation.count.should eq(0)
+      Subtask.first.task_id.should_not be_nil
+
+      subtask = Task.first.renamed_subtask
+      subtask.title.should eq("Subtask 1")
+    end
+  end
+end

data/spec/has_moderated/hooks_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe "hooks:" do
+  before do
+    dynamic_models.task {
+      has_moderated :title
+      moderation_creating do |moderation|
+        moderation.data = "Test!"
+      end
+    }
+  end
+
+  it "handles a creating hook properly" do
+    Task.create! :title => "Task 1"
+    Moderation.count.should eq(1)
+    Moderation.last.data.should eq("Test!")
+  end
+end

data/spec/has_moderated/moderated_create_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe "create moderation with association:" do
+  before do
+    dynamic_models.task {
+      has_many :renamed_subtasks, :class_name => "Subtask", :foreign_key => "task_id"
+      has_moderated_create :with_associations => [:renamed_subtasks]
+    }.subtask {
+      belongs_to :task
+    }
+  end
+
+  it "moderates create" do
+    task = Task.create! :title => "Task 1"
+    Moderation.count.should eq(1)
+    Task.count.should eq(0)
+
+    Moderation.last.accept
+    Task.count.should eq(1)
+    Task.first.title.should eq("Task 1")
+  end
+
+  # TODO: test all associations on create
+  it "moderates assoc on create" do
+    task = Task.new :title => "Task 1"
+    task.renamed_subtasks.build :title => "Subtask 1"
+    task.save
+    Subtask.count.should eq(0)
+    Moderation.last.accept
+
+    Task.last.renamed_subtasks.count.should eq(1)
+    Task.last.renamed_subtasks.first.title.should eq("Subtask 1")
+  end
+
+  it "doesn't create anything if nothing was created" do
+    task = Task.create! :title => "Task 1"
+    Moderation.last.accept
+
+    Task.first.renamed_subtasks.count.should eq(0)
+  end
+end

data/spec/has_moderated/moderated_destroy_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe "destroy moderation:" do
+  before do
+    dynamic_models.task {
+      has_moderated_destroy
+    }
+  end
+
+  it "moderates destroy" do
+    Task.create! :title => "Task 1"
+    Task.count.should eq(1)
+    Task.first.destroy
+    Task.count.should eq(1)
+    Moderation.last.accept
+    Task.count.should eq(0)
+  end
+
+  it "returns nil for #preview" do
+    Task.create! :title => "Task 1"
+    Task.first.destroy
+    Moderation.last.preview.should be_nil
+  end
+end

data/{test/dummy/spec/models → spec/has_moderated}/photo_spec.rb

@@ -1,20 +1,14 @@
-require File.expand_path('../../spec_helper', __FILE__)
+require 'spec_helper'
 
-def reload_models
-  crazy_models.reset
-  crazy_models.with_helpers &block if block_given?
-  crazy_models
-end
-
-describe Photo do
+describe "Photo" do
   before(:each) do
     FileUtils.rm_rf(TEMPDIR) # remove temp dir
-    FileUtils.rm_rf(File.expand_path("../../../public/uploads", __FILE__)) # remove uploads dir
+    FileUtils.rm_rf(File.expand_path("../../tmp/uploads", __FILE__)) # remove uploads dir
   end
 
   context "create moderated:" do
     before do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         has_moderated_create
         send :include, HasModerated::CarrierWave
@@ -52,7 +46,7 @@ describe Photo do
 
   context "not moderated:" do
     before do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
       }
     end
@@ -71,7 +65,7 @@ describe Photo do
 
   context "update moderated:" do
     before do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_carrierwave_field :avatar
@@ -133,17 +127,17 @@ describe Photo do
 
   context "moderated as association to has_moderated_create:" do
     before do
-      reload_models.task {
-        has_many :renamed_subtasks, :class_name => subtask_class_name, :foreign_key => task_fk
-        has_many :photos, :class_name => photo_class_name, :foreign_key => "parentable_id"
+      dynamic_models.task {
+        has_many :renamed_subtasks, :class_name => "Subtask", :foreign_key => "task_id"
+        has_many :photos, :class_name => "Photo", :foreign_key => "parentable_id"
         has_moderated_create :with_associations => [:photos, :renamed_subtasks]
       }.subtask {
-        belongs_to :task, :class_name => task_class_name
+        belongs_to :task, :class_name => "Task"
       }.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_carrierwave_field :avatar
-        belongs_to :task, :class_name => task_class_name, :foreign_key => "parentable_id"
+        belongs_to :task, :foreign_key => "parentable_id"
       }
 
     end
@@ -196,7 +190,7 @@ describe Photo do
 
   context "moderation preview" do
     it "should show the temporary file as the photo" do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_carrierwave_field :avatar
@@ -218,7 +212,7 @@ describe Photo do
     end
 
     it "should show the temporary file as the photo (create moderation)" do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_create
@@ -239,7 +233,7 @@ describe Photo do
     end
 
     it "should not move image to uploads when calling save on live_preview" do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_create
@@ -259,7 +253,7 @@ describe Photo do
     end
 
     it "should not move image to uploads when calling save on preview" do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_create
@@ -277,14 +271,14 @@ describe Photo do
     end
 
     it "should show the temporary file as the photo (create assoc moderation)" do
-      reload_models.task {
-        has_many :photos, :class_name => photo_class_name, :foreign_key => "parentable_id"
+      dynamic_models.task {
+        has_many :photos, :class_name => "Photo", :foreign_key => "parentable_id"
         has_moderated_create :with_associations => [:photos]
       }.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_carrierwave_field :avatar
-        belongs_to :task, :class_name => task_class_name, :foreign_key => "parentable_id"
+        belongs_to :task, :foreign_key => "parentable_id"
       }
 
       photo_file = carrierwave_test_photo
@@ -303,16 +297,16 @@ describe Photo do
     end
 
     it "should show the temporary file as the photo (assoc moderation)" do
-      reload_models.task {
-        has_many :photos, :class_name => photo_class_name, :foreign_key => "parentable_id"
+      dynamic_models.task {
+        has_many :photos, :class_name => "Photo", :foreign_key => "parentable_id"
         has_moderated_association :photos
       }.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_carrierwave_field :avatar
-        belongs_to :task, :class_name => task_class_name, :foreign_key => "parentable_id"
+        belongs_to :task, :foreign_key => "parentable_id"
       }
-
+      
       photo_file = carrierwave_test_photo
       task = Task.new
       photo = task.photos.build :avatar => photo_file
@@ -329,7 +323,7 @@ describe Photo do
     end
 
     it "should display preview of photo versions correctly" do
-      reload_models.photo {
+      dynamic_models.photo {
         mount_uploader :avatar, GenericUploader
         send :include, HasModerated::CarrierWave
         has_moderated_carrierwave_field :avatar

data/spec/has_moderated/polymorphic_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe "polymorphic associations" do
+  #
+  # has_moderated_association
+  # has_many polymorphic
+  #
+
+  context "has_many polymorphic association:" do
+    before do
+      dynamic_models.task {
+        has_many :renamed_subtasks, :class_name => "Subtask", :as => :parentable
+        has_moderated_association :renamed_subtasks
+      }.subtask {
+        belongs_to :parentable, :polymorphic => true
+      }
+    end
+
+    it "creates and associates subtask (create)" do
+      task = Task.create! :title => "Task 1"
+      Moderation.count.should eq(0)
+      task.renamed_subtasks.create! :title => "Subtask 1"
+
+      task = Task.first
+      task.renamed_subtasks.count.should eq(0)
+
+      Moderation.count.should eq(1)
+      Moderation.last.accept
+      Moderation.count.should eq(0)
+
+      subtask = Task.first.renamed_subtasks.first
+      subtask.title.should eq("Subtask 1")
+      subtask.parentable.should eq(Task.first)
+    end
+  end
+
+  #
+  # has_moderated_association
+  # has_one polymorphic
+  #
+
+  context "has_one polymorphic association:" do
+    before do
+      dynamic_models.task {
+        has_one :renamed_subtask, :class_name => "Subtask", :as => :parentable
+        has_moderated_association :renamed_subtask
+      }.subtask {
+        belongs_to :parentable, :polymorphic => true
+      }
+    end
+
+    it "creates and associates subtask (create)" do
+      task = Task.create! :title => "Task 1"
+      Moderation.count.should eq(0)
+      task.renamed_subtask = Subtask.new :title => "Subtask 1"
+      task.save
+
+      task = Task.first
+      task.renamed_subtask.should be_nil
+
+      Moderation.count.should eq(1)
+      Moderation.last.accept
+      Moderation.count.should eq(0)
+
+      subtask = Task.first.renamed_subtask
+      subtask.title.should eq("Subtask 1")
+      subtask.parentable.should eq(Task.first)
+    end
+  end
+end

data/spec/has_moderated/preview_spec.rb

@@ -0,0 +1,182 @@
+require 'spec_helper'
+
+describe "preview:" do
+  it "shows a live preview of changed attributes" do
+    dynamic_models.task {
+      has_moderated :title
+    }
+
+    Task.create! :title => "Task 1"
+    Task.last.title.should be_blank
+
+    last_task_id = Task.last.id
+    Moderation.last.live_preview do |preview|
+      preview.title.should eq("Task 1")
+      preview.id.should eq(last_task_id)
+    end
+
+    Task.last.title.should be_blank
+  end
+
+  it "returns a preview for create moderations (issue #13)" do
+    dynamic_models.task {
+      has_moderated_create
+    }
+
+    Task.create! :title => "Task 1"
+    Moderation.last.preview.should_not be_nil
+    Moderation.last.preview.title.should eq("Task 1")
+  end
+
+  it "shows a saved preview of changed attributes" do
+    dynamic_models.task {
+      has_moderated :title
+    }
+
+    task = Task.create! :title => "Task 1"
+    Task.last.title.should be_blank
+
+    preview = Moderation.last.preview
+    preview.title.should eq("Task 1")
+    preview.id.should eq(Task.last.id)
+    Task.last.title.should be_blank
+  end
+
+  it "supports dirty tracking for the saved preview" do
+    dynamic_models.task {
+      has_moderated :title
+    }
+
+    task = Task.create! :title => "Task 1"
+    Task.last.title.should be_blank
+
+    preview = Moderation.last.preview
+    preview.title_changed?.should be_true
+    preview.title_change.should eq([nil, "Task 1"])
+  end
+
+  it "supports updating moderation attributes for the saved preview if :saveable => true" do
+    dynamic_models.task {
+      has_moderated :title
+    }
+
+    task = Task.create! :title => "Task 1"
+    Task.last.title.should be_blank
+
+    preview = Moderation.last.preview(:saveable => true)
+    preview.title = "Task 2"
+    preview.update_moderation
+
+    moderation = Moderation.last
+    moderation.parsed_data.should eq({:attributes=>{"title"=>"Task 2"}})
+    moderation.accept
+    Task.last.title.should eq("Task 2")
+  end
+
+  it "doesn't support updating moderation attributes for the saved preview by default" do
+    dynamic_models.task {
+      has_moderated :title
+    }
+
+    task = Task.create! :title => "Task 1"
+    Task.last.title.should be_blank
+
+    moderation = Moderation.last
+    preview = Moderation.last.preview
+    preview.frozen?.should be_true
+    expect { preview.title = "Task 2" }.to raise_error
+    expect { preview.update_moderation }.to raise_error
+
+    moderation = Moderation.last
+    moderation.accept
+    Task.last.title.should eq("Task 1")
+  end
+
+  it "shows a saved preview of has_many association" do
+    dynamic_models.task {
+      has_many :renamed_subtasks, :class_name => "Subtask", :foreign_key => "task_id"
+      has_moderated_association :renamed_subtasks
+    }.subtask {
+      belongs_to :task
+    }
+
+    task = Task.create! :title => "Task 1"
+
+    task.renamed_subtasks.create! :title => "Subtask 1"
+    preview = Moderation.last.preview
+    subtask = preview.renamed_subtasks.first
+    subtask.title.should eq("Subtask 1")
+    subtask.id.should_not be_blank
+    subtask.task.should_not be_blank
+
+    Task.last.renamed_subtasks.count.should eq(0)
+    Subtask.count.should eq(0)
+  end
+
+  it "shows a saved preview of has_many :through association" do
+    dynamic_models.task {
+      has_many :renamed_connections, :class_name => "TaskConnection", :foreign_key => "m1_id"
+      has_many :renamed_subtasks, :class_name => "Subtask", :through => :renamed_connections, :source => :renamed_subtask
+      has_moderated_association :renamed_subtasks
+      has_moderated_association :renamed_connections
+    }.subtask {
+      belongs_to :task
+      has_many :renamed_connections, :class_name => "TaskConnection", :foreign_key => "m2_id"
+      has_many :renamed_tasks, :through => :renamed_connections, :source => :renamed_task
+    }.task_connection {
+      belongs_to :renamed_task, :class_name => "Task", :foreign_key => "m1_id"
+      belongs_to :renamed_subtask, :class_name => "Subtask", :foreign_key => "m2_id"
+    }
+
+    task = Task.create! :title => "Task 1"
+    conn = TaskConnection.new :title => "Connection 1"
+    conn.renamed_subtask = Subtask.new :title => "Subtask 1"
+    task.renamed_connections << conn
+    task.save
+
+    TaskConnection.count.should eq(0)
+    Subtask.count.should eq(0)
+
+    task = Moderation.last.preview
+
+    TaskConnection.count.should eq(0)
+    Subtask.count.should eq(0)
+    Moderation.count.should eq(1)
+
+    subtask = task.renamed_subtasks.first
+    subtask.title.should eq("Subtask 1")
+    subtask.renamed_connections.first.should be_present
+    conn = task.renamed_connections.first
+    conn.title.should eq("Connection 1")
+    conn.renamed_subtask.title.should eq("Subtask 1")
+    conn.renamed_task.title.should eq("Task 1")
+
+    # everything has to be frozen
+    task.frozen?.should be_true
+    task.renamed_subtasks.frozen?.should be_true
+    task.renamed_connections.frozen?.should be_true
+    subtask.frozen?.should be_true
+    subtask.renamed_connections.frozen?.should be_true
+    conn.frozen?.should be_true
+    conn.renamed_task.frozen?.should be_true
+    conn.renamed_subtask.frozen?.should be_true
+  end
+
+  it "freezes preview correctly" do
+    # especially important for Ruby 1.8 which behaves differently
+    dynamic_models.task {
+      has_many :subtasks
+      has_moderated_association :subtasks
+    }.subtask {
+      belongs_to :task
+    }
+
+    t = Task.create!
+    t.subtasks.create!
+
+    preview = Moderation.last.preview
+    preview.frozen?.should be_true
+    preview.instance_variable_get(:@has_moderated_fake_associations).frozen?.should be_true
+    preview.subtasks.frozen?.should be_true
+  end
+end