has_meta 0.0.4 → 0.0.5

data/README.md

@@ -4,7 +4,8 @@
 
 Adds convenience methods to extract "meta" (as in http meta) strings from
 models by using existing fields or lambda/Procs for source data. Result is stripped of html
-tags and truncated to length (default 255).
+tags and truncated to length (default 255). If the meta is 'keywords' the result will take extra
+steps to strip white space and remove blank elements (ie. multiple commas)
 
 ## Installation
 
@@ -34,7 +35,7 @@ Or install it yourself as:
 
     bp = BlogPost.new(...)
 
-    bp.meta_keywords == bp.meta_keywords
+    bp.meta_keywords == bp.keywords
 
     # if short_description is not blank and less than 255 characters then
     bp.meta_description == bp.short_description
@@ -47,6 +48,13 @@ Or install it yourself as:
     sleep 1
     bp.meta_foo == "Feb 27, 4:36:01 PM" # one second later
 
+    # 'keywords' gets extra special treatment.
+    bp.short_description = ',one  two,  ,three, '
+    bp.meta_description == ',one  two,  ,three, '
+
+    bp.keywords = ',one  two,  ,three, '
+    bp.meta_keywords == 'one,two,three'
+
 ## Contributing
 
 1. Fork it

data/lib/has_meta/version.rb

@@ -1,3 +1,3 @@
 module HasMeta
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/has_meta.rb

@@ -26,6 +26,14 @@ module HasMeta
             str = str.to_s.strip
             str.gsub!(' ', ' ')
             str.gsub!(/<.*?>/, '')
+
+            if meth.to_s == 'keywords'
+              str = str.gsub(/[\s,]+/, ',').
+                        gsub(/\s+/, ' ').
+                        gsub(/^,|,$/, '').
+                        strip 
+            end
+
             str = ::CGI::unescapeHTML(str)
             str = (str[0,length - 3] + '...') if str.size > length
             str

data/test/test_has_meta.rb

@@ -26,28 +26,38 @@ end
 class HasMetaTest < Test::Unit::TestCase
   def setup
     @widget = Widget.new
-    @widget.short_description = 'Short Description'
-    @widget.content = 'Long Description'
-    @widget.keywords = ''
+    @widget.short_description = "Short Description"
+    @widget.content = "Long Description"
+    @widget.keywords = ""
     @widget.some_ivar = 1
   end
 
   def test_knows_its_meta_description
-    assert_equal 'Short Description', @widget.meta_description
+    assert_equal "Short Description", @widget.meta_description
   end
 
   def test_knows_its_meta_description_when_first_option_blank
     @widget.short_description = nil
-    assert_equal 'Long Description', @widget.meta_description
+    assert_equal "Long Description", @widget.meta_description
   end
 
   def test_knows_its_truncated_meta_description
-    assert_equal 'Short...', @widget.meta_description(8)
+    assert_equal "Short...", @widget.meta_description(8)
   end
 
   def test_strip_tags
     @widget.short_description = "<i>ital</i> <b>bold</b> <a href='http://pjkh.com'>pjkh.com</a> the end"
-    assert_equal 'ital bold pjkh.com the end', @widget.meta_description
+    assert_equal "ital bold pjkh.com the end", @widget.meta_description
+  end
+
+  def test_treat_keywords_special
+    @widget.keywords = " , , one , , two , three , , "
+    assert_equal "one,two,three", @widget.meta_keywords
+  end
+
+  def test_do_not_treat_description_special
+    @widget.short_description = " , , one , , two , three , , "
+    assert_equal ", , one , , two , three , ,", @widget.meta_description
   end
 
   def test_knows_its_meta_keywords

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_meta
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors: