has_localization_table 0.3.5 → 0.3.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MWMxOGEwOTdjY2U5OWM3YTAwZDNhN2RhMWQ1N2IyODQ3YWZkYjU5YQ==
+    ZTA1YWMxMTY1ODUxODQ4ZDVkZjU3Yjk2OTkyZmEwNmM1NzU2NWY4OQ==
   data.tar.gz: !binary |-
-    YzUzNzFiMzk3MDViYzZmOWE4NWM3NzQ2ZjIzOWE4NTkxYzkwMjcyNA==
+    OGYwY2ZkNDFkY2E0YTg1OWMyN2FlNGNmMmRjOTM2YTRkMTI3NjViOA==
 SHA512:
   metadata.gz: !binary |-
-    MmUzNzEyOTAxMGYyNGY5MmM4MWEwNjFiZTY4M2FiY2Q0Y2Y4Njc1ZjZiZjRh
-    ZDQwMGE1ODM4ZmFhNGVlYjc3NWYyNWQ2NmQ0MzY0MWI5NjU5NGU5ODBmODZl
-    ZWE1NGVkNzIxMWQ2ZDgxZTUyZmUxNWMxNDc5ZGJiZmY4YTY0Zjg=
+    ZWUzMTFjZDg0ZDZlMjUwMTMyYTFiOWQ4ZDczMTZlMTQ1NTRmMzk0NGY4NzBh
+    NGM2NTcxYzk4ODc1ZjlmNDBjNjdlYzE2Y2M5MTRhOTliMTY1NGJiY2U2N2Rj
+    N2Q2ODNhZGU3ZmMwNDgyOGI5NjA2ODlmMjljOGFmMjQzZjk0MTU=
   data.tar.gz: !binary |-
-    M2Y4YzlhZTBjZThmZTM4ZDQwNTQyYTYxMGRlZjgwNmYyZWJjYTkxNDViNWMz
-    YTg1ZTk5YzEwMjY3MDkzNWFmZTNlYzc3ZjFiNzI4ZjliYTliMjc4YTE0MTMy
-    ZDI4YzJiODE2NjM4NTQ3ODkwNDkwNThmNTYzZGY4YWJlODIxMGU=
+    MGZlNWM1MmMzOGQ4OTJhYzQ2OWU2ZDVkNzc1MjBmYTQ5YmY0YTRlZDg5MTVh
+    Y2JkYzU5ZGRiMjc5MjY1MGFkYWNjNzhlODM0ZjJkYjkwYjAzZDE0ZDU1OWQy
+    YzU0MDJlMTAyNmQ0YjU4MDY4YmJiNjFiYWEzYWI0MGEyZjc1NTI=

data/has_localization_table.gemspec

@@ -19,5 +19,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'activerecord', ['>= 3.0.0']
   gem.add_development_dependency 'minitest'
   gem.add_development_dependency 'sqlite3'
+  gem.add_development_dependency 'rake'
 end
 

data/lib/has_localization_table/active_record/relation.rb

@@ -46,7 +46,7 @@ module HasLocalizationTable
 
       # Collect all localizations for the object
       def create_has_many_association
-        self.has_many localization_association_name, localization_table_options.except(:association_name, :required, :optional, :has_one) do
+        self.has_many localization_association_name, localization_table_options.except(:association_name, :required, :optional, :has_one).reverse_merge(autosave: true) do
           def for_locale(locale)
             # where(HasLocalizationTable.locale_foreign_key => locale).first
             select{ |s| s.send(HasLocalizationTable.locale_foreign_key) == locale }.first

data/lib/has_localization_table/active_record/validations.rb

@@ -13,7 +13,7 @@ module HasLocalizationTable
         
         # Add validation to ensure a string for the primary locale exists if the string is required
         validate do
-          if localization_table_options[:required] || false
+          if localization_table_options.fetch(:required, false)
             errors.add(localization_association_name, :primary_lang_string_required) unless localization_association.any? do |string|
               string.send(HasLocalizationTable.locale_foreign_key) == HasLocalizationTable.primary_locale.id
             end

data/lib/has_localization_table/version.rb

@@ -1,3 +1,3 @@
 module HasLocalizationTable
-  VERSION = "0.3.5"
+  VERSION = "0.3.6"
 end

data/spec/active_record/attributes_spec.rb

@@ -32,6 +32,12 @@ describe HasLocalizationTable do
     a.name.must_equal "Test"
     a.description.must_equal "Description"
   end
+
+  it "should save with update_attributes" do
+    a.save!
+    a.update_attributes!(name: "Test 2")
+    Article.find(a.id).name.must_equal "Test 2"
+  end
   
   it "should create mutator methods" do
     a.name = "Changed"

data/spec/active_record/{validation_spec.rb → validations_spec.rb}

@@ -15,19 +15,26 @@ describe HasLocalizationTable do
   end
   
   let(:a) { Article.new(name: "Test", description: "Description") }
-  
-  it "should add validations if given required: true" do
-    Article.has_localization_table required: true
-    a = Article.new
-    refute a.valid?
-    a.errors[:localizations].wont_be_empty
-    
-    a = Article.new(description: "Wishing the world hello!")
-    s = a.localizations.first
-    refute s.valid?
-    s.errors[:name].wont_be_empty
+
+  describe 'when the required option is true' do
+    before { Article.has_localization_table required: true }
+
+    it "should add an error to the base class if a string is not given" do
+      Article.has_localization_table required: true
+      a = Article.new
+      refute a.valid?
+      a.errors.wont_be_empty
+    end
+
+    it 'should add an error to the association column if a string is not given' do
+      Article.has_localization_table required: true
+      a = Article.new(description: "Wishing the world hello!")
+      s = a.localizations.first
+      refute s.valid?
+      s.errors[:name].wont_be_empty
+    end
   end
-  
+
   it "should not add validations if given required: false" do
     Article.has_localization_table required: false
     a = Article.new

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: has_localization_table
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Daniel Vandersluis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-30 00:00:00.000000000 Z
+date: 2014-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   type: :runtime
@@ -66,6 +66,20 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  type: :development
+  prerelease: false
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Automatically sets up usage of a relational table to contain user-created
   multi-locale string attributes
 email:
@@ -95,7 +109,7 @@ files:
 - spec/active_record/finder_method_spec.rb
 - spec/active_record/ordered_by_spec.rb
 - spec/active_record/relation_spec.rb
-- spec/active_record/validation_spec.rb
+- spec/active_record/validations_spec.rb
 - spec/active_record_spec.rb
 - spec/spec_helper.rb
 - spec/support/setup.rb
@@ -128,7 +142,7 @@ test_files:
 - spec/active_record/finder_method_spec.rb
 - spec/active_record/ordered_by_spec.rb
 - spec/active_record/relation_spec.rb
-- spec/active_record/validation_spec.rb
+- spec/active_record/validations_spec.rb
 - spec/active_record_spec.rb
 - spec/spec_helper.rb
 - spec/support/setup.rb