has_calculated_fields 1.0.3.5 → 1.0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80f022c4e87a567bdd3578d27a6ed797f317c44700407e42a54872556063b26c
-  data.tar.gz: b471fa50ce90385f9ef2dc4d048634827dd880ee9f3501db3fd94fc686a6efe7
+  metadata.gz: fe42e86264da503a5735ff33ad72337d8ce94bb5282a1c4971983a8b9a32e030
+  data.tar.gz: 036c3d42cb5514e44d63a0af95176c35562f06118d0ecab261df73e322ab7637
 SHA512:
-  metadata.gz: a592df5ed4a8a590b01209c6f4980e17020eb33cca40e84a9206c8263ab39ca15a8783a6ec93bdc632aa6f9d87c29469d7fde594c77a130daa3c3b10f8c7baf4
-  data.tar.gz: dd46d667edf614df0c509189cee7e8a822fbcb9239cfdd4d5e762620885b07ea0957da0dae54890030465a132cf185059e6b1df9650920db481dd21c05c836ac
+  metadata.gz: ba646c37722a97d9b92eb384022d68d6b3112a766abfa19d561bdbef0a6c02531041ec6288ca59019b3c4244150ff522e95ab1c4a8f4277d45c27ff6728bbb74
+  data.tar.gz: 554db6d1dab5b198f89b1231fca1ef7566ba15d250ee581c9c739662d741a5ebc259d84b6c0b1abcc5f7a26246c0eb4ae7a8b7c22ddb12c0a9cedcfc1e98eca6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    has_calculated_fields (1.0.3.4)
+    has_calculated_fields (1.0.3.7)
 
 GEM
   remote: https://rubygems.org/

data/has_calculated_fields.gemspec

@@ -3,7 +3,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "has_calculated_fields"
-  s.version     = "1.0.3.5"
+  s.version     = "1.0.3.8"
   s.platform    = Gem::Platform::RUBY
   s.author      = ["Adrian Fernandez"]
   s.email       = ["adrianfernandez85@gmail.com"]

data/lib/has_calculated_fields/has_calculated_fields.rb

@@ -207,6 +207,7 @@ module HasCalculatedFields
 
     def _process_data(data)
       return true unless _should_calculate_data?(data)
+
       attr_equal = "#{data[:calculated_field]}="
 
       value = case data[:type]
@@ -217,6 +218,8 @@ module HasCalculatedFields
       end
 
       send(attr_equal, value)
+
+      true
     end
 
     def _process_date(data)
@@ -255,12 +258,17 @@ module HasCalculatedFields
       end
     end
 
-    f _should_calculate_data?(data)
+    def _should_calculate_data?(data = {})
+      if_changed = data.fetch(:if_changed, nil)
+      unless_changed = data.fetch(:unless_changed, nil)
+
+      changed_keys = changes.keys.map(&:to_sym) || []
+
       return true if data.blank?
       return true if !data.has_key?(:if_changed) && !data.has_key?(:unless_changed)
 
-      return true if data.has_key?(:if_changed) && changes.keys.map(&:to_sym).include?(data[:if_changed])
-      return true if data.has_key?(:unless_changed) && !changes.keys.map(&:to_sym).include?(data[:unless_changed])
+      return true if data.has_key?(:if_changed) && changed_keys.include?(if_changed)
+      return true if data.has_key?(:unless_changed) && !changed_keys.include?(unless_changed)
 
       false
     end

data/lib/has_calculated_fields.rb

@@ -2,7 +2,6 @@
 
 require "active_record"
 require "active_support/inflector"
-require "active_model_serializers"
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 

data/spec/has_calculated_fields_spec.rb

@@ -29,23 +29,42 @@ describe HasCalculatedFields do
           .to("new name calculated!")
       end
 
-      it "assigns conditional when condition is matched" do
-        obj.name = "conditional name"
-        obj.random_attribute = "4"
-
-        expect { obj.save }.to change {
-          obj.calculated_conditional_unless
-        }.and change { obj.calculated_conditional_if }
-          .to("conditional name calculated!")
+      context "if_changed" do
+        it "assigns conditional when condition is matched" do
+          obj.name = "conditional name"
+          obj.random_attribute = "4"
+
+          expect { obj.save }.to change {
+            obj.calculated_conditional_if
+          }
+        end
+
+        it "does not assign conditional when condition is matched" do
+          obj.name = "conditional name"
+
+          expect { obj.save }.not_to change {
+            obj.calculated_conditional_if
+          }
+        end
       end
 
-      it "assigns conditional when condition is matched" do
-        obj.name = "conditional name"
+      context "unless_changed" do
+        it "assigns conditional when condition is matched" do
+          obj.name = "conditional name"
 
-        expect { obj.save }.to change {
-          obj.calculated_conditional_if
-        }.and change { obj.calculated_conditional_unless }
-          .to("conditional name calculated!")
+          expect { obj.save }.to change {
+            obj.calculated_conditional_unless
+          }
+        end
+
+        it "does not assign conditional when condition is matched" do
+          obj.name = "conditional name"
+          obj.random_attribute = "4"
+
+          expect { obj.save }.not_to change {
+            obj.calculated_conditional_unless
+          }
+        end
       end
     end
   end

data/spec/schema.rb

@@ -0,0 +1,12 @@
+ActiveRecord::Schema.define(version: 2022_05_07_120518) do
+  create_table :sample_models do |t|
+    t.string :name
+    t.string :random_attribute
+    t.datetime :created_at
+
+    t.string :calculated_name
+    t.string :calculated_created_at
+    t.string :calculated_conditional_if
+    t.string :calculated_conditional_unless
+  end
+end

data/spec/spec_helper.rb

@@ -4,7 +4,6 @@ $LOAD_PATH << File.join(File.dirname(__FILE__), "..", "lib")
 require "sqlite3"
 require "has_calculated_fields"
 require 'database_cleaner'
-require "active_model_serializers"
 
 RSpec.configure do |config|
   config.before(:suite) do
@@ -19,20 +18,9 @@ RSpec.configure do |config|
   end
 end
 
-ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
-
-ActiveRecord::Schema.define(version: 3) do
-  create_table :sample_models do |t|
-    t.string :name
-    t.string :random_attribute
-    t.datetime :created_at
-
-    t.string :calculated_name
-    t.string :calculated_created_at
-    t.string :calculated_conditional_if
-    t.string :calculated_conditional_unless
-  end
-end
+ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
+ActiveRecord::Schema.verbose = true
+load "spec/schema.rb"
 
 class SampleModel < ActiveRecord::Base
   has_calculated_fields on_before_save: [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_calculated_fields
 version: !ruby/object:Gem::Version
-  version: 1.0.3.5
+  version: 1.0.3.8
 platform: ruby
 authors:
 - Adrian Fernandez
@@ -155,6 +155,7 @@ files:
 - lib/has_calculated_fields/has_calculated_fields.rb
 - spec/.DS_Store
 - spec/has_calculated_fields_spec.rb
+- spec/schema.rb
 - spec/spec_helper.rb
 homepage: http://github.com/adrian-fernandez/has_calculated_fields
 licenses:
@@ -181,4 +182,5 @@ specification_version: 4
 summary: Rails gem to allow models to save auto calculated fields
 test_files:
 - spec/has_calculated_fields_spec.rb
+- spec/schema.rb
 - spec/spec_helper.rb