has-many-with-set 1.0.0 → 1.1.0

data/CHANGELOG

@@ -0,0 +1,6 @@
+has-many-with-set 1.1.0
+
+- Children can now see their parents.
+- The README now uses Ruby 1.9 features.
+- Fixed a bug with the relationships table. By default, Rails name has_and_belongs_to_many relationship tables in alphabetical order. This breaks the save callback if your parent > child.
+- Added CHANGELOG.

data/README.textile

@@ -16,11 +16,11 @@ The _join_ table model is a very redundant way of storing these relationships if
 
 For example:
 
-bc.. Tag.new(:name => 'programming').save
-Tag.new(:name => 'open source').save
-Tag.new(:name => 'startups').save
-Tag.new(:name => 'ruby').save
-Tag.new(:name => 'development').save
+bc.. Tag.create(:name => 'programming')
+Tag.create(:name => 'open source')
+Tag.create(:name => 'startups')
+Tag.create(:name => 'ruby')
+Tag.create(:name => 'development')
 
 tags = Tag.all
 
@@ -28,12 +28,8 @@ tags = Tag.all
   a = Article.new(:title => "Buzzword about buzzwords!",
                   :body => "Lorem ipsum")
 
-  rand(tags.size + 1).times do
-    t = tags[rand(tags.size)]
-    a.tags << t
-  end
+  a.tags = tags.sample(rand(tags.size + 1))
 
-  a.tags.uniq!
   a.save
 end
 
@@ -87,11 +83,11 @@ bc.. class Article < ActiveRecord::Base
   has_many_with_set :tags   # <--- key part!
 end
 
-Tag.new(:name => 'programming').save
-Tag.new(:name => 'open source').save
-Tag.new(:name => 'startups').save
-Tag.new(:name => 'ruby').save
-Tag.new(:name => 'development').save
+Tag.create(:name => 'programming')
+Tag.create(:name => 'open source')
+Tag.create(:name => 'startups')
+Tag.create(:name => 'ruby')
+Tag.create(:name => 'development')
 
 tags = Tag.all
 
@@ -99,12 +95,8 @@ tags = Tag.all
   a = Article.new(:title => "Buzzword about buzzwords!",
                   :body => "Lorem ipsum")
 
-  rand(tags.size + 1).times do
-    t = tags[rand(tags.size)]
-    a.tags << t
-  end
+  a.tags = tags.sample(rand(tags.size + 1))
 
-  a.tags.uniq!
   a.save
 end
 
@@ -119,6 +111,14 @@ Article.first.tags
 Article.last.tags
 => [#<Tag id: 1, name: "programming", ...>, #<Tag id: 5, name: "development", ...]
 
+# The child model can also see to which parent models it relates to
+
+Tag.first.articles.size
+=> 503
+
+Tag.first.article.first
+=> #<Article id: 2, title: "Buzzword about buzzwords!", ..>
+
 p. Same example as before, just now using *_has_many_with_set_*. We get the impressive number of 80 rows to represent the same information that we had before with thousands of rows (roughly the same, since we use random combinations is not _exactly_ the same article/tag layout).
 
 The funny thing in this particular example, is that since we have only five tags, there are only 32 possible ways to combine five tags together, these 32 combinations amount to 80 rows in our relationship table.... that is, even if we had a million articles we would still have the same 80 rows to represent our relationships, we don't need to create any more rows!!

data/lib/has-many-with-set/accessors.rb

@@ -41,5 +41,17 @@ module HasManyWithSet
         instance_variable_set(instance_var_name, elements)
       }
     end
+
+    def self.build_parent_loader_method (parent_table_name, child_table_name, set_table_name, set_items_table_name)
+      find_query = Queries.build_find_parents_query(parent_table_name, child_table_name, set_table_name, set_items_table_name)
+
+      parent_klass = Object.const_get(parent_table_name.classify)
+
+      Proc.new {
+        values = []
+        values = parent_klass.find_by_sql([ find_query, self ]).to_a
+        values
+      }
+    end
   end
 end

data/lib/has-many-with-set/has-many-with-set.rb

@@ -13,14 +13,18 @@ module HasManyWithSet
     set_model_name                  = set_table_name.classify
     set_items_table_name            = "#{ set_table_name }_#{ child_table_name }"
     instance_var_name               = "@#{ child_table_name }"
+    child_instance_var_name         = "@#{ parent_table_name }"
     setter_method_name              = "#{ child_table_name }="
     loader_method_name              = "#{ set_items_table_name }_loader"
+    parent_loader_method_name       = "#{ parent_table_name }_loader"
     save_callback_method_name       = "#{ set_items_table_name }_save_callback"
+    child_klass                     = Object.const_get(child_model_name)
 
     Relationships.create_set_model(set_model_name)
     Relationships.relate_child_to_set(set_model_name, child_model_name)
     Relationships.relate_parent_to_set(set_model_name, parent_model_name)
 
+    # Parent methods
     define_method(loader_method_name,
                   Accessors.build_loader_method(child_table_name, set_table_name))
 
@@ -34,6 +38,16 @@ module HasManyWithSet
                   Callbacks.build_saver_callback(set_table_name, set_items_table_name,
                                                  child_table_name, instance_var_name))
 
+    # Child methods
+    child_klass.send(:define_method, parent_loader_method_name,
+                     Accessors.build_parent_loader_method(parent_table_name, child_table_name,
+                                                          set_table_name, set_items_table_name))
+
+    child_klass.send(:define_method, parent_table_name,
+                     Accessors.build_getter_method(child_instance_var_name, parent_loader_method_name))
+
+    child_klass.send(:private, parent_loader_method_name)
+
     class_eval do
       private loader_method_name
       private save_callback_method_name

data/lib/has-many-with-set/queries.rb

@@ -3,7 +3,7 @@ module HasManyWithSet
     def self.build_find_empty_set_query(set_table_name, set_items_table_name)
       "select #{ set_table_name }.id from #{ set_table_name }
        where not exists (select null from #{ set_items_table_name }
-                         where #{ set_items_table_name }.#{ set_table_name.singularize }_id = #{ set_table_name }.id)"
+                         where #{ set_items_table_name }.#{ set_table_name.singularize }_id = #{ set_table_name }.id);"
     end
 
     def self.build_find_set_query(set_table_name, set_items_table_name, child_table_name)
@@ -16,7 +16,15 @@ module HasManyWithSet
               where c.#{ set_table_name.singularize }_id =
                     #{ set_items_table_name }.#{ set_table_name.singularize }_id) = ?
        group by #{ set_table_name }.id
-       having count(*) = ?"
+       having count(*) = ?;"
+    end
+
+    def self.build_find_parents_query (parent_table_name, child_table_name, set_table_name, set_items_table_name)
+     "select #{ parent_table_name }.* from #{ child_table_name }
+        join #{ set_items_table_name } on #{ child_table_name }.id = #{ set_items_table_name }.#{ child_table_name.singularize }_id
+        join #{ parent_table_name } on #{ parent_table_name }.#{ set_table_name.singularize }_id =
+          #{ set_items_table_name }.#{ set_table_name.singularize}_id
+      where #{ child_table_name }.id = ?;"
     end
   end
 end

data/lib/has-many-with-set/relationships.rb

@@ -8,12 +8,12 @@ module HasManyWithSet
     def self.relate_child_to_set (set_model_name, child_model_name)
       # Take the child model and add a regular many-to-many relationship to the Set model...
       Object.const_get(child_model_name).class_eval do
-        has_and_belongs_to_many set_model_name.tableize.to_sym
+        has_and_belongs_to_many set_model_name.tableize.to_sym, :join_table => "#{ set_model_name.tableize }_#{ child_model_name.tableize }"
       end
 
       # ... and take the Set model and finish the many-to-many relationship.
       Object.const_get(set_model_name).class_eval do
-        has_and_belongs_to_many child_model_name.tableize.to_sym
+        has_and_belongs_to_many child_model_name.tableize.to_sym, :join_table => "#{ set_model_name.tableize }_#{ child_model_name.tableize }"
       end
     end
 

data/lib/has-many-with-set/version.rb

@@ -1,3 +1,3 @@
 module HasManyWithSet
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/test/has-many-with-set_test.rb

@@ -32,6 +32,10 @@ class HasManyWithSetTest < ActiveSupport::TestCase
     assert_respond_to ModelOne.new, "model_twos="
   end
 
+  test "child class has the getter" do
+    assert_respond_to ModelTwo.new, "model_ones"
+  end
+
   test "getter type" do
     assert_kind_of Array, ModelOne.new.model_twos
   end
@@ -111,6 +115,20 @@ class HasManyWithSetTest < ActiveSupport::TestCase
     assert master_record.model_twos.size == items.size
   end
 
+  test "children can see parents" do
+    item = ModelTwo.create
+
+    how_many = rand(50)
+
+    how_many.times do
+      record = ModelOne.new(:num => 1)
+      record.model_twos << item
+      record.save
+    end
+
+    assert item.model_ones.size == how_many, "#{ item.model_ones.size } != #{ how_many }"
+  end
+
   test "items count match" do
     ModelOne.all.each do |m|
       assert m.num == m.model_twos.size

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has-many-with-set
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-13 00:00:00.000000000 Z
+date: 2012-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -62,11 +62,12 @@ files:
 - MIT-LICENSE
 - Rakefile
 - README.textile
+- CHANGELOG
 - test/has-many-with-set_test.rb
 - test/support/models.rb
 - test/support/prepare_activerecord.rb
 - test/test_helper.rb
-- test/tmp/db/migrate/20121113022938_create_model_ones_model_twos_set.rb
+- test/tmp/db/migrate/20121124222345_create_model_ones_model_twos_set.rb
 homepage: https://github.com/ebobby/has-many-with-set
 licenses: []
 post_install_message: 
@@ -81,7 +82,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2377775004769566141
+      hash: 3966952451817173381
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -90,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2377775004769566141
+      hash: 3966952451817173381
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -102,4 +103,4 @@ test_files:
 - test/support/models.rb
 - test/support/prepare_activerecord.rb
 - test/test_helper.rb
-- test/tmp/db/migrate/20121113022938_create_model_ones_model_twos_set.rb
+- test/tmp/db/migrate/20121124222345_create_model_ones_model_twos_set.rb