has-bit-field 0.3.1 → 0.3.2

data/.rvmrc

@@ -0,0 +1,2 @@
+rvm_gemset_create_on_use_flag=1
+rvm gemset use has-bit-field

data/README.md

@@ -43,6 +43,13 @@ One of the great advantages of this approach is that it is easy to add additiona
     end
 
 The new flag will be evaluated as false for existing rows on the database table until their values are explicitly set.  Be careful with the peanuts!
+
+Another gotcha to be aware of is when combining a bit field with Active Record's `validates_acceptance_of`.  When you call `validates_acceptance_of`, if there is no database column, Active Record will define an `attr_accessor` for that boolean field.  If you have already defined the bit field, this will clobber those methods.  Also, you need to set the value it's looking for to `true` instead of the default of `"1"`.  So here's an example of how to use it:
+
+    class Person < ActiveRecord::Base
+      validates_acceptance_of :read_books, :message => "You must agree to read", :accept => true
+      has_bit_field :bit_field, :likes_ice_cream, :plays_golf, :watches_tv, :reads_books
+    end
       
 Copyright
 ---------

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/has-bit-field.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{has-bit-field}
-  s.version = "0.3.1"
+  s.version = "0.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Paul Barry"]
@@ -18,6 +18,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
      ".gitignore",
+     ".rvmrc",
      "Gemfile",
      "LICENSE",
      "README.md",

data/test/has-bit-field_test.rb

@@ -13,23 +13,40 @@ end
 
 class Person < ActiveRecord::Base
   extend HasBitField
-  #attr_accessor :bit_field
+
   has_bit_field :bit_field, :likes_ice_cream, :plays_golf, :watches_tv, :reads_books
 end
 
+
+ActiveRecord::Base.connection.create_table(:skills) do |t|
+  t.integer :outdoor_bit_field, :default => 0
+  t.integer :indoor_bit_field, :default => 0
+end
+
+class Skill < ActiveRecord::Base
+  extend HasBitField
+
+  validates_acceptance_of :chops_trees, :message => "You have to be a lumberjack", :accept => true
+  validates_acceptance_of :plays_piano, :message => "You must be a pianist", :accept => true
+
+  has_bit_field :outdoor_bit_field, :chops_trees, :builds_fences, :cuts_hedges
+  has_bit_field :indoor_bit_field, :plays_piano, :mops_floors, :makes_soup
+end
+
 class HasBitFieldTest < Test::Unit::TestCase
+
   def test_bit_field
     p = Person.new
     [:likes_ice_cream, :plays_golf, :watches_tv, :reads_books].each do |f|
       assert p.respond_to?("#{f}?"), "Expected #{p.inspect} to respond to #{f}?"
       assert p.respond_to?("#{f}="), "Expected #{p.inspect} to respond to #{f}="
     end
-    
+
     assert_equal Person.likes_ice_cream_bit, (1 << 0)
     assert_equal Person.plays_golf_bit, (1 << 1)
     assert_equal Person.watches_tv_bit, (1 << 2)
     assert_equal Person.reads_books_bit, (1 << 3)
-    
+
     p.likes_ice_cream = true
     assert p.likes_ice_cream?
     assert !p.plays_golf?
@@ -78,12 +95,12 @@ class HasBitFieldTest < Test::Unit::TestCase
     a.plays_golf = true
     a.reads_books = true
     assert a.save
-    
+
     b = Person.new
     b.likes_ice_cream = true
     b.watches_tv = true
     assert b.save
-    
+
     c = Person.create!
 
     assert_equal [b], Person.likes_ice_cream.all(:order => "id")    
@@ -91,13 +108,14 @@ class HasBitFieldTest < Test::Unit::TestCase
 
     assert_equal [a], Person.plays_golf.all(:order => "id")
     assert_equal [b,c], Person.not_plays_golf.all(:order => "id")
-    
+
     assert_equal [b], Person.watches_tv.all(:order => "id")
     assert_equal [a,c], Person.not_watches_tv.all(:order => "id")
-    
+
     assert_equal [a], Person.reads_books.all(:order => "id")
     assert_equal [b,c], Person.not_reads_books.all(:order => "id")
   end
+
   def test_dirty_attributes
     Person.delete_all
     a = Person.new
@@ -113,4 +131,53 @@ class HasBitFieldTest < Test::Unit::TestCase
     assert_equal true, a.reads_books_was
     assert !a.reads_books_changed?
   end
+
+  def test_ar_validations_no_default
+    s = Skill.new(:plays_piano => true, :builds_fences => true, :cuts_hedges => false)
+
+    assert_equal false, s.chops_trees?
+    assert_equal false, s.chops_trees
+    assert s.builds_fences?
+    assert !s.cuts_hedges?
+    assert !s.cuts_hedges
+
+    assert !s.valid?
+    assert s.errors.on(:chops_trees)
+
+    s.chops_trees = false
+    assert !s.chops_trees?
+    assert !s.valid?
+    assert s.errors.on(:chops_trees)
+
+    s.chops_trees = true
+    assert s.chops_trees?
+    assert s.valid?
+    assert !s.errors.on(:chops_trees)
+    assert s.save
+  end
+
+  def test_ar_validations_with_default
+    s = Skill.new(:chops_trees => true, :mops_floors => true, :makes_soup => false)
+
+    assert_equal false, s.plays_piano?
+    assert_equal false, s.plays_piano
+    assert s.mops_floors?
+    assert !s.makes_soup?
+    assert !s.makes_soup
+
+    assert !s.valid?
+    assert s.errors.on(:plays_piano)
+
+    s.plays_piano = false
+    assert !s.plays_piano?
+    assert !s.valid?
+    assert s.errors.on(:plays_piano)
+
+    s.plays_piano = true
+    assert s.plays_piano?
+    assert s.valid?
+    assert !s.errors.on(:plays_piano)
+    assert s.save
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: has-bit-field
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 23
   prerelease: false
   segments: 
   - 0
   - 3
-  - 1
-  version: 0.3.1
+  - 2
+  version: 0.3.2
 platform: ruby
 authors: 
 - Paul Barry
@@ -31,6 +31,7 @@ extra_rdoc_files:
 files: 
 - .document
 - .gitignore
+- .rvmrc
 - Gemfile
 - LICENSE
 - README.md