harvesting 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36525f3c1b0a053c53690e55831d69d402bdc9fb5709b68e0d8cfc885f9a5bf0
-  data.tar.gz: bb3c642047e046ebbc8a72448ac5c29358264f8609b34f2c7a746680e721a74c
+  metadata.gz: 8f6d054347741b50002f88258ec6816852d6463fddcf45163779d5c8cc56c5b6
+  data.tar.gz: c92bb840b2825539dad52caab0d51871f89248d63b37ecb6e08cde0d9154b6b6
 SHA512:
-  metadata.gz: be1d66442a2b3bf3c0896055e15f8cdbdf506c8929814b1d5781c07676a36eab523e3182b155d593371aa91639fd55d86fb8689b0e1194f6f54ff091dd93c886
-  data.tar.gz: f0660def1ec97d8e02cb04dda6a52a14cd1fd08811a0372854632d076162ccc7990bcfa8e34906df3a439a7dcfc8d92bed60b25a78d531f1b045e9176062de1c
+  metadata.gz: e6a1957ac8fb4f16e77996e3f1d1504825d4b6bb90fb1e0bf749a0b399755fd04756eb4fd60b54bc2635b03c843de99a5fc19309fe4627059344ec9ec2027749
+  data.tar.gz: 96bae4c6ead7a63caacee4b67def836f5f76047677a09b0f7cdda4ecb0521f4b1bd81bc1666239cbb0a2bdfb3426e80564210b82ad5a8e79c94665a4768b35f7

data/.travis.yml

@@ -4,6 +4,7 @@ rvm:
   - 2.5.8
   - 2.6.6
   - 2.7.1
+  - 3.0
 env:
   - HARVEST_FIRST_NAME=Aaron HARVEST_LAST_NAME=Burr HARVEST_ACCOUNT_ID=112341234 HARVEST_NON_ADMIN_ACCOUNT_ID=112341234 HARVEST_ACCESS_TOKEN=112341234 HARVEST_NON_ADMIN_ACCESS_TOKEN=112341234 HARVEST_ADMIN_FULL_NAME=112341234
 

data/README.md

@@ -24,7 +24,7 @@ Or install it yourself as:
 
 ## Documentation
 
-The API is documented [here](https://www.rubydoc.info/github/fastruby/harvesting)
+The API is documented [here](https://www.rubydoc.info/gems/harvesting)
 
 ## Usage
 
@@ -243,6 +243,16 @@ We follow semantic versioning for version numbers: [https://semver.org](https://
 
 Bug reports and pull requests are welcome on GitHub at [https://github.com/fastruby/harvesting](https://github.com/fastruby/harvesting). This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
+When Submitting a Pull Request:
+
+* If your PR closes any open GitHub issues, please include `Closes #XXXX` in your comment
+
+* Please include a summary of the change and which issue is fixed or which feature is introduced.
+
+* If changes to the behavior are made, clearly describe what changes.
+
+* If changes to the UI are made, please include screenshots of the before and after.
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/RELEASE_NOTES.md

@@ -6,6 +6,14 @@
 
 **Bug Fixes**
 
+### Version 0.6.0 - July 17, 2023
+
+**Notes**
+
+**Bug Fixes**
+
+- Fix incompatibility with Ruby 3.0 and kwargs: https://github.com/fastruby/harvesting/pull/68
+
 ### Version 0.5.1 - January 14, 2021
 
 **Notes**

data/TODO.md

@@ -1,2 +1,2 @@
-* Implement methods like `user.time_entries`
+* Implement methods like `project.time_entries` or `user.time_entries`
 * Implement methods like `project.time_entries.create(attribute: value)`

data/harvesting.gemspec

@@ -20,13 +20,13 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-  spec.add_dependency "http", ">= 3.3", "< 5.0"
+  spec.add_dependency "http", ">= 3.3", "< 5.1"
 
   spec.add_development_dependency "bundler", ">= 2.0", "< 3.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "guard-rspec", "~> 4.7", ">= 4.7"
-  spec.add_development_dependency "byebug", "~> 10.0", ">= 10.0"
+  spec.add_development_dependency "byebug", ">= 10.0", "< 12.0"
   spec.add_development_dependency "vcr", "~> 4.0", ">= 4.0"
   spec.add_development_dependency "webmock", "~> 3.4", ">= 3.4"
   spec.add_development_dependency "dotenv", "~> 2.5", ">= 2.5"

data/lib/harvesting/client.rb

@@ -12,7 +12,7 @@ module Harvesting
 
     # Returns a new instance of `Client`
     #
-    #     client = Client.new(access_token: "12345678", account_id: "98764")
+    #     client = Client.new({ access_token: "12345678", account_id: "98764" })
     #
     # @param [Hash] opts the options to create an API client
     # @option opts [String] :access_token Harvest access token
@@ -30,7 +30,7 @@ module Harvesting
     def me
       Harvesting::Models::User.new(get("users/me"), harvest_client: self)
     end
-    
+
     # @return [Harvesting::Models::Clients]
     def clients(opts = {})
       Harvesting::Models::Clients.new(get("clients", opts), opts, harvest_client: self)
@@ -116,7 +116,7 @@ module Harvesting
       uri = URI(url)
       response = http_response(:delete, uri)
       raise UnprocessableRequest.new(response.to_s) unless response.code.to_i == 200
-      
+
       JSON.parse(response.body)
     end
 

data/lib/harvesting/models/base.rb

@@ -9,7 +9,7 @@ module Harvesting
       def initialize(attrs, opts = {})
         @models = {}
         @attributes = attrs.dup
-        @harvest_client = opts[:harvest_client] || Harvesting::Client.new(opts)
+        @harvest_client = opts[:harvest_client] || Harvesting::Client.new(**opts)
       end
 
       # It calls `create` or `update` depending on the record's ID. If the ID
@@ -65,7 +65,7 @@ module Harvesting
       # @param opts [Hash] options to pass along to the `Harvesting::Client`
       #   instance
       def self.get(id, opts = {})
-        client = opts[:harvest_client] || Harvesting::Client.new(opts)
+        client = opts[:harvest_client] || Harvesting::Client.new(**opts)
         self.new({ 'id' => id }, opts).fetch
       end
 
@@ -108,7 +108,7 @@ module Harvesting
       def self.modeled(opts = {})
         opts.each do |attribute_name, model|
           attribute_name_string = attribute_name.to_s
-          Harvesting::Models::Base.send :define_method, attribute_name_string do
+          define_method(attribute_name_string) do
             @models[attribute_name_string] ||= model.new(@attributes[attribute_name_string] || {}, harvest_client: harvest_client)
           end
         end

data/lib/harvesting/version.rb

@@ -1,3 +1,3 @@
 module Harvesting
-  VERSION = "0.5.1".freeze
+  VERSION = "0.6.0".freeze
 end

data/pull_request_template.md

@@ -0,0 +1,9 @@
+**IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issues, make sure you include _Closes #XXXX_ in your comment or use the option on the PR's sidebar to add related issues to auto-close the issue that your PR fixes. **
+
+**Description:**
+
+Please include a summary of the change and which issue is fixed or which feature is introduced. If changes to the behavior are made, clearly describe what changes.
+If changes to the UI are made, please include screenshots of the before and after.
+
+
+I will abide by the [code of conduct](CODE_OF_CONDUCT.md).

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: harvesting
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Ernesto Tagwerker
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-15 00:00:00.000000000 Z
+date: 2023-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -20,7 +20,7 @@ dependencies:
         version: '3.3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -30,7 +30,7 @@ dependencies:
         version: '3.3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -103,22 +103,22 @@ dependencies:
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -257,6 +257,7 @@ files:
 - lib/harvesting/models/user.rb
 - lib/harvesting/models/users.rb
 - lib/harvesting/version.rb
+- pull_request_template.md
 homepage: https://github.com/fastruby/harvesting
 licenses:
 - MIT
@@ -276,7 +277,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.3
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Ruby wrapper for the Harvest API v2.0