harvesting 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb6b38d71800f5156d305c7702286b90f74b0db7a0718912495117acc11a5865
-  data.tar.gz: 548e13f94ef0e0cac713350afadad6e039f995ce481ff7166ee5de441c3cc3a9
+  metadata.gz: 8f6d054347741b50002f88258ec6816852d6463fddcf45163779d5c8cc56c5b6
+  data.tar.gz: c92bb840b2825539dad52caab0d51871f89248d63b37ecb6e08cde0d9154b6b6
 SHA512:
-  metadata.gz: c8daf60be6c6c9fb503a1f7778a963390c8857d52f76b6aecfe8a1d046f589946defc9b56cd17c501aa84c6c6318224cb082f1c603a3ae0c38b3f92ab9109f9c
-  data.tar.gz: 781ed847b381891c9f66675720e4db332bc7835fb94d2362db73c65e5460f9580400b6a10812eefc5c6c10539f0f4c61603f0e1fb5dbd24452a891d521778704
+  metadata.gz: e6a1957ac8fb4f16e77996e3f1d1504825d4b6bb90fb1e0bf749a0b399755fd04756eb4fd60b54bc2635b03c843de99a5fc19309fe4627059344ec9ec2027749
+  data.tar.gz: 96bae4c6ead7a63caacee4b67def836f5f76047677a09b0f7cdda4ecb0521f4b1bd81bc1666239cbb0a2bdfb3426e80564210b82ad5a8e79c94665a4768b35f7

data/.travis.yml

@@ -1,10 +1,10 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4.10
   - 2.5.8
   - 2.6.6
   - 2.7.1
+  - 3.0
 env:
   - HARVEST_FIRST_NAME=Aaron HARVEST_LAST_NAME=Burr HARVEST_ACCOUNT_ID=112341234 HARVEST_NON_ADMIN_ACCOUNT_ID=112341234 HARVEST_ACCESS_TOKEN=112341234 HARVEST_NON_ADMIN_ACCESS_TOKEN=112341234 HARVEST_ADMIN_FULL_NAME=112341234
 

data/README.md

@@ -1,7 +1,8 @@
 # Harvesting
 
-[![Build Status](https://travis-ci.org/fastruby/harvesting.svg?branch=master)](https://travis-ci.org/ombulabs/harvesting)
-[![Code Climate](https://codeclimate.com/github/fastruby/harvesting/badges/gpa.svg)](https://codeclimate.com/github/ombulabs/harvesting)
+[![Build Status](https://travis-ci.org/fastruby/harvesting.svg?branch=main)](https://travis-ci.org/fastruby/harvesting)
+[![Code Climate](https://codeclimate.com/github/fastruby/harvesting/badges/gpa.svg)](https://codeclimate.com/github/fastruby/harvesting)
+[![codecov](https://codecov.io/gh/fastruby/harvesting/branch/main/graph/badge.svg)](https://codecov.io/gh/fastruby/harvesting)
 
 A Ruby gem to interact with the Harvest API v2.0 and forward.
 
@@ -23,7 +24,7 @@ Or install it yourself as:
 
 ## Documentation
 
-The API is documented [here](https://www.rubydoc.info/github/ombulabs/harvesting)
+The API is documented [here](https://www.rubydoc.info/gems/harvesting)
 
 ## Usage
 
@@ -166,7 +167,7 @@ end
 
 ## Roadmap
 
-There are many things to be developed for this gem. For now they are tracked here: [TODO.md](https://github.com/ombulabs/harvesting/blob/master/TODO.md)
+There are many things to be developed for this gem. For now they are tracked here: [TODO.md](https://github.com/fastruby/harvesting/blob/main/TODO.md)
 
 ## Releases
 
@@ -240,7 +241,17 @@ We follow semantic versioning for version numbers: [https://semver.org](https://
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at [https://github.com/ombulabs/harvesting](https://github.com/ombulabs/harvesting). This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at [https://github.com/fastruby/harvesting](https://github.com/fastruby/harvesting). This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+
+When Submitting a Pull Request:
+
+* If your PR closes any open GitHub issues, please include `Closes #XXXX` in your comment
+
+* Please include a summary of the change and which issue is fixed or which feature is introduced.
+
+* If changes to the behavior are made, clearly describe what changes.
+
+* If changes to the UI are made, please include screenshots of the before and after.
 
 ## License
 
@@ -248,4 +259,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the Harvesting project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/ombulabs/harvesting/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Harvesting project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/fastruby/harvesting/blob/main/CODE_OF_CONDUCT.md).

data/RELEASE_NOTES.md

@@ -1,13 +1,36 @@
 # RELEASE NOTES
 
-### main 
+### main
 
 **Notes**
 
-### Version 0.5.0 - September 3, 2020 
+**Bug Fixes**
+
+### Version 0.6.0 - July 17, 2023
+
+**Notes**
+
+**Bug Fixes**
+
+- Fix incompatibility with Ruby 3.0 and kwargs: https://github.com/fastruby/harvesting/pull/68
+
+### Version 0.5.1 - January 14, 2021
+
+**Notes**
+- Add support for Codecov so that we can track code coverage over time in the
+library: https://github.com/fastruby/harvesting/pull/59
+
+**Bug Fixes**
+- Fix incompatibility with Ruby 3.0: https://github.com/fastruby/harvesting/pull/64
+- Relax `http` dependency declaration so that we can `bundle install` with more
+modern versions of that gem: https://github.com/fastruby/harvesting/pull/63
+- Fix issue when trying to remove an entity that is not removable:
+https://github.com/fastruby/harvesting/pull/61
+
+### Version 0.5.0 - September 3, 2020
 
 **Notes**
-- Changed behavior of `client.clients` so that it returns an instance of `Harvesting::Models::Clients` instead of an `Array`: https://github.com/ombulabs/harvesting/pull/39
+- Changed behavior of `client.clients` so that it returns an instance of `Harvesting::Models::Clients` instead of an `Array`: https://github.com/fastruby/harvesting/pull/39
 
 **Bug Fixes**
 - Add support for Harvesting::RateLimitExceeded instead of a JSON::ParserError: https://github.com/fastruby/harvesting/pull/57
@@ -16,47 +39,47 @@
 ### Version 0.4.0 - June 6, 2020
 
 **Notes**
-- Added Ruby 2.5.1 to version matrix in Travis: https://github.com/ombulabs/harvesting/pull/31
-- Associated time entries for project: https://github.com/ombulabs/harvesting/pull/32
-- Add require forwardable in havest_record_collection model: https://github.com/ombulabs/harvesting/pull/40
-- Add syntax highlighting to readme examples: https://github.com/ombulabs/harvesting/pull/41
-- Rename the client key as harvest_client to avoid confusion: https://github.com/ombulabs/harvesting/pull/43
-- Update rake requirement from ~> 10.0 to ~> 13.0: https://github.com/ombulabs/harvesting/pull/44
-- Bump ffi from 1.9.23 to 1.12.2: https://github.com/ombulabs/harvesting/pull/45
-- Ability to supply filter options to the invoice end point and a model for line items on an invoice.: https://github.com/ombulabs/harvesting/pull/46
+- Added Ruby 2.5.1 to version matrix in Travis: https://github.com/fastruby/harvesting/pull/31
+- Associated time entries for project: https://github.com/fastruby/harvesting/pull/32
+- Add require forwardable in havest_record_collection model: https://github.com/fastruby/harvesting/pull/40
+- Add syntax highlighting to readme examples: https://github.com/fastruby/harvesting/pull/41
+- Rename the client key as harvest_client to avoid confusion: https://github.com/fastruby/harvesting/pull/43
+- Update rake requirement from ~> 10.0 to ~> 13.0: https://github.com/fastruby/harvesting/pull/44
+- Bump ffi from 1.9.23 to 1.12.2: https://github.com/fastruby/harvesting/pull/45
+- Ability to supply filter options to the invoice end point and a model for line items on an invoice.: https://github.com/fastruby/harvesting/pull/46
 
 **Bug Fixes**
 
-- Complete pending test: https://github.com/ombulabs/harvesting/pull/28
-- Fixed Code Climate link: https://github.com/ombulabs/harvesting/pull/38
+- Complete pending test: https://github.com/fastruby/harvesting/pull/28
+- Fixed Code Climate link: https://github.com/fastruby/harvesting/pull/38
 
 
 ### Version 0.3.0 - Jan 22, 2019
 
 **Notes**
 
-- Support for users: https://github.com/ombulabs/harvesting/pull/9
-- Support for fetching single records: https://github.com/ombulabs/harvesting/pull/14 and https://github.com/ombulabs/harvesting/pull/22
-- Nested models make it easier to access data: https://github.com/ombulabs/harvesting/pull/15
-- Better architecture for collections: https://github.com/ombulabs/harvesting/pull/18
+- Support for users: https://github.com/fastruby/harvesting/pull/9
+- Support for fetching single records: https://github.com/fastruby/harvesting/pull/14 and https://github.com/fastruby/harvesting/pull/22
+- Nested models make it easier to access data: https://github.com/fastruby/harvesting/pull/15
+- Better architecture for collections: https://github.com/fastruby/harvesting/pull/18
 
 **Bug Fixes**
 
-- Correct pagination support: https://github.com/ombulabs/harvesting/pull/17
-- Added documentation: https://github.com/ombulabs/harvesting/pull/30
+- Correct pagination support: https://github.com/fastruby/harvesting/pull/17
+- Added documentation: https://github.com/fastruby/harvesting/pull/30
 
 ### Version 0.2.0 - Oct 18, 2018
 
 **Notes**
 
 - More documentation in README.md
-- Adds ability to access user associated with time entries: https://github.com/ombulabs/harvesting/pull/3
-- Adds support for Docker for development: https://github.com/ombulabs/harvesting/pull/1
+- Adds ability to access user associated with time entries: https://github.com/fastruby/harvesting/pull/3
+- Adds support for Docker for development: https://github.com/fastruby/harvesting/pull/1
 
 **Bug Fixes**
 
-- Fixes issues with specs: https://github.com/ombulabs/harvesting/pull/2
-- Fixed https://github.com/ombulabs/harvesting/issues/6 with https://github.com/ombulabs/harvesting/pull/7
+- Fixes issues with specs: https://github.com/fastruby/harvesting/pull/2
+- Fixed https://github.com/fastruby/harvesting/issues/6 with https://github.com/fastruby/harvesting/pull/7
 
 ## Version 0.1.0 - Sep 04, 2018
 

data/harvesting.gemspec

@@ -20,14 +20,16 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-  spec.add_dependency "http", "~> 3.3", ">= 3.3"
+  spec.add_dependency "http", ">= 3.3", "< 5.1"
 
   spec.add_development_dependency "bundler", ">= 2.0", "< 3.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "guard-rspec", "~> 4.7", ">= 4.7"
-  spec.add_development_dependency "byebug", "~> 10.0", ">= 10.0"
+  spec.add_development_dependency "byebug", ">= 10.0", "< 12.0"
   spec.add_development_dependency "vcr", "~> 4.0", ">= 4.0"
   spec.add_development_dependency "webmock", "~> 3.4", ">= 3.4"
   spec.add_development_dependency "dotenv", "~> 2.5", ">= 2.5"
+  spec.add_development_dependency "simplecov", "~> 0.19.0"
+  spec.add_development_dependency "codecov", "~> 0.2.9"
 end

data/lib/harvesting/client.rb

@@ -12,7 +12,7 @@ module Harvesting
 
     # Returns a new instance of `Client`
     #
-    #     client = Client.new(access_token: "12345678", account_id: "98764")
+    #     client = Client.new({ access_token: "12345678", account_id: "98764" })
     #
     # @param [Hash] opts the options to create an API client
     # @option opts [String] :access_token Harvest access token
@@ -30,7 +30,7 @@ module Harvesting
     def me
       Harvesting::Models::User.new(get("users/me"), harvest_client: self)
     end
-    
+
     # @return [Harvesting::Models::Clients]
     def clients(opts = {})
       Harvesting::Models::Clients.new(get("clients", opts), opts, harvest_client: self)
@@ -115,7 +115,8 @@ module Harvesting
       url = "#{DEFAULT_HOST}/#{entity.path}"
       uri = URI(url)
       response = http_response(:delete, uri)
-      raise UnprocessableRequest(response.to_s) unless response.code.to_i == 200
+      raise UnprocessableRequest.new(response.to_s) unless response.code.to_i == 200
+
       JSON.parse(response.body)
     end
 

data/lib/harvesting/enumerable.rb

@@ -7,7 +7,7 @@ module Harvesting
     include ::Enumerable
 
     # @return [Enumerator]
-    def each(start = 0)
+    def each(start = 0, &block)
       @cursor = start
       return to_enum(:each, start) unless block_given?
       Array(@entries[start..-1]).each_with_index do |element, index|
@@ -18,7 +18,7 @@ module Harvesting
       unless last?
         start = [@entries.size, start].max
         fetch_next_page
-        each(start, &Proc.new)
+        each(start, &block)
       end
       self
     end

data/lib/harvesting/models/base.rb

@@ -9,7 +9,7 @@ module Harvesting
       def initialize(attrs, opts = {})
         @models = {}
         @attributes = attrs.dup
-        @harvest_client = opts[:harvest_client] || Harvesting::Client.new(opts)
+        @harvest_client = opts[:harvest_client] || Harvesting::Client.new(**opts)
       end
 
       # It calls `create` or `update` depending on the record's ID. If the ID
@@ -65,7 +65,7 @@ module Harvesting
       # @param opts [Hash] options to pass along to the `Harvesting::Client`
       #   instance
       def self.get(id, opts = {})
-        client = opts[:harvest_client] || Harvesting::Client.new(opts)
+        client = opts[:harvest_client] || Harvesting::Client.new(**opts)
         self.new({ 'id' => id }, opts).fetch
       end
 
@@ -108,7 +108,7 @@ module Harvesting
       def self.modeled(opts = {})
         opts.each do |attribute_name, model|
           attribute_name_string = attribute_name.to_s
-          Harvesting::Models::Base.send :define_method, attribute_name_string do
+          define_method(attribute_name_string) do
             @models[attribute_name_string] ||= model.new(@attributes[attribute_name_string] || {}, harvest_client: harvest_client)
           end
         end

data/lib/harvesting/version.rb

@@ -1,3 +1,3 @@
 module Harvesting
-  VERSION = "0.5.0".freeze
+  VERSION = "0.6.0".freeze
 end

data/pull_request_template.md

@@ -0,0 +1,9 @@
+**IMPORTANT: Please read the README before submitting pull requests for this project. Additionally, if your PR closes any open GitHub issues, make sure you include _Closes #XXXX_ in your comment or use the option on the PR's sidebar to add related issues to auto-close the issue that your PR fixes. **
+
+**Description:**
+
+Please include a summary of the change and which issue is fixed or which feature is introduced. If changes to the behavior are made, clearly describe what changes.
+If changes to the UI are made, please include screenshots of the before and after.
+
+
+I will abide by the [code of conduct](CODE_OF_CONDUCT.md).

metadata

@@ -1,36 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: harvesting
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Ernesto Tagwerker
 - M. Scott Ford
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-04 00:00:00.000000000 Z
+date: 2023-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.3'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.3'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -103,22 +103,22 @@ dependencies:
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -179,6 +179,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.5'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.19.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.19.0
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.9
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.9
 description: Interact with the Harvest API v2.0 from your Ruby application
 email:
 - ernesto+github@ombulabs.com
@@ -229,11 +257,12 @@ files:
 - lib/harvesting/models/user.rb
 - lib/harvesting/models/users.rb
 - lib/harvesting/version.rb
+- pull_request_template.md
 homepage: https://github.com/fastruby/harvesting
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -248,8 +277,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.3
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Ruby wrapper for the Harvest API v2.0
 test_files: []