harvestdor-indexer 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 60218ff6d0f0210900b1b6a0df4d3a09a7122c34
-  data.tar.gz: 04ba680a7f7864dca78cbc9751c8eb9f6f9c811b
+  metadata.gz: e3fa52b261d36405abf85f703fa18455149a37af
+  data.tar.gz: ec64353f2066115d63aaaff6088cc5c83c082aab
 SHA512:
-  metadata.gz: 2df842d3b19d9750f7a5e88f9af9dab60cfffa34cc80d7584b5b16f825aff64478e4c1ba3dde05de5749a9b8c17cbabd29fb55b4c71c965253b32d446686013b
-  data.tar.gz: 3c479f7be2c27ad39acad3316b77987dce8c487a654f47758513a4c4d094973ed7b0168f85307a5135de212d7469478e4e475285bd490250058b03869fea6619
+  metadata.gz: e186e0140e2d25192c6a897b4f65c5b7586223004778527132a4dfa782532cc7219a86984776b1f63e89fb8a49be84d3ef525574366b5fb04efcf0a73222dd49
+  data.tar.gz: 6c5710fcbf00a97f2da3282b9e612bbe8eed425e8aaa41a5ba3da8c5285c6721a4ad21c44be3fbf7977874bcb47792b6b078f2d4e3450514035440eea0f561bd

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,12 @@
+require: rubocop-rspec
+
+inherit_from: .rubocop_todo.yml
+
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+Style/TrailingBlankLines:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,314 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2015-10-21 18:25:46 -0700 using RuboCop version 0.34.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/DeprecatedClassMethods:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/harvestdor/indexer/solr.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+
+# Offense count: 4
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 2
+Metrics/AbcSize:
+  Max: 20
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 105
+
+# Offense count: 101
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 207
+
+# Offense count: 11
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+    - 'spec/unit/harvestdor-indexer-solr_spec.rb'
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 15
+# Configuration parameters: CustomTransform, IgnoredWords.
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+    - 'spec/unit/harvestdor/indexer/metrics_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: CustomTransform.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+    - 'spec/unit/harvestdor-indexer-solr_spec.rb'
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 102
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AndOr:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+    - 'lib/harvestdor/indexer/resource.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+Style/BlockDelimiters:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'lib/harvestdor/indexer/metrics.rb'
+    - 'lib/harvestdor/indexer/resource.rb'
+    - 'lib/harvestdor/indexer/solr.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ClosingParenthesisIndentation:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/CommentIndentation:
+  Exclude:
+    - 'harvestdor-indexer.gemspec'
+
+# Offense count: 3
+# Configuration parameters: Exclude.
+Style/Documentation:
+  Exclude:
+    - 'lib/harvestdor/indexer/resource.rb'
+    - 'lib/harvestdor/indexer/solr.rb'
+    - 'lib/harvestdor/indexer/version.rb'
+
+# Offense count: 1
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/harvestdor/indexer/resource.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EmptyLines:
+  Exclude:
+    - 'lib/harvestdor/indexer/resource.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EmptyLinesAroundMethodBody:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+
+# Offense count: 4
+# Configuration parameters: Exclude.
+Style/FileName:
+  Exclude:
+    - 'lib/harvestdor-indexer.rb'
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+    - 'spec/unit/harvestdor-indexer-solr_spec.rb'
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+
+# Offense count: 15
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
+Style/HashSyntax:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/IndentationConsistency:
+  Exclude:
+    - 'harvestdor-indexer.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: Width.
+Style/IndentationWidth:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/LeadingCommentSpace:
+  Exclude:
+    - 'spec/unit/harvestdor/indexer/metrics_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/MethodCallParentheses:
+  Exclude:
+    - 'spec/unit/harvestdor-indexer_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MethodDefParentheses:
+  Enabled: false
+
+# Offense count: 1
+Style/MultilineBlockChain:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/NegatedIf:
+  Exclude:
+    - 'lib/harvestdor/indexer/resource.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'harvestdor-indexer.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Proc:
+  Exclude:
+    - 'lib/harvestdor/indexer/solr.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'lib/harvestdor/indexer/metrics.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SignalException:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+    - 'lib/harvestdor/indexer/resource.rb'
+    - 'spec/unit/harvestdor/indexer/metrics_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: MultiSpaceAllowedForOperators.
+Style/SpaceAroundOperators:
+  Exclude:
+    - 'lib/harvestdor/indexer/metrics.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/SpaceInsideBrackets:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SpecialGlobalVars:
+  Exclude:
+    - 'harvestdor-indexer.gemspec'
+
+# Offense count: 147
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+Style/SymbolProc:
+  Exclude:
+    - 'lib/harvestdor/indexer.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/Tab:
+  Exclude:
+    - 'harvestdor-indexer.gemspec'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+Style/TrailingWhitespace:
+  Exclude:
+    - 'lib/harvestdor/indexer/metrics.rb'
+    - 'spec/unit/harvestdor-indexer-resource_spec.rb'
+    - 'spec/unit/harvestdor/indexer/metrics_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/UnneededPercentQ:
+  Exclude:
+    - 'harvestdor-indexer.gemspec'

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
-script: rake rspec
+sudo: false
+script: rake
 rvm:
   - 2.2.0
   - 2.1.5
@@ -11,4 +12,4 @@ notifications:
   email:
     - ndushay@stanford.edu
     - laneymcg@stanford.edu
-    - bess@stanford.edu
+    - cbeer@stanford.edu

data/README.rdoc

@@ -26,7 +26,15 @@ You must override the index method and provide configuration options.  It is rec
 
 === Configuration / Set up
 
-Create a yml config file for your collection going to a Solr index.  
+Create a yml config file for your collection going to a Solr index.
+
+See  spec/config/ap.yml for an example.
+You will want to copy that file and change the following settings:
+
+# whitelist
+# dor fetcher service_url
+# solr url
+# harvestdor log_dir, log_nam
 
 Note: Because of an update to underlying HTTP libraries, versions of this gem > 0.0.12 require an updated syntax. Errors like "unknown method timeout" might be because you're using an older version of a config file. The new configuration looks like this:
 
@@ -38,45 +46,46 @@ Note: Because of an update to underlying HTTP libraries, versions of this gem >
       timeout: 180
       open_timeout: 180
 
-See  spec/config/ap.yml for an example.
-You will want to copy that file and change the following settings:
-1. log_name
-2. default_set
-3. blacklist or whitelist if you are using them
 
-Update the dor-fetcher-client.yml file in the config directory with the location of the URL of the dor-fetcher-service provider.  The defaulted value is the 3000 port for a localhost - dor_fetcher_service_url: http://127.0.0.1:3000
+==== Whitelist
+
+Note: the whitelist is how you specify which objects to index.  The whitelist
+can be
+
+* an Array of druids inline in the config yml file
+* a filename containing a list of druids (one per line)
+
+If a druid, per the object's identityMetadata at purl page, is for a
+
+* collection record:  then we process all the item druids in that collection (as if they were included individually in the whitelist)
+* non-collection record: then we process the druid as an individual item
 
 === Override the Harvestdor::Indexer.index method
 
 In your code, override this method from the Harvestdor::Indexer class
 
-# create Solr doc for the druid and add it to Solr, unless it is on the blacklist.  
-#  NOTE: don't forget to send commit to Solr, either once at end (already in harvest_and_index), or for each add, or ...
-def index druid
-  if blacklist.include?(druid)
-    logger.info("Druid #{druid} is on the blacklist and will have no Solr doc created")
-  else
-    logger.error("You must override the index method to transform druids into Solr docs and add them to Solr")
-    
-    doc_hash = {}
-    doc_hash[:id] = druid
-    # doc_hash[:title_tsim] = smods_rec(druid).short_title
-
-    # you might add things from Indexer level class here
-    #  (e.g. things that are the same across all documents in the harvest)
-
-    solr_client.add(doc_hash)
-
-    # logger.info("Just created Solr doc for #{druid}")
-    # TODO: provide call to code to update DOR object's workflow datastream??
-  end
-end
+    # create Solr doc for the druid and add it to Solr
+    #  NOTE: don't forget to send commit to Solr, either once at end (already in harvest_and_index), or for each add, or ...
+    def index resource
+
+      benchmark "Indexing #{resource.druid}" do
+        logger.debug "About to index #{resource.druid}"
+        doc_hash = {}
+        doc_hash[:id] = resource.druid
+
+        # you might add things from Indexer level class here
+        #  (e.g. things that are the same across all documents in the harvest)
+        solr.add doc_hash
+        # TODO: provide call to code to update DOR object's workflow datastream??
+      end
+    end
+
 
 === Run it
 
 (bundle install)
 
-I suggest you write a script to run the code.  Your script might look like this:
+You may want to write a script to run the code.  Your script might look like this:
 
   #!/usr/bin/env ruby
   $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..'))
@@ -93,19 +102,14 @@ I suggest you write a script to run the code.  Your script might look like this:
     puts "** You must provide the full path to a collection config yml file **"
     exit
   end
-  if client_config_path.nil?
-    puts "** You must provide the full path to dor-fetcher-client config yml file **"
-    exit
-  end
-  indexer = Harvestdor::Indexer.new(config_yml_path, client_config_path, opts)
+  indexer = Harvestdor::Indexer.new(config_yml_path, opts)
   indexer.harvest_and_index
 
 Then you run the script like so:
 
 	 ./bin/indexer config/(your coll).yml
 
-I suggest you run your code on harvestdor-dev, as it is already set up to be able to harvest from the DorFetcher
-
+Run from deployed instance, as that box is already set up to be able to talk to DOR Fetcher service and to SUL Solr indexes.
 
 == Contributing
 

data/Rakefile

@@ -3,10 +3,6 @@ require "bundler/gem_tasks"
 require 'rake'
 require 'bundler'
 
-require 'rspec/core/rake_task'
-require 'yard'
-require 'yard/rake/yardoc_task'
-
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
@@ -15,10 +11,12 @@ rescue Bundler::BundlerError => e
   exit e.status_code
 end
 
-task :default => :ci  
+task :default => [:rspec, :rubocop]
+
+desc "run continuous integration suite (tests, coverage, docs)"
+task :ci => [:rspec, :doc, :rubocop]
 
-desc "run continuous integration suite (tests, coverage, docs)" 
-task :ci => [:rspec, :doc]
+require 'rspec/core/rake_task'
 
 task :spec => :rspec
 
@@ -31,7 +29,12 @@ RSpec::Core::RakeTask.new(:rspec) do |spec|
   spec.rspec_opts = ["-c", "-f progress", "--tty", "-r ./spec/spec_helper.rb"]
 end
 
+require 'rubocop/rake_task'
+RuboCop::RakeTask.new(:rubocop)
+
 # Use yard to build docs
+require 'yard'
+require 'yard/rake/yardoc_task'
 begin
   project_root = File.expand_path(File.dirname(__FILE__))
   doc_dest_dir = File.join(project_root, 'doc')
@@ -46,5 +49,4 @@ rescue LoadError
   task :doc do
     abort "Please install the YARD gem to generate rdoc."
   end
-end  
-
+end

data/harvestdor-indexer.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^spec/})
   gem.require_paths = ["lib"]
-  
+
   gem.add_dependency 'rsolr'
   gem.add_dependency 'retries'
   gem.add_dependency 'harvestdor', '>=0.0.14'
@@ -24,13 +24,11 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'dor-fetcher', '=1.0.5'
   gem.add_dependency "activesupport"
   gem.add_dependency "parallel"
-  
+
   # Runtime dependencies
   gem.add_runtime_dependency 'confstruct'
 
   # Development dependencies
-  # Bundler will install these gems too if you've checked out solrmarc-wrapper source from git and run 'bundle install'
-  # It will not add these as dependencies if you require solrmarc-wrapper for other projects
   gem.add_development_dependency "rake"
   # docs
   gem.add_development_dependency "rdoc"
@@ -38,8 +36,9 @@ Gem::Specification.new do |gem|
   # tests
 	gem.add_development_dependency 'rspec', "~> 3.0"
 	gem.add_development_dependency 'coveralls'
-	# gem.add_development_dependency 'ruby-debug19'
+  gem.add_development_dependency 'rubocop'
+  gem.add_development_dependency 'rubocop-rspec'
   gem.add_development_dependency 'vcr'
   gem.add_development_dependency 'webmock'
-  
+
 end

data/lib/harvestdor/indexer/resource.rb

@@ -5,13 +5,16 @@ module Harvestdor
     include ActiveSupport::Benchmarkable
 
     attr_reader :indexer, :druid, :options
-  
-    def initialize indexer, druid, options = {}
+
+    # @param [Harvestdor::Indexer] indexer an instance of Harvestdor::Indexer
+    # @param [String] coll_druid a collection druid of the form 'druid:oo123oo1234'
+    def initialize indexer, coll_druid, options = {}
       @indexer = indexer
-      @druid = druid
+      @druid = coll_druid
       @options = options
     end
 
+    # @return [String] string of form  oo123oo1234
     def bare_druid
       @bare_druid ||= druid.gsub("druid:", "")
     end
@@ -45,7 +48,7 @@ module Harvestdor
         ns_hash = {'rdf' => 'http://www.w3.org/1999/02/22-rdf-syntax-ns#', 'fedora' => "info:fedora/fedora-system:def/relations-external#", '' => ''}
         is_member_of_nodes ||= public_xml.xpath('/publicObject/rdf:RDF/rdf:Description/fedora:isMemberOfCollection/@rdf:resource', ns_hash)
 
-        is_member_of_nodes.reject { |n| n.value.empty? }.map do |n| 
+        is_member_of_nodes.reject { |n| n.value.empty? }.map do |n|
           Harvestdor::Indexer::Resource.new(indexer, n.value.gsub("info:fedora/", ""))
         end
       end
@@ -59,18 +62,16 @@ module Harvestdor
         druids.map { |x| Harvestdor::Indexer::Resource.new(indexer, x) }
       end
     end
-    
+
     # given a druid, get its objectLabel from its purl page identityMetadata
-    # @param [String] druid, e.g. ab123cd4567
     # @return [String] the value of the <objectLabel> element in the identityMetadata for the object
     def identity_md_obj_label
       logger.error("#{druid} missing identityMetadata") unless identity_metadata
       identity_metadata.xpath('identityMetadata/objectLabel').text
     end
-    
-    
+
+
     # return the MODS for the druid as a Stanford::Mods::Record object
-    # @param [String] druid e.g. ab123cd4567
     # @return [Stanford::Mods::Record] created from the MODS xml for the druid
     def smods_rec
       @smods_rec ||= benchmark "smods_rec(#{druid})", level: :debug do
@@ -85,9 +86,8 @@ module Harvestdor
     def mods
       @mods ||= harvestdor_client.mods bare_druid
     end
-    
+
     # the public xml for this DOR object, from the purl page
-    # @param [String] druid e.g. ab123cd4567
     # @return [Nokogiri::XML::Document] the public xml for the DOR object
     def public_xml
       @public_xml ||= benchmark "public_xml(#{druid})", level: :debug do
@@ -114,10 +114,8 @@ module Harvestdor
         bare_druid
       end
     end
-    
+
     # the contentMetadata for this DOR object, ultimately from the purl public xml
-    # @param [Object] object a String containing a druid (e.g. ab123cd4567), or 
-    #  a Nokogiri::XML::Document containing the public_xml for an object
     # @return [Nokogiri::XML::Document] the contentMetadata for the DOR object
     def content_metadata
       ng_doc = benchmark "content_metadata (#{druid})", level: :debug do
@@ -126,10 +124,8 @@ module Harvestdor
       raise "No contentMetadata for \"#{druid}\"" if !ng_doc || ng_doc.children.empty?
       ng_doc
     end
-    
+
     # the identityMetadata for this DOR object, ultimately from the purl public xml
-    # @param [Object] object a String containing a druid (e.g. ab123cd4567), or 
-    #  a Nokogiri::XML::Document containing the public_xml for an object
     # @return [Nokogiri::XML::Document] the identityMetadata for the DOR object
     def identity_metadata
       ng_doc = benchmark "identity_metadata (#{druid})", level: :debug do
@@ -138,10 +134,8 @@ module Harvestdor
       raise "No identityMetadata for \"#{druid}\"" if !ng_doc || ng_doc.children.empty?
       ng_doc
     end
-    
+
     # the rightsMetadata for this DOR object, ultimately from the purl public xml
-    # @param [Object] object a String containing a druid (e.g. ab123cd4567), or 
-    #  a Nokogiri::XML::Document containing the public_xml for an object
     # @return [Nokogiri::XML::Document] the rightsMetadata for the DOR object
     def rights_metadata
       ng_doc = benchmark "rights_metadata (#{druid})", level: :debug do
@@ -150,10 +144,8 @@ module Harvestdor
       raise "No rightsMetadata for \"#{druid}\"" if !ng_doc || ng_doc.children.empty?
       ng_doc
     end
-    
+
     # the RDF for this DOR object, ultimately from the purl public xml
-    # @param [Object] object a String containing a druid (e.g. ab123cd4567), or 
-    #  a Nokogiri::XML::Document containing the public_xml for an object
     # @return [Nokogiri::XML::Document] the RDF for the DOR object
     def rdf
       ng_doc = benchmark "rdf (#{druid})", level: :debug do