harness 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 45b1ba669c00fddf944318514aaae8cc3184d43a
-  data.tar.gz: 7aab2e9ccd8d860dff8eab3ce29ed1aba54e8c20
+  metadata.gz: 331d4b6080058b3d3691dbba570c2fd997a07d6b
+  data.tar.gz: 305a235a8ab89e07bd091dc381876ff9c4a7e656
 SHA512:
-  metadata.gz: e1b748e7ecbcf4a6c29da4b05835b60c1303865bacc4c0c6e9355399d25103e25624623394104a7b3f74f67b6f4ac264773dd4e1e5e30908b71056e381611914
-  data.tar.gz: 83bcf438c22c5a36a9b79cd1a4bb1449ab16dc11e698bff1ab85b6b82c6d9d04e31c82c23b08f9ad9b510846908ab5727272da1da66c5239b5634f474cc38f46
+  metadata.gz: ba1e3dbeeeafcdb43c21099b98ccda432c660b23d1f3cf130450a2c924d0894c527e5f66b94799c1e38d2025f3bc31b1ccf1638d667976b2c624805362b6f743
+  data.tar.gz: a6810d20de6134b3c1c43ff2aacec5d1e273248aaa6be557c771490f8c3da06fdd65f1cb5d6533683b0827378fc7891bee0c84bf74a60cbb7a035c897721ce87

data/lib/harness.rb

@@ -76,10 +76,14 @@ module Harness
   end
 
   def self.reset_counters!
-    redis.smembers('counters').each do |counter|
+    counters.each do |counter|
       redis.set counter, 0
     end
   end
+
+  def self.counters
+    redis.keys "counters/*"
+  end
 end
 
 require 'harness/measurement'

data/lib/harness/counter.rb

@@ -13,16 +13,14 @@ module Harness
 
       counter.id ||= event.name
 
-      Harness.redis.sadd 'counters', counter.id
-
       if event.payload[:counter].is_a? Fixnum
         counter.value = event.payload[:counter]
       end
 
       if counter.value
-        Harness.redis.set counter.id, counter.value
+        Harness.redis.set "counters/#{counter.id}", counter.value
       else
-        counter.value = Harness.redis.incr(counter.id).to_i
+        counter.value = Harness.redis.incr("counters/#{counter.id}").to_i
       end
 
       counter

data/lib/harness/version.rb

@@ -1,3 +1,3 @@
 module Harness
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

data/test/integration/counters_with_redis_test.rb

@@ -4,8 +4,7 @@ class CountersWithRedis < IntegrationTest
   def test_stores_name_in_redis
     instrument "event-counter", :counter => true
 
-    assert_includes redis.smembers('counters'), 'event-counter'
-    assert_equal 1, redis.get('event-counter').to_i
+    assert_equal 1, redis.get('counters/event-counter').to_i
 
     assert_counter_logged "event-counter"
   end
@@ -13,9 +12,9 @@ class CountersWithRedis < IntegrationTest
   def test_increments_counter_each_instrument
     instrument "event-counter", :counter => true
     assert_counter_logged "event-counter"
+
     counters.clear
 
-    assert_empty counters
     instrument "event-counter", :counter => true
     assert_counter_logged "event-counter"
 
@@ -25,8 +24,6 @@ class CountersWithRedis < IntegrationTest
   def test_sets_given_value_in_redis_with_shortform
     instrument "event-counter", :counter => 10
 
-    assert_equal 10, redis.get("event-counter").to_i
-
     counters.clear
 
     instrument "event-counter", :counter => true
@@ -38,7 +35,7 @@ class CountersWithRedis < IntegrationTest
   def test_sets_given_value_in_redis_with_longform
     instrument "event-counter", :counter => { :value => 10 }
 
-    assert_equal 10, redis.get("event-counter").to_i
+    assert_equal 10, redis.get("counters/event-counter").to_i
 
     counters.clear
 
@@ -52,29 +49,19 @@ class CountersWithRedis < IntegrationTest
     instrument "event-counter", :counter => true
     instrument "event-counter2", :counter => true
 
-    assert_equal 1, redis.get("event-counter").to_i
-    assert_equal 1, redis.get("event-counter2").to_i
+    assert_equal 1, redis.get("counters/event-counter").to_i
+    assert_equal 1, redis.get("counters/event-counter2").to_i
 
     Harness.reset_counters!
 
-    assert_equal 0, redis.get("event-counter").to_i
-    assert_equal 0, redis.get("event-counter2").to_i
+    assert_equal 0, redis.get("counters/event-counter").to_i
+    assert_equal 0, redis.get("counters/event-counter2").to_i
 
     counters.clear
     instrument "event-counter", :counter => true
     assert_counter_logged 'event-counter'
 
     assert_equal 1, counters.first.value
-    assert_equal 1, redis.get("event-counter").to_i
-  end
-
-  def test_resets_counters_resets_meters
-    instrument "event-counter", :counter => true
-
-    assert_equal 1, redis.get("event-counter").to_i
-
-    Harness.reset_counters!
-
-    assert_equal 0, redis.get("event-counter").to_i
+    assert_equal 1, redis.get("counters/event-counter").to_i
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: harness
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - ahawkins