harness 0.3.0 → 0.4.0

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+log

data/README.md

@@ -7,6 +7,8 @@ redis before being sent to the service.
 Currently Supported Services:
 
 * Librato
+* Statsd (thanks to fluxlux)
+* Stathat
 
 Current Features:
 
@@ -45,20 +47,26 @@ end
 
 Add this line to your application's Gemfile:
 
-    gem 'harness'
+```
+gem 'harness'
+```
 
 And then execute:
 
-    $ bundle
+```
+$ bundle
+```
 
 Or install it yourself as:
 
-    $ gem install harness
+```
+$ gem install harness
+```
 
 ## Usage
 
 In the metrics world there are two types of things: Gauges and Counters.
-Gauges are time senstive and represent something at a specific point in
+Gauges are time sensitive and represent something at a specific point in
 time. Counters keep track of things and should be increasing. Counters
 can be reset back to zero. You can combine counters and/or gauges to
 correlate data about your application. Meters monitor counters. They
@@ -94,7 +102,14 @@ stored in redis and incremented. This means you can simply pass
 may also pass `:counter => 5` if you'd like to provide your own value.
 This value is stored in redis so the next time `:counter => true` will
 work correctly. You can reset all the counters back to zero by calling:
-`Harness.reset_counters!`.
+`Harness.reset_counters!`. 
+
+**NOTE**: You should use the bundled rake task to reset counters with 
+a cron job. This will prevent unbounded growth of this metadata. You
+can call `rake harness:reset_counters` to do this. You should call
+this rake task at whatever your longest measurable interval is. Here's
+an example: You log gauges every 12 hours. You should reset the
+counters every 12 hours. This issue is discussed [here](https://github.com/twinturbo/harness/issues/15).
 
 ```ruby
 class MyClass
@@ -106,14 +121,25 @@ class MyClass
 end
 ```
 
-The instuments name will be sent as the name (`important_method.my_class`) 
+The instruments name will be sent as the name (`important_method.my_class`)
 for that gauge or counter.
 
+Note that `ActiveSupport::Notifications.instrument` doesn't require
+a block. This can be useful when you are taking an instant measurement.
+
+```ruby
+class MyClass
+  def important_method(stuff)
+    ActiveSupport::Notifications.instrument "important_method.my_class", :counter => true
+  end
+end
+```
+
 Harness will do all the extra work in sending these metrics to whatever
 service you're using.
 
 Once you the counters are you are instrumented, then you can meter them.
-Meters allow you take arbitary readings of counter rates. The results
+Meters allow you take arbitrary readings of counter rates. The results
 return a gauge so they can be logged as well.
 
 ```ruby
@@ -137,13 +163,18 @@ meter.per_hour
 
 ## Customizing
 
-You can pash a hash to `:counter` or `:gauge` to initialize the
+You can pass a hash to `:counter` or `:gauge` to initialize the
 measurement your own way.
 
+If you pass a value attribute to a gauge, it will be the value
+sent instead of the duration of the block.
+
 ```ruby
 class MyClass
   def important_method(stuff)
-    ActiveSupport::Notifications.instrument "important_method.my_class", :gauge => { :id => 'custom-id', :name => "My Measurement" } do
+    ActiveSupport::Notifications.instrument "important_method.my_class",
+    :gauge => { :id => 'custom-id', :name => "My Measurement",
+                :value => my_current_val, :units => 'cogs' } do
       do_important_stuff
     end
   end
@@ -152,10 +183,10 @@ end
 
 ## One Off Gauges and Counters
 
-You can instantiate `Harness::Counter` and `Harness::Guage` wherever you
+You can instantiate `Harness::Counter` and `Harness::Gauge` wherever you
 want. Events from `ActiveSupport` are just converted to these classes
 under the covers anyways. You can use these class if you want to take
-peridocial measurements or tracking something that happens outside the
+periodic measurements or tracking something that happens outside the
 application.
 
 ```ruby
@@ -174,21 +205,51 @@ counter.time # defaults to Time.now
 counter.value = read_total_users_in_database
 counter.log
 
-# Both class take an option hash
+### Both classes take an option hash
 
-gauge = Harness::Guage.new :time => Time.now, :id => 'foo.bar'
+gauge = Harness::Gauge.new :time => Time.now, :id => 'foo.bar'
 counter = Harness::Counter.new :time => Time.now, :id => 'foo.bar'
 ```
 
 ## Configuration
 
+### Librato
 ```ruby
 Harness.config.adapter = :librato
 
 Harness.config.librato.email = 'example@example.com'
 Harness.config.librato.token = 'your-api-key'
 
-Harness.redis = Redis.new
+```
+
+### StatsD
+
+Harness does **not** configure StatsD for you. It uses the StatsD class
+under the covers. If you've already configured that in your own way, great.
+If not, you can use the configuration proxy as described below. You
+must also add `statsd-instrument` to your `Gemfile`. This is a soft
+dependency that is not installed for you.
+
+```ruby
+Harness.config.adapter = :statsd
+
+# Harness.config.statsd is a proxy for the StatsD class
+Harness.config.statsd.host = 'localhost'
+Harness.config.statsd.port = '8080'
+Harness.config.statsd.default_sample_rate = 0.1
+Harness.config.statsd.logger = Rails.logger
+
+# You can assign your own StatsD implementation
+# by setting the "backend" attribute
+Harness.config.statsd.backend = CustomStatsD
+```
+
+### Stathat
+
+```ruby
+Harness.config.adapter = :stathat
+
+Harness.config.stathat.ezkey = 'example@example.com'
 ```
 
 ## Rails Integration
@@ -209,8 +270,8 @@ You can configure Harness from `application.rb`
 
 ```ruby
 config.harness.adapter = :librato
-config.librato.email = 'example@example.com'
-config.librato.token = 'your-api-key'
+config.harness.librato.email = 'example@example.com'
+config.harness.librato.token = 'your-api-key'
 ```
 
 Redis will be automatically configured if you `REDISTOGO_URL` or
@@ -225,7 +286,7 @@ require 'erb'
 file = Rails.root.join 'config', 'resque.yml'
 config = YAML.load(ERB.new(File.read(Rails.root.join('config', 'redis.yml'))).result)
 
-Harness.redis = Redis.new(:url => config[Rails.env])
+Harness.redis = Redis::Namespace.new('harness', :redis => Redis.connect(:url => config[Rails.env]))
 ```
 
 `rake harness:reset_counters` is also added.
@@ -239,10 +300,10 @@ logged in production.
 ### Background Processing
 
 Harness integrates automatically with Resque or Sidekiq. This is because
-reporting measurements can take time and add unncessary overhead to the
+reporting measurements can take time and add unnecessary overhead to the
 response time. If neither of these libraries are present, measurements
 **will be posted in realtime.** You can set your own queue by
-specifiying a class like so:
+specifying a class like so:
 
 ```ruby
 Harness.config.queue = MyCustomQueue

data/harness.gemspec

@@ -23,6 +23,10 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "webmock"
   gem.add_development_dependency "resque"
   gem.add_development_dependency "sidekiq"
+  gem.add_development_dependency "delayed_job_active_record"
   gem.add_development_dependency "active_model_serializers"
   gem.add_development_dependency "rails"
+  gem.add_development_dependency "sqlite3"
+  gem.add_development_dependency "minitest"
+  gem.add_development_dependency "statsd-instrument"
 end

data/lib/harness.rb

@@ -26,7 +26,7 @@ module Harness
 
     def adapter=(val)
       if val.is_a? Symbol
-        @adapter = "Harness::#{val.to_s.camelize}Adapter".constantize
+        @adapter = "Harness::#{val.to_s.camelize}Adapter".constantize.new
       else
         @adapter = val
       end
@@ -34,9 +34,9 @@ module Harness
 
     def queue=(val)
       if val.is_a? Symbol
-        @queue= "Harness::#{val.to_s.camelize}Queue".constantize
+        @queue = "Harness::#{val.to_s.camelize}Queue".constantize.new
       else
-        @queue= val
+        @queue = val
       end
     end
 
@@ -90,16 +90,13 @@ require 'harness/instrumentation'
 
 require 'harness/job'
 
-require 'harness/queues/syncronous_queue'
+require 'harness/queues/synchronous_queue'
 
 require 'harness/adapters/librato_adapter'
 require 'harness/adapters/memory_adapter'
 require 'harness/adapters/null_adapter'
-
-require 'harness/integration/action_controller'
-require 'harness/integration/action_view'
-require 'harness/integration/action_mailer'
-require 'harness/integration/active_support'
+require 'harness/adapters/statsd_adapter'
+require 'harness/adapters/stathat_adapter'
 
 require 'harness/railtie' if defined?(Rails)
 

data/lib/harness/adapters/librato_adapter.rb

@@ -12,7 +12,7 @@ module Harness
       @config ||= Config.new
     end
 
-    def self.log_gauge(gauge)
+    def log_gauge(gauge)
       raise Harness::LoggingError if gauge.id.length > 63
 
       post({:gauges => [{
@@ -25,7 +25,7 @@ module Harness
       }]})
     end
 
-    def self.log_counter(counter)
+    def log_counter(counter)
       raise Harness::LoggingError if counter.id.length > 63
 
       post({:counters => [{
@@ -39,7 +39,7 @@ module Harness
     end
 
     private
-    def self.post(params)
+    def post(params)
       unless config.email && config.token
         raise "Adapter not configured. Ensure email and token are set."
       end
@@ -68,7 +68,11 @@ module Harness
       true
     end
 
-    def self.sanitize(name)
+    def config
+      self.class.config
+    end
+
+    def sanitize(name)
       if Harness.config.namespace
         key = "#{name}.#{Harness.config.namespace}"
       else

data/lib/harness/adapters/memory_adapter.rb

@@ -8,12 +8,20 @@ module Harness
       @counters ||= []
     end
 
-    def self.log_gauge(gauge)
+    def log_gauge(gauge)
       gauges << gauge
     end
 
-    def self.log_counter(counter)
+    def log_counter(counter)
       counters << counter
     end
+
+    def counters
+      self.class.counters
+    end
+
+    def gauges
+      self.class.gauges
+    end
   end
 end

data/lib/harness/adapters/null_adapter.rb

@@ -1,10 +1,10 @@
 module Harness
   class NullAdapter
-    def self.log_gauge(gauge)
+    def log_gauge(gauge)
 
     end
 
-    def self.log_counter(counter)
+    def log_counter(counter)
 
     end
   end

data/lib/harness/adapters/stathat_adapter.rb

@@ -0,0 +1,75 @@
+require 'uri'
+require 'net/http'
+
+module Harness
+  class StathatAdapter
+    class Config
+      attr_accessor :ezkey
+    end
+
+    def self.config
+      @config ||= Config.new
+    end
+
+    def log_gauge(gauge)
+      raise Harness::LoggingError if gauge.id.length > 255
+
+      post({
+        :stat => sanitize(gauge.id),
+        :value => gauge.value,
+      })
+    end
+
+    def log_counter(counter)
+      raise Harness::LoggingError if counter.id.length > 255
+
+      post({
+        :stat => sanitize(counter.id),
+        :count => counter.value,
+      })
+    end
+
+    private
+
+    def post(params)
+      unless config.ezkey
+        raise "Adapter not configured. Ensure ezkey is set."
+      end
+
+      uri = URI.parse('https://api.stathat.com/ez')
+
+      Net::HTTP.start(uri.host, uri.port, :use_ssl => uri.scheme == 'https') do |http|
+        request = Net::HTTP::Post.new uri.request_uri
+
+        request.set_form_data params.merge(:ezkey => config.ezkey)
+
+        response = http.request request
+
+        unless response.code.to_i == 200
+          text = %Q{
+          Server Said: #{response.body}
+          Sent: #{params.inspect}
+          }
+
+          raise Harness::LoggingError, text
+        end
+      end
+
+      true
+    end
+
+    def config
+      self.class.config
+    end
+
+    def sanitize(name)
+      if Harness.config.namespace
+        key = "#{name}.#{Harness.config.namespace}"
+      else
+        key = name
+      end
+
+      key.gsub('/', '.')
+    end
+  end
+end

data/lib/harness/adapters/statsd_adapter.rb

@@ -0,0 +1,50 @@
+require 'statsd-instrument'
+
+module Harness
+  class StatsdAdapter
+    class Config
+      delegate :host, :port, :default_sample_rate, :mode, :logger, :to => :backend
+      delegate :host=, :port=, :default_sample_rate=, :mode=, :logger=, :to => :backend
+
+      def backend=(value)
+        @backend = value
+      end
+
+      def backend
+        @backend ||= StatsD
+      end
+    end
+
+    def self.config
+      @config ||= Config.new
+    end
+
+    def log_gauge(gauge)
+      validate!
+      backend.gauge sanitize(gauge.id), gauge.value
+    end
+
+    def log_counter(counter)
+      validate!
+      backend.increment sanitize(counter.id), counter.value
+    end
+
+    private
+    def validate!
+      raise "Adapter not configured. Ensure host and port are set." unless config.host and config.port
+    end
+
+    def sanitize(name)
+      key = Harness.config.namespace ? "#{Harness.config.namespace}.#{name}" : name
+      key.gsub(%r{[^a-z0-9]}, '.')
+    end
+
+    def backend
+      config.backend
+    end
+
+    def config
+      self.class.config
+    end
+  end
+end

data/lib/harness/gauge.rb

@@ -15,7 +15,7 @@ module Harness
       end
 
       gauge.id ||= event.name
-      gauge.value = event.duration
+      gauge.value ||= event.duration
 
       gauge
     end

data/lib/harness/queues/delayed_job_queue.rb

@@ -0,0 +1,7 @@
+module Harness
+  class DelayedJobQueue
+    def push(measurement)
+      Harness::Job.new.delay(:queue => 'harness').log(measurement)
+    end
+  end
+end

data/lib/harness/queues/resque_queue.rb

@@ -18,7 +18,7 @@ module Harness
       end
     end
 
-    def self.push(measurement)
+    def push(measurement)
       if measurement.is_a? Gauge
         Resque.enqueue SendGauge, measurement.attributes
       elsif measurement.is_a? Counter

data/lib/harness/queues/sidekiq_queue.rb

@@ -20,7 +20,7 @@ module Harness
       end
     end
 
-    def self.push(measurement)
+    def push(measurement)
       if measurement.is_a? Gauge
         SendGauge.perform_async measurement.attributes
       elsif measurement.is_a? Counter

data/lib/harness/queues/{syncronous_queue.rb → synchronous_queue.rb}

@@ -1,6 +1,6 @@
 module Harness
-  class SyncronousQueue
-    def self.push(measurement)
+  class SynchronousQueue
+    def push(measurement)
       begin
         Harness::Job.new.log(measurement)
       rescue LoggingError => ex
@@ -9,5 +9,10 @@ module Harness
         logger.warn "[Harness] Could not post measurement! Enable debug logging to see full errors"
       end
     end
+
+    private
+    def logger
+      Harness.logger
+    end
   end
 end

data/lib/harness/railtie.rb

@@ -12,29 +12,26 @@ module Harness
     # Custom instrumentation can be turned on as follows
     # See files in lib/harness/integration for available integrations
     #
-    # config.harness.insturment.sidekiq = true
-    # config.harness.insturment.active_model_serializers = true
+    # config.harness.instrument.sidekiq = true
+    # config.harness.instrument.active_model_serializers = true
 
     rake_tasks do
       load "harness/tasks.rake"
     end
 
     initializer "harness.adapter" do |app|
-      case Rails.env
-      when 'development'
-        app.config.harness.adapter = :null
-      when 'test'
-        app.config.harness.adapter = :null
-      else
-        app.config.harness.adapter = :librato
-      end
+      app.config.harness.adapter ||= case Rails.env
+                                     when 'development' then :null
+                                     when 'test' then :null
+                                     else :librato
+                                     end
     end
 
     initializer "harness.logger" do |app|
       Harness.logger = Rails.logger
     end
 
-    initializer "harness.redis" do 
+    initializer "harness.redis" do
       if existing_url = ENV['REDISTOGO_URL'] || ENV['REDIS_URL']
         Harness.redis ||= Redis::Namespace.new('harness', :redis => Redis.connect(:url => existing_url))
       else
@@ -43,7 +40,7 @@ module Harness
     end
 
     initializer "harness.queue" do
-      Harness.config.queue = Harness::SyncronousQueue
+      Harness.config.queue = :synchronous
     end
 
     initializer "harness.queue.production" do |app|
@@ -55,6 +52,9 @@ module Harness
       elsif defined?(Sidekiq::Worker) && use_real_queue
         require 'harness/queues/sidekiq_queue'
         Harness.config.queue = :sidekiq
+      elsif defined?(Delayed::Worker) && use_real_queue
+        require 'harness/queues/delayed_job_queue'
+        Harness.config.queue = :delayed_job
       end
     end
 

data/lib/harness/version.rb

@@ -1,3 +1,3 @@
 module Harness
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/test/integration/integrations/active_support_test.rb

@@ -33,6 +33,7 @@ class ActiveSupportIntegration < IntegrationTest
 
   private
   def instrument(event)
+    require 'harness/integration/active_support'
     ActiveSupport::Notifications.instrument "#{event}.active_support" do |*args|
       # nada
     end

data/test/integration/queues/delayed_job_test.rb

@@ -0,0 +1,59 @@
+require 'test_helper'
+require 'harness/queues/delayed_job_queue'
+require 'fileutils'
+
+class DelayedJobTest < IntegrationTest
+  def setup
+    super
+    
+    tmp = File.expand_path('../../../tmp', __FILE__)
+    db  = File.join(tmp, 'db.sqlite3')
+
+    FileUtils.mkdir_p tmp
+    FileUtils.rm_f db
+
+    ActiveRecord::Base.establish_connection(
+      :adapter => "sqlite3",
+      :database  => db
+    )
+
+    Class.new(ActiveRecord::Migration) do
+      def self.up
+        suppress_messages do
+          create_table :delayed_jobs, :force => true do |table|
+            table.integer  :priority, :default => 0      # Allows some jobs to jump to the front of the queue
+            table.integer  :attempts, :default => 0      # Provides for retries, but still fail eventually.
+            table.text     :handler                      # YAML-encoded string of the object that will do work
+            table.text     :last_error                   # reason for last failure (See Note below)
+            table.datetime :run_at                       # When to run. Could be Time.zone.now for immediately, or sometime in the future.
+            table.datetime :locked_at                    # Set when a client is working on this object
+            table.datetime :failed_at                    # Set when all retries have failed (actually, by default, the record is deleted instead)
+            table.string   :locked_by                    # Who is working on this object (if locked)
+            table.string   :queue                        # The name of the queue this job is in
+            table.timestamps
+          end
+
+          add_index :delayed_jobs, [:priority, :run_at], :name => 'delayed_jobs_priority'
+        end
+      end
+    end.up
+
+    Delayed::Worker.delay_jobs = false
+
+    Harness.config.queue = :delayed_job
+  end
+
+  def test_a_gauge_is_logged
+    instrument "test-gauge", :gauge => true
+
+    assert_gauge_logged "test-gauge"
+  end
+
+  def test_a_counter_is_logged
+    instrument "test-counter", :counter => true
+
+    assert_counter_logged "test-counter"
+
+    assert_equal 1, counters.first.value
+  end
+end

data/test/integration/railtie_test.rb

@@ -19,4 +19,8 @@ class RailtieTest < MiniTest::Unit::TestCase
     assert app.config.harness.instrument.action_view
     refute app.config.harness.instrument.active_support
   end
+
+  def test_configures_queue
+    assert_kind_of Harness::SynchronousQueue, app.config.harness.queue
+  end
 end

data/test/test_helper.rb

@@ -5,6 +5,8 @@ SimpleCov.start
 
 require 'resque'
 require 'sidekiq'
+require 'delayed_job_active_record'
+require 'sqlite3'
 
 require 'harness'
 
@@ -23,7 +25,7 @@ Harness.redis = Redis::Namespace.new 'harness-test', :redis => Redis.connect(:ho
 class IntegrationTest < MiniTest::Unit::TestCase
   def setup
     Harness.config.adapter = :memory
-    Harness.config.queue = :syncronous
+    Harness.config.queue = :synchronous
 
     gauges.clear ; counters.clear
     redis.flushall
@@ -58,7 +60,7 @@ class IntegrationTest < MiniTest::Unit::TestCase
   end
 
   def instrument(name, data = {})
-    ActiveSupport::Notifications.instrument name, data do 
+    ActiveSupport::Notifications.instrument name, data do
       # nothing
     end
   end

data/test/unit/adapters/librato_adapter_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class LibratoAdapterTest < MiniTest::Unit::TestCase
   def setup
-    @adapter = Harness::LibratoAdapter
+    @adapter = Harness::LibratoAdapter.new
 
     @gauge = Harness::Gauge.new
     @gauge.id = "fake-gauge"
@@ -66,7 +66,7 @@ class LibratoAdapterTest < MiniTest::Unit::TestCase
     assert_requested expected_request
   end
 
-  def test_logging_gague_raises_an_exception
+  def test_logging_gauge_raises_an_exception
     stub_request(:post, %r{metrics}).to_return(:status => 500, :body => "message")
 
     assert_raises Harness::LoggingError do

data/test/unit/adapters/memory_adapter_test.rb

@@ -5,7 +5,7 @@ class MemoryAdapterTest < MiniTest::Unit::TestCase
     Harness::MemoryAdapter.counters.clear
     Harness::MemoryAdapter.gauges.clear
 
-    @adapter = Harness::MemoryAdapter
+    @adapter = Harness::MemoryAdapter.new
   end
 
   def test_log_gauge_adds_to_gauges

data/test/unit/adapters/stathat_adapter_test.rb

@@ -0,0 +1,143 @@
+require 'test_helper'
+
+class StathatAdapterTest < MiniTest::Unit::TestCase
+  def setup
+    @adapter = Harness::StathatAdapter.new
+
+    @gauge = Harness::Gauge.new
+    @gauge.id = "fake-gauge"
+    @gauge.name = "Fake Gauge"
+    @gauge.source = "minitest"
+    @gauge.time = Time.now
+    @gauge.value = "55"
+
+    @counter = Harness::Counter.new
+    @counter.id = "fake-counter"
+    @counter.name = "Fake Counter"
+    @counter.source = "minitest"
+    @counter.time = Time.now
+    @counter.value = "55"
+    @counter.units = :bytes
+
+    Harness::StathatAdapter.config.ezkey = token
+    Harness.config.namespace = nil
+  end
+
+  def test_gauge_is_logged
+    args = {
+      :stat => @gauge.id,
+      :ezkey => token,
+      :value => @gauge.value,
+    }
+
+    expected_request = stub_request(:post, "https://api.stathat.com/ez").
+      with(:body => args, :headers => {'Content-Type'=>'application/x-www-form-urlencoded'}).
+      to_return(:status => 200)
+
+    assert @adapter.log_gauge(@gauge)
+    assert_requested expected_request
+  end
+
+  def test_gauge_is_logged_with_namespace
+    Harness.config.namespace = :foo
+
+    args = {
+      :stat => "#{@gauge.id}.foo",
+      :ezkey => token,
+      :value => @gauge.value,
+    }
+
+    expected_request = stub_request(:post, "https://api.stathat.com/ez").
+      with(:body => args, :headers => {'Content-Type'=>'application/x-www-form-urlencoded'}).
+      to_return(:status => 200)
+
+    assert @adapter.log_gauge(@gauge)
+    assert_requested expected_request
+  end
+
+  def test_logging_gauge_raises_an_exception
+    stub_request(:post, %r{stathat}).to_return(:status => 500, :body => "message")
+
+    assert_raises Harness::LoggingError do
+      @adapter.log_gauge @gauge
+    end
+  end
+
+  def test_logging_gauge_raises_an_exception_when_id_is_too_long
+    @gauge.id = "f" * 256
+
+    assert_raises Harness::LoggingError do
+      @adapter.log_gauge @gauge
+    end
+  end
+
+  def test_logging_gauge_raises_an_exception_when_not_configured
+    Harness::StathatAdapter.config.ezkey = nil
+
+    assert_raises RuntimeError do
+      @adapter.log_gauge @gauge
+    end
+  end
+
+  def test_counter_is_logged
+     args = {
+      :stat => @counter.id,
+      :ezkey => token,
+      :count => @counter.value,
+    }
+
+    expected_request = stub_request(:post, "https://api.stathat.com/ez").
+      with(:body => args, :headers => {'Content-Type'=>'application/x-www-form-urlencoded'}).
+      to_return(:status => 200)
+
+    assert @adapter.log_counter(@counter)
+    assert_requested expected_request
+  end
+
+  def test_counter_is_logged_with_namespace
+    Harness.config.namespace = :foo
+
+     args = {
+      :stat => "#{@counter.id}.foo",
+      :ezkey => token,
+      :count => @counter.value,
+    }
+
+    expected_request = stub_request(:post, "https://api.stathat.com/ez").
+      with(:body => args, :headers => {'Content-Type'=>'application/x-www-form-urlencoded'}).
+      to_return(:status => 200)
+
+    assert @adapter.log_counter(@counter)
+    assert_requested expected_request
+  end
+
+  def test_logging_counter_raises_an_exception
+    stub_request(:post, %r{stathat}).to_return(:status => 500, :body => "message")
+
+    assert_raises Harness::LoggingError do
+      @adapter.log_counter @counter
+    end
+  end
+
+  def test_logging_counter_raises_an_exception_when_not_configured
+    Harness::StathatAdapter.config.ezkey = nil
+
+    assert_raises RuntimeError do
+      @adapter.log_counter @counter
+    end
+  end
+
+  def test_logging_counter_raises_an_exception_when_id_is_too_long
+    @counter.id = "f" * 256
+
+    assert_raises Harness::LoggingError do
+      @adapter.log_counter @counter
+    end
+  end
+
+  private
+
+  def token
+    'example@example.com'
+  end
+end

data/test/unit/adapters/statsd_adapter_test.rb

@@ -0,0 +1,73 @@
+require 'test_helper'
+require 'ostruct'
+
+class StatsdAdapterTest < MiniTest::Unit::TestCase
+  def setup
+    @adapter = Harness::StatsdAdapter.new
+
+    @gauge = Harness::Gauge.new
+    @gauge.id = "fake-gauge"
+    @gauge.name = "Fake Gauge"
+    @gauge.source = "minitest"
+    @gauge.time = Time.now
+    @gauge.value = 55
+
+    @counter = Harness::Counter.new
+    @counter.id = "fake-counter"
+    @counter.name = "Fake Counter"
+    @counter.source = "minitest"
+    @counter.time = Time.now
+    @counter.value = 1337
+    @counter.units = :bytes
+    Harness.config.namespace = nil
+  end
+
+  def test_gauge_is_logged
+    mock_backend = MiniTest::Mock.new
+    mock_backend.expect :host, 'foo'
+    mock_backend.expect :port, 'bar'
+
+    Harness::StatsdAdapter.config.backend = mock_backend
+    mock_backend.expect :gauge, true, [String, 55] 
+
+    assert @adapter.log_gauge(@gauge)
+    assert mock_backend.verify
+  end
+
+  def test_logging_gauge_raises_an_exception_when_not_configured
+    mock_backend = MiniTest::Mock.new
+    mock_backend.expect :host, nil
+    mock_backend.expect :port, nil
+
+    Harness::StatsdAdapter.config.backend = mock_backend
+    mock_backend.expect :gauge, true, [String, 55] 
+
+    assert_raises RuntimeError do
+      @adapter.log_gauge @gauge
+    end
+  end
+
+  def test_counter_is_logged
+    mock_backend = MiniTest::Mock.new
+    mock_backend.expect :host, 'foo'
+    mock_backend.expect :port, 'bar'
+
+    Harness::StatsdAdapter.config.backend = mock_backend
+    mock_backend.expect :increment, true, [String, 1337]
+
+    assert @adapter.log_counter(@counter)
+    assert mock_backend.verify
+  end
+
+  def test_logging_counter_raises_an_exception_when_not_configured
+    mock_backend = MiniTest::Mock.new
+    mock_backend.expect :host, nil
+    mock_backend.expect :port, nil
+
+    Harness::StatsdAdapter.config.backend = mock_backend
+
+    assert_raises RuntimeError do
+      @adapter.log_counter @counter
+    end
+  end
+end

data/test/unit/gauge_test.rb

@@ -65,6 +65,16 @@ class GaugeTest < MiniTest::Unit::TestCase
     assert_equal 'foo', gauge.id
   end
 
+  def test_sets_value_from_payload_if_number
+    base = Time.now
+
+    event = ActiveSupport::Notifications::Event.new "name", base - 1, Time.now, nil, :gauge => {value: 42}
+
+    gauge = Harness::Gauge.from_event event
+
+    assert_equal 42, gauge.value
+  end
+
   def test_initializes_time_if_not_set
     gauge = Harness::Gauge.new
 

data/test/unit/harness_test.rb

@@ -4,25 +4,25 @@ class HarnessModuleTest < MiniTest::Unit::TestCase
   def test_can_set_the_adapter_with_a_symbol
     Harness.config.adapter = :memory
 
-    assert_equal Harness::MemoryAdapter, Harness.config.adapter
+    assert_kind_of Harness::MemoryAdapter, Harness.config.adapter
   end
 
-  def test_can_set_the_adapter_with_a_class
-    Harness.config.adapter = Harness::MemoryAdapter
+  def test_can_set_the_adapter_with_an_adapter_instance
+    Harness.config.adapter = Harness::MemoryAdapter.new
 
-    assert_equal Harness::MemoryAdapter, Harness.config.adapter
+    assert_kind_of Harness::MemoryAdapter, Harness.config.adapter
   end
 
   def test_can_set_the_queue_with_a_symbol
-    Harness.config.queue = :syncronous
+    Harness.config.queue = :synchronous
 
-    assert_equal Harness::SyncronousQueue, Harness.config.queue
+    assert_kind_of Harness::SynchronousQueue, Harness.config.queue
   end
 
-  def test_can_set_the_queue_with_a_class
-    Harness.config.adapter = Harness::SyncronousQueue
+  def test_can_set_the_queue_with_a_queue_instance
+    Harness.config.queue = Harness::SynchronousQueue.new
 
-    assert_equal Harness::SyncronousQueue, Harness.config.queue
+    assert_kind_of Harness::SynchronousQueue, Harness.config.queue
   end
 
   def test_uses_method_missing_to_configure_adapters

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: harness
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-05 00:00:00.000000000 Z
+date: 2012-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70133152109020 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,15 @@ dependencies:
         version: '3'
   type: :runtime
   prerelease: false
-  version_requirements: *70133152109020
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70133152107200 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70133152107200
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: redis-namespace
-  requirement: &70133152104740 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70133152104740
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70133152152020 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +69,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133152152020
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70133152149760 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +85,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133152149760
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: resque
-  requirement: &70133152148660 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +101,31 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133152148660
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sidekiq
-  requirement: &70133152148020 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: delayed_job_active_record
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +133,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133152148020
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
-  requirement: &70133152146920 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +149,63 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133152146920
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70133152145560 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: statsd-instrument
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,7 +213,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70133152145560
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: ''
 email:
 - me@broadcastingadam.com
@@ -127,6 +236,8 @@ files:
 - lib/harness/adapters/librato_adapter.rb
 - lib/harness/adapters/memory_adapter.rb
 - lib/harness/adapters/null_adapter.rb
+- lib/harness/adapters/stathat_adapter.rb
+- lib/harness/adapters/statsd_adapter.rb
 - lib/harness/consumer.rb
 - lib/harness/counter.rb
 - lib/harness/gauge.rb
@@ -140,9 +251,10 @@ files:
 - lib/harness/job.rb
 - lib/harness/measurement.rb
 - lib/harness/meter.rb
+- lib/harness/queues/delayed_job_queue.rb
 - lib/harness/queues/resque_queue.rb
 - lib/harness/queues/sidekiq_queue.rb
-- lib/harness/queues/syncronous_queue.rb
+- lib/harness/queues/synchronous_queue.rb
 - lib/harness/railtie.rb
 - lib/harness/tasks.rake
 - lib/harness/version.rb
@@ -156,17 +268,19 @@ files:
 - test/integration/integrations/sidekiq_test.rb
 - test/integration/logging_test.rb
 - test/integration/meter_test.rb
+- test/integration/queues/delayed_job_test.rb
 - test/integration/queues/resque_test.rb
 - test/integration/queues/sidekiq_test.rb
 - test/integration/railtie_test.rb
 - test/test_helper.rb
 - test/unit/adapters/librato_adapter_test.rb
 - test/unit/adapters/memory_adapter_test.rb
+- test/unit/adapters/stathat_adapter_test.rb
+- test/unit/adapters/statsd_adapter_test.rb
 - test/unit/counter_test.rb
 - test/unit/gauge_test.rb
 - test/unit/harness_test.rb
 - test/unit/measurement_test.rb
-- test/unit/meter_test.rb
 homepage: ''
 licenses: []
 post_install_message: 
@@ -179,15 +293,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -4565454551887677115
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -4565454551887677115
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: ''
@@ -202,14 +322,16 @@ test_files:
 - test/integration/integrations/sidekiq_test.rb
 - test/integration/logging_test.rb
 - test/integration/meter_test.rb
+- test/integration/queues/delayed_job_test.rb
 - test/integration/queues/resque_test.rb
 - test/integration/queues/sidekiq_test.rb
 - test/integration/railtie_test.rb
 - test/test_helper.rb
 - test/unit/adapters/librato_adapter_test.rb
 - test/unit/adapters/memory_adapter_test.rb
+- test/unit/adapters/stathat_adapter_test.rb
+- test/unit/adapters/statsd_adapter_test.rb
 - test/unit/counter_test.rb
 - test/unit/gauge_test.rb
 - test/unit/harness_test.rb
 - test/unit/measurement_test.rb
-- test/unit/meter_test.rb