happo 2.5.2 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a09a6eec66779447b6ca4ab2bae97639a1b0580
-  data.tar.gz: fc22584f040c324fc81c00ae3f50eacd78ad7bbb
+  metadata.gz: f9a8cddb3cdd182db6d8d96d32b9a81c5802f449
+  data.tar.gz: 6d9726df428ef2da13115dbfedbf739d27e0875d
 SHA512:
-  metadata.gz: 4b20a65e01766a900074ef668295ef21d807dbcbf731230335ee304cd4628647d324dca7bfcf63cb174fa04dd2ba4f214e74a25a9f01f5aa1ba94c745824c09a
-  data.tar.gz: 2158fbc4558027fa4e5a9f4af41d1361c3b9ccf098e151aa6f56cca23f8c154c638eaf557a53051ff71d32719eb68970b2e8abaf24f6ee76d1d527bb570f58bd
+  metadata.gz: f1b0f14bc41131d94b70ae1efc96bcde6e717958634dcb72cdd73438cc503b0a2aeadc1b7336589df246c1765c6c589ae1d313c4cba96c04b29d8d13ffb520c5
+  data.tar.gz: af494cf1cc7b4d18cf2aae3ab6941157f35a2cc474d9e7e1e3ae3c5661884cb54d838baf26a1939e02b869f4add0a1f6b7bb0739415cb1f8fb71d2b35b1fb90d

data/lib/happo/public/happo-runner.js

@@ -162,8 +162,27 @@ window.happo = {
     }
   },
 
+  // Scrollbars inside of elements may cause spurious visual diffs. To avoid
+  // this issue, we can hide them automatically by styling the overflow to be
+  // hidden.
+  removeScrollbars: function removeScrollbars(node) {
+    if (
+      node.scrollHeight !== node.clientHeight
+      || node.scrollWidth !== node.clientWidth
+    ) {
+      // We style this via node.style.cssText so that we can override any styles
+      // that might already be `!important`.
+      // eslint-disable-next-line no-param-reassign
+      node.style.cssText += 'overflow: hidden !important';
+    }
+  },
+
   // This function takes a node and a box object that we will mutate.
   getFullRectRecursive: function getFullRectRecursive(node, box) {
+    // Since we are already traversing through every node, let's piggyback on
+    // that work and remove scrollbars to prevent spurious diffs.
+    this.removeScrollbars(node);
+
     var rect = node.getBoundingClientRect();
 
     /* eslint-disable no-param-reassign */
@@ -183,6 +202,8 @@ window.happo = {
   // absolutely positioned elements. It is important that this is fast, since we
   // may be iterating over a high number of nodes.
   getFullRect: function getFullRect(node) {
+    this.removeScrollbars(node);
+
     var rect = node.getBoundingClientRect();
 
     // Set up the initial object that we will mutate in our recursive function.

data/lib/happo/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module Happo
-  VERSION = '2.5.2'
+  VERSION = '2.6.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: happo
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.6.0
 platform: ruby
 authors:
 - Henric Trotzig
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-01 00:00:00.000000000 Z
+date: 2016-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chunky_png