happo 2.0.7 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43b95ce6006d5d5246bca90fe6fafc4069d8455b
-  data.tar.gz: ccf5377c3bdde8d7c5d26f62cb20ed8528003856
+  metadata.gz: 6ab62af6f8c5cba90963fcca9ffa73576b2f161f
+  data.tar.gz: c12b3dcee9e5f6c0935333494214b693faa09258
 SHA512:
-  metadata.gz: cd127962736543218ba0358f0d237f45e72847432301711f48390aa7a8b12327c9bb8f622b4f2ca296de4b25cbb2f8eec62050eec659909fac67b896cdf4c190
-  data.tar.gz: 5611ae5b5f23aab6fa0ae94e729641b4a316684acd209384830aebef1d1452945c72012dd2bd64d360bd27228b4d3d43367092315e5dba93183541ab73e8fa84
+  metadata.gz: 743c15567f974688f373a3e1d114509013c1f357b803b00273cfb39691462e6d5a5b072ceb2f87c138fcec4a0b408efe0e4eba674587c69e4874aa066e2f07aa
+  data.tar.gz: 56d4de2b0e53e73ed4cd85823d6641be136537b354feb9edf500be578289d9a718e0d493f4c5f4fe76fc7d64c3a4ff4ebaae0811e25b43e7a36ebb40f4c3787f

data/lib/happo/public/happo-runner.js

@@ -153,6 +153,50 @@ window.happo = {
     }
   },
 
+  // This function takes a node and a box object that we will mutate.
+  getFullRectRecursive: function(node, box) {
+    var rect = node.getBoundingClientRect();
+
+    box.bottom = Math.max(box.bottom, rect.bottom);
+    box.left = Math.min(box.left, rect.left);
+    box.right = Math.max(box.right, rect.right);
+    box.top = Math.min(box.top, rect.top);
+
+    for (var i = 0; i < node.children.length; i++) {
+      getFullRectRecursive(node.children[i], box);
+    }
+  },
+
+  // This function gets the full size of the given node, including all
+  // descendent nodes. This allows us to ensure that the screenshot includes
+  // absolutely positioned elements. It is important that this is fast, since we
+  // may be iterating over a high number of nodes.
+  getFullRect: function(node) {
+    var rect = node.getBoundingClientRect();
+
+    // Set up the initial object that we will mutate in our recursive function.
+    var box = {
+      bottom: rect.bottom,
+      left: rect.left,
+      right: rect.right,
+      top: rect.top,
+    };
+
+    // If there are any children, we want to iterate over them recursively,
+    // mutating our box object along the way to expand to include all descendent
+    // nodes.
+    for (var i = 0; i < node.children.length; i++) {
+      getFullRectRecursive(node.children[i], box);
+    }
+
+    // Do width and height calculations at the end, to avoid having to do them
+    // for every node.
+    box.width =  box.right - box.left;
+    box.height =  box.bottom - box.top;
+
+    return box;
+  },
+
   processElem: function(currentExample, elem) {
     try {
       this.currentRenderedElement = elem;
@@ -166,14 +210,9 @@ window.happo = {
           left: 0,
         };
       } else {
-        // We use elem.getBoundingClientRect() instead of offsetTop and its ilk
-        // because elem.getBoundingClientRect() is more accurate and it also
-        // takes CSS transformations and other things of that nature into
-        // account whereas offsetTop and company do not.
-        //
         // Note that this method returns floats, so we need to round those off
         // to integers before returning.
-        rect = elem.getBoundingClientRect();
+        rect = this.getFullRect(elem);
       }
 
       return {

data/lib/happo/version.rb

@@ -1,4 +1,4 @@
 # Defines the gem version.
 module Happo
-  VERSION = '2.0.7'
+  VERSION = '2.1.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: happo
 version: !ruby/object:Gem::Version
-  version: 2.0.7
+  version: 2.1.0
 platform: ruby
 authors:
 - Henric Trotzig
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-05 00:00:00.000000000 Z
+date: 2016-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chunky_png