handlebars_assets 0.8.1 → 0.23.9

data/test/handlebars_assets/compiling_test.rb

@@ -0,0 +1,30 @@
+require 'test_helper'
+
+module HandlebarsAssets
+  class CompilingTest < ::MiniTest::Test
+
+    def teardown
+      HandlebarsAssets::Config.reset!
+      HandlebarsAssets::Handlebars.reset!
+    end
+
+    def test_custom_handlebars
+      source = "This is {{handlebars}}"
+
+      HandlebarsAssets::Config.compiler_path = File.expand_path '../../edge', __FILE__
+
+      compiled = Handlebars.precompile(source, HandlebarsAssets::Config.options)
+      assert_match /PRECOMPILE CALLED/, compiled
+    end
+
+    def test_patching_handlebars
+      source = "This is {{nested.handlebars}}"
+
+      HandlebarsAssets::Config.patch_path = File.expand_path '../../patch', __FILE__
+      HandlebarsAssets::Config.patch_files = ['patch.js']
+
+      compiled = Handlebars.precompile(source, HandlebarsAssets::Config.options)
+      assert_match /CALLED PATCH/, compiled
+    end
+  end
+end

data/test/handlebars_assets/hamlbars_test.rb

@@ -1,12 +1,12 @@
 require 'test_helper'
 
 module HandlebarsAssets
-  class HamlbarsTest < Test::Unit::TestCase
+  class HamlbarsTest < ::Minitest::Test
     include SprocketsScope
     include CompilerSupport
 
     def compile_haml(source)
-      Haml::Engine.new(source, HandlebarsAssets::Config.haml_options).render
+      (Haml::Engine.new(source, HandlebarsAssets::Config.haml_options).render).chomp
     end
 
     def teardown
@@ -20,7 +20,7 @@ module HandlebarsAssets
       scope = make_scope root, file
       source = "%p This is {{handlebars}}"
 
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
+      template = HandlebarsAssets::HandlebarsTemplate.new(scope.pathname.to_s) { source }
 
       assert_equal hbs_compiled('test_render', compile_haml(source)), template.render(scope, {})
     end

data/test/handlebars_assets/handlebars_processor_test.rb

@@ -0,0 +1,17 @@
+require 'test_helper'
+require_relative 'shared/adapter_tests'
+
+module HandlebarsAssets
+  class HandlebarsProcessorTest < Minitest::Test
+    include AdapterTests
+
+    def teardown
+      HandlebarsAssets::Config.reset!
+      HandlebarsAssets::Handlebars.reset!
+    end
+
+    def render_it(scope, source)
+      HandlebarsAssets::HandlebarsProcessor.call(filename: scope.pathname.to_s, data: source)
+    end
+  end
+end

data/test/handlebars_assets/shared/adapter_tests.rb

@@ -0,0 +1,199 @@
+require 'test_helper'
+require 'haml'
+require 'slim'
+
+module AdapterTests
+  include CompilerSupport
+  include SprocketsScope
+
+  def compile_haml(source)
+    ::Haml::Engine.new(source, HandlebarsAssets::Config.haml_options).render
+  end
+
+  def compile_slim(source)
+    ::Slim::Template.new(HandlebarsAssets::Config.slim_options) { source }.render
+  end
+
+  def test_render
+    root = '/myapp/app/assets/templates'
+    file = 'test_render.hbs'
+    scope = make_scope root, file
+    source = "This is {{handlebars}}"
+
+    assert_equal hbs_compiled('test_render', source), render_it(scope, source)
+  end
+
+  # Sprockets does not add nested root paths (i.e.
+  # app/assets/javascripts/templates is rooted at app/assets/javascripts)
+  def test_template_misnaming
+    root = '/myapp/app/assets/javascripts'
+    file = 'templates/test_template_misnaming.hbs'
+    scope = make_scope root, file
+    source = "This is {{handlebars}}"
+
+    assert_equal hbs_compiled('test_template_misnaming', source), render_it(scope, source)
+  end
+
+  def test_path_prefix
+    root = '/myapp/app/assets/javascripts'
+    file = 'app/templates/test_path_prefix.hbs'
+    scope = make_scope root, file
+    source = "This is {{handlebars}}"
+
+    HandlebarsAssets::Config.path_prefix = 'app/templates'
+
+    assert_equal hbs_compiled('test_path_prefix', source), render_it(scope, source)
+  end
+
+  def test_underscore_partials
+    root = '/myapp/app/assets/javascripts'
+    file1 = 'app/templates/_test_underscore.hbs'
+    scope1 = make_scope root, file1
+    file2 = 'app/templates/some/thing/_test_underscore.hbs'
+    scope2 = make_scope root, file2
+    source = "This is {{handlebars}}"
+
+    HandlebarsAssets::Config.path_prefix = 'app/templates'
+
+    assert_equal hbs_compiled_partial('_test_underscore', source), render_it(scope1, source)
+
+    assert_equal hbs_compiled_partial('some/thing/_test_underscore', source), render_it(scope2, source)
+  end
+
+  def test_chomped_underscore_partials
+    assert_equal HandlebarsAssets::Config.chomp_underscore_for_partials?, false
+
+    HandlebarsAssets::Config.chomp_underscore_for_partials = true
+    assert_equal HandlebarsAssets::Config.chomp_underscore_for_partials?, true
+
+    root = '/myapp/app/assets/javascripts'
+    file1 = 'app/templates/_test_underscore.hbs'
+    scope1 = make_scope root, file1
+    file2 = 'app/templates/some/thing/_test_underscore.hbs'
+    scope2 = make_scope root, file2
+    source = "This is {{handlebars}}"
+
+    HandlebarsAssets::Config.path_prefix = 'app/templates'
+
+    assert_equal hbs_compiled_partial('test_underscore', source), render_it(scope1, source)
+
+    assert_equal hbs_compiled_partial('some/thing/test_underscore', source), render_it(scope2, source)
+
+  end
+
+  def test_without_known_helpers_opt
+    root = '/myapp/app/assets/templates'
+    file = 'test_without_known.hbs'
+    scope = make_scope root, file
+    source = "{{#with author}}By {{first_name}} {{last_name}}{{/with}}"
+
+    assert_equal hbs_compiled('test_without_known', source), render_it(scope, source)
+  end
+
+  def test_known_helpers_opt
+    root = '/myapp/app/assets/templates'
+    file = 'test_known.hbs'
+    scope = make_scope root, file
+    source = "{{#with author}}By {{first_name}} {{last_name}}{{/with}}"
+
+    HandlebarsAssets::Config.known_helpers_only = true
+
+    assert_equal hbs_compiled('test_known', source), render_it(scope, source)
+  end
+
+  def test_with_custom_helpers
+    root = '/myapp/app/assets/templates'
+    file = 'test_custom_helper.hbs'
+    scope = make_scope root, file
+    source = "{{#custom author}}By {{first_name}} {{last_name}}{{/custom}}"
+
+    assert_equal hbs_compiled('test_custom_helper', source), render_it(scope, source)
+  end
+
+  def test_with_custom_known_helpers
+    root = '/myapp/app/assets/templates'
+    file = 'test_custom_known_helper.hbs'
+    scope = make_scope root, file
+    source = "{{#custom author}}By {{first_name}} {{last_name}}{{/custom}}"
+
+    HandlebarsAssets::Config.known_helpers_only = true
+    HandlebarsAssets::Config.known_helpers = %w(custom)
+
+    assert_equal hbs_compiled('test_custom_known_helper', source), render_it(scope, source)
+  end
+
+  def test_template_namespace
+    root = '/myapp/app/assets/javascripts/templates'
+    file = 'test_template_namespace.hbs'
+    scope = make_scope root, file
+    source = "This is {{handlebars}}"
+
+    HandlebarsAssets::Config.template_namespace = 'JST'
+
+    assert_equal hbs_compiled('test_template_namespace', source), render_it(scope, source)
+  end
+
+  def test_ember_render
+    root = '/myapp/app/assets/templates'
+    file = 'test_render.hbs'
+    scope = make_scope root, file
+    source = "This is {{handlebars}}"
+
+    HandlebarsAssets::Config.ember = true
+    HandlebarsAssets::Config.multiple_frameworks = false
+
+    expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("This is {{handlebars}}");};
+    assert_equal expected_compiled, render_it(scope, source)
+  end
+
+  def test_multiple_frameworks_with_ember_render
+    root = '/myapp/app/assets/templates'
+    non_ember = 'test_render.hbs'
+    non_ember_but_with_ember = 'test_member.hbs'
+    ember_ext_no_hbs = 'test_render.ember'
+    ember_ext = 'test_render.ember.hbs'
+    ember_with_haml = 'test_render.ember.hamlbars'
+    ember_with_slim = 'test_render.ember.slimbars'
+    ember_ext_with_erb = 'test_render.ember.hbs.erb'
+
+    HandlebarsAssets::Config.ember = true
+    HandlebarsAssets::Config.multiple_frameworks = true
+
+    # File without ember extension should compile to default namespace
+    scope = make_scope root, non_ember
+    source = "This is {{handlebars}}"
+    assert_equal hbs_compiled('test_render', source), render_it(scope, source)
+
+    # File without ember extension but with ember in it should compile to default namespace
+    scope = make_scope root, non_ember_but_with_ember
+    source = "This is {{handlebars}}"
+    assert_equal hbs_compiled('test_member', source), render_it(scope, source)
+
+    # File with ember extension should compile to ember specific namespace
+    expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("This is {{handlebars}}");};
+    scope = make_scope root, ember_ext_no_hbs
+    assert_equal expected_compiled, render_it(scope, source)
+
+    # File with ember and erb extension should compile to ember specific namespace
+    expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("This is {{handlebars}}");};
+    scope = make_scope root, ember_ext_with_erb
+    assert_equal expected_compiled, render_it(scope, source)
+
+    # File with ember.hbs extension should compile to ember specific namespace
+    expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("This is {{handlebars}}");};
+    scope = make_scope root, ember_ext
+    assert_equal expected_compiled, render_it(scope, source)
+
+    # File with ember.hamlbars extension should compile to ember specific namespace
+    expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("<p>This is {{handlebars}}</p>");};
+    scope = make_scope root, ember_with_haml
+    source = "%p This is {{handlebars}}"
+    assert_equal expected_compiled, render_it(scope, source)
+
+    # File with ember.slimbars extension should compile to ember specific namespace
+    expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("<p>This is {{handlebars}}</p>");};
+    source = "p This is {{handlebars}}"
+    scope = make_scope root, ember_with_slim
+    assert_equal expected_compiled, render_it(scope, source)
+  end
+end

data/test/handlebars_assets/slimbars_test.rb

@@ -0,0 +1,28 @@
+require 'test_helper'
+
+module HandlebarsAssets
+  class SlimbarsTest < ::Minitest::Test
+    include SprocketsScope
+    include CompilerSupport
+
+    def compile_slim(source)
+      Slim::Template.new(HandlebarsAssets::Config.slim_options) { source }.render
+    end
+
+    def teardown
+      HandlebarsAssets::Config.reset!
+      HandlebarsAssets::Handlebars.reset!
+    end
+
+    def test_render_slim
+      root = '/myapp/app/assets/templates'
+      file = 'test_render.slimbars'
+      scope = make_scope root, file
+      source = "p This is {{handlebars}}"
+
+      template = HandlebarsAssets::HandlebarsTemplate.new(scope.pathname.to_s) { source }
+
+      assert_equal hbs_compiled('test_render', compile_slim(source)), template.render(scope, {})
+    end
+  end
+end

data/test/handlebars_assets/tilt_handlebars_test.rb

@@ -1,144 +1,18 @@
 require 'test_helper'
+require_relative 'shared/adapter_tests'
 
 module HandlebarsAssets
-  class TiltHandlebarsTest < Test::Unit::TestCase
-    include CompilerSupport
-    include SprocketsScope
+  class HandlebarsTemplateTest < Minitest::Test
+    include AdapterTests
 
     def teardown
       HandlebarsAssets::Config.reset!
       HandlebarsAssets::Handlebars.reset!
     end
 
-    def test_render
-      root = '/myapp/app/assets/templates'
-      file = 'test_render.hbs'
-      scope = make_scope root, file
-      source = "This is {{handlebars}}"
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_render', source), template.render(scope, {})
-    end
-
-    # Sprockets does not add nested root paths (i.e.
-    # app/assets/javascripts/templates is rooted at app/assets/javascripts)
-    def test_template_misnaming
-      root = '/myapp/app/assets/javascripts'
-      file = 'templates/test_template_misnaming.hbs'
-      scope = make_scope root, file
-      source = "This is {{handlebars}}"
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_template_misnaming', source), template.render(scope, {})
-    end
-
-    def test_path_prefix
-      root = '/myapp/app/assets/javascripts'
-      file = 'app/templates/test_path_prefix.hbs'
-      scope = make_scope root, file
-      source = "This is {{handlebars}}"
-
-      HandlebarsAssets::Config.path_prefix = 'app/templates'
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_path_prefix', source), template.render(scope, {})
-    end
-
-    def test_underscore_partials
-      root = '/myapp/app/assets/javascripts'
-      file1 = 'app/templates/_test_underscore.hbs'
-      scope1 = make_scope root, file1
-      file2 = 'app/templates/some/thing/_test_underscore.hbs'
-      scope2 = make_scope root, file2
-      source = "This is {{handlebars}}"
-
-      HandlebarsAssets::Config.path_prefix = 'app/templates'
-
-      template1 = HandlebarsAssets::TiltHandlebars.new(scope1.pathname.to_s) { source }
-
-      assert_equal hbs_compiled_partial('_test_underscore', source), template1.render(scope1, {})
-
-      template2 = HandlebarsAssets::TiltHandlebars.new(scope2.pathname.to_s) { source }
-
-      assert_equal hbs_compiled_partial('_some_thing_test_underscore', source), template2.render(scope2, {})
-    end
-
-    def test_without_known_helpers_opt
-      root = '/myapp/app/assets/templates'
-      file = 'test_without_known.hbs'
-      scope = make_scope root, file
-      source = "{{#with author}}By {{first_name}} {{last_name}}{{/with}}"
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_without_known', source), template.render(scope, {})
-    end
-
-    def test_known_helpers_opt
-      root = '/myapp/app/assets/templates'
-      file = 'test_known.hbs'
-      scope = make_scope root, file
-      source = "{{#with author}}By {{first_name}} {{last_name}}{{/with}}"
-
-      HandlebarsAssets::Config.known_helpers_only = true
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_known', source), template.render(scope, {})
-    end
-
-    def test_with_custom_helpers
-      root = '/myapp/app/assets/templates'
-      file = 'test_custom_helper.hbs'
-      scope = make_scope root, file
-      source = "{{#custom author}}By {{first_name}} {{last_name}}{{/custom}}"
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_custom_helper', source), template.render(scope, {})
-    end
-
-    def test_with_custom_known_helpers
-      root = '/myapp/app/assets/templates'
-      file = 'test_custom_known_helper.hbs'
-      scope = make_scope root, file
-      source = "{{#custom author}}By {{first_name}} {{last_name}}{{/custom}}"
-
-      HandlebarsAssets::Config.known_helpers_only = true
-      HandlebarsAssets::Config.known_helpers = %w(custom)
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_custom_known_helper', source), template.render(scope, {})
-    end
-
-    def test_template_namespace
-      root = '/myapp/app/assets/javascripts'
-      file = 'test_template_namespace.hbs'
-      scope = make_scope root, file
-      source = "This is {{handlebars}}"
-
-      HandlebarsAssets::Config.template_namespace = 'JST'
-
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      assert_equal hbs_compiled('test_template_namespace', source), template.render(scope, {})
-    end
-
-    def test_ember_render
-      root = '/myapp/app/assets/templates'
-      file = 'test_render.hbs'
-      scope = make_scope root, file
-      source = "This is {{handlebars}}"
-
-      HandlebarsAssets::Config.ember = true
-      template = HandlebarsAssets::TiltHandlebars.new(scope.pathname.to_s) { source }
-
-      expected_compiled = %{window.Ember.TEMPLATES["test_render"] = Ember.Handlebars.compile("This is {{handlebars}}");};
-      assert_equal expected_compiled, template.render(scope, {})
+    def render_it(scope, source)
+      template = HandlebarsAssets::HandlebarsTemplate.new(scope.pathname.to_s) { source }
+      template.render(scope, {})
     end
   end
 end

data/test/patch/patch.js

@@ -0,0 +1,10 @@
+var originalLookup = Handlebars.JavaScriptCompiler.prototype.nameLookup;
+
+Handlebars.JavaScriptCompiler.prototype.nameLookup = function(parent, name, type) {
+  if (type === 'context') {
+    return '"CALLED PATCH"';
+  }
+  else {
+    return originalLookup.call(this, parent, name, type);
+  }
+};

data/test/test_helper.rb

@@ -1,9 +1,9 @@
 require 'handlebars_assets'
 require 'handlebars_assets/config'
-require 'handlebars_assets/tilt_handlebars'
+require 'handlebars_assets/handlebars_template'
 require 'handlebars_assets/handlebars'
 
-require 'test/unit'
+require 'minitest/autorun'
 
 module SprocketsScope
   # Try to act like sprockets.
@@ -23,29 +23,29 @@ module CompilerSupport
 
   def compile_hbs(source)
     compiler_src = Pathname(HandlebarsAssets::Config.compiler_path).join(HandlebarsAssets::Config.compiler).read
-    ExecJS.compile(compiler_src).call('Handlebars.precompile', source, HandlebarsAssets::Config.options)
+    ExecJS.compile("var window = {}; " + compiler_src).call('Handlebars.precompile', source, HandlebarsAssets::Config.options)
   end
 
   def hbs_compiled(template_name, source)
-    compiled_hbs = compile_hbs(source)
+    compiled_hbs = compile_hbs(source).strip
     template_namespace = HandlebarsAssets::Config.template_namespace
 
-    unindent <<-END_EXPECTED
-      (function() {
-        this.#{template_namespace} || (this.#{template_namespace} = {});
-        this.#{template_namespace}[#{template_name.dump}] = Handlebars.template(#{compiled_hbs});
-        return this.#{template_namespace}[#{template_name.dump}];
-      }).call(this);
+    <<-END_EXPECTED
+(function() {
+  this.#{template_namespace} || (this.#{template_namespace} = {});
+  this.#{template_namespace}[#{template_name.dump}] = Handlebars.template(#{compiled_hbs});
+  return this.#{template_namespace}[#{template_name.dump}];
+}).call(this);
     END_EXPECTED
   end
 
   def hbs_compiled_partial(partial_name, source)
     compiled_hbs = compile_hbs(source)
 
-    unindent <<-END_EXPECTED
-      (function() {
-        Handlebars.registerPartial(#{partial_name.dump}, Handlebars.template(#{compiled_hbs}));
-      }).call(this);
+    <<-END_EXPECTED
+(function() {
+  Handlebars.registerPartial(#{partial_name.dump}, Handlebars.template(#{compiled_hbs}));
+}).call(this);
     END_EXPECTED
   end
 end
@@ -55,12 +55,15 @@ module HandlebarsAssets
     extend self
 
     def reset!
+      @chomp_underscore_for_partials = nil
       @compiler = nil
       @compiler_path = nil
       @haml_options = nil
       @known_helpers = nil
       @known_helpers_only = nil
       @options = nil
+      @patch_files = nil
+      @patch_path = nil
       @path_prefix = nil
       @template_namespace = nil
       @ember = nil
@@ -73,6 +76,7 @@ module HandlebarsAssets
     def self.reset!
       @context = nil
       @source = nil
+      @patch_path = nil
       @path = nil
       @assets_path = nil
     end