handbrake 0.2.0 → 0.2.1

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+0.2.1
+=====
+
+- Include parent references in {HandBrake::Title} and
+  {HandBrake::Chapter}.
+- When parsing a title scan, do not keep references to the parsed tree
+  in the {HandBrake::Title} objects.
+
 0.2.0
 =====
 

data/lib/handbrake/cli.rb

@@ -206,7 +206,7 @@ module HandBrake
       @runner.run(arguments.push(*more_args)).tap do |result|
         unless result.status == 0
           unless trace?
-            $stderr.puts result.output
+            $stderr.write result.output
           end
           raise "HandBrakeCLI execution failed (#{result.status.inspect})"
         end
@@ -266,7 +266,7 @@ module HandBrake
         IO.popen(cmd) do |io|
           while line = io.gets
             output << line
-            $stderr.puts(line.chomp) if @cli.trace?
+            $stderr.write(line) if @cli.trace?
           end
         end
         RunnerResult.new(output, $?)

data/lib/handbrake/titles.rb

@@ -36,6 +36,7 @@ module HandBrake
         titles.raw_output = output
         titles.raw_tree.children.
           collect { |title_node| Title.from_tree(title_node) }.
+          each { |title| title.collection = titles }.
           each { |title| titles[title.number] = title }
       end
     end
@@ -123,6 +124,10 @@ module HandBrake
     #   "main feature".
     attr_writer :main_feature
 
+    ##
+    # @return [Titles] The collection this title belongs to.
+    attr_accessor :collection
+
     ##
     # Creates a new instance from the given scan subtree.
     #
@@ -137,8 +142,11 @@ module HandBrake
           scan(/duration: (\d\d:\d\d:\d\d)/).first.first
         title.chapters = title_node['chapters:'].children.
           collect { |ch_node| Chapter.from_tree(ch_node) }.
+          tap { |chapters| chapters.each { |c| c.title = title } }.
           inject({}) { |h, ch| h[ch.number] = ch; h }
-        title.main_feature = title_node.children.detect { |c| c.name =~ /Main Feature/ }
+        # !! is so that there's no reference to the node in the
+        # resulting object
+        title.main_feature = !!title_node.children.detect { |c| c.name =~ /Main Feature/ }
       end
     end
 
@@ -179,6 +187,10 @@ module HandBrake
     #   integer)
     attr_accessor :number
 
+    ##
+    # @return [Title] The title that contains this chapter
+    attr_accessor :title
+
     ##
     # Creates a new instance from the given title subtree.
     #

data/lib/handbrake/version.rb

@@ -1,5 +1,5 @@
 module HandBrake
   ##
   # The current version
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/handbrake/titles_spec.rb

@@ -47,6 +47,10 @@ module HandBrake
     let(:title_1) { titles[1] }
     let(:title_3) { titles[3] }
 
+    it 'has a reference to its parent collection' do
+      title_1.collection.should eql(titles)
+    end
+
     describe '#main_feature?' do
       it 'is true when it is' do
         title_1.should be_main_feature
@@ -55,6 +59,10 @@ module HandBrake
       it 'is false when it is' do
         title_3.should_not be_main_feature
       end
+
+      it 'is not a complex value when true, so that serializations are simpler' do
+        title_1.main_feature?.should == true
+      end
     end
 
     it 'has the number' do
@@ -98,6 +106,10 @@ module HandBrake
       it 'has the number' do
         chapter.number.should == 5
       end
+
+      it 'has a reference to its parent' do
+        chapter.title.should eql title_3
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: handbrake
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-07 00:00:00.000000000Z
+date: 2011-08-14 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubytree
-  requirement: &2153799900 !ruby/object:Gem::Requirement
+  requirement: &2153698700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2153799900
+  version_requirements: *2153698700
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2153799400 !ruby/object:Gem::Requirement
+  requirement: &2153698200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '2.5'
   type: :development
   prerelease: false
-  version_requirements: *2153799400
+  version_requirements: *2153698200
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2153798940 !ruby/object:Gem::Requirement
+  requirement: &2153697740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 0.9.0
   type: :development
   prerelease: false
-  version_requirements: *2153798940
+  version_requirements: *2153697740
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &2153798480 !ruby/object:Gem::Requirement
+  requirement: &2153697280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,7 +54,7 @@ dependencies:
         version: 0.7.0
   type: :development
   prerelease: false
-  version_requirements: *2153798480
+  version_requirements: *2153697280
 description: A lightweight literate ruby wrapper for HandBrakeCLI, the command-line
   interface for the HandBrake video transcoder.
 email: