hanami 2.3.0.beta2 → 2.3.0

data/spec/integration/router/resource_routes_spec.rb

@@ -0,0 +1,281 @@
+# frozen_string_literal: true
+
+require "dry/inflector"
+require "hanami/slice/router"
+require "json"
+
+RSpec.describe "Router / Resource routes" do
+  let(:router) { Hanami::Slice::Router.new(routes:, resolver:, inflector: Dry::Inflector.new) { } }
+
+  let(:resolver) { Hanami::Slice::Routing::Resolver.new(slice:) }
+  let(:slice) {
+    Class.new(Hanami::Slice).tap { |slice|
+      allow(slice).to receive(:container) { actions_container }
+      allow(slice).to receive(:slices) { {reviews: child_slice} }
+    }
+  }
+  let(:child_slice) {
+    Class.new(Hanami::Slice).tap { |slice|
+      allow(slice).to receive(:container) { actions_container("[reviews]") }
+    }
+  }
+  def actions_container(prefix = nil)
+    Hash.new { |_hsh, key|
+      Class.new { |klass|
+        klass.define_method(:call) do |env|
+          body = key
+          body = "#{body} #{JSON.generate(env["router.params"])}" if env["router.params"].any?
+          body = "#{prefix}#{body}" if prefix
+          [200, {}, body]
+        end
+      }.new
+    }.tap { |container|
+      def container.resolve(key) = self[key]
+    }
+  end
+
+  let(:app) { Rack::MockRequest.new(router) }
+  def routed(method, url)
+    app.request(method, url).body
+  end
+
+  describe "resources" do
+    let(:routes) { proc { resources :posts } }
+
+    it "routes all RESTful actions to the resource" do
+      expect(routed("GET", "/posts")).to eq %(actions.posts.index)
+      expect(routed("GET", "/posts/new")).to eq %(actions.posts.new)
+      expect(routed("POST", "/posts")).to eq %(actions.posts.create)
+      expect(routed("GET", "/posts/1")).to eq %(actions.posts.show {"id":"1"})
+      expect(routed("GET", "/posts/1/edit")).to eq %(actions.posts.edit {"id":"1"})
+      expect(routed("PATCH", "/posts/1")).to eq %(actions.posts.update {"id":"1"})
+      expect(routed("DELETE", "/posts/1")).to eq %(actions.posts.destroy {"id":"1"})
+
+      expect(router.path("posts")).to eq "/posts"
+      expect(router.path("new_post")).to eq "/posts/new"
+      expect(router.path("edit_post", id: 1)).to eq "/posts/1/edit"
+    end
+
+    describe "with :only" do
+      let(:routes) { proc { resources :posts, only: %i(index show) } }
+
+      it "routes only the given actions to the resource" do
+        expect(routed("GET", "/posts")).to eq %(actions.posts.index)
+        expect(routed("GET", "/posts/1")).to eq %(actions.posts.show {"id":"1"})
+
+        expect(routed("GET", "/posts/new")).not_to eq %(actions.posts.new)
+        expect(routed("POST", "/posts")).to eq "Method Not Allowed"
+        expect(routed("GET", "/posts/1/edit")).to eq "Not Found"
+        expect(routed("PATCH", "/posts/1")).to eq "Method Not Allowed"
+        expect(routed("DELETE", "/posts/1")).to eq "Method Not Allowed"
+      end
+    end
+
+    describe "with :except" do
+      let(:routes) { proc { resources :posts, except: %i(edit update destroy) } }
+
+      it "routes all except the given actions to the resource" do
+        expect(routed("GET", "/posts")).to eq %(actions.posts.index)
+        expect(routed("GET", "/posts/new")).to eq %(actions.posts.new)
+        expect(routed("POST", "/posts")).to eq %(actions.posts.create)
+        expect(routed("GET", "/posts/1")).to eq %(actions.posts.show {"id":"1"})
+
+        expect(routed("GET", "/posts/1/edit")).to eq "Not Found"
+        expect(routed("PATCH", "/posts/1")).to eq "Method Not Allowed"
+        expect(routed("DELETE", "/posts/1")).to eq "Method Not Allowed"
+      end
+    end
+
+    describe "with :to" do
+      let(:routes) { proc { resources :posts, to: "articles" } }
+
+      it "uses actions from the given container key namespace" do
+        expect(routed("GET", "/posts")).to eq %(actions.articles.index)
+        expect(routed("GET", "/posts/new")).to eq %(actions.articles.new)
+        expect(routed("POST", "/posts")).to eq %(actions.articles.create)
+        expect(routed("GET", "/posts/1")).to eq %(actions.articles.show {"id":"1"})
+        expect(routed("GET", "/posts/1/edit")).to eq %(actions.articles.edit {"id":"1"})
+        expect(routed("PATCH", "/posts/1")).to eq %(actions.articles.update {"id":"1"})
+        expect(routed("DELETE", "/posts/1")).to eq %(actions.articles.destroy {"id":"1"})
+      end
+    end
+
+    describe "witih :path" do
+      let(:routes) { proc { resources :posts, path: "articles" } }
+
+      it "uses the given path for the routes" do
+        expect(routed("GET", "/articles")).to eq %(actions.posts.index)
+        expect(routed("GET", "/articles/new")).to eq %(actions.posts.new)
+        expect(routed("POST", "/articles")).to eq %(actions.posts.create)
+        expect(routed("GET", "/articles/1")).to eq %(actions.posts.show {"id":"1"})
+        expect(routed("GET", "/articles/1/edit")).to eq %(actions.posts.edit {"id":"1"})
+        expect(routed("PATCH", "/articles/1")).to eq %(actions.posts.update {"id":"1"})
+        expect(routed("DELETE", "/articles/1")).to eq %(actions.posts.destroy {"id":"1"})
+      end
+    end
+  end
+
+  describe "resource" do
+    let(:routes) { proc { resource :profile } }
+
+    it "routes all RESTful actions (except index) to the resource" do
+      expect(routed("GET", "/profile/new")).to eq %(actions.profile.new)
+      expect(routed("POST", "/profile")).to eq %(actions.profile.create)
+      expect(routed("GET", "/profile")).to eq %(actions.profile.show)
+      expect(routed("GET", "/profile/edit")).to eq %(actions.profile.edit)
+      expect(routed("PATCH", "/profile")).to eq %(actions.profile.update)
+      expect(routed("DELETE", "/profile")).to eq %(actions.profile.destroy)
+
+      expect(routed("GET", "/profiles")).to eq "Not Found"
+      expect(routed("GET", "/profiles/1")).to eq "Not Found"
+      expect(routed("GET", "/profile/1")).to eq "Not Found"
+
+      expect(router.path("profile")).to eq "/profile"
+      expect(router.path("new_profile")).to eq "/profile/new"
+      expect(router.path("edit_profile")).to eq "/profile/edit"
+    end
+
+    describe "with :only" do
+      let(:routes) { proc { resource :profile, only: %i(show edit update) } }
+
+      it "routes only the given actions to the resource" do
+        expect(routed("GET", "/profile")).to eq %(actions.profile.show)
+        expect(routed("GET", "/profile/edit")).to eq %(actions.profile.edit)
+        expect(routed("PATCH", "/profile")).to eq %(actions.profile.update)
+
+        expect(routed("GET", "/profile/new")).to eq "Not Found"
+        expect(routed("POST", "/profile")).to eq "Method Not Allowed"
+        expect(routed("DELETE", "/profile")).to eq "Method Not Allowed"
+      end
+    end
+
+    describe "with :except" do
+      let(:routes) { proc { resource :profile, except: %i(edit update destroy) } }
+
+      it "routes all except the given actions to the resource" do
+        expect(routed("GET", "/profile/new")).to eq %(actions.profile.new)
+        expect(routed("POST", "/profile")).to eq %(actions.profile.create)
+        expect(routed("GET", "/profile")).to eq %(actions.profile.show)
+
+        expect(routed("GET", "/profile/edit")).to eq "Not Found"
+        expect(routed("PATCH", "/profile")).to eq "Method Not Allowed"
+        expect(routed("DELETE", "/profile")).to eq "Method Not Allowed"
+      end
+    end
+
+    describe "with :to" do
+      let(:routes) { proc { resource :profile, to: "user" } }
+
+      it "uses actions from the given container key namespace" do
+        expect(routed("GET", "/profile/new")).to eq %(actions.user.new)
+        expect(routed("POST", "/profile")).to eq %(actions.user.create)
+        expect(routed("GET", "/profile")).to eq %(actions.user.show)
+        expect(routed("GET", "/profile/edit")).to eq %(actions.user.edit)
+        expect(routed("PATCH", "/profile")).to eq %(actions.user.update)
+        expect(routed("DELETE", "/profile")).to eq %(actions.user.destroy)
+      end
+    end
+
+    describe "with :path" do
+      let(:routes) { proc { resource :profile, path: "user"} }
+
+      it "uses the given path for the routes" do
+        expect(routed("GET", "/user/new")).to eq %(actions.profile.new)
+        expect(routed("POST", "/user")).to eq %(actions.profile.create)
+        expect(routed("GET", "/user")).to eq %(actions.profile.show)
+        expect(routed("GET", "/user/edit")).to eq %(actions.profile.edit)
+        expect(routed("PATCH", "/user")).to eq %(actions.profile.update)
+        expect(routed("DELETE", "/user")).to eq %(actions.profile.destroy)
+      end
+    end
+  end
+
+  describe "nested resources" do
+    let(:routes) {
+      proc {
+        resources :cafes, only: :show do
+          resources :reviews, only: :index do
+            resources :comments, only: [:index, :new, :create]
+          end
+        end
+
+        resource :profile, only: :show do
+          resource :avatar, only: :show do
+            resources :comments, only: :index
+          end
+        end
+      }
+    }
+
+    it "routes to the nested resources" do
+      expect(routed("GET", "/cafes/1")).to eq %(actions.cafes.show {"id":"1"})
+      expect(routed("GET", "/cafes/1/reviews")).to eq %(actions.cafes.reviews.index {"cafe_id":"1"})
+      expect(routed("GET", "/cafes/1/reviews/2/comments")).to eq %(actions.cafes.reviews.comments.index {"cafe_id":"1","review_id":"2"})
+
+      expect(router.path("cafe", id: 1)).to eq "/cafes/1"
+      expect(router.path("cafe_reviews", cafe_id: 1)).to eq "/cafes/1/reviews"
+      expect(router.path("cafe_review_comments", cafe_id: 1, review_id: 1)).to eq "/cafes/1/reviews/1/comments"
+      expect(router.path("new_cafe_review_comment", cafe_id: 1, review_id: 1)).to eq "/cafes/1/reviews/1/comments/new"
+
+      expect(routed("GET", "/profile")).to eq %(actions.profile.show)
+      expect(routed("GET", "/profile/avatar")).to eq %(actions.profile.avatar.show)
+      expect(routed("GET", "/profile/avatar/comments")).to eq %(actions.profile.avatar.comments.index)
+    end
+  end
+
+  describe "standalone routes nested under resources" do
+    let(:routes) {
+      proc {
+        resources :cafes, only: :show do
+          get "/top-reviews", to: "cafes.top_reviews.index", as: :top_reviews
+        end
+      }
+    }
+
+    it "nests the standalone route under the resource" do
+      expect(routed("GET", "/cafes/1")).to eq %(actions.cafes.show {"id":"1"})
+      expect(routed("GET", "/cafes/1/top-reviews")).to eq %(actions.cafes.top_reviews.index {"cafe_id":"1"})
+
+      expect(router.path("cafe_top_reviews", cafe_id: 1)).to eq "/cafes/1/top-reviews"
+    end
+  end
+
+  describe "resources nested under scopes" do
+    let(:routes) {
+      proc {
+        scope "coffee-lovers" do
+          resources :cafes, only: :show do
+            get "/top-reviews", to: "cafes.top_reviews.index", as: :top_reviews
+          end
+        end
+      }
+    }
+
+    it "routes to the resources under the scope" do
+      expect(routed("GET", "/coffee-lovers/cafes/1")).to eq %(actions.cafes.show {"id":"1"})
+      expect(routed("GET", "/coffee-lovers/cafes/1/top-reviews")).to eq %(actions.cafes.top_reviews.index {"cafe_id":"1"})
+
+      expect(router.path("coffee_lovers_cafe", id: 1)).to eq "/coffee-lovers/cafes/1"
+      expect(router.path("coffee_lovers_cafe_top_reviews", cafe_id: 1)).to eq "/coffee-lovers/cafes/1/top-reviews"
+    end
+  end
+
+  describe "slices nested under resources" do
+    let(:routes) {
+      proc {
+        resources :cafes, only: :show do
+          slice :reviews, at: "" do
+            resources :reviews, only: :index
+          end
+        end
+      }
+    }
+
+    it "routes to actions within the nested slice" do
+      expect(routed("GET", "/cafes/1")).to eq %(actions.cafes.show {"id":"1"})
+      expect(routed("GET", "/cafes/1/reviews")).to eq %([reviews]actions.cafes.reviews.index {"cafe_id":"1"})
+
+      expect(router.path("cafe_reviews", cafe_id: 1)).to eq "/cafes/1/reviews"
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hanami
 version: !ruby/object:Gem::Version
-  version: 2.3.0.beta2
+  version: 2.3.0
 platform: ruby
 authors:
 - Hanakai team
@@ -147,7 +147,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
@@ -157,7 +157,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
@@ -165,30 +165,30 @@ dependencies:
   name: hanami-cli
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0.beta2
+        version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0.beta2
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: hanami-utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0.beta2
+        version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.3.0.beta2
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -309,6 +309,7 @@ files:
 - lib/hanami/extensions/action/slice_configured_action.rb
 - lib/hanami/extensions/db/repo.rb
 - lib/hanami/extensions/operation.rb
+- lib/hanami/extensions/operation/slice_configured_db_operation.rb
 - lib/hanami/extensions/router/errors.rb
 - lib/hanami/extensions/view.rb
 - lib/hanami/extensions/view/context.rb
@@ -413,6 +414,7 @@ files:
 - spec/integration/rack_app/non_booted_rack_app_spec.rb
 - spec/integration/rack_app/rack_app_spec.rb
 - spec/integration/rake_tasks_spec.rb
+- spec/integration/router/resource_routes_spec.rb
 - spec/integration/settings/access_in_slice_class_body_spec.rb
 - spec/integration/settings/access_to_constants_spec.rb
 - spec/integration/settings/loading_from_env_spec.rb
@@ -568,6 +570,7 @@ test_files:
 - spec/integration/rack_app/non_booted_rack_app_spec.rb
 - spec/integration/rack_app/rack_app_spec.rb
 - spec/integration/rake_tasks_spec.rb
+- spec/integration/router/resource_routes_spec.rb
 - spec/integration/settings/access_in_slice_class_body_spec.rb
 - spec/integration/settings/access_to_constants_spec.rb
 - spec/integration/settings/loading_from_env_spec.rb