hanami 2.0.0.beta2 → 2.0.0.beta4

data/spec/unit/hanami/settings_spec.rb

@@ -5,51 +5,106 @@ require "hanami/settings"
 RSpec.describe Hanami::Settings do
   describe "#initialize" do
     it "uses values from the store when present" do
-      config_class = Class.new(described_class) do
+      settings_class = Class.new(described_class) do
         setting :database_url, default: "postgres://localhost/test_app_development"
       end
-      store = { database_url: "mysql://localhost/test_app_development" }.freeze
 
-      instance = config_class.new(store)
+      store = {database_url: "mysql://localhost/test_app_development"}.freeze
+
+      instance = settings_class.new(store)
 
       expect(instance.config.database_url).to eq("mysql://localhost/test_app_development")
     end
 
     it "uses defaults when values are not present in the store" do
-      config_class = Class.new(described_class) do
+      settings_class = Class.new(described_class) do
         setting :database_url, default: "postgres://localhost/test_app_development"
       end
+
       store = {}.freeze
 
-      instance = config_class.new(store)
+      instance = settings_class.new(store)
 
       expect(instance.config.database_url).to eq("postgres://localhost/test_app_development")
     end
 
-    it "collects error for all failed settings" do
-      config_class = Class.new(described_class) do
+    it "collects error for all setting values failing their constructors" do
+      settings_class = Class.new(described_class) do
         setting :database_url, constructor: ->(_v) { raise "nope to database" }
         setting :redis_url, constructor: ->(_v) { raise "nope to redis" }
       end
+
       store = {
         database_url: "postgres://localhost/test_app_development",
         redis_url: "redis://localhost:6379"
       }.freeze
 
-      expect { config_class.new(store) }.to raise_error(
+      expect { settings_class.new(store) }.to raise_error(
         described_class::InvalidSettingsError,
         /(database_url: nope to database).*(redis_url: nope to redis)/m,
       )
     end
+
+    it "collects errors for missing settings failing their constructors" do
+      settings_class = Class.new(described_class) do
+        setting :database_url, constructor: ->(_v) { raise "nope to database" }
+      end
+
+      store = {}
+
+      expect { settings_class.new(store) }.to raise_error(
+        described_class::InvalidSettingsError,
+        /database_url: nope to database/m,
+      )
+    end
+
+    it "finalizes the config" do
+      settings_class = Class.new(described_class) do
+        setting :database_url
+      end
+
+      store = {database_url: "postgres://localhost/test_app_development"}
+
+      settings = settings_class.new(store)
+
+      expect(settings.config).to be_frozen
+      expect { settings.database_url = "new" }.to raise_error(Dry::Configurable::FrozenConfig)
+    end
+  end
+
+  describe "#inspect" do
+    it "shows keys" do
+      settings_class = Class.new(described_class) do
+        setting :password, default: "dont_tell_anybody"
+        setting :passphrase, default: "shhhh"
+      end
+
+      expect(settings_class.new.inspect).to eq(
+        "#<#{settings_class.to_s} [password, passphrase]>"
+      )
+    end
+  end
+
+  describe "#inspect_values" do
+    it "shows keys & values" do
+      settings_class = Class.new(described_class) do
+        setting :password, default: "dont_tell_anybody"
+        setting :passphrase, default: "shhh"
+      end
+
+      expect(settings_class.new.inspect_values).to eq(
+        "#<#{settings_class.to_s} password=\"dont_tell_anybody\" passphrase=\"shhh\">"
+      )
+    end
   end
 
   it "delegates unknown methods to config" do
-    config_class = Class.new(described_class) do
+    settings_class = Class.new(described_class) do
       setting :foo, default: "bar"
     end
     store = {}.freeze
 
-    instance = config_class.new(store)
+    instance = settings_class.new(store)
 
     expect(instance.foo).to eq("bar")
   end

data/spec/unit/hanami/slice_configurable_spec.rb

@@ -28,8 +28,6 @@ RSpec.describe Hanami::SliceConfigurable, :app_integration do
         end
       end
     end
-
-    Hanami.app.prepare
   end
 
   context "subclass inside slice namespace" do
@@ -101,4 +99,25 @@ RSpec.describe Hanami::SliceConfigurable, :app_integration do
       end
     end
   end
+
+  context "subclass inside nested slice namespace" do
+    before do
+      module Main
+        class Slice
+          register_slice :nested
+        end
+      end
+
+      module Nested
+        class MySubclass < TestApp::BaseClass
+        end
+      end
+    end
+
+    subject(:subclass) { Nested::MySubclass }
+
+    it "calls `configure_for_slice` with the nested slice" do
+      expect(subclass.traces).to eq [Nested::Slice]
+    end
+  end
 end

data/spec/unit/hanami/version_spec.rb

@@ -2,6 +2,6 @@
 
 RSpec.describe "Hanami::VERSION" do
   it "returns current version" do
-    expect(Hanami::VERSION).to eq("2.0.0.beta2")
+    expect(Hanami::VERSION).to eq("2.0.0.beta4")
   end
 end