hanami-view 1.0.1 → 1.1.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3f3b5a91fabf790905218d179350b9ca5b09ea5
-  data.tar.gz: 90708fec73255ef891fa0210527ea32bf49c82a5
+  metadata.gz: '0499a5ecaa4e50c44d7e759ea91747b42332a13c'
+  data.tar.gz: '066865e74b723cea4e703accc5ea1e45ad76e7ff'
 SHA512:
-  metadata.gz: e414c7c8df49dfa4e33ff5e694baa9408ac8336aff315f631044ed8f86300dfbad8fdf066bed6e8227ba96d77c2e6e46cf20600d0cc7480e56ed83e55429f1f3
-  data.tar.gz: b21512ad851b40cd8dca788ff9c93ae98f40eec8a1087ee855e2c8858324543f45d3c403872b061f1c772f1a42d10332830f66f43607c3a2da7fec83b111f0b9
+  metadata.gz: d161a7bac58d23014c570372f456555ad993f5a191e024f4f50a925771bc53ca8181c8d6a3aa1884a1ead62b3b00e0e70a60bbee50319358896b1e9d0638c7e8
+  data.tar.gz: 46ee3fde97ffa129632ad10209aab687e08b72571a565b4bd384f17c9c1bccc9234e6231b674725090bfc95e94f532492beba5eeebe43c9130c877a74215e83a

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Hanami::View
 View layer for Hanami
 
+## v1.1.0.beta1 - 2017-08-11
+### Fixed
+- [yjukaku] Raise `Hanami::View::UnknownRenderTypeError` when an argument different from `:template` or `:partial` is passed to `render`
+
 ## v1.0.1 - 2017-08-04
 ### Added
 - [Luca Guidi] Compatibility with `haml` 5.0

data/hanami-view.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.3.0'
 
   spec.add_runtime_dependency 'tilt',         '~> 2.0', '>= 2.0.1'
-  spec.add_runtime_dependency 'hanami-utils', '~> 1.0'
+  spec.add_runtime_dependency 'hanami-utils', '1.1.0.beta1'
 
   spec.add_development_dependency 'bundler', '~> 1.5'
   spec.add_development_dependency 'rspec',   '~> 3.5'

data/lib/hanami/view/configuration.rb

@@ -91,7 +91,7 @@ module Hanami
       #     # => will return from MyApp::View
       def self.for(base)
         # TODO this implementation is similar to Hanami::Controller::Configuration consider to extract it into Hanami::Utils
-        namespace = Utils::String.new(base).namespace
+        namespace = Utils::String.namespace(base)
         framework = Utils::Class.load_from_pattern!("(#{namespace}|Hanami)::View")
         framework.configuration
       end

data/lib/hanami/view/errors.rb

@@ -48,13 +48,13 @@ module Hanami
       end
     end
 
-    # Unknown or missing render type
+    # Unknown or render type
     #
-    # This is raised at the runtime when Hanami::Layout doesn't recognize the render type.
+    # This is raised at the runtime when `Hanami::Layout` doesn't recognize the render type.
     #
-    # @since X.X.X
-    class UnknownOrMissingRenderTypeLayoutError < Error
-      # @since X.X.X
+    # @since 1.1.0
+    class UnknownRenderTypeError < Error
+      # @since 1.1.0
       # @api private
       def initialize(known_types, supplied_options)
         known_types_list = known_types.map{|t| "':#{t}'"}.join(', ')

data/lib/hanami/view/rendering/layout_finder.rb

@@ -65,7 +65,7 @@ module Hanami
           case layout
           when Symbol, String
             # TODO Move this low level logic into a Hanami::Utils solution
-            class_name = "#{ Utils::String.new(layout).classify }#{ SUFFIX }"
+            class_name = "#{ Utils::String.classify(layout) }#{ SUFFIX }"
             namespace  = Utils::Class.load_from_pattern!(namespace)
             namespace.const_get(class_name)
           when Class

data/lib/hanami/view/rendering/layout_scope.rb

@@ -4,13 +4,13 @@ require 'hanami/utils/escape'
 module Hanami
   module View
     module Rendering
-        
-      # List of render types that exactly one of must be included when calling `#render`. 
+      # List of render types that exactly one of must be included when calling `#render`.
       # For example, when calling `<%= render something: 'my_thing', locals: {} %>`,
       # 'something' must be one of the values listed here.
-      # 
-      # @since X.X.X
-      KNOWN_RENDER_TYPES = [:partial, :template]
+      #
+      # @since 1.1.0
+      # @api private
+      KNOWN_RENDER_TYPES = [:partial, :template].freeze
 
       # Scope for layout rendering
       #
@@ -60,6 +60,9 @@ module Hanami
         #
         # @return [String] the output of the rendering process
         #
+        # @raise [Hanami::Error::UnknownRenderTypeError] if the given type to
+        #   be rendered is unknown
+        #
         # @since 0.1.0
         #
         # @example Rendering partial
@@ -95,9 +98,6 @@ module Hanami
         #   #
         #   # `user` will be available in the scope of the sidebar rendering
         def render(options)
-          if !KNOWN_RENDER_TYPES.any?{|render_type| options[render_type]}
-            ::Kernel.raise UnknownOrMissingRenderTypeLayoutError.new(KNOWN_RENDER_TYPES, options)
-          end
           renderer(options).render
         end
 
@@ -243,6 +243,8 @@ module Hanami
             Rendering::Partial
           elsif options[:template]
             Rendering::Template
+          else
+            ::Kernel.raise UnknownRenderTypeError.new(KNOWN_RENDER_TYPES, options)
           end.new(view, _options(options))
         end
 

data/lib/hanami/view/rendering/template_name.rb

@@ -28,7 +28,7 @@ module Hanami
         # @api private
         def compile!(namespace)
           tokens(namespace) {|token| replace!(token) }
-          @name = Utils::String.new(@name).underscore
+          @name = Utils::String.underscore(@name)
         end
 
         # @since 0.2.0

data/lib/hanami/view/version.rb

@@ -3,6 +3,6 @@ module Hanami
     # Defines the version
     #
     # @since 0.1.0
-    VERSION = '1.0.1'.freeze
+    VERSION = '1.1.0.beta1'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hanami-view
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0.beta1
 platform: ruby
 authors:
 - Luca Guidi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-04 00:00:00.000000000 Z
+date: 2017-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tilt
@@ -34,16 +34,16 @@ dependencies:
   name: hanami-utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.1.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.1.0.beta1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -141,9 +141,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.11