hanami-events-cloud_pubsub 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b625cc3f94218143ebafd31a854fdefb3e4b3ab5d54aa66385784f6560265c8
-  data.tar.gz: e7eb0b9995c66e2c4610b9eba4913a4ff94e8c89981302b4f736ccc9cdddf6aa
+  metadata.gz: 49a7d1c90e1e14b61aed89764e006780686f58394810ed4f58ae2be580325fed
+  data.tar.gz: 9839accaae0d4057c2b2acdeb8a88f35958343510f05d16edd97fc41c523bfe4
 SHA512:
-  metadata.gz: f3e44b4a055f90493bfafe9cbeb8243ddc2bba0c6eb693f5b29c664f2675546a5415387519fbe9075a110304aa3d8136b8da9b0ce0dddfa793a155fa39aeca98
-  data.tar.gz: e7107a4d84b881d2522b04002f07395783912d83a3653673650b2947a1e500cf47b4d8282adaaf0aabacbcfb3572a6780e828ff994ffcdffe160805dd30272ec
+  metadata.gz: 1fcf93deb007707ebb82693a764cffa7d866056a28c56dd0c74b653ee80a29ca4e9ab71e6e9f35a6c883bfa45c7f87572eff63902ce27139807fc53345c72d65
+  data.tar.gz: 3ea0abe9e5bbab02d93c6ad649c29a7e091abdb22cfae66b50fcbee1735cc044966280664ef69475f47bcf1ac254c1406f8fed855ee38f87939a2baf0c83b51a

data/lib/hanami/events/cloud_pubsub.rb

@@ -63,7 +63,7 @@ module Hanami
       if defined?(Yabeda::Prometheus::Exporter)
         begin
           require 'hanami/events/cloud_pubsub/middleware/prometheus'
-          middleware_stack.prepend(Middleware::Prometheus.new)
+          middleware_stack << Middleware::Prometheus.new
         rescue LoadError
           # ok
         end

data/lib/hanami/events/cloud_pubsub/middleware/prometheus.rb

@@ -6,15 +6,27 @@ module Hanami
       module Middleware
         # Middleware used for logging useful information about an event
         class Prometheus
+          LONG_RUNNING_JOB_RUNTIME_BUCKETS = [
+            0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10, # standard (from Prometheus)
+            30, 60, 120, 300, 1800, 3600, 21_600 # Tasks may be very long-running
+          ].freeze
+
           Yabeda.configure do
             counter(
               :received_pubsub_events,
               tags: %i[event_name subscription status],
               comment: 'A counter of received pubsub events'
             )
+
+            histogram :subscriber_runtime, comment: 'A histogram of the subscriber execution time.',
+                                           unit: :seconds,
+                                           per: :message,
+                                           tags: %i[event_name subscription status],
+                                           buckets: LONG_RUNNING_JOB_RUNTIME_BUCKETS
           end
 
           def call(msg, **opts)
+            start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
             status = :running
 
             begin
@@ -26,16 +38,18 @@ module Hanami
               raise
             end
           ensure
-            record_metrics(msg, status)
+            record_metrics(msg, status, start)
           end
 
           private
 
-          def record_metrics(msg, status)
+          def record_metrics(msg, status, start)
+            elapsed = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start).round(3)
             sub = msg.subscription.subscriber.subscription_name
             event_name = msg.attributes['event_name']
             labels = { event_name: event_name, subscription: sub, status: status }
             Yabeda.received_pubsub_events.increment(labels, by: 1)
+            Yabeda.subscriber_runtime.measure(labels, elapsed)
           rescue StandardError
             # ok
           end

data/lib/hanami/events/cloud_pubsub/version.rb

@@ -3,7 +3,7 @@
 module Hanami
   module Events
     module CloudPubsub
-      VERSION = '3.1.0'
+      VERSION = '3.1.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hanami-events-cloud_pubsub
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Ian Ker-Seymer