hanami-controller 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e43dfef6c8d6484a6ef636194dd0369b7780274b
-  data.tar.gz: f8d80e3ab997981d7dff0beecf372359334bf484
+SHA256:
+  metadata.gz: dec60bc59285348cfcf6fc743dbc586d8bd7356bfb02197db37bc18fe0131fcd
+  data.tar.gz: c8b851ca2730d18b886dcb4300fdcd28c31c12cf03df5505c995bd4a3819ef28
 SHA512:
-  metadata.gz: fc087535ca74c735b55c7fe5fbeb618b3e6fb974e85b28163092ab5db3da74334ef7111431fa1a3dbfaa7afab4c8dac46fdf0e0f7af377d6829886db355309a4
-  data.tar.gz: 9ab870daa9fed48f56ffa14a8efa6138bc9c4cba09a03f8788d278f99f5d82eab1084e0315307c79fb1e475ce7da5585ca222a96e8dc42d92b4c18556ee1bd56
+  metadata.gz: a0bdc218188b3f71d5bd22bd11e81fae44089dad09191ed31ea5a1da742e4ea007df521e899469bbe01e3fd8d28d9652ec032589e83e817733a53144860a8582
+  data.tar.gz: f0f04ea096539c67c1413dc1a527b68aa258a155389324601c9cbf419c1423f0eb6fcf8a23cce67f49cf4d1109a98dd3f068f6a88dcff5b8d337fd2dba66fd91

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Hanami::Controller
 Complete, fast and testable actions for Rack
 
+## v1.1.1 - 2017-11-22
+### Fixed
+- [Luca Guidi] Ensure `Hanami::Action#send_file` and `#unsafe_send_file` to run `after` action callbacks
+- [Luca Guidi] Ensure Rack env to have the `REQUEST_METHOD` key set to `GET` during actions unit tests
+
 ## v1.1.0 - 2017-10-25
 ### Added
 - [Luca Guidi] Introduce `Hanami::Action::CookieJar#each` to iterate through action's `cookies`

data/lib/hanami/action/base_params.rb

@@ -29,6 +29,18 @@ module Hanami
       #   action.session[:foo] # => "bar"
       RACK_SESSION = 'rack.session'.freeze
 
+      # HTTP request method for Rack env
+      #
+      # @since 1.1.1
+      # @api private
+      REQUEST_METHOD = 'REQUEST_METHOD'.freeze
+
+      # Default HTTP request method for Rack env
+      #
+      # @since 1.1.1
+      # @api private
+      DEFAULT_REQUEST_METHOD = 'GET'.freeze
+
       # @attr_reader env [Hash] the Rack env
       #
       # @since 0.7.0
@@ -150,6 +162,7 @@ module Hanami
           result.merge! _router_params
         else
           result.merge! _router_params(env)
+          env[REQUEST_METHOD] ||= DEFAULT_REQUEST_METHOD
         end
 
         result

data/lib/hanami/action/rack.rb

@@ -383,6 +383,10 @@ module Hanami
           headers.delete(CONTENT_LENGTH)
           halt NOT_FOUND
         else
+          # FIXME: this is a fix for https://github.com/hanami/controller/issues/240
+          # It's here to maintain the backward compat with 1.1, as we can't remove `#halt`
+          # We should review the workflow for 2.0, because I don't like callbacks to be referenced from here.
+          _run_after_callbacks(params)
           halt response[RESPONSE_CODE], response[RESPONSE_BODY]
         end
       end

data/lib/hanami/controller/version.rb

@@ -3,6 +3,6 @@ module Hanami
     # Defines the version
     #
     # @since 0.1.0
-    VERSION = '1.1.0'.freeze
+    VERSION = '1.1.1'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hanami-controller
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Luca Guidi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-25 00:00:00.000000000 Z
+date: 2017-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -158,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.1
 signing_key: 
 specification_version: 4
 summary: Complete, fast and testable actions for Rack and Hanami