hanami-assets 1.3.0 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 656523e5106429d46d4ef06f9e49a9d8b0c7c6e9a5887034137ee94959833827
-  data.tar.gz: a9a823309ae222cf1fdaf789fd0619c51649abddd8cd11d8235516cd2a725edf
+  metadata.gz: 5176826ee1e6f1cdf7930ec50f52e9e2c3ddaad08c29081f50c3b523edf39910
+  data.tar.gz: 5cdb9005b3f3c818d0ede825faa6e022ea61bf0d11d5d48c290b96797f28b0e4
 SHA512:
-  metadata.gz: ea5984af832c0541ad530607e548b77c35a265fcf30bb38f439424b17834766ec2ee14d1e04964f58a86332e42ee90a1e5a19f8be158e5f7cad81a831ca61e30
-  data.tar.gz: 58d11b450a70857fe77fb6eb157eca3109fcd34ebda8bfa515bbe728248aa2a22935f0055c1df96345bd40f8c0b74f554957495b30af50be1e4d612f04aad779
+  metadata.gz: 249d3393b9b7936b601b680273da8f3ca07e5eca1dd684b0906d6132a476741a80729d7f0ac596de525b4e48a7a97cc5ca67bfc38806e9209ac1c6cf031d68c1
+  data.tar.gz: 66588d6713351e17e2777fcf08f2eb65aa06c9d67dc6329dcacd119dfa3d41c8a57b7fe0875863a9e2a1c4a792f0b4142f61c849ec26add1f6951250d6c3e685

data/CHANGELOG.md

@@ -1,6 +1,32 @@
 # Hanami::Assets
 Assets management for Ruby web applications
 
+## v1.3.5 - 2021-01-14
+### Added
+- [Luca Guidi] Official support for Ruby: MRI 3.0
+- [Luca Guidi] Official support for Ruby: MRI 2.7
+
+## v1.3.4 - 2019-10-11
+### Fixed
+- [unleashy] Precompile assets using binary mode to ensure compatibility with Windows
+
+## v1.3.3 - 2019-09-13
+### Fixed
+- [Landon Grindheim] Lazily load `sassc` only when required
+- [Landon Grindheim] Ensure assets precompilation to not crash when SASS stylesheet doesn't have dependencies
+
+## v1.3.2 - 2019-08-02
+### Added
+- [Landon Grindheim & Sean Collins] Added support for `sassc` gem, because `sass` is no longer maintained
+
+## v1.3.1 - 2019-01-18
+### Added
+- [Luca Guidi] Official support for Ruby: MRI 2.6
+- [Luca Guidi] Support `bundler` 2.0+
+
+### Fixed
+- [Luca Guidi] Make optional nested assets feature to maintain backward compatibility with `1.2.x`
+
 ## v1.3.0 - 2018-10-24
 
 ## v1.3.0.beta1 - 2018-08-08

data/LICENSE.md

@@ -1,4 +1,4 @@
-Copyright © 2014-2017 Luca Guidi
+Copyright © 2014-2021 Luca Guidi
 
 MIT License
 

data/README.md

@@ -5,8 +5,7 @@ Assets management for Ruby web projects
 ## Status
 
 [![Gem Version](https://badge.fury.io/rb/hanami-assets.svg)](https://badge.fury.io/rb/hanami-assets)
-[![TravisCI](https://travis-ci.org/hanami/assets.svg?branch=master)](https://travis-ci.org/hanami/assets)
-[![CircleCI](https://circleci.com/gh/hanami/assets/tree/master.svg?style=svg)](https://circleci.com/gh/hanami/assets/tree/master)
+[![CI](https://github.com/hanami/assets/workflows/ci/badge.svg?branch=master)](https://github.com/hanami/assets/actions?query=workflow%3Aci+branch%3Amaster)
 [![Test Coverage](https://codecov.io/gh/hanami/assets/branch/master/graph/badge.svg)](https://codecov.io/gh/hanami/assets)
 [![Depfu](https://badges.depfu.com/badges/4b37347bd74042ff96477495cc16531d/overview.svg)](https://depfu.com/github/hanami/assets?project=Bundler)
 [![Inline Docs](http://inch-ci.org/github/hanami/assets.svg)](http://inch-ci.org/github/hanami/assets)
@@ -15,7 +14,7 @@ Assets management for Ruby web projects
 
 * Home page: http://hanamirb.org
 * Community: http://hanamirb.org/community
-* Guides: http://hanamirb.org/guides
+* Guides: https://guides.hanamirb.org
 * Mailing List: http://hanamirb.org/mailing-list
 * API Doc: http://rdoc.info/gems/hanami-assets
 * Bugs/Issues: https://github.com/hanami/assets/issues
@@ -200,7 +199,7 @@ handling: `.css` for stylesheets.
 The second one is optional and it's for a preprocessor: `.scss` for Sass.
 
 ```ruby
-require 'sass'
+require 'sassc'
 require 'hanami/assets'
 
 Hanami::Assets.configure do
@@ -353,7 +352,7 @@ Hanami can use the following compressors (aka minifiers) for stylesheets.
 
   * `:builtin` - Ruby based compressor. It doesn't require any external gem. It's fast, but not an efficient compressor.
   * `:yui` - [YUI Compressor](http://yui.github.io/yuicompressor), it depends on [`yui-compressor`](https://rubygems.org/gems/yui-compressor) gem and it requires Java 1.4+
-  * `:sass` - [Sass](http://sass-lang.com/), it depends on [`sass`](https://rubygems.org/gems/sass) gem
+  * `:sass` - [Sass](http://sass-lang.com/), it depends on [`sassc`](https://rubygems.org/gems/sassc) gem
 
 ```ruby
 Hanami::Assets.configure do
@@ -437,6 +436,28 @@ From now on, helpers will return the absolute URL for the asset, hosted on the C
 <script src="https://123.cloudfront.net/assets/application-d1829dc353b734e3adc24855693b70f9.js" type="text/javascript"></script>
 ```
 
+## Standalone mode
+
+If you're using `hanami-assets` without `hanami`, you must explicitly boot the framework with:
+
+```ruby
+Hanami::Assets.configure do
+  # ...
+end.load!
+```
+
+or
+
+```ruby
+Hanami::Assets.configure do
+  # ...
+end
+
+# ...
+
+Hanami::Assets.load!
+```
+
 ## Third party gems
 
 Developers can maintain gems that distribute assets for Hanami. For instance `hanami-ember` or `hanami-jquery`.
@@ -472,6 +493,6 @@ __Hanami::Assets__ uses [Semantic Versioning 2.0.0](http://semver.org)
 
 ## Copyright
 
-Copyright © 2014-2017 Luca Guidi – Released under MIT License
+Copyright © 2014-2021 Luca Guidi – Released under MIT License
 
 This project was formerly known as Lotus (`lotus-assets`).

data/bin/hanami-assets

@@ -1,22 +1,23 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require 'optparse'
-require 'pathname'
+require "optparse"
+require "pathname"
 
 options = {}
 OptionParser.new do |opts|
-  opts.banner = 'Usage: hanami-assets --config=path/to/config.rb'
+  opts.banner = "Usage: hanami-assets --config=path/to/config.rb"
 
-  opts.on('-c', '--config FILE', 'Path to config') do |c|
+  opts.on("-c", "--config FILE", "Path to config") do |c|
     options[:config] = c
   end
 end.parse!
 
-config = options.fetch(:config) { raise ArgumentError.new('You must specify a configuration file') }
+config = options.fetch(:config) { raise ArgumentError.new("You must specify a configuration file") }
 config = Pathname.new(config)
 config.exist? or raise ArgumentError.new("Cannot find configuration file: #{config}")
 
-require 'hanami/assets'
+require "hanami/assets"
 load config
 
 Hanami::Assets.deploy

data/hanami-assets.gemspec

@@ -24,15 +24,17 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'hanami-helpers',  '~> 1.3'
   spec.add_runtime_dependency 'tilt',            '~> 2.0', '>= 2.0.2'
 
-  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'bundler',          '>= 1.6', '< 3'
   spec.add_development_dependency 'rake',             '~> 12.0'
   spec.add_development_dependency 'rspec',            '~> 3.7'
 
   spec.add_development_dependency 'yui-compressor',   '~> 0.12'
   spec.add_development_dependency 'uglifier',         '~> 2.7'
   spec.add_development_dependency 'closure-compiler', '~> 1.1'
-  spec.add_development_dependency 'sass',             '~> 3.4'
+  spec.add_development_dependency 'sassc',            '~> 2.0'
 
   spec.add_development_dependency 'coffee-script',    '~> 2.3'
   spec.add_development_dependency 'babel-transpiler', '~> 0.7'
+
+  spec.add_development_dependency 'rubocop', '0.81'
 end

data/lib/hanami/assets.rb

@@ -1,4 +1,6 @@
-require 'hanami/utils/class_attribute'
+# frozen_string_literal: true
+
+require "hanami/utils/class_attribute"
 
 # Hanami
 #
@@ -16,10 +18,10 @@ module Hanami
     class Error < ::StandardError
     end
 
-    require 'hanami/assets/version'
-    require 'hanami/assets/configuration'
-    require 'hanami/assets/config/global_sources'
-    require 'hanami/assets/helpers'
+    require "hanami/assets/version"
+    require "hanami/assets/configuration"
+    require "hanami/assets/config/global_sources"
+    require "hanami/assets/helpers"
 
     include Utils::ClassAttribute
 
@@ -48,8 +50,8 @@ module Hanami
     #
     # @since 0.1.0
     def self.deploy
-      require 'hanami/assets/precompiler'
-      require 'hanami/assets/bundler'
+      require "hanami/assets/precompiler"
+      require "hanami/assets/bundler"
 
       Precompiler.new(configuration, duplicates).run
       Bundler.new(configuration,     duplicates).run
@@ -59,8 +61,8 @@ module Hanami
     #
     # @since 0.4.0
     def self.precompile(configurations)
-      require 'hanami/assets/precompiler'
-      require 'hanami/assets/bundler'
+      require "hanami/assets/precompiler"
+      require "hanami/assets/bundler"
 
       Precompiler.new(configuration, configurations).run
       Bundler.new(configuration,     configurations).run

data/lib/hanami/assets/bundler.rb

@@ -1,9 +1,11 @@
-require 'fileutils'
-require 'json'
+# frozen_string_literal: true
 
-require 'hanami/assets/bundler/compressor'
-require 'hanami/assets/bundler/asset'
-require 'hanami/assets/bundler/manifest_entry'
+require "fileutils"
+require "json"
+
+require "hanami/assets/bundler/compressor"
+require "hanami/assets/bundler/asset"
+require "hanami/assets/bundler/manifest_entry"
 
 module Hanami
   module Assets
@@ -18,11 +20,11 @@ module Hanami
 
       # @since 0.1.0
       # @api private
-      URL_SEPARATOR       = '/'.freeze
+      URL_SEPARATOR       = "/"
 
       # @since 0.1.0
       # @api private
-      URL_REPLACEMENT     = ''.freeze
+      URL_REPLACEMENT     = ""
 
       # Return a new instance
       #
@@ -105,7 +107,7 @@ module Hanami
       # @api private
       def _convert_to_url(path)
         path.sub(public_directory.to_s, URL_REPLACEMENT)
-            .gsub(File::SEPARATOR, URL_SEPARATOR)
+          .gsub(File::SEPARATOR, URL_SEPARATOR)
       end
 
       # @since 0.1.0

data/lib/hanami/assets/bundler/asset.rb

@@ -1,4 +1,6 @@
-require 'openssl'
+# frozen_string_literal: true
+
+require "openssl"
 
 module Hanami
   module Assets
@@ -20,7 +22,7 @@ module Hanami
 
         # @since 0.3.0
         # @api private
-        WILDCARD_EXT = '.*'.freeze
+        WILDCARD_EXT = ".*"
 
         # Return a new instance
         #

data/lib/hanami/assets/bundler/compressor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hanami
   module Assets
     class Bundler
@@ -8,11 +10,11 @@ module Hanami
       class Compressor
         # @since 0.3.0
         # @api private
-        JAVASCRIPT_EXT      = '.js'.freeze
+        JAVASCRIPT_EXT      = ".js"
 
         # @since 0.3.0
         # @api private
-        STYLESHEET_EXT      = '.css'.freeze
+        STYLESHEET_EXT      = ".css"
 
         # Return a new instance
         #
@@ -39,19 +41,19 @@ module Hanami
         # @since 0.3.0
         # @api private
         def compressor(type)
-          @configuration.__send__(:"#{ type }_compressor")
+          @configuration.__send__(:"#{type}_compressor")
         end
 
         # @since 0.3.0
         # @api private
         def _compress(compressor)
           compressor.compress(@path)
-        rescue => e # rubocop:disable Style/RescueStandardError
+        rescue => exception # rubocop:disable Style/RescueStandardError
           warn(
             [
               "Skipping compression of: `#{@path}'",
-              "Reason: #{e}\n",
-              "\t#{e.backtrace.join("\n\t")}\n\n"
+              "Reason: #{exception}\n",
+              "\t#{exception.backtrace.join("\n\t")}\n\n"
             ].join("\n")
           )
         end

data/lib/hanami/assets/bundler/manifest_entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hanami
   module Assets
     class Bundler
@@ -8,7 +10,7 @@ module Hanami
       class ManifestEntry
         # @since 0.3.0
         # @api private
-        SUBRESOURCE_INTEGRITY_SEPARATOR = '-'.freeze
+        SUBRESOURCE_INTEGRITY_SEPARATOR = "-"
 
         # Return a new instance
         #
@@ -22,7 +24,7 @@ module Hanami
         # @since 0.3.0
         # @api private
         def entry
-          { name => values }
+          {name => values}
         end
 
         private
@@ -38,7 +40,7 @@ module Hanami
         def values
           Hash[
             target: _convert_to_url(@asset.expanded_fingerprinted_target),
-            sri:    subresource_integrity_values
+            sri: subresource_integrity_values
           ]
         end
 
@@ -54,7 +56,7 @@ module Hanami
         # @api private
         def _convert_to_url(path)
           path.sub(@asset.configuration.public_directory.to_s, URL_REPLACEMENT)
-              .gsub(File::SEPARATOR, URL_SEPARATOR)
+            .gsub(File::SEPARATOR, URL_SEPARATOR)
         end
       end
     end

data/lib/hanami/assets/cache.rb

@@ -1,4 +1,6 @@
-require 'pathname'
+# frozen_string_literal: true
+
+require "pathname"
 
 module Hanami
   module Assets

data/lib/hanami/assets/compiler.rb

@@ -1,13 +1,15 @@
-require 'set'
-require 'find'
-require 'hanami/utils/class_attribute'
+# frozen_string_literal: true
+
+require "set"
+require "find"
+require "hanami/utils/class_attribute"
 
 module Hanami
   module Assets
     # Missing Asset error
     class MissingAsset < Error
       def initialize(name, sources)
-        sources = sources.map(&:to_s).join(', ')
+        sources = sources.map(&:to_s).join(", ")
         super("Missing asset: `#{name}' (sources: #{sources})")
       end
     end
@@ -28,18 +30,18 @@ module Hanami
     #
     # @since 0.1.0
     # @api private
-    class Compiler # rubocop:disable Metrics/ClassLength
+    class Compiler
       # @since 0.1.0
       # @api private
       DEFAULT_PERMISSIONS = 0o644
 
       # @since 0.1.0
       # @api private
-      COMPILE_PATTERN = '*.*.*'.freeze # Example hello.js.es6
+      COMPILE_PATTERN = "*.*.*" # Example hello.js.es6
 
       # @since 0.1.0
       # @api private
-      EXTENSIONS = { '.js' => true, '.css' => true, '.map' => true }.freeze
+      EXTENSIONS = {".js" => true, ".css" => true, ".map" => true}.freeze
 
       include Utils::ClassAttribute
 
@@ -67,10 +69,10 @@ module Hanami
       def self.compile(configuration, name)
         return unless configuration.compile
 
-        require 'tilt'
-        require 'hanami/assets/cache'
-        require 'hanami/assets/compilers/sass'
-        require 'hanami/assets/compilers/less'
+        require "tilt"
+        require "hanami/assets/cache"
+        require "hanami/assets/compilers/sass"
+        require "hanami/assets/compilers/less"
         fabricate(configuration, name).compile
       end
 
@@ -177,11 +179,10 @@ module Hanami
         relative_destination_name(name: Pathname.new(result), add_prefix: false)
       end
 
-      # @since 0.1.0
+      # @since 1.3.0
       # @api private
       def destination_name
-        result = @name.relative? ? relative_destination_name : absolute_destination_name
-        result = result.to_s
+        result = destination_path
 
         if compile?
           result.scan(/\A[[[:alnum:]][\-\_]]*\.[[\w]]*/).first || result
@@ -190,6 +191,16 @@ module Hanami
         end
       end
 
+      # @since 1.3.1
+      # @api private
+      def destination_path
+        if @configuration.nested
+          @name.relative? ? relative_destination_name : absolute_destination_name
+        else
+          ::File.basename(@name)
+        end.to_s
+      end
+
       # @since 0.1.0
       # @api private
       def exist?
@@ -222,7 +233,7 @@ module Hanami
       # @since 0.1.0
       # @api private
       def copy!
-        write { source.read }
+        write { source.binread }
       end
 
       # @since 0.1.0
@@ -235,7 +246,7 @@ module Hanami
       # @api private
       def write
         destination.dirname.mkpath
-        destination.open(File::WRONLY | File::TRUNC | File::CREAT, DEFAULT_PERMISSIONS) do |file|
+        destination.open(File::WRONLY | File::TRUNC | File::CREAT | File::BINARY, DEFAULT_PERMISSIONS) do |file|
           file.write(yield)
         end
       end

data/lib/hanami/assets/compilers/less.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hanami
   module Assets
     module Compilers
@@ -8,7 +10,7 @@ module Hanami
       class Less < Compiler
         # @since 0.3.0
         # @api private
-        EXTENSIONS = /\.(less)\z/
+        EXTENSIONS = /\.(less)\z/.freeze
 
         # @since 0.3.0
         # @api private

data/lib/hanami/assets/compilers/sass.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hanami
   module Assets
     module Compilers
@@ -8,12 +10,7 @@ module Hanami
       class Sass < Compiler
         # @since 0.3.0
         # @api private
-        EXTENSIONS = /\.(sass|scss)\z/
-
-        # @since 0.1.0
-        # @api private
-        CACHE_LOCATION = Pathname(Hanami.respond_to?(:root) ? # rubocop:disable Style/MultilineTernaryOperator
-                                  Hanami.root : Dir.pwd).join('tmp', 'sass-cache')
+        EXTENSIONS = /\.(sass|scss)\z/.freeze
 
         # @since 0.3.0
         # @api private
@@ -21,24 +18,42 @@ module Hanami
           name.to_s =~ EXTENSIONS
         end
 
+        # @since 1.3.3
+        # @api private
+        def initialize(*)
+          super
+          require "sassc"
+        end
+
         private
 
         # @since 0.3.0
         # @api private
         def renderer
-          Tilt.new(source, nil, load_paths: load_paths, cache_location: CACHE_LOCATION)
+          @renderer ||=
+            ::SassC::Engine.new(
+              source.read,
+              syntax: target_syntax,
+              load_paths: load_paths
+            )
         end
 
         # @since 0.3.0
         # @api private
         def dependencies
-          engine.dependencies.map { |d| d.options[:filename] }
+          renderer.dependencies.map(&:filename)
+        rescue source::NotRenderedError
+          []
         end
 
-        # @since 0.3.0
+        # @since 1.3.2
         # @api private
-        def engine
-          ::Sass::Engine.for_file(source.to_s, load_paths: load_paths, cache_location: CACHE_LOCATION)
+        def target_syntax
+          if source.extname =~ /sass\z/.freeze
+            :sass
+          else
+            :scss
+          end
         end
       end
     end

data/lib/hanami/assets/compressors/sass_stylesheet.rb

@@ -1,12 +1,11 @@
 require 'hanami/assets/compressors/stylesheet'
-require 'sass'
 
 module Hanami
   module Assets
     module Compressors
       # Sass compressor for stylesheet
       #
-      # It depends on <tt>sass</tt> gem.
+      # It depends on <tt>sassc</tt> gem.
       #
       # @since 0.1.0
       # @api private
@@ -16,21 +15,20 @@ module Hanami
       class SassStylesheet < Stylesheet
         # @since 0.1.0
         # @api private
-        #
-        # FIXME This is the same logic that we have for Hanami::Assets::Compiler
-        SASS_CACHE_LOCATION = Pathname(Hanami.respond_to?(:root) ? # rubocop:disable Style/MultilineTernaryOperator
-                                       Hanami.root : Dir.pwd).join('tmp', 'sass-cache')
-        # @since 0.1.0
-        # @api private
         def initialize
-          @compressor = Sass::Engine
+          require 'sassc'
+          @compressor = ::SassC::Engine
         end
 
         # @since 0.1.0
         # @api private
         def compress(filename)
-          compressor.new(read(filename), filename: filename, syntax: :scss,
-                                         style: :compressed, cache_location: SASS_CACHE_LOCATION).render
+          compressor.new(
+            read(filename),
+            filename: filename,
+            syntax: :scss,
+            style: :compressed
+          ).render
         end
       end
     end

data/lib/hanami/assets/config/global_sources.rb

@@ -1,4 +1,6 @@
-require 'hanami/utils/load_paths'
+# frozen_string_literal: true
+
+require "hanami/utils/load_paths"
 
 module Hanami
   module Assets
@@ -27,7 +29,7 @@ module Hanami
 
         # @since 0.1.0
         # @api private
-        alias << push
+        alias_method :<<, :push
 
         private
 

data/lib/hanami/assets/config/manifest.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hanami
   module Assets
     # This error is raised when the application starts but can't be load the
@@ -83,11 +85,11 @@ module Hanami
       class Manifest
         # @since 0.4.0
         # @api private
-        TARGET                = 'target'.freeze
+        TARGET                = "target"
 
         # @since 0.3.0
         # @api private
-        SUBRESOURCE_INTEGRITY = 'sri'.freeze
+        SUBRESOURCE_INTEGRITY = "sri"
 
         # Return a new instance
         #

data/lib/hanami/assets/config/sources.rb

@@ -1,5 +1,7 @@
-require 'hanami/utils/load_paths'
-require 'hanami/utils/file_list'
+# frozen_string_literal: true
+
+require "hanami/utils/load_paths"
+require "hanami/utils/file_list"
 
 module Hanami
   module Assets
@@ -20,7 +22,7 @@ module Hanami
       class Sources < Utils::LoadPaths
         # @since 0.3.0
         # @api private
-        SKIPPED_FILE_PREFIX = '_'.freeze
+        SKIPPED_FILE_PREFIX = "_"
 
         # @since 0.1.0
         # @api private

data/lib/hanami/assets/configuration.rb

@@ -1,61 +1,63 @@
-require 'pathname'
-require 'json'
-require 'hanami/utils/string'
-require 'hanami/utils/class'
-require 'hanami/utils/path_prefix'
-require 'hanami/utils/basic_object'
-require 'hanami/assets/config/manifest'
-require 'hanami/assets/config/sources'
+# frozen_string_literal: true
+
+require "pathname"
+require "json"
+require "hanami/utils/string"
+require "hanami/utils/class"
+require "hanami/utils/path_prefix"
+require "hanami/utils/basic_object"
+require "hanami/assets/config/manifest"
+require "hanami/assets/config/sources"
 
 module Hanami
   module Assets
     # Framework configuration
     #
     # @since 0.1.0
-    class Configuration # rubocop:disable Metrics/ClassLength
+    class Configuration
       # @since 0.1.0
       # @api private
-      DEFAULT_SCHEME                          = 'http'.freeze
+      DEFAULT_SCHEME                          = "http"
 
       # @since 0.1.0
       # @api private
-      DEFAULT_HOST                            = 'localhost'.freeze
+      DEFAULT_HOST                            = "localhost"
 
       # @since 0.1.0
       # @api private
-      DEFAULT_PORT                            = '2300'.freeze
+      DEFAULT_PORT                            = "2300"
 
       # @since 0.1.0
       # @api private
-      DEFAULT_PUBLIC_DIRECTORY                = 'public'.freeze
+      DEFAULT_PUBLIC_DIRECTORY                = "public"
 
       # @since 0.1.0
       # @api private
-      DEFAULT_MANIFEST                        = 'assets.json'.freeze
+      DEFAULT_MANIFEST                        = "assets.json"
 
       # @since 0.1.0
       # @api private
-      DEFAULT_PREFIX                          = '/assets'.freeze
+      DEFAULT_PREFIX                          = "/assets"
 
       # @since 0.1.0
       # @api private
-      URL_SEPARATOR                           = '/'.freeze
+      URL_SEPARATOR                           = "/"
 
       # @since 0.1.0
       # @api private
-      HTTP_SCHEME                             = 'http'.freeze
+      HTTP_SCHEME                             = "http"
 
       # @since 0.1.0
       # @api private
-      HTTP_PORT                               = '80'.freeze
+      HTTP_PORT                               = "80"
 
       # @since 0.1.0
       # @api private
-      HTTPS_SCHEME                            = 'https'.freeze
+      HTTPS_SCHEME                            = "https"
 
       # @since 0.1.0
       # @api private
-      HTTPS_PORT                              = '443'.freeze
+      HTTPS_PORT                              = "443"
 
       # @since 0.3.0
       # @api private
@@ -63,7 +65,7 @@ module Hanami
 
       # @since 0.3.0
       # @api private
-      SUBRESOURCE_INTEGRITY_SEPARATOR         = ' '.freeze
+      SUBRESOURCE_INTEGRITY_SEPARATOR         = " "
 
       # Return a copy of the configuration of the framework instance associated
       # with the given class.
@@ -80,9 +82,10 @@ module Hanami
       # @since 0.1.0
       # @api private
       def self.for(base)
-        # TODO: this implementation is similar to Hanami::Controller::Configuration consider to extract it into Hanami::Utils
+        # TODO: this implementation is similar to Hanami::Controller::Configuration
+        # consider to extract it into Hanami::Utils
         namespace = Utils::String.namespace(base)
-        framework = Utils::Class.load("#{namespace}::Assets") || Utils::Class.load!('Hanami::Assets')
+        framework = Utils::Class.load("#{namespace}::Assets") || Utils::Class.load!("Hanami::Assets")
         framework.configuration
       end
 
@@ -129,6 +132,17 @@ module Hanami
         end
       end
 
+      # Support for nested path
+      #
+      # @since 1.3.1
+      def nested(value = nil)
+        if value.nil?
+          @nested
+        else
+          @nested = !!value
+        end
+      end
+
       # Subresource integrity mode
       #
       # Determine if the helpers should generate the integrity attribute for an
@@ -155,7 +169,7 @@ module Hanami
         if value.nil?
           @cdn
         else
-          @cdn = !!value # rubocop:disable Style/DoubleNegation
+          @cdn = !!value
         end
       end
 
@@ -172,7 +186,8 @@ module Hanami
       #   * <tt>:builtin</tt> - Ruby based implementation of jsmin. It doesn't require any external gem.
       #   * <tt>:yui</tt> - YUI Compressor, it depends on <tt>yui-compressor</tt> gem and it requires Java 1.4+
       #   * <tt>:uglifier</tt> - UglifyJS, it depends on <tt>uglifier</tt> gem and it requires Node.js
-      #   * <tt>:closure</tt> - Google Closure Compiler, it depends on <tt>closure-compiler</tt> gem and it requires Java
+      #   * <tt>:closure</tt> - Google Closure Compiler, it depends on <tt>closure-compiler</tt> gem
+      #                         and it requires Java
       #
       # @param value [Symbol,#compress] the compressor
       #
@@ -220,9 +235,10 @@ module Hanami
       #
       # The following symbols are accepted:
       #
-      #   * <tt>:builtin</tt> - Ruby based compressor. It doesn't require any external gem. It's fast, but not an efficient compressor.
+      #   * <tt>:builtin</tt> - Ruby based compressor. It doesn't require any external gem.
+      #                         It's fast, but not an efficient compressor.
       #   * <tt>:yui</tt> - YUI-Compressor, it depends on <tt>yui-compressor</tt> gem and requires Java 1.4+
-      #   * <tt>:sass</tt> - Sass, it depends on <tt>sass</tt> gem
+      #   * <tt>:sass</tt> - Sass, it depends on <tt>sassc</tt> gem
       #
       # @param value [Symbol,#compress] the compressor
       #
@@ -232,7 +248,7 @@ module Hanami
       # @see https://rubygems.org/gems/yui-compressor
       #
       # @see http://sass-lang.com
-      # @see https://rubygems.org/gems/sass
+      # @see https://rubygems.org/gems/sassc
       #
       # @example YUI Compressor
       #   require 'hanami/assets'
@@ -473,7 +489,7 @@ module Hanami
       # @see Hanami::Assets::Configuration#javascript_compressor
       # @see Hanami::Assets::Compressors::Javascript#for
       def js_compressor
-        require 'hanami/assets/compressors/javascript'
+        require "hanami/assets/compressors/javascript"
         Hanami::Assets::Compressors::Javascript.for(javascript_compressor)
       end
 
@@ -490,13 +506,13 @@ module Hanami
       # @see Hanami::Assets::Configuration#stylesheet_compressor
       # @see Hanami::Assets::Compressors::Stylesheet#for
       def css_compressor
-        require 'hanami/assets/compressors/stylesheet'
+        require "hanami/assets/compressors/stylesheet"
         Hanami::Assets::Compressors::Stylesheet.for(stylesheet_compressor)
       end
 
       # @since 0.1.0
       # @api private
-      def duplicate # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def duplicate
         Configuration.new.tap do |c|
           c.root                  = root
           c.scheme                = scheme
@@ -506,6 +522,7 @@ module Hanami
           c.subresource_integrity = subresource_integrity
           c.cdn                   = cdn
           c.compile               = compile
+          c.nested                = nested
           c.public_directory      = public_directory
           c.manifest              = manifest
           c.sources               = sources.dup
@@ -516,7 +533,7 @@ module Hanami
 
       # @since 0.1.0
       # @api private
-      def reset! # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def reset!
         @scheme                = DEFAULT_SCHEME
         @host                  = DEFAULT_HOST
         @port                  = DEFAULT_PORT
@@ -526,6 +543,7 @@ module Hanami
         @cdn                   = false
         @fingerprint           = false
         @compile               = false
+        @nested                = false
         @base_url              = nil
         @destination_directory = nil
         @public_manifest       = Config::NullManifest.new(self)
@@ -569,6 +587,10 @@ module Hanami
       # @api private
       attr_writer :compile
 
+      # @since 1.3.1
+      # @api private
+      attr_writer :nested
+
       # @since 0.1.0
       # @api private
       attr_writer :scheme

data/lib/hanami/assets/helpers.rb

@@ -1,6 +1,8 @@
-require 'uri'
-require 'hanami/helpers/html_helper'
-require 'hanami/utils/escape'
+# frozen_string_literal: true
+
+require "uri"
+require "hanami/helpers/html_helper"
+require "hanami/utils/escape"
 
 module Hanami
   module Assets
@@ -13,51 +15,50 @@ module Hanami
     # @see http://www.rubydoc.info/gems/hanami-helpers/Hanami/Helpers/HtmlHelper
     #
     # rubocop:disable Metrics/ModuleLength
-    # rubocop:disable Naming/UncommunicativeMethodParamName
     module Helpers
       # @since 0.1.0
       # @api private
-      NEW_LINE_SEPARATOR = "\n".freeze
+      NEW_LINE_SEPARATOR = "\n"
 
       # @since 0.1.0
       # @api private
-      WILDCARD_EXT   = '.*'.freeze
+      WILDCARD_EXT   = ".*"
 
       # @since 0.1.0
       # @api private
-      JAVASCRIPT_EXT = '.js'.freeze
+      JAVASCRIPT_EXT = ".js"
 
       # @since 0.1.0
       # @api private
-      STYLESHEET_EXT = '.css'.freeze
+      STYLESHEET_EXT = ".css"
 
       # @since 0.1.0
       # @api private
-      JAVASCRIPT_MIME_TYPE = 'text/javascript'.freeze
+      JAVASCRIPT_MIME_TYPE = "text/javascript"
 
       # @since 0.1.0
       # @api private
-      STYLESHEET_MIME_TYPE = 'text/css'.freeze
+      STYLESHEET_MIME_TYPE = "text/css"
 
       # @since 0.1.0
       # @api private
-      FAVICON_MIME_TYPE    = 'image/x-icon'.freeze
+      FAVICON_MIME_TYPE    = "image/x-icon"
 
       # @since 0.1.0
       # @api private
-      STYLESHEET_REL  = 'stylesheet'.freeze
+      STYLESHEET_REL  = "stylesheet"
 
       # @since 0.1.0
       # @api private
-      FAVICON_REL     = 'shortcut icon'.freeze
+      FAVICON_REL     = "shortcut icon"
 
       # @since 0.1.0
       # @api private
-      DEFAULT_FAVICON = 'favicon.ico'.freeze
+      DEFAULT_FAVICON = "favicon.ico"
 
       # @since 0.3.0
       # @api private
-      CROSSORIGIN_ANONYMOUS = 'anonymous'.freeze
+      CROSSORIGIN_ANONYMOUS = "anonymous"
 
       # @since 0.3.0
       # @api private
@@ -65,7 +66,7 @@ module Hanami
 
       # @since 1.1.0
       # @api private
-      QUERY_STRING_MATCHER = /\?/
+      QUERY_STRING_MATCHER = /\?/.freeze
 
       include Hanami::Helpers::HtmlHelper
 
@@ -140,13 +141,15 @@ module Hanami
       #
       #   <%= javascript 'application' %>
       #
-      #   # <script src="/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.js" type="text/javascript" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
+      #   # <script src="/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.js"
+      #   #         type="text/javascript" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
       #
       # @example Subresource Integrity for 3rd Party Scripts
       #
       #   <%= javascript 'https://example.com/assets/example.js', integrity: 'sha384-oqVu...Y8wC' %>
       #
-      #   # <script src="https://example.com/assets/example.js" type="text/javascript" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
+      #   # <script src="https://example.com/assets/example.js" type="text/javascript"
+      #   #         integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
       #
       # @example Deferred Execution
       #
@@ -170,18 +173,19 @@ module Hanami
       #
       #   <%= javascript 'application' %>
       #
-      #   # <script src="https://assets.bookshelf.org/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.js" type="text/javascript"></script>
+      #   # <script src="https://assets.bookshelf.org/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.js"
+      #   #         type="text/javascript"></script>
       #
       # @example Disable Push Promise/Early Hints
       #
       #   <%= javascript 'application', push: false %>
       #   <%= javascript 'http://cdn.example.test/jquery.js', 'dashboard', push: false %>
-      def javascript(*sources, push: true, **options) # rubocop:disable Metrics/MethodLength
+      def javascript(*sources, push: true, **options)
         options = options.reject { |k, _| k.to_sym == :src }
 
         _safe_tags(*sources) do |source|
           attributes = {
-            src:  _typed_asset_path(source, JAVASCRIPT_EXT, push: push, as: :script),
+            src: _typed_asset_path(source, JAVASCRIPT_EXT, push: push, as: :script),
             type: JAVASCRIPT_MIME_TYPE
           }
           attributes.merge!(options)
@@ -247,19 +251,22 @@ module Hanami
       #
       #   <%= stylesheet 'application' %>
       #
-      #   # <link href="/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.css" type="text/css" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
+      #   # <link href="/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.css"
+      #   #       type="text/css" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
       #
       # @example Subresource Integrity for 3rd Party Assets
       #
       #   <%= stylesheet 'https://example.com/assets/example.css', integrity: 'sha384-oqVu...Y8wC' %>
       #
-      #   # <link href="https://example.com/assets/example.css" type="text/css" rel="stylesheet" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
+      #   # <link href="https://example.com/assets/example.css"
+      #   #       type="text/css" rel="stylesheet" integrity="sha384-oqVu...Y8wC" crossorigin="anonymous"></script>
       #
       # @example Absolute URL
       #
       #   <%= stylesheet 'https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css' %>
       #
-      #   # <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css" type="text/css" rel="stylesheet">
+      #   # <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"
+      #   #       type="text/css" rel="stylesheet">
       #
       # @example Fingerprint Mode
       #
@@ -271,20 +278,21 @@ module Hanami
       #
       #   <%= stylesheet 'application' %>
       #
-      #   # <link href="https://assets.bookshelf.org/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.css" type="text/css" rel="stylesheet">
+      #   # <link href="https://assets.bookshelf.org/assets/application-28a6b886de2372ee3922fcaf3f78f2d8.css"
+      #   #       type="text/css" rel="stylesheet">
       #
       # @example Disable Push Promise/Early Hints
       #
       #   <%= stylesheet 'application', push: false %>
       #   <%= stylesheet 'http://cdn.example.test/bootstrap.css', 'dashboard', push: false %>
-      def stylesheet(*sources, push: true, **options) # rubocop:disable Metrics/MethodLength
+      def stylesheet(*sources, push: true, **options)
         options = options.reject { |k, _| k.to_sym == :href }
 
         _safe_tags(*sources) do |source|
           attributes = {
             href: _typed_asset_path(source, STYLESHEET_EXT, push: push, as: :style),
             type: STYLESHEET_MIME_TYPE,
-            rel:  STYLESHEET_REL
+            rel: STYLESHEET_REL
           }
           attributes.merge!(options)
 
@@ -435,7 +443,8 @@ module Hanami
       #
       #   <%= favicon %>
       #
-      #   # <link href="https://assets.bookshelf.org/assets/favicon-28a6b886de2372ee3922fcaf3f78f2d8.ico" rel="shortcut icon" type="image/x-icon">
+      #   # <link href="https://assets.bookshelf.org/assets/favicon-28a6b886de2372ee3922fcaf3f78f2d8.ico"
+      #           rel="shortcut icon" type="image/x-icon">
       #
       # @example Enable Push Promise/Early Hints
       #
@@ -445,7 +454,7 @@ module Hanami
 
         attributes = {
           href: asset_path(source, push: options.delete(:push) || false, as: :image),
-          rel:  FAVICON_REL,
+          rel: FAVICON_REL,
           type: FAVICON_MIME_TYPE
         }
         attributes.merge!(options)
@@ -863,7 +872,7 @@ module Hanami
 
       # @api private
       def _subresource_integrity?
-        !!self.class.assets_configuration.subresource_integrity # rubocop:disable Style/DoubleNegation
+        !!self.class.assets_configuration.subresource_integrity
       end
 
       # @api private
@@ -910,7 +919,7 @@ module Hanami
         end
 
         if !options[:src] && !block_given?
-          raise ArgumentError.new('You should provide a source via `src` option or with a `source` HTML tag')
+          raise ArgumentError.new("You should provide a source via `src` option or with a `source` HTML tag")
         end
 
         options
@@ -920,7 +929,7 @@ module Hanami
       # @api private
       def _push_promise(url, as: nil)
         Thread.current[:__hanami_assets] ||= {}
-        Thread.current[:__hanami_assets][url.to_s] = { as: as, crossorigin: _crossorigin?(url) }
+        Thread.current[:__hanami_assets][url.to_s] = {as: as, crossorigin: _crossorigin?(url)}
 
         url
       end
@@ -931,7 +940,6 @@ module Hanami
         source !~ QUERY_STRING_MATCHER && source !~ /#{Regexp.escape(ext)}\z/
       end
     end
-    # rubocop:enable Naming/UncommunicativeMethodParamName
     # rubocop:enable Metrics/ModuleLength
   end
 end

data/lib/hanami/assets/precompiler.rb

@@ -1,5 +1,7 @@
-require 'fileutils'
-require 'hanami/assets/compiler'
+# frozen_string_literal: true
+
+require "fileutils"
+require "hanami/assets/compiler"
 
 module Hanami
   module Assets
@@ -48,18 +50,18 @@ module Hanami
       # @api private
       def clear_manifest(manifest)
         JSON.parse(manifest).each_value do |asset_hash|
-          asset_file_name = @configuration.public_directory.join(asset_hash['target'])
+          asset_file_name = @configuration.public_directory.join(asset_hash["target"])
           asset_file_name.unlink if asset_file_name.exist?
         end
       rescue JSON::ParserError
-        warn 'Non JSON manifest found and unlinked.'
+        warn "Non JSON manifest found and unlinked."
       ensure
         manifest.unlink
       end
 
       # @since 0.1.0
       # @api private
-      def precompile # rubocop:disable Metrics/MethodLength
+      def precompile
         applications.each do |duplicate|
           config = if duplicate.respond_to?(:configuration)
                      duplicate.configuration

data/lib/hanami/assets/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Hanami
   module Assets
     # Defines the version
     #
     # @since 0.1.0
-    VERSION = '1.3.0'.freeze
+    VERSION = "1.3.5"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hanami-assets
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.5
 platform: ruby
 authors:
 - Luca Guidi
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-10-24 00:00:00.000000000 Z
+date: 2021-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hanami-utils
@@ -64,14 +64,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -143,19 +149,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: sass
+  name: sassc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: coffee-script
   requirement: !ruby/object:Gem::Requirement
@@ -184,6 +190,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.81'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.81'
 description: Assets management for Ruby web applications
 email:
 - me@lucaguidi.com
@@ -229,7 +249,7 @@ homepage: http://hanamirb.org
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -244,9 +264,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
-signing_key: 
+rubygems_version: 3.2.4
+signing_key:
 specification_version: 4
 summary: Assets management
 test_files: []