hana 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4fb4c95fd3541788a19d1c4b9d7bd1931242191a
-  data.tar.gz: 83e628bf62efb6e476121837a710c0d64bfc7590
+  metadata.gz: 54a300a1f4f135540a4c590cf3e7e1b8ad617b4a
+  data.tar.gz: 499cba6697fe8fca1bd5a4788042cb5492ed01d4
 SHA512:
-  metadata.gz: 5b60dc61f8c64a99d6595b7b8e8192b2d1f658a47eab4a74bfca692edc4883dc25979b41bc4a68b3f1a5b02f69f832fdfa9ca744aea279ef7480d836b3ba0463
-  data.tar.gz: 52c58c0d9d5690a9f37c8e24621ae21dba3fd651566730c723c4603ab41c6b843da2f3b13eca22cf31a7bd0eb12e476b1f0c3f5d50a45d4eac57474b0e896480
+  metadata.gz: 50c03edacec8defe7b7e82289a87bfe3c52e77255d019dc96abdc1407be82c9ceb027ebae98bfb2dfb7c2a987d42a73e4ea08e639f5217282de93cabbc856384
+  data.tar.gz: fb38bcb65aedbffa1e1cdf3d109776abcf1a7bf6cba5ca91dd32f41df67983f10438027dffc0f3df632c819ddb3b20e4d6da1af8f1aadf8d486250075df5cb4f

data/lib/hana.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Hana
-  VERSION = '1.3.2'
+  VERSION = '1.3.3'
 
   class Pointer
     include Enumerable
@@ -21,7 +23,7 @@ module Hana
         return nil unless o
 
         if Array === o
-          raise Patch::IndexError unless part =~ /\A\d+\Z/
+          raise Patch::IndexError unless part =~ /\A(?:\d|[1-9]\d+)\Z/
           part = part.to_i
         end
         o[part]
@@ -188,8 +190,11 @@ module Hana
     def rm_op obj, key
       if Array === obj
         raise Patch::IndexError unless key =~ /\A\d+\Z/
-        obj.delete_at key.to_i
+        key = key.to_i
+        raise Patch::OutOfBoundsException if key >= obj.length
+        obj.delete_at key
       else
+        raise Patch::IndexError unless obj.key? key
         obj.delete key
       end
     end

data/test/helper.rb

@@ -12,7 +12,16 @@ module Hana
         tests.each_with_index do |test, i|
           next unless test['doc']
 
-          define_method("test_#{test['comment'] || i }") do
+          method = "test_#{test['comment'] || i }"
+          loop do
+            if method_defined? method
+              method = "test_#{test['comment'] || i } x"
+            else
+              break
+            end
+          end
+
+          define_method(method) do
             skip "disabled" if test['disabled']
 
             doc   = test['doc']
@@ -50,6 +59,10 @@ module Hana
         [Hana::Patch::IndexError, Hana::Patch::ObjectOperationOnArrayException]
       when /bad number$/ then
         [Hana::Patch::IndexError, Hana::Patch::ObjectOperationOnArrayException]
+      when /removing a nonexistent (field|index)/ then
+        [Hana::Patch::IndexError, Hana::Patch::OutOfBoundsException]
+      when /test op should reject the array value, it has leading zeros/ then
+        [Hana::Patch::IndexError]
       when /missing '(from|value)' parameter/ then
         [KeyError]
       when /Unrecognized op 'spam'/ then

data/test/json-patch-tests/tests.json

@@ -383,5 +383,26 @@
     { "comment": "unrecognized op should fail",
       "doc": {"foo": 1},
       "patch": [{"op": "spam", "path": "/foo", "value": 1}],
-      "error": "Unrecognized op 'spam'" }
+      "error": "Unrecognized op 'spam'" },
+
+    { "comment": "test with bad array number that has leading zeros",
+      "doc": ["foo", "bar"],
+      "patch": [{"op": "test", "path": "/00", "value": "foo"}],
+      "error": "test op should reject the array value, it has leading zeros" },
+
+    { "comment": "test with bad array number that has leading zeros",
+      "doc": ["foo", "bar"],
+      "patch": [{"op": "test", "path": "/01", "value": "bar"}],
+      "error": "test op should reject the array value, it has leading zeros" },
+    
+    { "comment": "Removing nonexistent field",
+      "doc": {"foo" : "bar"},
+      "patch": [{"op": "remove", "path": "/baz"}],
+      "error": "removing a nonexistent field should fail" },
+
+    { "comment": "Removing nonexistent index",
+      "doc": ["foo", "bar"],
+      "patch": [{"op": "remove", "path": "/2"}],
+      "error": "removing a nonexistent index should fail" }
+
 ]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hana
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Aaron Patterson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-29 00:00:00.000000000 Z
+date: 2017-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.9'
+        version: '5.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.9'
+        version: '5.10'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.15'
+        version: '3.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.15'
+        version: '3.16'
 description: Implementation of [JSON Patch][1] and [JSON Pointer][2] RFC.
 email:
 - aaron@tenderlovemaking.com
@@ -97,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Implementation of [JSON Patch][1] and [JSON Pointer][2] RFC.