hammer_cli_katello 1.5.0 → 1.5.1

data/test/functional/repository/update_test.rb

@@ -0,0 +1,150 @@
+require_relative '../test_helper'
+require_relative '../organization/organization_helpers'
+require 'hammer_cli_katello/repository'
+
+module HammerCLIKatello # rubocop:disable Metrics/ModuleLength
+  describe Repository::UpdateCommand do
+    include OrganizationHelpers
+
+    it 'allows minimal options' do
+      api_expects(:repositories, :update) do |p|
+        p['id'] == 1 && p['name'] == 'rep1'
+      end
+
+      run_cmd(%w(repository update --id 1 --new-name rep1))
+    end
+
+    describe 'tags docker images' do
+      let(:repo_id) { 3 }
+      let(:tag_name) { "latest" }
+      let(:digest) { "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855" }
+      let(:upload_id) { "1234" }
+      let(:_href) { "/pulp/api/v2/content/uploads/#{upload_id}" }
+      let(:upload_response) do
+        {
+          "upload_id" => upload_id,
+          "_href" => _href
+        }
+      end
+      it "adds a tag to an image" do
+        skip "Until we  https://projects.theforeman.org/issues/34817 is resolved"
+        ex = api_expects(:content_uploads, :create)
+             .with_params('repository_id' => repo_id, :size => 0)
+
+        ex.returns(upload_response)
+        ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+              .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true,
+                           :uploads => [{
+                             :id => '1234',
+                             :name => tag_name,
+                             :digest => digest
+                           }],
+                           :content_type => "docker_tag"
+                          )
+
+        ex2.returns("")
+
+        ex3 = api_expects(:content_uploads, :destroy, "Delete the upload")
+              .with_params('id' => upload_id, 'repository_id' => repo_id)
+
+        ex3.returns("")
+        # rubocop:disable LineLength
+        result = run_cmd(%W(repository update --id #{repo_id} --docker-tag #{tag_name} --docker-digest #{digest}))
+        # rubocop:enable LineLength
+        assert_equal(result.exit_code, 0)
+      end
+    end
+
+    describe 'resolves repository ID' do
+      it 'by requiring product' do
+        api_expects_no_call
+        result = run_cmd(%w(repository update --name repo1 --new-name rep1))
+        assert(result.err[/--product, --product-id is required/], 'Incorrect error message')
+      end
+
+      it 'by product ID' do
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        api_expects(:repositories, :update) do |p|
+          p['id'] == 1 && p['name'] == 'rep1'
+        end
+
+        run_cmd(%w(repository update --name repo1 --product-id 3 --new-name rep1))
+      end
+    end
+
+    describe 'resolves product ID' do
+      it 'by requiring organization options' do
+        api_expects_no_call
+        result = run_cmd(%w(repository update --name repo1 --product prod1 --new-name rep1))
+        assert(result.err[/--organization-id, --organization, --organization-label is required/],
+               "Organization option requirements must be validated")
+      end
+
+      it 'by organization ID' do
+        ex = api_expects(:products, :index) do |p|
+          p['name'] == 'prod3' && p['organization_id'] == '5'
+        end
+        ex.returns(index_response([{'id' => 3}]))
+
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        api_expects(:repositories, :update) do |p|
+          p['id'] == 1 && p['name'] == 'rep1'
+        end
+
+        run_cmd(%w(repository update --name repo1 --product prod3 --organization-id 5
+                   --new-name rep1))
+      end
+
+      it 'by organization name' do
+        expect_organization_search('org5', 5)
+
+        ex = api_expects(:products, :index) do |p|
+          p['name'] == 'prod3' && p['organization_id'] == 5
+        end
+        ex.returns(index_response([{'id' => 3}]))
+
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        api_expects(:repositories, :update) do |p|
+          p['id'] == 1 && p['name'] == 'rep1'
+        end
+
+        run_cmd(%w(repository update --name repo1 --product prod3 --organization org5
+                   --new-name rep1))
+      end
+
+      it 'by organization label' do
+        expect_organization_search('org5', 5, field: 'label')
+
+        ex = api_expects(:products, :index) do |p|
+          p['name'] == 'prod3' && p['organization_id'] == 5
+        end
+        ex.returns(index_response([{'id' => 3}]))
+
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        api_expects(:repositories, :update) do |p|
+          p['id'] == 1 && p['name'] == 'rep1'
+        end
+
+        run_cmd(%w(repository update --name repo1 --product prod3 --organization-label org5
+                   --new-name rep1))
+      end
+    end
+  end
+end
+# rubocop:enable ModuleLength

data/test/functional/repository/upload_test.rb

@@ -0,0 +1,368 @@
+require File.join(File.dirname(__FILE__), '../test_helper')
+require File.join(File.dirname(__FILE__), '../product/product_helpers')
+require File.join(File.dirname(__FILE__), './repository_helpers')
+
+describe 'upload repository' do
+  include ProductHelpers
+  include RepositoryHelpers
+  include ForemanTaskHelpers
+
+  before do
+    @cmd = %w(repository upload-content)
+  end
+
+  let(:org_id) { 1 }
+  let(:product_id) { 2 }
+  let(:repo_id) { 3 }
+  let(:path) { "./test.rpm" }
+  let(:upload_id) { "1234" }
+  let(:_href) { "/pulp/api/v2/content/uploads/#{upload_id}" }
+  let(:task_id) { "2ea4f" }
+  let(:upload_response) do
+    {
+      "upload_id" => upload_id,
+      "href" => _href
+    }
+  end
+  let(:import_uploads_response) do
+    {
+      "id" => task_id
+    }
+  end
+
+  it "uploads a package" do
+    file = File.new("test.rpm", "w")
+
+    params = ["--id=#{repo_id}", "--path=#{path}"]
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params('repository_id' => repo_id, :size => file.size)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+          .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :async => true,
+                       :uploads => [{
+                         :id => '1234',
+                         :name => 'test.rpm',
+                         :size => 0,
+                         :content_unit_id => nil,
+                         :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                       }]
+                      )
+    # rubocop:enable LineLength
+
+    ex2.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+    expect_foreman_task(task_id)
+
+    ex3 = api_expects(:content_uploads, :destroy, "Delete the upload")
+          .with_params('id' => upload_id, 'repository_id' => repo_id)
+
+    ex3.returns("")
+    result = run_cmd(@cmd + params)
+
+    assert_equal(result.exit_code, 0)
+    File.delete("test.rpm")
+  end
+
+  it "uploads srpm with content-type" do
+    file = File.new("test.src.rpm", "w")
+    params = ["--id=#{repo_id}", '--path=./test.src.rpm', '--content-type=srpm']
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params('repository_id' => repo_id, :content_type => 'srpm', :size => file.size)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+          .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :content_type => 'srpm', :async => true,
+                       :uploads => [{
+                         :id => '1234',
+                         :name => 'test.src.rpm',
+                         :size => 0,
+                         :content_unit_id => nil,
+                         :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                       }]
+                      )
+    # rubocop:enable LineLength
+
+    ex2.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+    expect_foreman_task(task_id)
+
+    ex3 = api_expects(:content_uploads, :destroy, "Delete the upload")
+          .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex3.returns("")
+
+    result = run_cmd(@cmd + params)
+    assert_equal(result.exit_code, 0)
+    File.delete("test.src.rpm")
+  end
+
+  it 'fails upload of srpm with no content-type' do
+    file = File.new("test.src.rpm", "w")
+
+    params = ["--id=#{repo_id}", '--path=./test.src.rpm']
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params('repository_id' => repo_id, :size => file.size)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+          .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :async => true,
+                       :uploads => [{
+                         :id => '1234',
+                         :name => 'test.src.rpm',
+                         :size => 0,
+                         :content_unit_id => nil,
+                         :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                       }]
+                      )
+    # rubocop:enable LineLength
+
+    ex2.returns(400)
+
+    ex3 = api_expects(:content_uploads, :destroy, "Delete the upload")
+          .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex3.returns("")
+
+    result = run_cmd(@cmd + params)
+    assert_equal(result.exit_code, 70)
+    File.delete("test.src.rpm")
+  end
+
+  it "uploads a docker image" do
+    file = File.new("test.rpm", "w")
+
+    params = ["--id=#{repo_id}", "--path=#{path}"]
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params(:repository_id => repo_id, :size => file.size)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+          .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :async => true,
+                       :uploads => [{
+                         :id => '1234',
+                         :name => 'test.rpm',
+                         :size => 0,
+                         :content_unit_id => nil,
+                         :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                       }]
+                      )
+    # rubocop:enable LineLength
+
+    ex2.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+
+    ex3 = api_expects(:foreman_tasks, :show, 'Show task')
+    ex3.returns('id' => task_id, 'state' => 'stopped', 'progress' => 1,
+                'humanized' => {'output' => {'upload_results' => [{'type' => 'docker_manifest',
+                                                                   'digest' => 'sha256:1234'}]},
+                                'errors' => ''})
+
+    ex4 = api_expects(:content_uploads, :destroy, "Delete the upload")
+          .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex4.returns("")
+
+    result = run_cmd(@cmd + params)
+    assert_equal(result.exit_code, 0)
+    File.delete("test.rpm")
+  end
+
+  it "uploads a package with an organization-id" do
+    file = File.new("test.rpm", "w")
+
+    params = ["--name=test_repo", "--product=test_product", "--organization-id=#{org_id}",
+              "--path=#{path}"]
+
+    expect_product_search(org_id, 'test_product', product_id)
+
+    expect_repository_search(product_id, 'test_repo', repo_id)
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params(:repository_id => repo_id, :size => file.size)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+          .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :async => true,
+                       :uploads => [{
+                         :id => '1234',
+                         :name => 'test.rpm',
+                         :size => 0,
+                         :content_unit_id => nil,
+                         :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                       }]
+                      )
+    # rubocop:enable LineLength
+
+    ex2.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+    expect_foreman_task(task_id)
+
+    ex3 = api_expects(:content_uploads, :destroy, "Delete the upload")
+          .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex3.returns("")
+
+    result = run_cmd(@cmd + params)
+    assert_equal(result.exit_code, 0)
+    File.delete("test.rpm")
+  end
+
+  it "supports globs" do
+    file = File.new("test.rpm", "w")
+
+    params = ["--id=#{repo_id}", "--path={test}.[r{1}]pm"]
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params(:repository_id => repo_id, :size => file.size)
+
+    ex.returns(upload_response)
+    # rubocop:disable LineLength
+    ex2 = api_expects(:repositories, :import_uploads, 'Take in an upload')
+          .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :async => true,
+                       :uploads => [{
+                         :id => '1234',
+                         :name => 'test.rpm',
+                         :size => 0,
+                         :content_unit_id => nil,
+                         :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                       }]
+                      )
+    # rubocop:enable LineLength
+    ex2.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+    expect_foreman_task(task_id)
+
+    ex3 = api_expects(:content_uploads, :destroy, "Delete the upload")
+          .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex3.returns("")
+
+    result = run_cmd(@cmd + params)
+    assert_equal(result.exit_code, 0)
+    File.delete("test.rpm")
+  end
+
+  it "only syncs the capsule on the last file import" do
+    File.new("test1.rpm", "w")
+    File.new("test2.rpm", "w")
+
+    params = ["--id=#{repo_id}", "--path=test*.rpm"]
+
+    # Begin first upload cycle
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params(:repository_id => repo_id)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex = api_expects(:repositories, :import_uploads, 'Take in an upload')
+         .with_params(:id => repo_id, :sync_capsule => false, :publish_repository => false, :async => true,
+                      :uploads => [{
+                        :id => '1234',
+                        :name => 'test1.rpm',
+                        :size => 0,
+                        :content_unit_id => nil,
+                        :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                      }]
+                     )
+    # rubocop:enable LineLength
+
+    ex.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+    expect_foreman_task(task_id)
+
+    ex = api_expects(:content_uploads, :destroy, "Delete the upload")
+         .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex.returns("")
+
+    # Begin second upload cycle
+
+    ex = api_expects(:content_uploads, :create, "Create upload for content")
+         .with_params(:repository_id => repo_id)
+
+    ex.returns(upload_response)
+
+    # rubocop:disable LineLength
+    ex = api_expects(:repositories, :import_uploads, 'Take in an upload')
+         .with_params(:id => repo_id, :sync_capsule => true, :publish_repository => true, :async => true,
+                      :uploads => [{
+                        :id => '1234',
+                        :name => 'test2.rpm',
+                        :size => 0,
+                        :content_unit_id => nil,
+                        :checksum => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855'
+                      }]
+                     )
+    # rubocop:enable LineLength
+
+    ex.returns(import_uploads_response)
+    expect_foreman_task(task_id)
+    expect_foreman_task(task_id)
+
+    ex = api_expects(:content_uploads, :destroy, "Delete the upload")
+         .with_params(:id => upload_id, :repository_id => repo_id)
+
+    ex.returns("")
+
+    result = run_cmd(@cmd + params)
+    assert_equal(result.exit_code, 0)
+    File.delete("test1.rpm")
+    File.delete("test2.rpm")
+  end
+
+  it "errors if there are no matching files" do
+    params = ["--id=#{repo_id}", "--path=#{path}"]
+
+    result = run_cmd(@cmd + params)
+
+    assert_equal "Could not find any files matching PATH\n", result.err
+    assert_equal HammerCLI::EX_NOINPUT, result.exit_code
+  end
+
+  describe 'requires' do
+    it 'repository options' do
+      api_expects_no_call
+      error = run_cmd(@cmd + %W(--path #{path})).err
+      assert error.include?('--id, --name is required'), "Actual result: #{error}"
+    end
+
+    it 'product options when repository name is specified' do
+      api_expects_no_call
+      error = run_cmd(@cmd + %W(--name repo1 --path #{path})).err
+      assert(error.include?('--product, --product-id is required'), "Actual result: #{error}")
+    end
+
+    it 'organization options when product name is specified' do
+      api_expects_no_call
+      error = run_cmd(@cmd + %W(--name repo1 --product product2 --path #{path})).err
+      assert(error.include?('--organization-id, --organization, --organization-label is required'),
+             "Actual result: #{error}")
+    end
+  end
+
+  describe 'disallows' do
+    it 'product options when repository ID is specified' do
+      api_expects_no_call
+      error = run_cmd(@cmd + %W(--id 1 --product product2 --path #{path})).err
+      assert(error.include?('Cannot specify both product options and repository ID'),
+             "Actual result: #{error}")
+    end
+  end
+end

data/test/functional/repository_set/available_repositories_test.rb

@@ -0,0 +1,18 @@
+require_relative '../test_helper'
+require 'hammer_cli_katello/repository_set'
+
+module HammerCLIKatello
+  describe RepositorySetCommand::AvailableRepositoriesCommand do
+    it 'allows minimal options' do
+      api_expects(:repository_sets, :available_repositories)
+        .with_params('id' => 1)
+        .returns(index_response([]))
+      assert_success run_cmd(%w(repository-set available-repositories --id 1))
+    end
+
+    it 'requires repository set options' do
+      api_expects_no_call
+      assert_failure run_cmd(%w(repository-set available-repositories)), /id.*name.*required/
+    end
+  end
+end

data/test/functional/repository_set/disable_test.rb

@@ -0,0 +1,48 @@
+require_relative '../test_helper'
+require_relative './repository_set_helpers'
+require 'hammer_cli_katello/repository_set'
+
+module HammerCLIKatello
+  describe RepositorySetCommand::DisableCommand do
+    include RepositorySetHelpers
+
+    it 'allows minimal options' do
+      api_expects(:repository_sets, :disable)
+        .with_params('id' => 1)
+      assert_success run_cmd(%w(repository-set disable --id 1))
+    end
+
+    it 'requires repository set options' do
+      api_expects_no_call
+      assert_failure run_cmd(%w(repository-set disable)), /id.*name.*required/
+    end
+
+    describe 'resolves repository set ID' do
+      it 'by requiring organization or product options' do
+        api_expects_no_call
+        assert_failure run_cmd(%w(repository-set disable --name reposet1)),
+          /organization.*product.*required/
+      end
+
+      it 'from organization options' do
+        expect_repository_set_search('reposet1', 1, organization_id: 2)
+        api_expects(:repository_sets, :disable)
+          .with_params('id' => 1)
+        assert_success run_cmd(%w(repository-set disable --name reposet1 --organization-id 2))
+      end
+
+      it 'from product options' do
+        repo_id = 1001
+        product_id = 3
+        api_expects(:repositories, :index, 'Find a repository')
+          .with_params('product_id' => product_id)
+          .returns(index_response([{'id' => repo_id}]))
+
+        expect_repository_set_search('reposet1', 1, product_id: 3)
+        api_expects(:repository_sets, :disable)
+          .with_params('id' => 1, 'repository_id' => repo_id)
+        assert_success run_cmd(%w(repository-set disable --name reposet1 --product-id 3))
+      end
+    end
+  end
+end

data/test/functional/repository_set/enable_test.rb

@@ -0,0 +1,42 @@
+require_relative '../test_helper'
+require_relative './repository_set_helpers'
+require 'hammer_cli_katello/repository_set'
+
+module HammerCLIKatello
+  describe RepositorySetCommand::EnableCommand do
+    include RepositorySetHelpers
+
+    it 'allows minimal options' do
+      api_expects(:repository_sets, :enable)
+        .with_params('id' => 1)
+      assert_success run_cmd(%w(repository-set enable --id 1))
+    end
+
+    it 'requires repository set options' do
+      api_expects_no_call
+      assert_failure run_cmd(%w(repository-set enable)), /id.*name.*required/
+    end
+
+    describe 'resolves repository set ID' do
+      it 'by requiring organization or product options' do
+        api_expects_no_call
+        assert_failure run_cmd(%w(repository-set enable --name reposet1)),
+          /organization.*product.*required/
+      end
+
+      it 'from organization options' do
+        expect_repository_set_search('reposet1', 1, organization_id: 2)
+        api_expects(:repository_sets, :enable)
+          .with_params('id' => 1)
+        assert_success run_cmd(%w(repository-set enable --name reposet1 --organization-id 2))
+      end
+
+      it 'from product options' do
+        expect_repository_set_search('reposet1', 1, product_id: 3)
+        api_expects(:repository_sets, :enable)
+          .with_params('id' => 1)
+        assert_success run_cmd(%w(repository-set enable --name reposet1 --product-id 3))
+      end
+    end
+  end
+end

data/test/functional/repository_set/info_test.rb

@@ -0,0 +1,17 @@
+require_relative '../test_helper'
+require 'hammer_cli_katello/repository_set'
+
+module HammerCLIKatello
+  describe RepositorySetCommand::InfoCommand do
+    it 'allows minimal options' do
+      api_expects(:repository_sets, :show)
+        .with_params('id' => 1)
+      assert_success run_cmd(%w(repository-set info --id 1))
+    end
+
+    it 'requires repository set options' do
+      api_expects_no_call
+      assert_failure run_cmd(%w(repository-set info)), /id.*name.*required/
+    end
+  end
+end

data/test/functional/repository_set/list_test.rb

@@ -0,0 +1,18 @@
+require_relative '../test_helper'
+require 'hammer_cli_katello/repository_set'
+
+module HammerCLIKatello
+  describe RepositorySetCommand::ListCommand do
+    it 'allows minimal options' do
+      api_expects(:repository_sets, :index)
+        .with_params('organization_id' => 1)
+        .returns(index_response([]))
+      assert_success run_cmd(%w(repository-set list --organization-id 1))
+    end
+
+    it 'requires organization options' do
+      api_expects_no_call
+      assert_failure run_cmd(%w(repository-set list)), /organization.*required/
+    end
+  end
+end

data/test/functional/repository_set/repository_set_helpers.rb

@@ -0,0 +1,20 @@
+require_relative '../search_helpers'
+
+module RepositorySetHelpers
+  include SearchHelpers
+
+  def expect_repository_set_search(name, id, organization_id: nil, product_id: nil)
+    params = {'name' => name}
+    params.merge(organization_id: organization_id) if organization_id.nil?
+    params.merge(product_id: product_id) if product_id.nil?
+    expect_generic_repository_sets_search(
+      params: params,
+      returns: {'id' => id})
+  end
+
+  def expect_generic_repository_sets_search(params: {}, returns: [])
+    api_expects(:repository_sets, :index, 'Find repository sets')
+      .with_params(params)
+      .returns(index_response(returns))
+  end
+end