hammer_cli_katello 0.3.0 → 0.10.0

data/test/functional/host_collection/content_remove_test.rb

@@ -1,27 +1,37 @@
 require_relative '../test_helper'
+require_relative './content_api_expectations'
 require 'hammer_cli_katello/host_collection'
 
 module HammerCLIKatello
   describe HostCollection::RemoveContentBaseCommand do
-    it 'removes packages from hosts in a host collection' do
-      api_expects(:hosts_bulk_actions, :remove_content) do |p|
-        p['organization_id'] == 1 &&
-          p['included'] == { search: "host_collection_id=\"3\"" } &&
-          p['content'] == ['wget']
-      end
+    include HammerCLIKatello::ContentAPIExpectations
+
+    def api_expects_content_remove(content_type, expected_params)
+      api_expects_content_action(:remove_content, content_type, expected_params)
+    end
 
+    it 'removes packages from hosts in a host collection' do
+      api_expects_content_remove('package', :content => ['wget'])
       run_cmd(%w(host-collection package remove --id 3 --packages wget --organization-id 1))
     end
 
-    it 'removes package groups from hosts in a host collection' do
-      api_expects(:hosts_bulk_actions, :remove_content) do |p|
-        p['organization_id'] == 1 &&
-          p['included'] == { search: "host_collection_id=\"3\"" } &&
-          p['content'] == ['birds']
-      end
+    it 'removes packages from hosts in a host collection specified by name' do
+      api_expects_collection_search
+      api_expects_content_remove('package', :content => ['wget'])
+      run_cmd(%w(host-collection package remove --name Test --packages wget --organization-id 1))
+    end
 
+    it 'removes package groups from hosts in a host collection' do
+      api_expects_content_remove('package_group', :content => ['birds'])
       run_cmd(%w(host-collection package-group remove --id 3
                  --package-groups birds --organization-id 1))
     end
+
+    it 'removes package groups from hosts in a host collection specified by name' do
+      api_expects_collection_search
+      api_expects_content_remove('package_group', :content => ['birds'])
+      run_cmd(%w(host-collection package-group remove --name Test
+                 --package-groups birds --organization-id 1))
+    end
   end
 end

data/test/functional/host_collection/content_update_test.rb

@@ -1,27 +1,37 @@
 require_relative '../test_helper'
+require_relative './content_api_expectations'
 require 'hammer_cli_katello/host_collection'
 
 module HammerCLIKatello
   describe HostCollection::UpdateContentBaseCommand do
-    it 'updates packages on hosts in a host collection' do
-      api_expects(:hosts_bulk_actions, :update_content) do |p|
-        p['organization_id'] == 1 &&
-          p['included'] == { search: "host_collection_id=\"3\"" } &&
-          p['content'] == ['wget']
-      end
+    include HammerCLIKatello::ContentAPIExpectations
+
+    def api_expects_content_update(content_type, expected_params)
+      api_expects_content_action(:update_content, content_type, expected_params)
+    end
 
+    it 'updates packages on hosts in a host collection' do
+      api_expects_content_update('package', :content => ['wget'])
       run_cmd(%w(host-collection package update --id 3 --packages wget --organization-id 1))
     end
 
-    it 'updates package groups on hosts in a host collection' do
-      api_expects(:hosts_bulk_actions, :update_content) do |p|
-        p['organization_id'] == 1 &&
-          p['included'] == { search: "host_collection_id=\"3\"" } &&
-          p['content'] == ['birds']
-      end
+    it 'updates packages on hosts in a host collection specified by name' do
+      api_expects_collection_search
+      api_expects_content_update('package', :content => ['wget'])
+      run_cmd(%w(host-collection package update --name Test --packages wget --organization-id 1))
+    end
 
+    it 'updates package groups on hosts in a host collection' do
+      api_expects_content_update('package_group', :content => ['birds'])
       run_cmd(%w(host-collection package-group update --id 3
                  --package-groups birds --organization-id 1))
     end
+
+    it 'updates package groups on hosts in a host collection specified by name' do
+      api_expects_collection_search
+      api_expects_content_update('package_group', :content => ['birds'])
+      run_cmd(%w(host-collection package-group update --name Test
+                 --package-groups birds --organization-id 1))
+    end
   end
 end

data/test/functional/hostgroup/create_test.rb

@@ -31,6 +31,12 @@ module HammerCLIForeman
         run_cmd(%w(hostgroup create --name hg1 --content-view cv1 --query-organization-id 1))
       end
 
+      it 'requires organization options to resolve content view name' do
+        api_expects_no_call
+        result = run_cmd(%w(hostgroup create --name hg1 --content-view cv1))
+        assert_match(/--query-organization/, result.err)
+      end
+
       it 'allows lifecycle environment id' do
         api_expects(:hostgroups, :create) do |p|
           p['hostgroup']['name'] == 'hg1' && p['hostgroup']['lifecycle_environment_id'] == 1 &&

data/test/functional/hostgroup/data/hostgroup.json

@@ -1,6 +1,6 @@
 {
-	"content_source_id":null,
-	"content_source_name":null,
+	"content_source_id":1,
+	"content_source_name":"foreman.example.com",
 	"content_view_id":1,
 	"content_view_name":"Default Organization View",
 	"lifecycle_environment_id":1,

data/test/functional/hostgroup/info_test.rb

@@ -21,7 +21,8 @@ module HammerCLIForeman
 
         result = run_cmd(@cmd + params)
         expected_fields = [['Lifecycle Environment', 'Library'],
-                           ['Content View', 'Default Organization View']]
+                           ['Content View', 'Default Organization View'],
+                           ['Content Source', 'foreman.example.com']]
         expected_results = expected_fields.map { |field| success_result(FieldMatcher.new(*field)) }
         expected_results.each { |expected|  assert_cmd(expected, result) }
       end

data/test/functional/hostgroup/update_test.rb

@@ -31,6 +31,12 @@ module HammerCLIForeman
         run_cmd(%w(hostgroup update --id 1 --content-view cv1 --query-organization-id 1))
       end
 
+      it 'requires organization options to resolve content view name' do
+        api_expects_no_call
+        result = run_cmd(%w(hostgroup update --id 1 --content-view cv1))
+        assert_match(/--query-organization/, result.err)
+      end
+
       it 'allows lifecycle environment id' do
         api_expects(:hostgroups, :update) do |p|
           p['id'] == '1' && p['hostgroup']['lifecycle_environment_id'] == 1 &&
@@ -56,6 +62,12 @@ module HammerCLIForeman
         result = run_cmd(%w(hostgroup update --name hg1 --lifecycle-environment le1))
         assert_match(/--query-organization/, result.err)
       end
+
+      it 'requires organization options to resolve lifecycle environment name' do
+        api_expects_no_call
+        result = run_cmd(%w(hostgroup update --id 1 --lifecycle-environment le1))
+        assert_match(/--query-organization/, result.err)
+      end
     end
   end
 end

data/test/functional/package/list_test.rb

@@ -1,47 +1,118 @@
 require_relative '../test_helper'
+require_relative '../repository/repository_helpers'
+require_relative '../product/product_helpers'
+require_relative '../organization/organization_helpers'
 require 'hammer_cli_katello/package'
 
 module HammerCLIKatello
   describe PackageCommand::ListCommand do
+    include OrganizationHelpers
+    include RepositoryHelpers
+    include ProductHelpers
+
     it 'allows minimal options' do
       api_expects(:packages, :index)
 
       run_cmd(%w(package list))
     end
 
-    describe 'organization options' do
-      it 'can be provided by organization ID' do
+    describe 'repository options' do
+      it 'may be specified by ID' do
         api_expects(:packages, :index) do |params|
-          params['organization_id'] == 1
+          params['repository_id'] == 1
         end
 
-        run_cmd(%w(package list --organization-id 1))
+        run_cmd(%w(package list --repository-id 1))
       end
 
-      it 'can be provided by organization name' do
-        ex = api_expects(:organizations, :index) do |params|
-          params[:search] == "name = \"org1\""
-        end
-        ex.at_least_once.returns(index_response([{'id' => 1}]))
+      it 'require product ID when given repository name' do
+        api_expects_no_call
+
+        r = run_cmd(%w(package list --repository repo1))
+        assert(r.err.include?("--product-id, --product is required"), "Invalid error message")
+      end
+
+      it 'may be specified by name and product ID' do
+        expect_repository_search(2, 'repo1', 1)
 
         api_expects(:packages, :index) do |params|
-          params['organization_id'] == 1
+          params['repository_id'] == 1
         end
 
-        run_cmd(%w(package list --organization org1))
+        run_cmd(%w(package list --repository repo1 --product-id 2))
       end
+    end
 
-      it 'can be provided by organization label' do
-        ex = api_expects(:organizations, :index) do |params|
-          params[:search] == "label = \"org1\""
+    describe 'product options' do
+      it 'may be specified by ID' do
+        ex = api_expects(:repositories, :index) do |p|
+          p['product_id'] == 1
         end
-        ex.at_least_once.returns(index_response([{'id' => 1}]))
+        ex.returns(index_response([{'id' => 2}]))
 
-        api_expects(:packages, :index) do |params|
-          params['organization_id'] == 1
+        api_expects(:packages, :index) do |p|
+          p['repository_id'] = 2
+        end
+
+        run_cmd(%w(package list --product-id 1))
+      end
+
+      it 'fail if more than one repository is found' do
+        ex = api_expects(:repositories, :index) do |p|
+          p['product_id'] == 1
+        end
+        ex.returns(index_response([{'id' => 2}, {'id' => 3}]))
+
+        r = run_cmd(%w(package list --product-id 1))
+        assert(r.err.include?("found more than one repository"), "Invalid error message")
+      end
+
+      it 'requires organization options to resolve ID by name' do
+        api_expects_no_call
+
+        r = run_cmd(%w(package list --product product1))
+        expected_error = "--organization-id, --organization, --organization-label is required"
+        assert(r.err.include?(expected_error), "Invalid error message")
+      end
+
+      it 'allows organization ID when resolving ID by name' do
+        expect_product_search(3, 'product1', 1)
+
+        expect_repository_search(1, nil, 2)
+
+        api_expects(:packages, :index) do |p|
+          p['repository_id'] = 2
+        end
+
+        run_cmd(%w(package list --product product1 --organization-id 3))
+      end
+
+      it 'allows organization name when resolving ID by name' do
+        expect_organization_search('org3', 3)
+
+        expect_product_search(3, 'product1', 1)
+
+        expect_repository_search(1, nil, 2)
+
+        api_expects(:packages, :index) do |p|
+          p['repository_id'] = 2
+        end
+
+        run_cmd(%w(package list --product product1 --organization org3))
+      end
+
+      it 'allows organization label when resolving ID by name' do
+        expect_organization_search('org3', 3, field: 'label')
+
+        expect_product_search(3, 'product1', 1)
+
+        expect_repository_search(1, nil, 2)
+
+        api_expects(:packages, :index) do |p|
+          p['repository_id'] = 2
         end
 
-        run_cmd(%w(package list --organization-label org1))
+        run_cmd(%w(package list --product product1 --organization-label org3))
       end
     end
   end

data/test/functional/package_group/list_test.rb

@@ -0,0 +1,33 @@
+require_relative '../test_helper'
+require 'hammer_cli_katello/package_group'
+
+module HammerCLIKatello
+  describe PackageGroupCommand::ListCommand do
+    it 'allows minimal options' do
+      api_expects(:package_groups, :index)
+
+      run_cmd(%w(package-group list))
+    end
+
+    it 'can be provided by repository ID' do
+      api_expects(:package_groups, :index) do |params|
+        params['repository_id'] == 1
+      end
+
+      run_cmd(%w(package-group list --repository-id 1))
+    end
+
+    it 'can be provided by repository name' do
+      ex = api_expects(:repositories, :index) do |params|
+        params['name'] = 'Repo'
+      end
+      ex.returns(index_response([{'id' => 1}]))
+
+      api_expects(:package_groups, :index) do |params|
+        params['repository_id'] == 1
+      end
+
+      run_cmd(%w(package-group list --repository Repo))
+    end
+  end
+end

data/test/functional/repository/export_test.rb

@@ -0,0 +1,121 @@
+require_relative '../test_helper'
+require_relative '../organization/organization_helpers'
+require 'hammer_cli_katello/repository'
+
+module HammerCLIKatello
+  describe Repository::ExportCommand do
+    include ForemanTaskHelpers
+    include OrganizationHelpers
+
+    it 'allows minimal options' do
+      ex = api_expects(:repositories, :export) do |p|
+        p['id'] == '1'
+      end
+      ex.returns(id: 2)
+
+      expect_foreman_task('2')
+
+      run_cmd(%w(repository export --id 1))
+    end
+
+    describe 'resolves repository ID' do
+      it 'by requiring product' do
+        api_expects_no_call
+        result = run_cmd(%w(repository export --name repo1))
+        assert(result.err[/--product, --product-id is required/], 'Incorrect error message')
+      end
+
+      it 'by product ID' do
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        ex = api_expects(:repositories, :export) do |p|
+          p['id'] == 1
+        end
+        ex.returns(id: 2)
+
+        expect_foreman_task('2')
+
+        run_cmd(%w(repository export --name repo1 --product-id 3))
+      end
+    end
+
+    describe 'resolves product ID' do
+      it 'by requiring organization options' do
+        api_expects_no_call
+        result = run_cmd(%w(repository export --name repo1 --product prod1))
+        assert(result.err[/--organization-id, --organization, --organization-label is required/],
+               "Organization option requirements must be validated")
+      end
+
+      it 'by organization ID' do
+        ex = api_expects(:products, :index) do |p|
+          p['name'] == 'prod3' && p['organization_id'] == '5'
+        end
+        ex.returns(index_response([{'id' => 3}]))
+
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        ex = api_expects(:repositories, :export) do |p|
+          p['id'] == 1
+        end
+        ex.returns(id: 2)
+
+        expect_foreman_task('2')
+
+        run_cmd(%w(repository export --name repo1 --product prod3 --organization-id 5))
+      end
+
+      it 'by organization name' do
+        expect_organization_search('org5', 5)
+
+        ex = api_expects(:products, :index) do |p|
+          p['name'] == 'prod3' && p['organization_id'] == 5
+        end
+        ex.returns(index_response([{'id' => 3}]))
+
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        ex = api_expects(:repositories, :export) do |p|
+          p['id'] == 1
+        end
+        ex.returns(id: 2)
+
+        expect_foreman_task('2')
+
+        run_cmd(%w(repository export --name repo1 --product prod3 --organization org5))
+      end
+
+      it 'by organization label' do
+        expect_organization_search('org5', 5, field: 'label')
+
+        ex = api_expects(:products, :index) do |p|
+          p['name'] == 'prod3' && p['organization_id'] == 5
+        end
+        ex.returns(index_response([{'id' => 3}]))
+
+        ex = api_expects(:repositories, :index) do |p|
+          p['name'] == 'repo1' && p['product_id'] == 3
+        end
+        ex.returns(index_response([{'id' => 1}]))
+
+        ex = api_expects(:repositories, :export) do |p|
+          p['id'] == 1
+        end
+        ex.returns(id: 2)
+
+        expect_foreman_task('2')
+
+        run_cmd(%w(repository export --name repo1 --product prod3 --organization-label org5))
+      end
+    end
+  end
+end