hammer_cli_foreman_ansible 0.3.2 → 0.4.0

data/test/functional/host_test.rb

@@ -0,0 +1,200 @@
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+describe 'host' do
+  let(:ansible_role_1) do
+    {
+      'id' => 1,
+      'name' => 'role1',
+      'inherited' => false,
+      'directly_assigned' => true
+    }
+  end
+  let(:ansible_role_2) do
+    {
+      'id' => 2,
+      'name' => 'role2',
+      'inherited' => true,
+      'directly_assigned' => false
+    }
+  end
+  let(:ansible_roles) do
+    [
+      ansible_role_1,
+      ansible_role_2
+    ]
+  end
+
+  describe 'add ansible role' do
+    let(:cmd) { %w[host ansible-roles add] }
+
+    it 'requires host --id' do
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --name, --id is required.',
+        'Could not associate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'requires host id and asnible role id' do
+      params = %w[--id=1]
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --ansible-role, --ansible-role-id is required.',
+        'Could not associate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'associates ansible role with host' do
+      params = %w[--id=1 --ansible-role-id=2]
+
+      api_expects(:hosts, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns([ansible_role_1])
+
+      api_expects(:hosts, :update) do |par|
+        par['id'] == '1' &&
+          par['host']['ansible_role_ids'] == %w[1 2]
+      end
+
+      result = run_cmd(cmd + params)
+      assert_cmd(success_result("Ansible role has been associated.\n"), result)
+    end
+
+    it 'raises an error on associating an inherited ansible role to host' do
+      params = %w[--id=1 --ansible-role-id=2]
+      expected_result = CommandExpectation.new
+      expected_result.expected_err = [
+        'Could not associate the Ansible role:',
+        '  Ansible role role2 is already inherited from a host group. Please use --force for direct association.',
+        ''
+      ].join("\n")
+      expected_result.expected_exit_code = HammerCLI::EX_USAGE
+
+      api_expects(:hosts, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'associates inherited ansible role with host' do
+      params = %w[--id=1 --ansible-role-id=2 --force]
+
+      api_expects(:hosts, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects(:hosts, :update) do |par|
+        par['id'] == '1' &&
+          par['host']['ansible_role_ids'] == %w[1 2]
+      end
+
+      result = run_cmd(cmd + params)
+      assert_cmd(success_result("Ansible role has been associated.\n"), result)
+    end
+  end
+
+  describe 'remove ansible role' do
+    let(:cmd) { %w[host ansible-roles remove] }
+
+    it 'requires host --id' do
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --name, --id is required.',
+        'Could not disassociate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'requires host id and asnible role id' do
+      params = %w[--id=1]
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --ansible-role, --ansible-role-id is required.',
+        'Could not disassociate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'disassociates ansible role from host' do
+      params = %w[--id=1 --ansible-role-id=1]
+
+      api_expects(:hosts, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects(:hosts, :update) do |par|
+        par['id'] == '1' &&
+          par['host']['ansible_role_ids'] == %w[]
+      end
+
+      result = run_cmd(cmd + params)
+      assert_cmd(success_result("Ansible role has been disassociated.\n"), result)
+    end
+
+    it 'raises an error on disassociating an inherited ansible role from host by id' do
+      params = %w[--id=1 --ansible-role-id=2]
+      expected_result = CommandExpectation.new
+      expected_result.expected_err = [
+        'Could not disassociate the Ansible role:',
+        '  Ansible role role2 is not assigned directly and cannot be removed.',
+        ''
+      ].join("\n")
+      expected_result.expected_exit_code = HammerCLI::EX_USAGE
+
+      api_expects(:hosts, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'raises an error on disassociating an inherited ansible role from host by name' do
+      params = %w[--id=1 --ansible-role=role2]
+      expected_result = CommandExpectation.new
+      expected_result.expected_err = [
+        'Could not disassociate the Ansible role:',
+        '  Ansible role role2 is not assigned directly and cannot be removed.',
+        ''
+      ].join("\n")
+      expected_result.expected_exit_code = HammerCLI::EX_USAGE
+
+      api_expects(:ansible_roles, :index) do |par|
+        par[:search] == 'name = "role2"'
+      end.returns(ansible_role_2)
+
+      api_expects(:hosts, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+  end
+end

data/test/functional/hostgroup_test.rb

@@ -0,0 +1,200 @@
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+describe 'hostgroup' do
+  let(:ansible_role_1) do
+    {
+      'id' => 1,
+      'name' => 'role1',
+      'inherited' => false,
+      'directly_assigned' => true
+    }
+  end
+  let(:ansible_role_2) do
+    {
+      'id' => 2,
+      'name' => 'role2',
+      'inherited' => true,
+      'directly_assigned' => false
+    }
+  end
+  let(:ansible_roles) do
+    [
+      ansible_role_1,
+      ansible_role_2
+    ]
+  end
+
+  describe 'add ansible role' do
+    let(:cmd) { %w[hostgroup ansible-roles add] }
+
+    it 'requires hostgroup --id' do
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --name, --title, --id is required.',
+        'Could not associate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'requires hostgroup id and asnible role id' do
+      params = %w[--id=1]
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --ansible-role, --ansible-role-id is required.',
+        'Could not associate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'associates ansible role with hostgroup' do
+      params = %w[--id=1 --ansible-role-id=2]
+
+      api_expects(:hostgroups, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns([ansible_role_1])
+
+      api_expects(:hostgroups, :update) do |par|
+        par['id'] == '1' &&
+          par['hostgroup']['ansible_role_ids'] == %w[1 2]
+      end
+
+      result = run_cmd(cmd + params)
+      assert_cmd(success_result("Ansible role has been associated.\n"), result)
+    end
+
+    it 'raises an error on associating an inherited ansible role to host' do
+      params = %w[--id=1 --ansible-role-id=2]
+      expected_result = CommandExpectation.new
+      expected_result.expected_err = [
+        'Could not associate the Ansible role:',
+        '  Ansible role role2 is already inherited from a host group. Please use --force for direct association.',
+        ''
+      ].join("\n")
+      expected_result.expected_exit_code = HammerCLI::EX_USAGE
+
+      api_expects(:hostgroups, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'associates inherited ansible role with hostgroup' do
+      params = %w[--id=1 --ansible-role-id=2 --force]
+
+      api_expects(:hostgroups, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects(:hostgroups, :update) do |par|
+        par['id'] == '1' &&
+          par['hostgroup']['ansible_role_ids'] == %w[1 2]
+      end
+
+      result = run_cmd(cmd + params)
+      assert_cmd(success_result("Ansible role has been associated.\n"), result)
+    end
+  end
+
+  describe 'remove ansible role' do
+    let(:cmd) { %w[hostgroup ansible-roles remove] }
+
+    it 'requires hostgroup --id' do
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --name, --title, --id is required.',
+        'Could not disassociate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'requires hostgroup id and asnible role id' do
+      params = %w[--id=1]
+      expected_result = usage_error_result(
+        cmd,
+        'At least one of options --ansible-role, --ansible-role-id is required.',
+        'Could not disassociate the Ansible role'
+      )
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'disassociates ansible role from hostgroup' do
+      params = %w[--id=1 --ansible-role-id=1]
+
+      api_expects(:hostgroups, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects(:hostgroups, :update) do |par|
+        par['id'] == '1' &&
+          par['hostgroup']['ansible_role_ids'] == %w[]
+      end
+
+      result = run_cmd(cmd + params)
+      assert_cmd(success_result("Ansible role has been disassociated.\n"), result)
+    end
+
+    it 'raises an error on disassociating an inherited ansible role from hostgroup by id' do
+      params = %w[--id=1 --ansible-role-id=2]
+      expected_result = CommandExpectation.new
+      expected_result.expected_err = [
+        'Could not disassociate the Ansible role:',
+        '  Ansible role role2 is not assigned directly and cannot be removed.',
+        ''
+      ].join("\n")
+      expected_result.expected_exit_code = HammerCLI::EX_USAGE
+
+      api_expects(:hostgroups, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+
+    it 'raises an error on disassociating an inherited ansible role from hostgroup by name' do
+      params = %w[--id=1 --ansible-role=role2]
+      expected_result = CommandExpectation.new
+      expected_result.expected_err = [
+        'Could not disassociate the Ansible role:',
+        '  Ansible role role2 is not assigned directly and cannot be removed.',
+        ''
+      ].join("\n")
+      expected_result.expected_exit_code = HammerCLI::EX_USAGE
+
+      api_expects(:ansible_roles, :index) do |par|
+        par[:search] == 'name = "role2"'
+      end.returns(ansible_role_2)
+
+      api_expects(:hostgroups, :ansible_roles) do |par|
+        par[:id] == '1'
+      end.returns(ansible_roles)
+
+      api_expects_no_call
+
+      result = run_cmd(cmd + params)
+      assert_cmd(expected_result, result)
+    end
+  end
+end

data/test/functional/test_helper.rb

@@ -0,0 +1,11 @@
+require File.join(File.dirname(__FILE__), '../test_helper')
+
+require 'hammer_cli/testing/output_matchers'
+require 'hammer_cli/testing/command_assertions'
+require 'hammer_cli/testing/data_helpers'
+require 'hammer_cli_foreman/testing/api_expectations'
+
+include HammerCLI::Testing::OutputMatchers
+include HammerCLI::Testing::CommandAssertions
+include HammerCLI::Testing::DataHelpers
+include HammerCLIForeman::Testing::APIExpectations

data/test/test_helper.rb

@@ -1,4 +1,18 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
-require 'hammer_cli_foreman_ansible'
+ENV['TEST_API_VERSION'] = ENV['TEST_API_VERSION'] || '3.3'
+FOREMAN_ANSIBLE_VERSION = Gem::Version.new(ENV['TEST_API_VERSION']).to_s
 
 require 'minitest/autorun'
+require 'minitest/spec'
+require 'minitest-spec-context'
+require 'mocha/minitest'
+require 'hammer_cli'
+
+HammerCLI.context[:api_connection].create('foreman') do
+  HammerCLI::Apipie::ApiConnection.new(
+    apidoc_cache_dir: 'test/data/' + FOREMAN_ANSIBLE_VERSION,
+    apidoc_cache_name: 'foreman_api',
+    dry_run: true
+  )
+end
+
+require 'hammer_cli_foreman_ansible'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hammer_cli_foreman_ansible
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Oleh Fedorenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-21 00:00:00.000000000 Z
+date: 2022-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hammer_cli_foreman
@@ -24,48 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.12.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.16'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.16'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 description: 
 email:
 - ofedoren@redhat.com
@@ -78,12 +50,21 @@ files:
 - config/foreman_ansible.yml
 - lib/hammer_cli_foreman_ansible.rb
 - lib/hammer_cli_foreman_ansible/ansible.rb
+- lib/hammer_cli_foreman_ansible/ansible_inventory.rb
 - lib/hammer_cli_foreman_ansible/ansible_roles.rb
 - lib/hammer_cli_foreman_ansible/ansible_variables.rb
+- lib/hammer_cli_foreman_ansible/associated_ansible_role.rb
+- lib/hammer_cli_foreman_ansible/command_extensions.rb
+- lib/hammer_cli_foreman_ansible/command_extensions/inventory.rb
+- lib/hammer_cli_foreman_ansible/command_extensions/resolver.rb
 - lib/hammer_cli_foreman_ansible/host.rb
 - lib/hammer_cli_foreman_ansible/hostgroup.rb
 - lib/hammer_cli_foreman_ansible/i18n.rb
 - lib/hammer_cli_foreman_ansible/version.rb
+- test/data/3.3/foreman_api.json
+- test/functional/host_test.rb
+- test/functional/hostgroup_test.rb
+- test/functional/test_helper.rb
 - test/test_helper.rb
 homepage: https://github.com/theforeman/hammer-cli-foreman-ansible
 licenses:
@@ -104,10 +85,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Foreman Ansible plugin for Hammer CLI
 test_files:
+- test/data/3.3/foreman_api.json
+- test/functional/test_helper.rb
+- test/functional/host_test.rb
+- test/functional/hostgroup_test.rb
 - test/test_helper.rb