hammer_cli_foreman 3.7.0 → 3.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 153f99e72a9d4a889641be0d5a99e60192ee3dd20a783e86db831b5de9618744
-  data.tar.gz: 4038d91f5d942a78cd5ce71296ed1a07438abadcfc6a5f77eac0abcdfcebbf76
+  metadata.gz: 85d5c798f08f0d775ede7457aab35f687b300a74d623cb07cfd43a532a9af6ac
+  data.tar.gz: b2c32e64f0fa54187da3e66fe745ef7da093f9696e7757737a2dd802c7ffcd5e
 SHA512:
-  metadata.gz: 7290953f2d944f09645d2eb31a868398d8e75e1ea5086d1c84cfb1d2a097914df10d6e0ee76195b6258ca2a8fe8c6ccc755f4a906d1c3fba756c1eb218ffcfe3
-  data.tar.gz: c8624ea106c8daa295010f58ed340763513a919b0463392400df940444f2b3859d879e98160483161e94aeaacee45736e3b4d3329bc0e7b3a7d80ae3bba27a8c
+  metadata.gz: b3575fcc16dd4f4a48549b121b6ef4cbde40cfcd9a8de8f7b8f7fa395d843926962b61f0b543f50a0b58aac7235df9e5682b1a0b21ee1a5e870c6d13df706343
+  data.tar.gz: 8ebbec2ded6ed488d41de567e2696d564ed0640eb7c1c9305f77c318218dff5b8456808cd0e9bc3a441fbebf7b4e0388a16c06297147fe3c6a0ee9e5e427d311

data/doc/host_create.md

@@ -252,12 +252,6 @@ preallocate        # boolean, set true to preallocate
 wipe_after_delete  # boolean, set true to wipe disk after delete
 ```
 
-## Rackspace
-Available keys for `--compute-attributes`:
-```
-flavor_id
-```
-
 ## VMware
 Available keys for `--compute-attributes`:
 ```

data/doc/release_notes.md

@@ -1,5 +1,20 @@
 Release notes
 =============
+### 3.9.0 (2023-11-29)
+* Add cache status to ping output ([PR #622](https://github.com/theforeman/hammer-cli-foreman/pull/622)), [#36954](http://projects.theforeman.org/issues/36954)
+* Use strings, not floats to denote ruby versions ([PR #623](https://github.com/theforeman/hammer-cli-foreman/pull/623))
+* Update packit
+* Drop rackspace cr support ([PR #619](https://github.com/theforeman/hammer-cli-foreman/pull/619)), [#36813](http://projects.theforeman.org/issues/36813)
+* Update rel-eng
+* Bump to 3.9.0-develop
+
+### 3.8.0 (2023-08-25)
+* Support mocha 2.1 ([PR #618](https://github.com/theforeman/hammer-cli-foreman/pull/618)), [#34879](http://projects.theforeman.org/issues/34879)
+* Add ga to run tests on ruby 3+ ([PR #617](https://github.com/theforeman/hammer-cli-foreman/pull/617))
+* Update tx for hammer-cli-foreman, [#36315](http://projects.theforeman.org/issues/36315)
+* Add packit config
+* Bump to 3.8.0-develop
+
 ### 3.7.0 (2023-05-23)
 * Update rake for hammer-cli-foreman ([PR #613](https://github.com/theforeman/hammer-cli-foreman/pull/613)), [#36337](http://projects.theforeman.org/issues/36337)
 * Update minitest version ([PR #611](https://github.com/theforeman/hammer-cli-foreman/pull/611)), [#36349](http://projects.theforeman.org/issues/36349)

data/lib/hammer_cli_foreman/command_extensions/ping.rb

@@ -7,9 +7,23 @@ module HammerCLIForeman
           data['results']['foreman']['database']['active'] = status ? 'ok' : 'FAIL'
           duration = data['results']['foreman']['database']['duration_ms']
           data['results']['foreman']['database']['duration_ms'] = _('Duration: %sms') % duration
+          cache = data['results']['foreman']['cache']
+          data['results']['foreman']['cache'] = format_cache(cache) if cache
         end
       end
 
+      def self.format_cache(cache)
+        servers = cache['servers'].map do |server|
+          {
+            status: server['status'],
+            duration_ms: _('Duration: %sms') % server['duration_ms']
+          }
+        end
+        {
+          'servers': servers
+        }
+      end
+
       def self.check_for_unrecognized(plugins, output_definition)
         failed = plugins.select { |_, data| data['services'] }
                         .each_with_object([]) { |(_, d), s| s << d['services'] }

data/lib/hammer_cli_foreman/compute_resource/register_compute_resources.rb

@@ -13,6 +13,5 @@ module HammerCLIForeman
   require 'hammer_cli_foreman/compute_resource/libvirt.rb'
   require 'hammer_cli_foreman/compute_resource/openstack.rb'
   require 'hammer_cli_foreman/compute_resource/ovirt.rb'
-  require 'hammer_cli_foreman/compute_resource/rackspace.rb'
   require 'hammer_cli_foreman/compute_resource/vmware.rb'
 end

data/lib/hammer_cli_foreman/ping.rb

@@ -12,6 +12,12 @@ module HammerCLIForeman
             field :active, _('Status')
             field :duration_ms, _('Server Response')
           end
+          field :cache, _('cache'), Fields::Label do
+            field :servers, _('servers'), Fields::Collection do
+              field :status, _('Status')
+              field :duration_ms, _('Server Response')
+            end
+          end
         end
       end
 

data/lib/hammer_cli_foreman/version.rb

@@ -1,5 +1,5 @@
 module HammerCLIForeman
   def self.version
-    @version ||= Gem::Version.new "3.7.0"
+    @version ||= Gem::Version.new "3.9.0"
   end
 end

data/test/functional/associating_commands_test.rb

@@ -3,7 +3,7 @@ require File.join(File.dirname(__FILE__), 'test_helper')
 require 'hammer_cli_foreman/operating_system'
 
 describe HammerCLIForeman::OperatingSystem do
-  context 'AddProvisioningTemplateCommand' do
+  describe 'AddProvisioningTemplateCommand' do
     before do
       @cmd = ['os', 'add-provisioning-template']
       @os_before_update = {
@@ -106,7 +106,7 @@ describe HammerCLIForeman::OperatingSystem do
 
   end
 
-  context 'RemoveProvisioningTemplateCommand' do
+  describe 'RemoveProvisioningTemplateCommand' do
     before do
       @cmd = ['os', 'remove-provisioning-template']
       @os_before_update = {

data/test/functional/commands/list_test.rb

@@ -33,7 +33,7 @@ describe HammerCLIForeman::ListCommand do
     HammerCLI::Settings.clear
   end
 
-  context 'help' do
+  describe 'help' do
     let(:cmd) { ['host', 'list'] }
     let(:params) { ['--help'] }
 
@@ -49,7 +49,7 @@ describe HammerCLIForeman::ListCommand do
   end
 
   describe "api interaction" do
-    context "without per_page in settings" do
+    describe "without per_page in settings" do
       it "fetches only first page when there's not enough records" do
         expect_paged_call(1, 1000, 10)
         result = run_cmd([], {}, TestList)
@@ -86,7 +86,7 @@ describe HammerCLIForeman::ListCommand do
       end
     end
 
-    context "with per_page in settings" do
+    describe "with per_page in settings" do
       let(:per_page_in_settings) { 30 }
       before do
         HammerCLI::Settings.load({ :ui => { :per_page => per_page_in_settings } })
@@ -139,7 +139,7 @@ describe HammerCLIForeman::ListCommand do
       assert_cmd(expected_result, result)
     end
 
-    context 'with per_page in settings' do
+    describe 'with per_page in settings' do
       before do
         HammerCLI::Settings.load({ :ui => { :per_page => '1' } })
       end

data/test/functional/ping_test.rb

@@ -33,6 +33,31 @@ describe 'ping' do
       assert_cmd(expected_result, result)
     end
 
+    it 'includes cache status if foreman reports it' do
+      ping_results['results']['foreman']['cache'] = {
+        'servers' => [
+          {
+            'status' => 'ok',
+            'duration_ms' => 5
+          }
+        ]
+      }
+      api_expects(:ping, :ping, 'Ping').returns(ping_results)
+
+      output = OutputMatcher.new(
+        [
+          'cache:',
+          '    servers:',
+          '     1) Status:          ok',
+          '        Server Response: Duration: 5ms'
+        ]
+      )
+
+      expected_result = success_result(output)
+      result = run_cmd(cmd)
+      assert_cmd(expected_result, result)
+    end
+
     it 'returns 1 if one of the services failed and shows unrecognized services' do
       ping_results['results']['new_plugin'] = {
         'services' => {

data/test/functional/report_template_test.rb

@@ -114,7 +114,7 @@ describe 'report-template' do
 
     it 'invokes editor in interactive mode' do
       params = ['--name=test', '--default=yes', "--interactive", '--locked=no', '--snippet=no']
-      HammerCLI.expects(:open_in_editor).with("", {:content_type => "report_template", :suffix => ".erb"}).returns('Template content')
+      HammerCLI.expects(:open_in_editor).with("", content_type: "report_template", suffix: ".erb").returns('Template content')
       api_expects(:report_templates, :create, 'Create template').with_params(
         'report_template' => {
           'name' => 'test',
@@ -181,7 +181,7 @@ describe 'report-template' do
     it 'invokes editor in interactive mode' do
       params = ['--id=3', '--new-name=test', '--default=yes', "--interactive", '--locked=no', '--snippet=no']
       HammerCLI.expects(:open_in_editor).with(
-        "Template Content", {:content_type => "report_template", :suffix => ".erb"}).returns('Template content')
+        "Template Content", content_type: "report_template", suffix: ".erb").returns('Template content')
       api_expects(:report_templates, :show, 'Show').with_params('id' => '3').returns(third_report)
       api_expects(:report_templates, :update, 'Update template').with_params(
         'report_template' => {
@@ -307,7 +307,7 @@ describe 'report-template' do
       { 'job_id' => job_id, 'data_url' => "/report_data/#{job_id}" }
     end
 
-    context 'without --wait' do
+    describe 'without --wait' do
       it 'schedule report and prints out data for getting the result' do
         params = ['--id=3', '--inputs=Host filter=filter']
         api_expects(:report_templates, :schedule_report, 'Schedule').with_params(
@@ -320,7 +320,7 @@ describe 'report-template' do
       end
     end
 
-    context 'with --wait' do
+    describe 'with --wait' do
       it 'generates the report to the file' do
         params = ['--id=3', '--inputs=Host filter=filter', '--wait', '--path=/tmp']
         api_expects(:report_templates, :schedule_report, 'Schedule').with_params(

data/test/functional/virtual_machine_test.rb

@@ -5,7 +5,7 @@ require 'hammer_cli_foreman/compute_resource'
 
 describe HammerCLIForeman::VirtualMachine do
 
-  context "InfoCommand" do
+  describe "InfoCommand" do
     before do
       @cmd = ["compute-resource", "virtual-machine", "info"]
       @vm = {
@@ -43,7 +43,7 @@ describe HammerCLIForeman::VirtualMachine do
 
   end
 
-  context "ListCommand" do
+  describe "ListCommand" do
     before do
       @cmd = ["compute-resource", "virtual-machines"]
       @available_virtual_machines = [
@@ -68,7 +68,7 @@ describe HammerCLIForeman::VirtualMachine do
     end
   end
 
-  context "PowerCommand" do
+  describe "PowerCommand" do
     before do
       @cmd = ["compute-resource", "virtual-machine", "power"]
     end
@@ -97,7 +97,7 @@ describe HammerCLIForeman::VirtualMachine do
     end
   end
 
-  context "DeleteCommand" do
+  describe "DeleteCommand" do
     before do
       @cmd = ["compute-resource", "virtual-machine", "delete"]
     end

data/test/test_helper.rb

@@ -11,7 +11,6 @@ SimpleCov.root Pathname.new(File.dirname(__FILE__) + "../../../")
 
 require 'minitest/autorun'
 require 'minitest/spec'
-require "minitest-spec-context"
 require "mocha/minitest"
 
 require 'hammer_cli'

data/test/unit/api/interactive_basic_auth_test.rb

@@ -4,7 +4,7 @@ describe HammerCLIForeman::Api::InteractiveBasicAuth do
   let(:request) { mock() }
   let(:args) { {} }
 
-  context "interactive mode" do
+  describe "interactive mode" do
     before :each do
       HammerCLI.stubs(:interactive?).returns true
     end
@@ -42,7 +42,7 @@ describe HammerCLIForeman::Api::InteractiveBasicAuth do
     end
   end
 
-  context "non-interactive mode" do
+  describe "non-interactive mode" do
     it "doesn't ask for credentials when they're not provided" do
       HammerCLI.stubs(:interactive?).returns false
       auth = HammerCLIForeman::Api::InteractiveBasicAuth.new(nil, nil)

data/test/unit/api/oauth/oauth_authentication_code_grant_test.rb

@@ -1,7 +1,7 @@
 require File.join(File.dirname(__FILE__), '../../test_helper')
 
 describe HammerCLIForeman::Api::Oauth::AuthenticationCodeGrant do
-  let(:request) { mock().stubs({}) }
+  let(:request) { {} }
   let(:args) { {} }
   let(:params) {{
     oidc_redirect_uri: 'urn:ietf:wg:oauth:2.0:oob',
@@ -33,7 +33,7 @@ describe HammerCLIForeman::Api::Oauth::AuthenticationCodeGrant do
     end
   end
 
-  context "interactive mode" do
+  describe "interactive mode" do
     before :each do
       HammerCLI.stubs(:interactive?).returns true
     end

data/test/unit/api/oauth/oauth_password_grant_test.rb

@@ -1,7 +1,7 @@
 require File.join(File.dirname(__FILE__), '../../test_helper')
 
 describe HammerCLIForeman::Api::Oauth::PasswordGrant do
-  let(:request) { mock().stubs({}) }
+  let(:request) { {} }
   let(:args) { {} }
   let(:params) {{
     username: 'user1',
@@ -31,7 +31,7 @@ describe HammerCLIForeman::Api::Oauth::PasswordGrant do
     end
   end
 
-  context "interactive mode" do
+  describe "interactive mode" do
     before :each do
       HammerCLI.stubs(:interactive?).returns true
     end

data/test/unit/api/session_authenticator_wrapper_test.rb

@@ -52,7 +52,7 @@ describe HammerCLIForeman::Api::SessionAuthenticatorWrapper do
   end
 
   describe '#authenticate' do
-    context "when there's saved session" do
+    describe "when there's saved session" do
       it 'sets session id in cookies for basic auth' do
         session_params = {
           session_id: 'SOME_SESSION_ID', auth_type: 'Basic_Auth'
@@ -139,7 +139,7 @@ describe HammerCLIForeman::Api::SessionAuthenticatorWrapper do
       end
     end
 
-    context "when the session file is corrupted" do
+    describe "when the session file is corrupted" do
       it 'reports error' do
         _dir, _out, err = prepare_session_storage :session_id => 'SOME_SESSION_ID' do |auth, dir|
           write_session(dir, '{not a valid: json')
@@ -152,7 +152,7 @@ describe HammerCLIForeman::Api::SessionAuthenticatorWrapper do
       end
     end
 
-    context "when no session is saved" do
+    describe "when no session is saved" do
       it 'passes to wrapped authenticator' do
         prepare_session_storage do |auth, dir|
           wrapped_auth.expects(:authenticate).with(request, args)
@@ -164,7 +164,7 @@ describe HammerCLIForeman::Api::SessionAuthenticatorWrapper do
   end
 
   describe '#error' do
-    context 'when there is existing session' do
+    describe 'when there is existing session' do
       it 'sets session id to nil on unauthorized exception' do
         prepare_session_storage :session_id => 'SOME_SESSION_ID' do |auth, dir|
           ex = RestClient::Unauthorized.new
@@ -204,7 +204,7 @@ describe HammerCLIForeman::Api::SessionAuthenticatorWrapper do
         end
       end
 
-      context 'when user has changed' do
+      describe 'when user has changed' do
         it 'sets a special error message' do
           prepare_session_storage :session_id => 'SOME_SESSION_ID' do |auth, dir|
             auth.force_user_change
@@ -227,7 +227,7 @@ describe HammerCLIForeman::Api::SessionAuthenticatorWrapper do
       end
     end
 
-    context 'when there is no existing session' do
+    describe 'when there is no existing session' do
       it 'passes exception to wrapped authenticator on unauthorized exception' do
         prepare_session_storage do |auth, dir|
           ex = RestClient::Unauthorized.new

data/test/unit/architecture_test.rb

@@ -7,21 +7,21 @@ describe HammerCLIForeman::Architecture do
 
   include CommandTestHelper
 
-  context "ListCommand" do
+  describe "ListCommand" do
     before do
       ResourceMocks.mock_action_call(:architectures, :index, [])
     end
 
     let(:cmd) { HammerCLIForeman::Architecture::ListCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "no arguments"
       it_should_accept_search_params
       it_should_accept 'organization', ['--organization-id=1']
       it_should_accept 'location', ['--location-id=1']
     end
 
-    context "output" do
+    describe "output" do
       let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
 
       it_should_print_n_records
@@ -32,11 +32,11 @@ describe HammerCLIForeman::Architecture do
   end
 
 
-  context "InfoCommand" do
+  describe "InfoCommand" do
 
     let(:cmd) { HammerCLIForeman::Architecture::InfoCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "id", ["--id=1"]
       it_should_accept "name", ["--name=arch"]
       it_should_accept 'organization', %w[--id=1 --organization-id=1]
@@ -44,7 +44,7 @@ describe HammerCLIForeman::Architecture do
       # it_should_fail_with "no arguments" # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
-    context "output" do
+    describe "output" do
       with_params ["--id=1"] do
         it_should_print_n_records 1
         it_should_print_column "Name"
@@ -55,11 +55,11 @@ describe HammerCLIForeman::Architecture do
   end
 
 
-  context "CreateCommand" do
+  describe "CreateCommand" do
 
     let(:cmd) { HammerCLIForeman::Architecture::CreateCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "name", ["--name=arch"]
       it_should_accept 'organization', %w[--name=arch --organization-id=1]
       it_should_accept 'location', %w[--name=arch --location-id=1]
@@ -70,11 +70,11 @@ describe HammerCLIForeman::Architecture do
   end
 
 
-  context "DeleteCommand" do
+  describe "DeleteCommand" do
 
     let(:cmd) { HammerCLIForeman::Architecture::DeleteCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "name", ["--name=arch"]
       it_should_accept "id", ["--id=1"]
       it_should_accept 'organization', %w[--id=1 --organization-id=1]
@@ -85,11 +85,11 @@ describe HammerCLIForeman::Architecture do
   end
 
 
-  context "UpdateCommand" do
+  describe "UpdateCommand" do
 
     let(:cmd) { HammerCLIForeman::Architecture::UpdateCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "name", ["--name=arch", "--new-name=arch2"]
       it_should_accept "id", ["--id=1", "--new-name=arch2"]
       it_should_accept 'organization', %w[--id=1 --new-name=arch2 --organization-id=1]

data/test/unit/audit_test.rb

@@ -6,19 +6,19 @@ require 'hammer_cli_foreman/audit'
 describe HammerCLIForeman::Audit do
   include CommandTestHelper
 
-  context "ListCommand" do
+  describe "ListCommand" do
     before do
       ResourceMocks.mock_action_call(:audits, :index, [])
     end
 
     let(:cmd) { HammerCLIForeman::Audit::ListCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "no arguments"
       it_should_accept_search_params
     end
 
-    context "output" do
+    describe "output" do
       let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
 
       it_should_print_n_records
@@ -32,18 +32,18 @@ describe HammerCLIForeman::Audit do
     end
   end
 
-  context "InfoCommand" do
+  describe "InfoCommand" do
     before do
         cmd.stubs(:extend_data)
     end
 
     let(:cmd) { HammerCLIForeman::Audit::InfoCommand.new("", ctx) }
 
-    context "parameters" do
+    describe "parameters" do
       it_should_accept "id", ["--id=1"]
     end
 
-    context "output" do
+    describe "output" do
       with_params ["--id=1"] do
         it_should_print_n_records 1
         it_should_print_column "Id"

data/test/unit/auth_source_external.rb

@@ -7,20 +7,20 @@ describe HammerCLIForeman::AuthSourceExternal do
 
   include CommandTestHelper
 
-  context 'ListCommand' do
+  describe 'ListCommand' do
     before :each do
       ResourceMocks.auth_source_external_index
     end
 
     let(:cmd) { HammerCLIForeman::AuthSourceExternal::ListCommand.new('', ctx) }
 
-    context 'parameters' do
+    describe 'parameters' do
       it_should_accept 'no arguments'
       it_should_accept 'per page', ['--per-page=1']
       it_should_accept 'page', ['--page=2']
     end
 
-    context 'output' do
+    describe 'output' do
       let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
 
       it_should_print_n_records 1
@@ -29,10 +29,10 @@ describe HammerCLIForeman::AuthSourceExternal do
     end
   end
 
-  context 'UpdateCommand' do
+  describe 'UpdateCommand' do
     let(:cmd) { HammerCLIForeman::AuthSourceExternal::UpdateCommand.new('', ctx) }
 
-    context 'parameters' do
+    describe 'parameters' do
       it_should_accept 'name', ['--name=External', '--new-name=auth-external-1']
       it_should_accept 'id', ['--id=11', '--new-name=auth-external-2']
     end