hammer_cli_foreman 0.1.0 → 0.1.1

data/test/unit/hostgroup_test.rb

@@ -4,11 +4,7 @@ require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
 
 describe HammerCLIForeman::Hostgroup do
 
-  extend CommandTestHelper
-
-  before :each do
-    cmd.stubs(:name_to_id).returns(1)
-  end
+  include CommandTestHelper
 
   context "ListCommand" do
 
@@ -23,10 +19,8 @@ describe HammerCLIForeman::Hostgroup do
       let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
-      it_should_print_columns ["Id", "Name", "Label", "Operating System Id", "Subnet Id"]
-      it_should_print_columns ["Domain Id", "Environment Id", "Puppetclass Ids", "Ancestry"]
-      it_should_print_columns ["Architecture Id", "Partition Table Id", "Medium Id"]
-      it_should_print_columns ["Puppet CA Proxy Id", "Puppet Master Proxy Id"]
+      it_should_print_columns ["Id", "Name", "Label", "Operating System"]
+      it_should_print_columns ["Environment", "Model"]
     end
 
   end
@@ -35,20 +29,16 @@ describe HammerCLIForeman::Hostgroup do
 
     let(:cmd) { HammerCLIForeman::Hostgroup::InfoCommand.new("", ctx) }
 
-    before :each do
-      HammerCLIForeman::Parameter.stubs(:get_parameters).returns([])
-    end
-
     context "parameters" do
       it_should_accept "id", ["--id=1"]
-      it_should_fail_with "no arguments"
+      # it_should_fail_with "no arguments" # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
     context "output" do
       with_params ["--id=1"] do
         it_should_print_n_records 1
-        it_should_print_columns ["Id", "Name", "Label", "Operating System Id", "Subnet Id"]
-        it_should_print_columns ["Domain Id", "Environment Id", "Puppetclass Ids", "Ancestry"]
+        it_should_print_columns ["Id", "Name", "Label", "Operating System", "Subnet"]
+        it_should_print_columns ["Domain", "Environment", "Puppetclasses", "Ancestry"]
         it_should_print_columns ["Parameters"]
       end
     end
@@ -61,7 +51,7 @@ describe HammerCLIForeman::Hostgroup do
 
     context "parameters" do
       it_should_accept "id", ["--id=1"]
-      it_should_fail_with "id missing", []
+      # it_should_fail_with "no params", [] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end
@@ -74,8 +64,9 @@ describe HammerCLIForeman::Hostgroup do
       it_should_accept "name, parent_id, environment_id, architecture_id, domain_id, puppet_proxy_id, operatingsystem_id and more",
           ["--name=hostgroup", "--parent-id=1", "--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1",
             "--operatingsystem-id=1", "--medium-id=1", "--ptable-id=1", "--subnet-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids=1,2']
-      it_should_fail_with "name or id missing",
-          ["--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1"]
+      # it_should_fail_with "name or id missing",
+      #    ["--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1"]
+      # TODO: temporarily disabled, parameters are checked in the api
     end
   end
 
@@ -87,8 +78,9 @@ describe HammerCLIForeman::Hostgroup do
       it_should_accept "name, parent_id, environment_id, architecture_id, domain_id, puppet_proxy_id, operatingsystem_id and more",
           ["--id=1 --name=hostgroup2", "--parent-id=1", "--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1",
             "--operatingsystem-id=1", "--medium-id=1", "--ptable-id=1", "--subnet-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids=1,2']
-      it_should_fail_with "no params", []
-      it_should_fail_with "id missing", ["--name=host2"]
+      # it_should_fail_with "no params", []
+      # it_should_fail_with "id missing", ["--name=host2"]
+      # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end
@@ -106,7 +98,7 @@ describe HammerCLIForeman::Hostgroup do
       it_should_accept "name, value and hostgroup id", ["--name=name", "--value=val", "--hostgroup-id=id"]
       it_should_fail_with "name missing", ["--value=val", "--hostgroup-id=1"]
       it_should_fail_with "value missing", ["--name=name", "--hostgroup-id=1"]
-      it_should_fail_with "hostgroup id missing", ["--name=name", "--value=val"]
+      # it_should_fail_with "hostgroup id missing", ["--name=name", "--value=val"] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end
@@ -117,9 +109,10 @@ describe HammerCLIForeman::Hostgroup do
     let(:cmd) { HammerCLIForeman::Hostgroup::DeleteParameterCommand.new("", ctx) }
 
     context "parameters" do
-      it_should_accept "name and hostgroup id", ["--name=name", "--hostgroup-id=id"]
-      it_should_fail_with "name missing", ["--hostgroup-id=id"]
-      it_should_fail_with "hostgroup id missing", ["--name=name"]
+      it_should_accept "name and hostgroup id", ["--name=param", "--hostgroup-id=id"]
+      # it_should_fail_with "name missing", ["--hostgroup-id=id"]
+      # it_should_fail_with "hostgroup id missing", ["--name=param"]
+      # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end
@@ -136,7 +129,7 @@ describe HammerCLIForeman::Hostgroup do
     context "parameters" do
       it_should_accept "name", ["--name=env"]
       it_should_accept "id", ["--id=1"]
-      it_should_fail_with "name or id missing", []
+      # it_should_fail_with "name or id missing", [] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end

data/test/unit/id_resolver_test.rb

@@ -0,0 +1,225 @@
+require File.join(File.dirname(__FILE__), 'test_helper')
+require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
+require File.join(File.dirname(__FILE__), 'helpers/fake_searchables')
+
+describe HammerCLIForeman::IdResolver do
+
+  let(:api) { HammerCLIForeman.foreman_api_connection.api }
+  let(:searchables) { FakeSearchables.new(['name','label']) }
+  let(:resolver) { HammerCLIForeman::IdResolver.new(api, searchables) }
+
+  describe "scoped options" do
+    it "returns empty hash when there are no options" do
+      resolver.scoped_options("scope", {}).must_equal({})
+    end
+
+    it "unscopes options" do
+      scoped = {
+        "option_id" => 1,
+        "option_org_id" => 2,
+        "option_org_name" => "ACME",
+        "option_a" => :value
+      }
+      unscoped = {
+        "option_id" => 2,
+        "option_name" => "ACME",
+        "option_a" => :value
+      }
+      resolver.scoped_options("org", scoped).must_equal(unscoped)
+    end
+
+    it "does not change the original options" do
+      scoped = {
+        "option_id" => 1,
+        "option_org_id" => 2,
+        "option_org_name" => "ACME",
+        "option_a" => :value
+      }
+      scoped_original = scoped.dup
+      resolver.scoped_options("org", scoped)
+      scoped.must_equal(scoped_original)
+    end
+
+  end
+
+
+  describe "id params" do
+      let(:required_params) {[
+        stub(:name => "architecture_id", :required? => true),
+        stub(:name => "organization_id", :required? => true)
+      ]}
+      let(:id_params) {[
+        stub(:name => "domain_id", :required? => false)
+      ]}
+      let(:other_params) {[
+        stub(:name => "location", :required? => true),
+        stub(:name => "param", :required? => false)
+      ]}
+      let(:action) {
+        stub(:params => (required_params+id_params+other_params))
+      }
+
+    it "returns only required params ending with _id" do
+      resolver.id_params(action, :required => true).must_equal required_params
+    end
+
+    it "returns only ending with _id when :required is set to false" do
+      resolver.id_params(action, :required => false).must_equal (required_params+id_params)
+    end
+
+    it "returns required params by default" do
+      resolver.id_params(action).must_equal required_params
+    end
+  end
+
+  describe "param to resource" do
+
+    let(:expected_resource) { HammerCLIForeman.foreman_resource(:architectures) }
+
+    it "finds resource for params with _id" do
+      resolver.param_to_resource("architecture_id").name.must_equal expected_resource.name
+    end
+
+    it "finds resource for params without _id" do
+      resolver.param_to_resource("architecture").name.must_equal expected_resource.name
+    end
+
+    it "returns nil for unknown resource" do
+      resolver.param_to_resource("unknown").must_equal nil
+    end
+
+  end
+
+  describe "depedent resources" do
+
+    it "returns empty array for an independent resource" do
+      resource = HammerCLIForeman.foreman_resource(:architectures)
+      resolver.dependent_resources(resource).must_equal []
+    end
+
+    it "returns list of dependent resources" do
+      resource = HammerCLIForeman.foreman_resource(:images)
+      resolver.dependent_resources(resource).map(&:name).must_equal [:compute_resources]
+    end
+
+  end
+
+  describe "resolving ids" do
+
+    it "must define methods for all resources" do
+      expected_method_names = api.resources.map(&:singular_name).collect{|r| "#{r}_id"}
+      missing_methods = expected_method_names - resolver.methods.map(&:to_s)
+      missing_methods.must_equal []
+    end
+
+    describe "when no search options are found" do
+      let(:resolver_run) { proc { resolver.architecture_id({"option_unknown" => "value"}) } }
+
+      it "raises exception" do
+        err = resolver_run.must_raise HammerCLIForeman::MissingSeachOptions
+      end
+
+      it "builds correct error message" do
+        err = resolver_run.must_raise HammerCLIForeman::MissingSeachOptions
+        err.message.must_equal "Missing options to search architecture"
+      end
+    end
+
+    describe "searching independent resource" do
+      let(:resolver_run) { proc { resolver.architecture_id({"option_name" => "arch"}) } }
+
+      it "raises exception when no resource is found" do
+        ResourceMocks.mock_action_call(:architectures, :index, [])
+
+        err = resolver_run.must_raise HammerCLIForeman::ResolverError
+        err.message.must_equal "architecture not found"
+      end
+
+      it "raises exception when multiple resources are found" do
+        ResourceMocks.mock_action_call(:architectures, :index, [
+          {"id" => 11, "name" => "arch1"},
+          {"id" => 22, "name" => "arch2"}
+        ])
+
+        err = resolver_run.must_raise HammerCLIForeman::ResolverError
+        err.message.must_equal "architecture found more than once"
+      end
+
+      it "calls index action with appropriate search params" do
+        ApipieBindings::API.any_instance.expects(:call).with() do |resource, action, params, headers, opts|
+          ( resource == :architectures &&
+            action == :index &&
+            params[:search] == "name = \"arch\"")
+        end.returns({"id" => 11, "name" => "arch1"})
+
+        resolver_run.call
+      end
+
+      it "uses option id when it's available" do
+        ResourceMocks.mock_action_call(:architectures, :index, [])
+
+        resolver.architecture_id({"option_id" => 83, "option_name" => "arch"}).must_equal 83
+      end
+
+      it "returns id of the resource" do
+        ResourceMocks.mock_action_call(:architectures, :index, [
+          {"id" => 11, "name" => "arch1"}
+        ])
+
+        resolver_run.call.must_equal 11
+      end
+
+    end
+
+    describe "searching dependent resource" do
+      let(:resolver_run) { proc { resolver.image_id({"option_name" => "img", "option_compute_resource_name" => "cr"}) } }
+
+      it "raises exception when no resource is found" do
+        ResourceMocks.mock_action_call(:images, :index, [])
+        ResourceMocks.mock_action_call(:compute_resources, :index, [])
+
+        err = resolver_run.must_raise HammerCLIForeman::ResolverError
+        err.message.must_equal "compute_resource not found"
+      end
+
+      it "raises exception when multiple resources are found" do
+        ResourceMocks.mock_action_call(:images, :index, [])
+        ResourceMocks.mock_action_call(:compute_resources, :index, [
+          {"id" => 11, "name" => "cr1"},
+          {"id" => 22, "name" => "cr2"}
+        ])
+
+        err = resolver_run.must_raise HammerCLIForeman::ResolverError
+        err.message.must_equal "compute_resource found more than once"
+      end
+
+      it "calls index action with appropriate search params" do
+        ApipieBindings::API.any_instance.expects(:call).with() do |resource, action, params, headers, opts|
+          ( resource == :compute_resources &&
+            action == :index &&
+            params[:search] == "name = \"cr\"")
+        end.returns({"id" => 11, "name" => "cr"})
+
+        ApipieBindings::API.any_instance.expects(:call).with() do |resource, action, params, headers, opts|
+          ( resource == :images &&
+            action == :index &&
+            params[:search] == "name = \"img\"")
+        end.returns({"id" => 11, "name" => "img"})
+
+        resolver_run.call
+      end
+
+      it "returns id of the resource" do
+        ResourceMocks.mock_action_call(:images, :index, [
+          {"id" => 11, "name" => "img1"}
+        ])
+        ResourceMocks.mock_action_call(:compute_resources, :index, [
+          {"id" => 22, "name" => "cr2"}
+        ])
+
+        resolver_run.call.must_equal 11
+      end
+    end
+
+  end
+end

data/test/unit/image_test.rb

@@ -7,11 +7,7 @@ require File.join(File.dirname(__FILE__), 'test_output_adapter')
 describe HammerCLIForeman::Image do
 
 
-  extend CommandTestHelper
-
-  before :each do
-    cmd.stubs(:name_to_id).returns(1)
-  end
+  include CommandTestHelper
 
   context "ListCommand" do
 
@@ -30,7 +26,7 @@ describe HammerCLIForeman::Image do
         it_should_print_n_records
         it_should_print_column "Id"
         it_should_print_column "Name"
-        it_should_print_column "Operating System Id"
+        it_should_print_column "Operating System"
         it_should_print_column "Username"
         it_should_print_column "UUID"
       end
@@ -54,8 +50,8 @@ describe HammerCLIForeman::Image do
         it_should_print_n_records 1
         it_should_print_column "Id"
         it_should_print_column "Name"
-        it_should_print_column "Operating System Id"
-        it_should_print_column "Architecture Id"
+        it_should_print_column "Operating System"
+        it_should_print_column "Architecture"
         it_should_print_column "Username"
         it_should_print_column "UUID"
         it_should_print_column "IAM role"
@@ -72,7 +68,6 @@ describe HammerCLIForeman::Image do
       ResourceMocks.compute_resources_available_images
     end
 
-
     context "parameters" do
       it_should_accept "compute resource name", ["--compute-resource=cr"]
       it_should_accept "compute resource id", ["--compute-resource-id=1"]
@@ -93,11 +88,12 @@ describe HammerCLIForeman::Image do
     context "parameters" do
       it_should_accept "all required params", ["--name=img", "--operatingsystem-id=1", "--architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
       it_should_accept "all required params and resource's name", ["--name=img", "--operatingsystem-id=1", "--architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource=ec2"]
-      it_should_fail_with "name missing", ["--operatingsystem-id=1", "architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
-      it_should_fail_with "os id missing", ["--name=img", "--operatingsystem-id=1", "architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
-      it_should_fail_with "architecture id missing", ["--name=img", "--operatingsystem-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
-      it_should_fail_with "username id missing", ["--name=img", "--operatingsystem-id=1", "architecture-id=1", "--uuid=aabbcc123", "--compute-resource-id=1"]
-      it_should_fail_with "uuid missing", ["--name=img", "--operatingsystem-id=1", "architecture-id=1", "--username=root", "--compute-resource-id=1"]
+      # it_should_fail_with "name missing", ["--operatingsystem-id=1", "architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
+      # it_should_fail_with "os id missing", ["--name=img", "--operatingsystem-id=1", "architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
+      # it_should_fail_with "architecture id missing", ["--name=img", "--operatingsystem-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
+      # it_should_fail_with "username id missing", ["--name=img", "--operatingsystem-id=1", "architecture-id=1", "--uuid=aabbcc123", "--compute-resource-id=1"]
+      # it_should_fail_with "uuid missing", ["--name=img", "--operatingsystem-id=1", "architecture-id=1", "--username=root", "--compute-resource-id=1"]
+      # TODO: temporarily disabled, parameters are checked in the api
     end
 
   end
@@ -110,8 +106,9 @@ describe HammerCLIForeman::Image do
     context "parameters" do
       it_should_accept "id and resource's id", ["--id=1", "--compute-resource-id=1"]
       it_should_accept "id and resource's name", ["--id=1", "--compute-resource=ec2"]
-      it_should_fail_with "id missing", ["--compute-resource-id=1"]
-      it_should_fail_with "resource's id or name missing", ["--id=1"]
+      # it_should_fail_with "id missing", ["--compute-resource-id=1"]
+      # it_should_fail_with "resource's id or name missing", ["--id=1"]
+      # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end
@@ -125,8 +122,9 @@ describe HammerCLIForeman::Image do
       it_should_accept "id and resource's id", ["--id=1", "--compute-resource-id=1"]
       it_should_accept "id and resource's name", ["--id=1", "--compute-resource=ec2"]
       it_should_accept "all available params", ["--id=1", "--name=img", "--operatingsystem-id=1", "--architecture-id=1", "--username=root", "--uuid=aabbcc123", "--compute-resource-id=1"]
-      it_should_fail_with "id missing", ["--compute-resource-id=1"]
-      it_should_fail_with "resource's id or name missing", ["--id=1"]
+      # it_should_fail_with "id missing", ["--compute-resource-id=1"]
+      # it_should_fail_with "resource's id or name missing", ["--id=1"]
+      # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
   end

data/test/unit/location_test.rb

@@ -3,13 +3,9 @@ require File.join(File.dirname(__FILE__), 'helpers/resource_disabled')
 
 describe HammerCLIForeman::Location do
 
-  extend CommandTestHelper
+  include CommandTestHelper
   extend ResourceDisabled
 
-  before :each do
-    cmd.stubs(:name_to_id).returns(1)
-  end
-
   context "ListCommand" do
 
     let(:cmd) { HammerCLIForeman::Location::ListCommand.new("", ctx) }
@@ -46,7 +42,7 @@ describe HammerCLIForeman::Location do
     context "parameters" do
       it_should_accept "id", ["--id=1"]
       it_should_accept "name", ["--name=arch"]
-      it_should_fail_with "no arguments"
+      # it_should_fail_with "no arguments" # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
     context "output" do
@@ -71,7 +67,8 @@ describe HammerCLIForeman::Location do
 
     context "parameters" do
       it_should_accept "name", ["--name=org"]
-      it_should_fail_with "name missing", []
+      # it_should_fail_with "name missing", []
+      # TODO: temporarily disabled, parameters are checked in the api
     end
 
     with_params ["--name=loc"] do
@@ -87,7 +84,7 @@ describe HammerCLIForeman::Location do
     context "parameters" do
       it_should_accept "name", ["--name=org"]
       it_should_accept "id", ["--id=1"]
-      it_should_fail_with "name or id missing", []
+      # it_should_fail_with "name or id missing", [] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
     with_params ["--id=1"] do
@@ -103,8 +100,9 @@ describe HammerCLIForeman::Location do
     context "parameters" do
       it_should_accept "name", ["--name=org", "--new-name=org2"]
       it_should_accept "id", ["--id=1", "--new-name=org2"]
-      it_should_fail_with "no params", []
-      it_should_fail_with "name or id missing", ["--new-name=org2"]
+      # it_should_fail_with "no params", []
+      # it_should_fail_with "name or id missing", ["--new-name=org2"]
+      # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
     with_params ["--id=1"] do