hammer_cli_foreman 0.0.18 → 0.1.0

data/test/unit/domain_test.rb

@@ -7,7 +7,6 @@ describe HammerCLIForeman::Domain do
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -21,7 +20,7 @@ describe HammerCLIForeman::Domain do
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
       it_should_print_columns ["Id", "Name"]
@@ -97,9 +96,7 @@ describe HammerCLIForeman::Domain do
   context "SetParameterCommand" do
 
     before :each do
-      resource_mock = ApipieResourceMock.new(cmd.class.resource.resource_class)
-      resource_mock.stub_method(:index, [])
-      cmd.class.resource resource_mock
+      ResourceMocks.parameters_index
     end
 
     let(:cmd) { HammerCLIForeman::Domain::SetParameterCommand.new("", ctx) }

data/test/unit/environment_test.rb

@@ -7,7 +7,6 @@ describe HammerCLIForeman::Environment do
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -21,7 +20,7 @@ describe HammerCLIForeman::Environment do
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
       it_should_print_column "Name"
@@ -95,7 +94,7 @@ describe HammerCLIForeman::Environment do
   context "SCParamsCommand" do
 
     before :each do
-      cmd.class.resource ResourceMocks.smart_class_parameter
+      ResourceMocks.smart_class_parameters_index
     end
 
     let(:cmd) { HammerCLIForeman::Environment::SCParamsCommand.new("", ctx) }

data/test/unit/exception_handler_test.rb

@@ -57,9 +57,9 @@ describe HammerCLIForeman::ExceptionHandler do
   end
 
   it "should print resource errors on resource not found exception" do
-   response = <<-RESPONSE
-   {"error":{"message":"Resource architecture not found by id '1'"}}
-   RESPONSE
+    response = <<-RESPONSE
+    {"error":{"message":"Resource architecture not found by id '1'"}}
+    RESPONSE
     ex = RestClient::ResourceNotFound.new(response)
     ex.stubs(:message).returns("")
 
@@ -69,7 +69,7 @@ describe HammerCLIForeman::ExceptionHandler do
   end
 
   it "should print exception message on resource not found exception without explicit message" do
-   response = '{"error": ""}'
+    response = '{"error": ""}'
     ex = RestClient::ResourceNotFound.new(response)
     ex.stubs(:message).returns("ResourceNotFound message")
 
@@ -78,5 +78,30 @@ describe HammerCLIForeman::ExceptionHandler do
     err_code.must_equal HammerCLI::EX_NOT_FOUND
   end
 
+  it "should print resource errors on internal error exception" do
+    response = <<-RESPONSE
+    {"error":{"message":"Some internal exception"}}
+    RESPONSE
+    ex = RestClient::InternalServerError.new(response)
+    ex.stubs(:message).returns("")
+
+    output.expects(:print_error).with(heading, "Some internal exception")
+    err_code = handler.handle_exception(ex, :heading => heading)
+    err_code.must_equal HammerCLI::EX_SOFTWARE
+  end
+
+  it "should print exception message on internal error exception without formatted message" do
+    response = <<-RESPONSE.gsub(/^\s+/, "")
+    Unformatted
+    lines
+    RESPONSE
+    ex = RestClient::InternalServerError.new(response)
+    ex.stubs(:message).returns(response)
+
+    output.expects(:print_error).with("Something went wrong", "Unformatted\nlines\n")
+    err_code = handler.handle_exception(ex, :heading => heading)
+    err_code.must_equal HammerCLI::EX_SOFTWARE
+  end
+
 end
 

data/test/unit/fact_test.rb

@@ -7,7 +7,6 @@ describe HammerCLIForeman::Fact do
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 

data/test/unit/helpers/command.rb

@@ -13,7 +13,9 @@ module CommandTestHelper
   def it_should_call_action(action, params, headers={})
     it "should call action "+action.to_s do
       arguments ||= respond_to?(:with_params) ? with_params : []
-      cmd.resource.resource_class.expects_with(action, params, headers)
+      ApipieBindings::API.any_instance.expects(:call).with() do |r,a,p,h,o|
+        (r == cmd.resource.name && a == action && p == params && h == headers)
+      end
       cmd.run(arguments)
     end
   end
@@ -21,7 +23,9 @@ module CommandTestHelper
   def it_should_call_action_and_test_params(action, &block)
     it "should call action "+action.to_s do
       arguments ||= respond_to?(:with_params) ? with_params : []
-      cmd.resource.resource_class.expects_with_block(action, &block)
+      ApipieBindings::API.any_instance.expects(:call).with() do |r,a,p,h,o|
+        (r == cmd.resource.name && a == action && yield(p))
+      end
       cmd.run(arguments)
     end
   end
@@ -34,7 +38,20 @@ module CommandTestHelper
 
   def it_should_accept(message, arguments=[])
     it "should accept " + message.to_s do
-      cmd.run(arguments).must_equal HammerCLI::EX_OK
+      out, err = capture_io do
+        cmd.run(arguments).must_equal HammerCLI::EX_OK
+      end
+    end
+  end
+
+  def it_should_output(message, adapter=:base)
+    it "should output '" + message.to_s + "'" do
+      arguments ||= respond_to?(:with_params) ? with_params : []
+      cmd.stubs(:context).returns(ctx.update(:adapter => adapter))
+      out, err = capture_io do
+        cmd.run(arguments)
+      end
+      out.must_include message
     end
   end
 
@@ -62,7 +79,6 @@ module CommandTestHelper
       out, err = capture_io do
         cmd.run(arguments)
       end
-
       out.split(/\n/).length.must_equal count+1 # plus 1 for line with column headers
     end
   end

data/test/unit/helpers/resource_disabled.rb

@@ -7,13 +7,13 @@ module ResourceDisabled
     context "resource disabled" do
 
       it "should return error" do
-        cmd.class.resource ApipieDisabledResourceMock.new(cmd.class.resource.resource_class)
+        cmd.class.resource.stubs(:call).raises(RestClient::ResourceNotFound)
         arguments = respond_to?(:with_params) ? with_params : []
         cmd.run(arguments).must_equal HammerCLI::EX_UNAVAILABLE
       end
 
       it "should print error message" do
-        cmd.class.resource ApipieDisabledResourceMock.new(cmd.class.resource.resource_class)
+        cmd.class.resource.stubs(:call).raises(RestClient::ResourceNotFound)
         cmd.stubs(:context).returns(ctx.update(:adapter => :test))
 
         arguments = respond_to?(:with_params) ? with_params : []

data/test/unit/host_test.rb

@@ -7,7 +7,6 @@ describe HammerCLIForeman::Host do
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -21,7 +20,7 @@ describe HammerCLIForeman::Host do
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
       it_should_print_columns ["Id", "Name", "Operating System Id", "Host Group Id", "IP", "MAC"]
@@ -56,6 +55,7 @@ describe HammerCLIForeman::Host do
         it_should_print_columns ["Created at", "Updated at", "Installed at", "Last report"]
         it_should_print_columns ["Puppet CA Proxy Id", "Medium Id", "Model Id", "Owner Id", "Subnet Id", "Domain Id"]
         it_should_print_columns ["Puppet Proxy Id", "Owner Type", "Partition Table Id", "Architecture Id", "Image Id", "Compute Resource Id"]
+        it_should_print_columns ["BMC Network Interfaces", "Managed Network Interfaces"]
         it_should_print_columns ["Comment"]
       end
     end
@@ -67,9 +67,7 @@ describe HammerCLIForeman::Host do
     let(:cmd) { HammerCLIForeman::Host::StatusCommand.new("", ctx) }
 
     before :each do
-      resource_mock = ApipieResourceMock.new(cmd.class.resource.resource_class)
-      resource_mock.stub_method(:power, {'power' => 'running'})
-      cmd.class.resource resource_mock
+      ResourceMocks.mock_action_call(:hosts, :power, {'power' => 'running'} )
     end
 
     context "parameters" do
@@ -196,11 +194,16 @@ describe HammerCLIForeman::Host do
 
     let(:cmd) { HammerCLIForeman::Host::CreateCommand.new("", ctx) }
 
+    before :each do
+      HammerCLIForeman::CommonHostUpdateOptions.stubs(:ask_password).returns("password")
+    end
+
     context "parameters" do
       it_should_accept "name, environment_id, architecture_id, domain_id, puppet_proxy_id, operatingsystem_id and more",
           ["--name=host", "--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1",
             "--ip=1.2.3.4", "--mac=11:22:33:44:55:66", "--medium-id=1", "--partition-table-id=1", "--subnet-id=1",
-            "--sp-subnet-id=1", "--model-id=1", "--hostgroup-id=1", "--owner-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids']
+            "--sp-subnet-id=1", "--model-id=1", "--hostgroup-id=1", "--owner-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids',
+            "--root-password=pwd", "--ask-root-password=true", "--provision-method=build"]
       it_should_fail_with "name or id missing",
           ["--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1"]
       it_should_fail_with "environment_id missing",
@@ -216,10 +219,12 @@ describe HammerCLIForeman::Host do
 
       with_params ["--name=host", "--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1",
             "--ip=1.2.3.4", "--mac=11:22:33:44:55:66", "--medium-id=1", "--partition-table-id=1", "--subnet-id=1",
-            "--sp-subnet-id=1", "--model-id=1", "--hostgroup-id=1", "--owner-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids'] do
+            "--sp-subnet-id=1", "--model-id=1", "--hostgroup-id=1", "--owner-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids',
+            "--root-password=pwd", "--ask-root-password=true", "--provision-method=build"] do
         it_should_call_action_and_test_params(:create) { |par| par["host"]["managed"] == true }
         it_should_call_action_and_test_params(:create) { |par| par["host"]["build"] == true }
         it_should_call_action_and_test_params(:create) { |par| par["host"]["enabled"] == true }
+        it_should_call_action_and_test_params(:create) { |par| par["host"]["provision_method"] == "build" }
       end
     end
   end
@@ -228,12 +233,17 @@ describe HammerCLIForeman::Host do
 
     let(:cmd) { HammerCLIForeman::Host::UpdateCommand.new("", ctx) }
 
+    before :each do
+      HammerCLIForeman::CommonHostUpdateOptions.stubs(:ask_password).returns("password")
+    end
+
     context "parameters" do
       it_should_accept "name", ["--name=host", "--new-name=host2"]
       it_should_accept "id and more", ["--id=1", "--new-name=host2", "--environment-id=1", "--architecture-id=1",
             "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1",
             "--ip=1.2.3.4", "--mac=11:22:33:44:55:66", "--medium-id=1", "--partition-table-id=1", "--subnet-id=1",
-            "--sp-subnet-id=1", "--model-id=1", "--hostgroup-id=1", "--owner-id=1", '--puppet-ca-proxy-id=1']
+            "--sp-subnet-id=1", "--model-id=1", "--hostgroup-id=1", "--owner-id=1", '--puppet-ca-proxy-id=1',
+            "--root-password=pwd", "--ask-root-password=true", "--provision-method=build"]
       it_should_fail_with "no params", []
       it_should_fail_with "name or id missing", ["--new-name=host2"]
 
@@ -250,6 +260,10 @@ describe HammerCLIForeman::Host do
       with_params ["--id=1", "--enabled=false"] do
         it_should_call_action_and_test_params(:update) { |par| par["host"]["enabled"] == false }
       end
+
+      with_params ["--id=1","--provision-method=build"] do
+        it_should_call_action_and_test_params(:update) { |par| par["host"]["provision_method"] == "build" }
+      end
     end
 
   end
@@ -258,9 +272,7 @@ describe HammerCLIForeman::Host do
   context "SetParameterCommand" do
 
     before :each do
-      resource_mock = ApipieResourceMock.new(cmd.class.resource.resource_class)
-      resource_mock.stub_method(:index, [])
-      cmd.class.resource resource_mock
+      ResourceMocks.parameters_index
     end
 
     let(:cmd) { HammerCLIForeman::Host::SetParameterCommand.new("", ctx) }
@@ -320,7 +332,7 @@ describe HammerCLIForeman::Host do
   context "SCParamsCommand" do
 
     before :each do
-      cmd.class.resource ResourceMocks.smart_class_parameter
+      ResourceMocks.smart_class_parameters_index
     end
 
     let(:cmd) { HammerCLIForeman::Host::SCParamsCommand.new("", ctx) }

data/test/unit/hostgroup_test.rb

@@ -7,7 +7,6 @@ describe HammerCLIForeman::Hostgroup do
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -21,11 +20,13 @@ describe HammerCLIForeman::Hostgroup do
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
       it_should_print_columns ["Id", "Name", "Label", "Operating System Id", "Subnet Id"]
       it_should_print_columns ["Domain Id", "Environment Id", "Puppetclass Ids", "Ancestry"]
+      it_should_print_columns ["Architecture Id", "Partition Table Id", "Medium Id"]
+      it_should_print_columns ["Puppet CA Proxy Id", "Puppet Master Proxy Id"]
     end
 
   end
@@ -72,7 +73,7 @@ describe HammerCLIForeman::Hostgroup do
     context "parameters" do
       it_should_accept "name, parent_id, environment_id, architecture_id, domain_id, puppet_proxy_id, operatingsystem_id and more",
           ["--name=hostgroup", "--parent-id=1", "--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1",
-            "--operatingsystem-id=1", "--medium-id=1", "--ptable-id=1", "--subnet-id=1", '--puppet-ca-proxy-id=1']
+            "--operatingsystem-id=1", "--medium-id=1", "--ptable-id=1", "--subnet-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids=1,2']
       it_should_fail_with "name or id missing",
           ["--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1", "--operatingsystem-id=1"]
     end
@@ -85,7 +86,7 @@ describe HammerCLIForeman::Hostgroup do
     context "parameters" do
       it_should_accept "name, parent_id, environment_id, architecture_id, domain_id, puppet_proxy_id, operatingsystem_id and more",
           ["--id=1 --name=hostgroup2", "--parent-id=1", "--environment-id=1", "--architecture-id=1", "--domain-id=1", "--puppet-proxy-id=1",
-            "--operatingsystem-id=1", "--medium-id=1", "--ptable-id=1", "--subnet-id=1", '--puppet-ca-proxy-id=1']
+            "--operatingsystem-id=1", "--medium-id=1", "--ptable-id=1", "--subnet-id=1", '--puppet-ca-proxy-id=1', '--puppetclass-ids=1,2']
       it_should_fail_with "no params", []
       it_should_fail_with "id missing", ["--name=host2"]
     end
@@ -96,9 +97,7 @@ describe HammerCLIForeman::Hostgroup do
   context "SetParameterCommand" do
 
     before :each do
-      resource_mock = ApipieResourceMock.new(cmd.class.resource.resource_class)
-      resource_mock.stub_method(:index, [])
-      cmd.class.resource resource_mock
+      ResourceMocks.parameters_index
     end
 
     let(:cmd) { HammerCLIForeman::Hostgroup::SetParameterCommand.new("", ctx) }
@@ -129,7 +128,7 @@ describe HammerCLIForeman::Hostgroup do
   context "SCParamsCommand" do
 
     before :each do
-      cmd.class.resource ResourceMocks.smart_class_parameter
+      ResourceMocks.smart_class_parameters_index
     end
 
     let(:cmd) { HammerCLIForeman::Hostgroup::SCParamsCommand.new("", ctx) }

data/test/unit/image_test.rb

@@ -10,7 +10,6 @@ describe HammerCLIForeman::Image do
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -21,11 +20,11 @@ describe HammerCLIForeman::Image do
     context "parameters" do
       it_should_accept "compute resource name", ["--compute-resource=cr"]
       it_should_accept "compute resource id", ["--compute-resource-id=1"]
-      # it_should_accept_search_params
+      #it_should_accept_search_params
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index, :compute_resource_id=>1).length }
 
       with_params ["--compute-resource-id=1"] do
         it_should_print_n_records
@@ -49,7 +48,7 @@ describe HammerCLIForeman::Image do
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       with_params ["--compute-resource-id=1", "--id=1"] do
         it_should_print_n_records 1
@@ -69,11 +68,11 @@ describe HammerCLIForeman::Image do
     let(:cmd) { HammerCLIForeman::Image::AvailableImagesCommand.new("", ctx) }
 
     before :each do
-      resource_mock = ApipieResourceMock.new(cmd.class.resource.resource_class)
-      resource_mock.stub_method(:available_images, [])
-      cmd.class.resource resource_mock
+
+      ResourceMocks.compute_resources_available_images
     end
 
+
     context "parameters" do
       it_should_accept "compute resource name", ["--compute-resource=cr"]
       it_should_accept "compute resource id", ["--compute-resource-id=1"]

data/test/unit/location_test.rb

@@ -7,10 +7,6 @@ describe HammerCLIForeman::Location do
   extend ResourceDisabled
 
   before :each do
-    resource_mock = ApipieResourceMock.new(cmd.class.resource.resource_class)
-    resource_mock.stub_method(:index, [])
-    resource_mock.stub_method(:show, {})
-    cmd.class.resource resource_mock
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -18,13 +14,17 @@ describe HammerCLIForeman::Location do
 
     let(:cmd) { HammerCLIForeman::Location::ListCommand.new("", ctx) }
 
+    before :each do
+      ResourceMocks.locations_index
+    end
+
     context "parameters" do
       it_should_accept "no arguments"
       it_should_accept_search_params
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
       it_should_print_column "Name"
@@ -39,6 +39,10 @@ describe HammerCLIForeman::Location do
 
     let(:cmd) { HammerCLIForeman::Location::InfoCommand.new("", ctx) }
 
+    before :each do
+      ResourceMocks.locations_show
+    end
+
     context "parameters" do
       it_should_accept "id", ["--id=1"]
       it_should_accept "name", ["--name=arch"]

data/test/unit/media_test.rb

@@ -1,13 +1,11 @@
 require File.join(File.dirname(__FILE__), 'test_helper')
 require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
 
-
 describe HammerCLIForeman::Medium do
 
   extend CommandTestHelper
 
   before :each do
-    cmd.class.resource ApipieResourceMock.new(cmd.class.resource.resource_class)
     cmd.stubs(:name_to_id).returns(1)
   end
 
@@ -21,7 +19,7 @@ describe HammerCLIForeman::Medium do
     end
 
     context "output" do
-      let(:expected_record_count) { cmd.resource.call(:index)[0].length }
+      let(:expected_record_count) { cmd.resource.call(:index).length }
 
       it_should_print_n_records
       it_should_print_column "Name"
@@ -31,7 +29,6 @@ describe HammerCLIForeman::Medium do
 
   end
 
-
   context "InfoCommand" do
 
     let(:cmd) { HammerCLIForeman::Medium::InfoCommand.new("", ctx) }
@@ -54,10 +51,8 @@ describe HammerCLIForeman::Medium do
         it_should_print_column "Updated at"
       end
     end
-
   end
 
-
   context "CreateCommand" do
 
     let(:cmd) { HammerCLIForeman::Medium::CreateCommand.new("", ctx) }
@@ -73,7 +68,6 @@ describe HammerCLIForeman::Medium do
     end
   end
 
-
   context "DeleteCommand" do
 
     let(:cmd) { HammerCLIForeman::Medium::DeleteCommand.new("", ctx) }
@@ -83,10 +77,8 @@ describe HammerCLIForeman::Medium do
       it_should_accept "id", ["--id=1"]
       it_should_fail_with "name or id missing", []
     end
-
   end
 
-
   context "UpdateCommand" do
 
     let(:cmd) { HammerCLIForeman::Medium::UpdateCommand.new("", ctx) }