hammer_cli 3.1.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 510f07df29c39c069ae58e923507361a276e12ef50cc38628868361794a7754c
-  data.tar.gz: 13790a4114574688531978c11a9bb479062381d1b5196168f6d0e70deddc6a43
+  metadata.gz: 8a4ae8103129f5454bb936dbb55071ee6710e70f7ea90404d8f32f024d006b18
+  data.tar.gz: 928d97708685626852128ba704d638a7c02e5119d122cd658ae8421780f73854
 SHA512:
-  metadata.gz: a8bd5241448ccae9b7bd27f4260ebe5cbc8d75f2a79dcf76fb710c13e7bba42275cda6332acd6b67c33125572393b17e1f2d1575166ce8edfc76c7a81cdb9854
-  data.tar.gz: 9656ed10f1c8d44f35f0d321e1568d82a9607dc82b5ecf3e03999ec471eb67aa5dc119fcc31c90b1f540bab4a3d5abc5eff444d498eb275a7e0b061c61426fcf
+  metadata.gz: 5b9e62f788e6f7e70a72a4f588d955cc9fd9b690e7ec074098f52805a61a721294a51c35fb92202c4dda4c18752e1694409ebaa67285be5bc350ae20cf47ff51
+  data.tar.gz: ea53be858296c5a99db9c2cc11ce9e1916b807863972dec3da6412633d51019cbdfc5758dfb37a20aca55e81d755f7cd43a018c5b881e399811c80c7f7f92396

data/doc/release_notes.md

@@ -1,5 +1,15 @@
 Release notes
 =============
+### 3.3.0 (2022-05-10)
+* Fix hammer shell with pipe as stdin ([PR #360](https://github.com/theforeman/hammer-cli/pull/360)), [#34724](http://projects.theforeman.org/issues/34724)
+* Bump to 3.3.0-develop
+
+### 3.2.0 (2022-02-10)
+* Fix fr translation ([PR #358](https://github.com/theforeman/hammer-cli/pull/358)), [#34204](http://projects.theforeman.org/issues/34204)
+* Add missing_args_error_result test helper ([PR #357](https://github.com/theforeman/hammer-cli/pull/357))
+* Allow explicit strings in key=value options ([PR #356](https://github.com/theforeman/hammer-cli/pull/356)), [#34079](http://projects.theforeman.org/issues/34079)
+* Bump to 3.2.0-develop
+
 ### 3.1.0 (2021-11-10)
 * Remove a space in hammer's shebang, [#33810](http://projects.theforeman.org/issues/33810)
 * Revert fix rake version

data/lib/hammer_cli/options/normalizers.rb

@@ -104,15 +104,13 @@ module HammerCLI
 
         def strip_value(value)
           if value.is_a? Array
-            value.map do |item|
-              strip_chars(item.strip, '"\'')
-            end
+            value.map(&:strip)
           elsif value.is_a? Hash
             value.map do |key, val|
-              [strip_chars(key.strip, '"\''), strip_chars(val.strip, '"\'')]
+              [strip_chars(key.strip, '"\''), val.strip]
             end.to_h
           else
-            strip_chars(value.strip, '"\'')
+            value.strip
           end
         end
 

data/lib/hammer_cli/shell.rb

@@ -86,7 +86,7 @@ module HammerCLI
       Readline.completer_word_break_characters = ' ='
       Readline.completion_proc = complete_proc
 
-      stty_save = `stty -g`.chomp
+      stty_save = `stty -g`.chomp if $stdin.tty?
 
       history = ShellHistory.new(Settings.get(:ui, :history_file) || DEFAULT_HISTORY_FILE)
 
@@ -102,7 +102,8 @@ module HammerCLI
       rescue Interrupt; end
 
       puts
-      system('stty', stty_save) # Restore
+      # Restore
+      system('stty', stty_save) if $stdin.tty?
       HammerCLI::EX_OK
     end
 

data/lib/hammer_cli/testing/command_assertions.rb

@@ -94,6 +94,20 @@ module HammerCLI
         end
       end
 
+      def missing_args_error(command, opts, heading = nil)
+        opts = Array(opts).map { |o| "'#{o}'" }.join(', ')
+        message = "  Missing arguments for #{opts}."
+        if heading.nil?
+          ["Could not #{command[-1]} the #{command[-2]}:",
+           message,
+           ''].join("\n")
+        else
+          ["#{heading}:",
+           message,
+           ''].join("\n")
+        end
+      end
+
       def usage_error_result(command, message, heading=nil)
         expected_result = CommandExpectation.new
         expected_result.expected_err = usage_error(command, message, heading)
@@ -115,6 +129,13 @@ module HammerCLI
         expected_result
       end
 
+      def missing_args_error_result(command, opts, heading = nil)
+        expected_result = CommandExpectation.new
+        expected_result.expected_err = missing_args_error(command, opts, heading)
+        expected_result.expected_exit_code = HammerCLI::EX_USAGE
+        expected_result
+      end
+
       def success_result(message)
         CommandExpectation.new(message)
       end

data/lib/hammer_cli/version.rb

@@ -1,5 +1,5 @@
 module HammerCLI
   def self.version
-    @version ||= Gem::Version.new "3.1.0"
+    @version ||= Gem::Version.new "3.3.0"
   end
 end

data/test/unit/options/normalizers_test.rb

@@ -177,16 +177,20 @@ describe HammerCLI::Options::Normalizers do
         formatter.format("a= 1 , b = 2 ,c =3").must_equal({'a' => '1', 'b' => '2', 'c' => '3'})
       end
 
-      it "should parse a comma separated string with spaces using single quotes" do
-        formatter.format("a= ' 1 ' , b =' 2',c ='3'").must_equal({'a' => ' 1 ', 'b' => ' 2', 'c' => '3'})
+      it 'should parse a comma separated string with spaces using single quotes' do
+        formatter.format("a= ' 1 ' , b =' 2',c ='3'").must_equal({ 'a' => "' 1 '", 'b' => "' 2'", 'c' => "'3'" })
       end
 
-      it "should parse a comma separated string with spaces using double quotes" do
-        formatter.format("a= \" 1 \" , b =\" 2\",c =\"3\"").must_equal({'a' => ' 1 ', 'b' => ' 2', 'c' => '3'})
+      it 'should parse a comma separated string with spaces using double quotes' do
+        formatter.format('a= " 1 " , b =" 2",c ="3"').must_equal({ 'a' => '" 1 "', 'b' => '" 2"', 'c' => '"3"' })
       end
 
-      it "should deal with equal sign in value" do
-        formatter.format("a=1,b='2=2',c=3").must_equal({'a' => '1', 'b' => '2=2', 'c' => '3'})
+      it 'should deal with equal sign in string value' do
+        formatter.format("a=1,b='2=2',c=3").must_equal({ 'a' => '1', 'b' => "'2=2'", 'c' => '3' })
+      end
+
+      it 'should deal with equal sign in value' do
+        formatter.format('a=1,b=2=2,c=3').must_equal({ 'a' => '1', 'b' => '2=2', 'c' => '3' })
       end
 
       it "should parse arrays" do
@@ -197,12 +201,20 @@ describe HammerCLI::Options::Normalizers do
         formatter.format("a=1,b=[1, 2, 3],c=3").must_equal({'a' => '1', 'b' => ['1', '2', '3'], 'c' => '3'})
       end
 
-      it "should parse arrays with spaces using by single quotes" do
-        formatter.format("a=1,b=['1 1', ' 2 ', ' 3 3'],c=3").must_equal({'a' => '1', 'b' => ['1 1', ' 2 ', ' 3 3'], 'c' => '3'})
+      it 'should parse arrays with spaces using by single quotes' do
+        formatter.format("a=1,b=['1 1', ' 2 ', ' 3 3'],c=3").must_equal(
+          { 'a' => '1', 'b' => ["'1 1'", "' 2 '", "' 3 3'"], 'c' => '3' }
+        )
+      end
+
+      it 'should parse arrays with spaces using by double quotes' do
+        formatter.format('a=1,b=["1 1", " 2 ", " 3 3"],c=3').must_equal(
+          { 'a' => '1', 'b' => ['"1 1"', '" 2 "', '" 3 3"'], 'c' => '3' }
+        )
       end
 
-      it "should parse arrays with spaces using by double quotes" do
-        formatter.format("a=1,b=[\"1 1\", \" 2 \", \" 3 3\"],c=3").must_equal({'a' => '1', 'b' => ['1 1', ' 2 ', ' 3 3'], 'c' => '3'})
+      it 'should parse arrays with spaces' do
+        formatter.format('a=1,b=[1 1,  2 ,  3 3],c=3').must_equal({ 'a' => '1', 'b' => ['1 1', '2', '3 3'], 'c' => '3' })
       end
 
       it "should parse array with one item" do
@@ -226,6 +238,10 @@ describe HammerCLI::Options::Normalizers do
       it "should parse a comma separated string 2" do
         proc { formatter.format("a=1,b,c=3") }.must_raise ArgumentError
       end
+
+      it 'should parse explicit strings' do
+        formatter.format('name="*"').must_equal({ 'name' => '"*"' })
+      end
     end
 
     describe 'json format' do

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: hammer_cli
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Martin Bačovský
 - Tomáš Strachota
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-11-10 00:00:00.000000000 Z
+date: 2022-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp
@@ -135,17 +135,17 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: 0.5.0
 description: 'Hammer cli provides universal extendable CLI interface for ruby apps
 
-'
+  '
 email: mbacovsk@redhat.com
 executables:
 - hammer
@@ -163,6 +163,7 @@ extra_rdoc_files:
 - doc/option_normalizers.md
 - doc/writing_a_plugin.md
 - doc/installation_source.md
+- doc/creating_commands.md
 - doc/release_notes.md
 - doc/commands_extension.md
 - doc/commands_modification.md
@@ -172,10 +173,9 @@ extra_rdoc_files:
 - doc/installation_rpm.md
 - doc/output.md
 - doc/review_checklist.md
-- doc/creating_commands.md
 - config/cli.modules.d/module_config_template.yml
-- config/cli_config.template.yml
 - config/hammer.completion
+- config/cli_config.template.yml
 - README.md
 files:
 - LICENSE
@@ -379,7 +379,7 @@ homepage: https://github.com/theforeman/hammer-cli
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -395,7 +395,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Universal command-line interface
 test_files:
@@ -414,8 +414,8 @@ test_files:
 - test/unit/connection_test.rb
 - test/unit/csv_parser_test.rb
 - test/unit/defaults_test.rb
-- test/unit/fixtures/apipie/architectures.json
 - test/unit/fixtures/apipie/documented.json
+- test/unit/fixtures/apipie/architectures.json
 - test/unit/fixtures/certs/ca_cert.pem
 - test/unit/fixtures/certs/non_ca_cert.pem
 - test/unit/fixtures/defaults/defaults.yml
@@ -443,9 +443,9 @@ test_files:
 - test/unit/options/sources/command_line_test.rb
 - test/unit/options/sources/saved_defaults_test.rb
 - test/unit/options/validators/dsl_test.rb
-- test/unit/options/normalizers_test.rb
 - test/unit/options/option_family_test.rb
 - test/unit/options/option_definition_test.rb
+- test/unit/options/normalizers_test.rb
 - test/unit/output/adapter/abstract_test.rb
 - test/unit/output/adapter/base_test.rb
 - test/unit/output/adapter/csv_test.rb