haml_lint 0.55.0 → 0.57.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54085c44173d09dee5402e01e6d0d6daedd8cafcf9bd680c9ff0dd58a56648ad
-  data.tar.gz: '09cca038ff259c096d34398dc23f07d1c2a89af596eeb72389dc5e14d2aeb0af'
+  metadata.gz: '092e548aae63e23d9c6a5c3c11087590219e52792459ee548a5802503e80f6ec'
+  data.tar.gz: 120a88fbfb5b78e5d08724dffc9c7cf22292e391633c780da94161295ea745e0
 SHA512:
-  metadata.gz: 15dfc1078747b42d5bba6af59adcf98803f05bfbc228e30322420e9c4876ba47c202a6d89412e1e30de72cfba5bc2cf1b9ffebe105717e76ee167df4540de591
-  data.tar.gz: 0f5d12c1c4336536d3574b5d40ebb8cad94af8124def6b5273148c984271dd7e4e10c8abea51bb69d4d3ee2208fccc5a76d94060d9c6db811c19b8621fbde501
+  metadata.gz: 5123d876bb4b79d4fbf14fae8acef295993c909baaee63975f899571fe450cf67f503c761b2628ddb96874f39a4be51a8c489ddb94a87eb95034e3a05ba44431
+  data.tar.gz: 152d02d1daa2f51e9c0ddca5602d74642b324e860daa33aeec715ff4e2be297054abaf0d35dd9d15cfafcf15955bfce48823575643b18c4375707f172621eb66

data/lib/haml_lint/reporter/github_reporter.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: false
+
+module HamlLint
+  # Outputs GitHub workflow commands for GitHub check annotations when run within GitHub actions.
+  class Reporter::GithubReporter < Reporter
+    ESCAPE_MAP = { '%' => '%25', "\n" => '%0A', "\r" => '%0D' }.freeze
+
+    include Reporter::Utils
+
+    def added_lint(lint, report)
+      if lint.severity >= report.fail_level
+        print_workflow_command(lint: lint)
+      else
+        print_workflow_command(severity: 'warning', lint: lint)
+      end
+    end
+
+    def display_report(report)
+      print_summary(report)
+    end
+
+    private
+
+    def print_workflow_command(lint:, severity: 'error')
+      log.log "::#{severity} file=#{lint.filename},line=#{lint.line}::#{github_escape(lint.message)}"
+    end
+
+    def github_escape(string)
+      string.gsub(Regexp.union(ESCAPE_MAP.keys), ESCAPE_MAP)
+    end
+  end
+end

data/lib/haml_lint/ruby_extraction/chunk_extractor.rb

@@ -247,31 +247,29 @@ module HamlLint::RubyExtraction
     def visit_tag(node)
       indent = @original_haml_lines[node.line - 1].index(/\S/)
 
+      @ruby_chunks << PlaceholderMarkerChunk.new(node, 'tag', indent: indent)
+
+      current_line_index = visit_tag_attributes(node, indent: indent)
+      visit_tag_script(node, line_index: current_line_index, indent: indent)
+
       # We don't want to use a block because assignments in a block are local to that block,
       # so the semantics of the extracted ruby would be different from the one generated by
       # Haml. Those differences can make some cops, such as UselessAssignment, have false
       # positives
       code = 'begin'
-      @ruby_chunks << AdHocChunk.new(node,
-                                     [' ' * indent + code])
-      indent += 2
-
-      tag_chunk = PlaceholderMarkerChunk.new(node, 'tag', indent: indent)
-      @ruby_chunks << tag_chunk
+      begin_chunk = AdHocChunk.new(node, [' ' * indent + code])
+      @ruby_chunks << begin_chunk
 
-      current_line_index = visit_tag_attributes(node, indent: indent)
-      visit_tag_script(node, line_index: current_line_index, indent: indent)
+      indent += 2
 
       yield
 
       indent -= 2
 
-      if @ruby_chunks.last.equal?(tag_chunk)
+      if @ruby_chunks.last.equal?(begin_chunk)
         # So there is nothing going "in" the tag, remove the wrapping "begin" and replace the PlaceholderMarkerChunk
         # by one less indented
         @ruby_chunks.pop
-        @ruby_chunks.pop
-        @ruby_chunks << PlaceholderMarkerChunk.new(node, 'tag', indent: indent)
       else
         @ruby_chunks << AdHocChunk.new(node,
                                        [' ' * indent + 'ensure', ' ' * indent + '  HL.noop', ' ' * indent + 'end'],
@@ -600,9 +598,12 @@ module HamlLint::RubyExtraction
         return [char_index, [haml_processed_ruby_code]]
       end
 
-      min_non_white_chars_to_add = haml_processed_ruby_code.scan(/\S/).size
+      # The +1 is for the closing brace, which we need
+      min_non_white_chars_to_add = haml_processed_ruby_code.scan(/\S/).size + 1
 
-      regexp = HamlLint::Utils.regexp_for_parts(haml_processed_ruby_code.split(/\s+/), '\\s+')
+      regexp = HamlLint::Utils.regexp_for_parts(
+        haml_processed_ruby_code.split(/\s+/), '\\s+', prefix: '\s*', suffix: '\s*(?=[)}])'
+      )
 
       joined_lines = first_line.rstrip
       process_multiline!(joined_lines)
@@ -624,7 +625,7 @@ module HamlLint::RubyExtraction
 
       first_line_offset = match.begin(0)
       raw_ruby = match[0]
-      ruby_lines = raw_ruby.split("\n")
+      ruby_lines = raw_ruby.split("\n", -1)
 
       [first_line_offset, ruby_lines]
     end

data/lib/haml_lint/spec/shared_rubocop_autocorrect_context.rb

@@ -115,7 +115,7 @@ module HamlLint
 
           syntax_lints = subject.lints.select { |lint| lint.message =~ %r{Lint/Syntax} }
 
-          if start_ruby.strip != 'SKIP' && subject.last_extracted_source
+          if start_ruby.strip != 'SKIP' && subject.last_extracted_source && ENV['UPDATE_EXAMPLES'] != '1'
             matcher = eq(start_ruby)
             subject.last_extracted_source.source.should(
               matcher,
@@ -125,7 +125,7 @@ module HamlLint
 
           syntax_lints.should(be_empty, "Generated Ruby has Syntax Lints:\n#{format_lints(syntax_lints)}")
 
-          if end_ruby.strip != 'SKIP' && subject.last_new_ruby_source
+          if end_ruby.strip != 'SKIP' && subject.last_new_ruby_source && ENV['UPDATE_EXAMPLES'] != '1'
             matcher = eq(end_ruby)
             subject.last_new_ruby_source.should(
               matcher,
@@ -141,10 +141,40 @@ module HamlLint
             -> { "Final HAML is different from expected. #{matcher.failure_message}\n#{format_lints}" }
           )
 
-          if subject.last_extracted_source && start_ruby.strip != 'SKIP'
+          if subject.last_extracted_source && start_ruby.strip != 'SKIP' && ENV['UPDATE_EXAMPLES'] != '1'
             subject.last_extracted_source.source_map.should == source_map
           end
 
+          if ENV['UPDATE_EXAMPLES'] == '1' && respond_to?(:example_first_line_no) &&
+              start_ruby.strip != 'SKIP' && end_ruby.strip != 'SKIP'
+            original_content = File.read(example_path)
+            old_steps_string = '---' + steps_string.partition('---').last.rpartition('---').first + '---'
+
+            if old_steps_string.scan(/\$\$\d+/).tally.values.any? { |v| v > 1 }
+              # If the $$3 was there twice, let's not update the example
+              return
+            end
+            original_content.scan(old_steps_string).count
+
+            new_generated_ruby_lines = subject.last_extracted_source.source.split("\n", -1)
+            last_seen_haml_line_no = 1
+            subject.last_extracted_source.source_map.each do |ruby_line_no, haml_line_no|
+              if haml_line_no != last_seen_haml_line_no
+                last_seen_haml_line_no = haml_line_no
+                new_generated_ruby_lines[ruby_line_no - 1] += " $$#{haml_line_no}"
+              end
+            end
+
+            new_steps_string = <<~NEW.chop # Chop to remove the added newlines
+              ---
+              #{new_generated_ruby_lines.join("\n")}---
+              #{subject.last_new_ruby_source}---
+            NEW
+
+            new_content = original_content.gsub(old_steps_string, new_steps_string)
+            File.write(example_path, new_content)
+          end
+
           haml_different = start_haml != end_haml
           document.source_was_changed.should == haml_different
         end

data/lib/haml_lint/utils.rb

@@ -277,8 +277,9 @@ module HamlLint
       $stdin = original_stdin
     end
 
-    def regexp_for_parts(parts, join_regexp)
+    def regexp_for_parts(parts, join_regexp, prefix: nil, suffix: nil)
       regexp_code = parts.map { |c| Regexp.quote(c) }.join(join_regexp)
+      regexp_code = "#{prefix}#{regexp_code}#{suffix}"
       Regexp.new(regexp_code)
     end
   end

data/lib/haml_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module HamlLint
-  VERSION = '0.55.0'
+  VERSION = '0.57.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: haml_lint
 version: !ruby/object:Gem::Version
-  version: 0.55.0
+  version: 0.57.0
 platform: ruby
 authors:
 - Shane da Silva
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-23 00:00:00.000000000 Z
+date: 2024-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: haml
@@ -153,6 +153,7 @@ files:
 - lib/haml_lint/reporter/checkstyle_reporter.rb
 - lib/haml_lint/reporter/default_reporter.rb
 - lib/haml_lint/reporter/disabled_config_reporter.rb
+- lib/haml_lint/reporter/github_reporter.rb
 - lib/haml_lint/reporter/hash_reporter.rb
 - lib/haml_lint/reporter/hooks.rb
 - lib/haml_lint/reporter/json_reporter.rb
@@ -200,7 +201,7 @@ homepage: https://github.com/sds/haml-lint
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -215,8 +216,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: HAML lint tool
 test_files: []