halite 1.0.0.rc.1 → 1.0.0

data/spec/converter/metadata_spec.rb

@@ -1,16 +1,42 @@
+#
+# Copyright 2015, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 require 'spec_helper'
-require 'halite/converter/metadata'
-require 'halite/dependencies'
 
 describe Halite::Converter::Metadata do
   describe '#generate' do
     let(:gem_name) { 'mygem' }
     let(:cookbook_name) { gem_name }
     let(:version) { '1.0.0' }
-    let(:license_header) { '' }
     let(:cookbook_dependencies) { [] }
-    let(:spec) { double(name: gem_name, cookbook_name: cookbook_name, version: version, license_header: license_header, cookbook_dependencies: cookbook_dependencies.map {|dep| Halite::Dependencies::Dependency.new(*dep) }) }
-    subject { described_class.generate(spec) }
+    let(:spec) do
+      instance_double('Gem::Specification', description: '')
+    end
+    let(:gem_data) do
+      instance_double('Halite::Gem',
+        cookbook_dependencies: cookbook_dependencies.map {|dep| Halite::Dependencies::Dependency.new(*dep) },
+        cookbook_name: cookbook_name,
+        find_misc_path: nil,
+        license_header: '',
+        name: gem_name,
+        spec: spec,
+        version: version,
+      )
+    end
+    subject { described_class.generate(gem_data) }
 
     context 'with simple data' do
       it { is_expected.to eq <<-EOH }
@@ -20,7 +46,9 @@ EOH
     end # /context with simple data
 
     context 'with a license header' do
-      let(:license_header) { "# header\n" }
+      before do
+        allow(gem_data).to receive(:license_header).and_return("# header\n")
+      end
       it { is_expected.to eq <<-EOH }
 # header
 name "mygem"
@@ -33,7 +61,7 @@ EOH
       it { is_expected.to eq <<-EOH }
 name "mygem"
 version "1.0.0"
-depends "other", ">= 0"
+depends "other"
 EOH
     end # /context with one dependency
 
@@ -46,10 +74,35 @@ depends "other", "~> 1.0"
 depends "another", "~> 2.0.0"
 EOH
     end # /context with two dependencies
+
+    context 'with a description' do
+      before do
+        allow(spec).to receive(:description).and_return('My awesome library!')
+      end
+
+      it { is_expected.to eq <<-EOH }
+name "mygem"
+version "1.0.0"
+description "My awesome library!"
+EOH
+    end # /context with a description
+
+    context 'with a readme' do
+      before do
+        allow(gem_data).to receive(:find_misc_path).and_return('/source/README.md')
+        allow(IO).to receive(:read).with('/source/README.md').and_return("My awesome readme!\nCopyright me.\n")
+      end
+
+      it { is_expected.to eq <<-'EOH' }
+name "mygem"
+version "1.0.0"
+long_description "My awesome readme!\nCopyright me.\n"
+EOH
+    end # /context with a readme
   end # /describe #generate
 
   describe '#write' do
-    let(:output) { double('output') } # sentinel
+    let(:output) { double('output sentinel') }
     before { allow(described_class).to receive(:generate).and_return(output) }
 
     it 'should write out metadata' do

data/spec/converter/misc_spec.rb

@@ -0,0 +1,61 @@
+#
+# Copyright 2015, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Halite::Converter::Misc do
+  describe '#write' do
+    let(:files) { [] }
+    let(:gem_data) do
+      instance_double('Halite::Gem').tap do |d|
+        allow(d).to receive(:find_misc_path) do |name|
+          if files.include?(name)
+            "/source/#{name}"
+          else
+            nil
+          end
+        end
+      end
+    end
+    subject { described_class.write(gem_data, '/test') }
+
+    context 'with no files' do
+      it do
+        expect(FileUtils).to_not receive(:copy)
+        subject
+      end
+    end # /context with no files
+
+    context 'with a Readme' do
+      let(:files) { 'Readme' }
+
+      it do
+        expect(FileUtils).to receive(:copy).with('/source/Readme', '/test/Readme', preserve: true)
+        subject
+      end
+    end # /context with a Readme
+
+    context 'with multiple files' do
+      let(:files) { %w{Readme License} }
+
+      it 'writes out a README' do
+        expect(FileUtils).to receive(:copy).with('/source/Readme', '/test/Readme', preserve: true)
+        expect(FileUtils).to receive(:copy).with('/source/License', '/test/License', preserve: true)
+        subject
+      end
+    end # /context with multiple files
+  end # /describe #write
+end

data/spec/converter_spec.rb

@@ -1,13 +1,28 @@
+#
+# Copyright 2015, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 require 'spec_helper'
-require 'halite/converter'
 
 describe Halite::Converter do
   describe '#write' do
-    it 'should call all submodules' do
-      expect(Halite::Converter::Metadata).to receive(:write).ordered
-      expect(Halite::Converter::Libraries).to receive(:write).ordered
-      expect(Halite::Converter::Other).to receive(:write).ordered
-      expect(Halite::Converter::Readme).to receive(:write).ordered
+    it do
+      expect(Halite::Converter::Metadata).to receive(:write)
+      expect(Halite::Converter::Libraries).to receive(:write)
+      expect(Halite::Converter::Chef).to receive(:write)
+      expect(Halite::Converter::Misc).to receive(:write)
       described_class.write(nil, '/test')
     end
   end

data/spec/dependencies_spec.rb

@@ -1,17 +1,46 @@
+#
+# Copyright 2015, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 require 'spec_helper'
 require 'halite/dependencies'
 
 describe Halite::Dependencies do
+  def fake_gem(name='name', version='1.0.0', &block)
+    Gem::Specification.new do |s|
+      s.name = name
+      s.version = Gem::Version.new(version)
+      block.call(s) if block
+    end
+  end
+
+  let(:gem_stubs) do
+    [
+      fake_gem('gem1'),
+      fake_gem('gem2') {|s| s.requirements << 'dep2' },
+      fake_gem('gem3') {|s| s.add_dependency 'halite' },
+    ]
+  end
+
   before do
-    allow(Gem::Specification).to receive(:stubs).and_return([
-      Gem::Specification.new {|s| s.name = 'gem1'; s.version = Gem::Version.new('1.0.0') },
-      Gem::Specification.new {|s| s.name = 'gem2'; s.version = Gem::Version.new('1.0.0'); s.requirements << 'dep2' },
-    ])
+    allow(Gem::Specification).to receive(:stubs).and_return(gem_stubs)
   end
 
   describe '#extract_from_requirements' do
     let(:requirements) { [] }
-    subject { described_class.extract_from_requirements(Gem::Specification.new {|s| s.name = 'name'; s.version = Gem::Version.new('1.0.0'); s.requirements += requirements }) }
+    subject { described_class.extract_from_requirements(fake_gem {|s| s.requirements += requirements }) }
 
     context 'with []' do
       it { is_expected.to eq [] }
@@ -31,7 +60,7 @@ describe Halite::Dependencies do
 
   describe '#extract_from_metadata' do
     let(:metadata) { nil }
-    subject { described_class.extract_from_metadata(Gem::Specification.new {|s| s.name = 'name'; s.version = Gem::Version.new('1.0.0'); s.metadata = {'halite_dependencies' => metadata} if metadata}) }
+    subject { described_class.extract_from_metadata(fake_gem {|s| s.metadata = {'halite_dependencies' => metadata} if metadata }) }
 
     context 'with no metadata' do
       it { is_expected.to eq [] }
@@ -48,6 +77,26 @@ describe Halite::Dependencies do
     end
   end # /describe #extract_from_metadata
 
+  describe '#extract_from_dependencies' do
+    let(:gemspec) { }
+    subject { described_class.extract_from_dependencies(gemspec) }
+
+    context 'with a halite-ish dependency' do
+      let(:gemspec) { fake_gem {|s| s.add_dependency 'gem3' } }
+      it { is_expected.to eq [['gem3', '>= 0', gem_stubs[2]]] }
+    end
+
+    context 'with a development dependency' do
+      let(:gemspec) { fake_gem {|s| s.add_development_dependency 'gem3' } }
+      it { is_expected.to eq [] }
+    end
+
+    context 'with a non-halite dependency' do
+      let(:gemspec) { fake_gem {|s| s.add_development_dependency 'gem1' } }
+      it { is_expected.to eq [] }
+    end
+  end # /describe #extract_from_dependencies
+
   describe '#clean' do
     let(:dependency) { nil }
     subject { described_class.clean(dependency) }
@@ -80,7 +129,7 @@ describe Halite::Dependencies do
 
     context 'with [name, = 1.0.0, = 1.0.0]' do
       let(:dependency) { ['name', '= 1.0.0', '= 1.0.0'] }
-      it { expect { subject }.to raise_error Halite::Dependencies::InvalidDependencyError }
+      it { expect { subject }.to raise_error Halite::InvalidDependencyError }
     end
   end # /describe #clean
 
@@ -146,17 +195,22 @@ describe Halite::Dependencies do
 
     context 'with 0' do
       let(:version) { '0' }
-      it { is_expected.to eq '0.0' }
+      it { is_expected.to eq '0' }
+    end
+
+    context 'with 0.0' do
+      let(:version) { '0.0' }
+      it { is_expected.to eq '0' }
     end
 
     context 'with 1.0.a' do
       let(:version) { '1.0.a' }
-      it { expect { subject }.to raise_error Halite::Dependencies::InvalidDependencyError }
+      it { expect { subject }.to raise_error Halite::InvalidDependencyError }
     end
 
     context 'with 1.2.3.4' do
       let(:version) { '1.2.3.4' }
-      it { expect { subject }.to raise_error Halite::Dependencies::InvalidDependencyError }
+      it { expect { subject }.to raise_error Halite::InvalidDependencyError }
     end
 
     context 'with 1.2.3' do

data/spec/example_resources/poise.rb

@@ -0,0 +1,42 @@
+#
+# Copyright 2015, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef/resource'
+require 'chef/provider'
+require 'poise'
+
+
+# A `halite_test_poise` resource for use in Halite's unit tests.
+module HaliteTestPoise
+  class Resource < Chef::Resource
+    include Poise
+    provides(:halite_test_poise)
+    actions(:run)
+  end
+
+  class Provider < Chef::Provider
+    include Poise
+    provides(:halite_test_poise)
+
+    def action_run
+      notifying_block do
+        ruby_block new_resource.name do
+          block { }
+        end
+      end
+    end
+  end
+end

data/spec/example_resources/simple.rb

@@ -0,0 +1,48 @@
+#
+# Copyright 2015, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'chef/resource'
+require 'chef/provider'
+
+
+# A `halite_test_simple` resource for use in Halite's unit tests.
+class Chef
+  class Resource::HaliteTestSimple < Resource
+    provides(:halite_test_simple) # For Chef >= 12.4
+
+    def initialize(*args)
+      super
+      @resource_name = :halite_test_simple
+      @action = :run
+      @allowed_actions << :run
+    end
+  end
+
+  class Provider::HaliteTestSimple < Provider
+    include Chef::DSL::Recipe
+
+    provides(:halite_test_simple) # For Chef >= 12.4
+
+    def load_current_resource
+    end
+
+    def action_run
+      ruby_block new_resource.name do
+        block { }
+      end
+    end
+  end
+end

data/spec/fixtures/cookbooks/test1/libraries/default.rb

@@ -0,0 +1,4 @@
+# coding: utf-8
+# Awesome license
+raise 'Halite is not compatible with no_lazy_load false, please set no_lazy_load true in your Chef configuration file.' unless Chef::Config[:no_lazy_load]
+$LOAD_PATH << File.expand_path('../../files/halite_gem', __FILE__)

data/spec/fixtures/cookbooks/test2/libraries/default.rb

@@ -0,0 +1,3 @@
+# coding: utf-8
+raise 'Halite is not compatible with no_lazy_load false, please set no_lazy_load true in your Chef configuration file.' unless Chef::Config[:no_lazy_load]
+$LOAD_PATH << File.expand_path('../../files/halite_gem', __FILE__)

data/spec/{data/integration_cookbooks → fixtures/cookbooks}/test2/metadata.rb

@@ -1,4 +1,4 @@
 # coding: utf-8
 name "test2"
 version "4.5.6"
-depends "testdep", ">= 0.0"
+depends "testdep"