hal-client 4.3.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 77b2bd2a2ee75f106ff5dfc1ca7af3bb49c53ac7
-  data.tar.gz: 5e2abf209a2e898da64afb88f0118a58a61a4c47
+  metadata.gz: 9c3528fbb7facf2ddaaf7cab9634d158b385edc3
+  data.tar.gz: c67b245256c4d41e8f859bfa90c0b2b14c58e450
 SHA512:
-  metadata.gz: 8bbbb2faa0fcc3cc2f072b9fff4e0acf582509cd554cd0884aaeaa95ddcba4a81fc800970139a37a66550189f7b07eee9d5c4a80a95a301d9fa26b358fa02725
-  data.tar.gz: 25982fec801a367a71d163ce0830e7cbaae826531a1d4d56505d2464a43c3264fb7865768adf740e0aeab7ad05363c5774c838fa1b9ca5d039614d99fdbbe8f1
+  metadata.gz: 296b8c5870795fb49c223bde5526ac3d2be9a9e506545919910752fb28bde495048e33bca1f24c4b88108c5ffbb127d328ac02f9e7752675ee3a2fbf017bcb53
+  data.tar.gz: 612db56ad0eb2dae52f6fd26004349d6d55bb2ec08471a645c6eafcb89e841ee79e95ef616e42935fbf236e0cefaf3e5eea2b40460e57f0cb4c2c10f69b853fb

data/README.md

@@ -188,6 +188,10 @@ Or install it yourself as:
 
     $ gem install hal-client
 
+## Upgrading from 4.x to 5.x
+
+`HalClient::RepresentationEditor#add_link` now raises if passed nil or empty values. This is the only breaking change.
+
 ## Upgrading from 3.x to 4.x
 
 Support for ruby 2.0 has been removed. Please upgrade to ruby 2.1 or later. No other breaking changes were made.

data/lib/hal_client/representation_editor.rb

@@ -122,6 +122,7 @@ class HalClient
     # opts
     #   :templated - is this link templated? Default: false
     def add_link(rel, target, opts={})
+      raise ArgumentError, "target must not be nil or empty" if target.nil? || target.empty?
       templated = opts.fetch(:templated, false)
 
       link_obj = { "href" => target.to_s }

data/lib/hal_client/version.rb

@@ -1,3 +1,3 @@
 class HalClient
-  VERSION = "4.3.0"
+  VERSION = "5.0.0"
 end

data/spec/hal_client/representation_editor_spec.rb

@@ -122,6 +122,14 @@ RSpec.describe HalClient::RepresentationEditor do
              .and have_link("about", with_href("http://example.com/another"))
     end
 
+    it "raises if target is nil" do
+      expect { subject.add_link("nowhere", nil) }.to raise_error(ArgumentError)
+    end
+
+    it "raises if target is empty" do
+      expect { subject.add_link("nowhere", "") }.to raise_error(ArgumentError)
+    end
+
     it "adds templated links" do
       expect(subject.add_link("related", "http://example.com/third{?wat}", templated: true))
         .to have_link "related", with_href("http://example.com/third{?wat}")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hal-client
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Peter Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-20 00:00:00.000000000 Z
+date: 2018-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http