hako 2.5.1 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 455bfab68b9704f5c88024b8b7cedf62e785c0402c7319a27cc7ad211d7469e5
-  data.tar.gz: 8e77ee272e621bd74313efa44fe3893a7ca321f70782a79080fcc93f565b0fe7
+  metadata.gz: 7b787a7d8f621f8f8c1f9c36b4d2f6388d537c58eb33a3b0f5ff084864187b68
+  data.tar.gz: b274e28a64b66a768aa782e80d42d5a8193cd46e85b5125726bf755ceef512d1
 SHA512:
-  metadata.gz: baa10b71b8e5082c3349651f5497d2dd46bc67f66b88245c13e535b40c6253a68402232e9596b21133c781b31c893c4a7792139688fda4fd3af5412d051bd80f
-  data.tar.gz: e24e45b42ddad5852bf55696126155a6268c807fbaf079978677270c86eaa89bc4b6011907b1201e08c8285a231e9f3a91f5c11a311495054d2d1c4e5734cccb
+  metadata.gz: 3dbfbe813c945a3c566200681c436e0efc95580a60c5db7750d7d584e81b7963cd31dc1e284cfd020aca0ad4104f4f7820133dab0f524759ee30dc8d1db7397b
+  data.tar.gz: 6c91241388f94a031a411fd0cbfa896da13a9a1a55db717c6878f1a954cf93c680956dbef983e59d8947955bc2a43b8495f1e742cfb98491bf4e3c9eba901c22

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# 2.6.0 (2018-12-13)
+## New features
+- Support `essential` parameter for each container
+  - The default value remains `true`
+
+## Bug fixes
+- Stop trying to deregister non-existent scalable target on `hako remove`
+- Update service when `health_check_grace_period_seconds` changes
+
 # 2.5.1 (2018-11-29)
 ## Bug fixes
 - Check secrets existence in dry-run mode

data/lib/hako/container.rb

@@ -26,6 +26,7 @@ module Hako
       memory
       memory_reservation
       links
+      essential
       command
       user
       privileged
@@ -221,6 +222,7 @@ module Hako
         'env' => {},
         'docker_labels' => {},
         'links' => [],
+        'essential' => true,
         'mount_points' => [],
         'port_mappings' => [],
         'volumes_from' => [],

data/lib/hako/schedulers/ecs.rb

@@ -45,7 +45,9 @@ module Hako
           @ecs_elb_v2_options['target_type'] = 'ip'
         end
         @dynamic_port_mapping = options.fetch('dynamic_port_mapping', @ecs_elb_options.nil?)
-        @health_check_grace_period_seconds = options.fetch('health_check_grace_period_seconds', nil)
+        @health_check_grace_period_seconds = options.fetch('health_check_grace_period_seconds') do
+          @ecs_elb_options || @ecs_elb_v2_options ? 0 : nil
+        end
         if options.key?('autoscaling')
           @autoscaling = EcsAutoscaling.new(options.fetch('autoscaling'), @region, ecs_elb_client, dry_run: @dry_run)
         end
@@ -303,9 +305,6 @@ module Hako
             ecs_client.delete_service(cluster: service.cluster_arn, service: service.service_arn)
             Hako.logger.info "#{service.service_arn} is deleted"
           end
-          if @autoscaling
-            @autoscaling.remove(service)
-          end
         else
           puts "Service #{@app_id} doesn't exist"
         end
@@ -599,7 +598,7 @@ module Hako
           memory_reservation: container.memory_reservation,
           links: container.links,
           port_mappings: container.port_mappings,
-          essential: true,
+          essential: container.essential,
           environment: environment,
           secrets: container.secrets,
           docker_labels: container.docker_labels,

data/lib/hako/schedulers/ecs_autoscaling.rb

@@ -113,24 +113,6 @@ module Hako
         nil
       end
 
-      # @param [Aws::ECS::Types::Service] service
-      # @return [nil]
-      def remove(service)
-        resource_id = service_resource_id(service)
-        service_namespace = 'ecs'
-        scalable_dimension = 'ecs:service:DesiredCount'
-
-        Hako.logger.info("Deregister scalable target #{resource_id} and its policies")
-        unless @dry_run
-          begin
-            autoscaling_client.deregister_scalable_target(service_namespace: service_namespace, resource_id: resource_id, scalable_dimension: scalable_dimension)
-          rescue Aws::ApplicationAutoScaling::Errors::ObjectNotFoundException => e
-            Hako.logger.warn(e)
-          end
-        end
-        nil
-      end
-
       # @param [Aws::ECS::Types::Service] service
       # @return [nil]
       def status(service)

data/lib/hako/schedulers/ecs_definition_comparator.rb

@@ -26,6 +26,7 @@ module Hako
           struct.member(:memory, Schema::Nullable.new(Schema::Integer.new))
           struct.member(:memory_reservation, Schema::Nullable.new(Schema::Integer.new))
           struct.member(:links, Schema::UnorderedArray.new(Schema::String.new))
+          struct.member(:essential, Schema::Boolean.new)
           struct.member(:port_mappings, Schema::UnorderedArray.new(port_mapping_schema))
           struct.member(:environment, Schema::UnorderedArray.new(environment_schema))
           struct.member(:secrets, Schema::Nullable.new(Schema::UnorderedArray.new(secrets_schema)))

data/lib/hako/schedulers/ecs_service_comparator.rb

@@ -25,6 +25,7 @@ module Hako
           struct.member(:deployment_configuration, Schema::WithDefault.new(deployment_configuration_schema, default_configuration))
           struct.member(:platform_version, Schema::String.new)
           struct.member(:network_configuration, Schema::Nullable.new(network_configuration_schema))
+          struct.member(:health_check_grace_period_seconds, Schema::Nullable.new(Schema::Integer.new))
         end
       end
 

data/lib/hako/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hako
-  VERSION = '2.5.1'
+  VERSION = '2.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hako
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 2.6.0
 platform: ruby
 authors:
 - Kohei Suzuki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-29 00:00:00.000000000 Z
+date: 2018-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-applicationautoscaling