hako 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 767220800b5dfd1061a252661ffbcbc906add32e8530ff6a995c0a7bd0ca8638
-  data.tar.gz: 2e55c3884f6fffd16c1be7c11d4d88bf25e92f8673d8879fe07bd0453fb60fb4
+  metadata.gz: 455bfab68b9704f5c88024b8b7cedf62e785c0402c7319a27cc7ad211d7469e5
+  data.tar.gz: 8e77ee272e621bd74313efa44fe3893a7ca321f70782a79080fcc93f565b0fe7
 SHA512:
-  metadata.gz: 240ca907d82750a600bcb21b94df017fc4b10732b78ede4e0025042957a0b0eadb3636512a0a4c0fdb59cff31ebb0e541da067397bad6a8da0ffb3a3293cfbec
-  data.tar.gz: c9949c11c16665d5efebe91e92acf30df5ae0c5cdd4d229e0f2b8711e503d5e43267aa233f6830ad6e24fba6f9bc8dbcd4c3a4e4efddb67c31d8861c8558cc4a
+  metadata.gz: baa10b71b8e5082c3349651f5497d2dd46bc67f66b88245c13e535b40c6253a68402232e9596b21133c781b31c893c4a7792139688fda4fd3af5412d051bd80f
+  data.tar.gz: e24e45b42ddad5852bf55696126155a6268c807fbaf079978677270c86eaa89bc4b6011907b1201e08c8285a231e9f3a91f5c11a311495054d2d1c4e5734cccb

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.5.1 (2018-11-29)
+## Bug fixes
+- Check secrets existence in dry-run mode
+
 # 2.5.0 (2018-11-22)
 ## New features
 - Add `load_balancer_name` and `target_group_name` option to skip creating ELB

data/hako.gemspec

@@ -31,6 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'aws-sdk-elasticloadbalancingv2'
   spec.add_dependency 'aws-sdk-s3'
   spec.add_dependency 'aws-sdk-sns'
+  spec.add_dependency 'aws-sdk-ssm'
   spec.add_dependency 'jsonnet'
 
   spec.add_development_dependency 'bundler'

data/lib/hako/schedulers/ecs.rb

@@ -5,6 +5,7 @@ require 'aws-sdk-ec2'
 require 'aws-sdk-ecs'
 require 'aws-sdk-s3'
 require 'aws-sdk-sns'
+require 'aws-sdk-ssm'
 require 'hako'
 require 'hako/error'
 require 'hako/scheduler'
@@ -104,6 +105,7 @@ module Hako
           end
           definitions.each do |d|
             print_definition_in_cli_format(d)
+            check_secrets(d)
           end
           if @autoscaling
             @autoscaling.apply(Aws::ECS::Types::Service.new(cluster_arn: @cluster, service_name: @app_id))
@@ -192,6 +194,7 @@ module Hako
               d[:command] = commands
             end
             print_definition_in_cli_format(d, additional_env: env)
+            check_secrets(d)
           end
           0
         else
@@ -337,6 +340,11 @@ module Hako
         @ec2_client ||= Aws::EC2::Client.new(region: @region)
       end
 
+      # @return [Aws::SSM::Client]
+      def ssm_client
+        @ssm_client ||= Aws::SSM::Client.new(region: @region)
+      end
+
       # @return [EcsElb, EcsElbV2]
       def ecs_elb_client
         @ecs_elb_client ||=
@@ -1221,6 +1229,27 @@ module Hako
         nil
       end
 
+      # @param [Hash] container_definition
+      # @return [nil]
+      def check_secrets(container_definition)
+        parameter_names = (container_definition[:secrets] || []).map { |secret| secret.fetch(:value_from) }
+        invalid_parameter_names = parameter_names.each_slice(10).flat_map do |names|
+          names = names.map do |name|
+            if name.start_with?('arn:')
+              name.slice(%r{:parameter(/.+)\z}, 1)
+            else
+              name
+            end
+          end
+          ssm_client.get_parameters(names: names).invalid_parameters
+        end
+        unless invalid_parameter_names.empty?
+          raise Error.new("Invalid parameters for secrets: #{invalid_parameter_names}")
+        end
+
+        nil
+      end
+
       # @param [Aws::ECS::Types::Service] service
       # @return [nil]
       def warn_placement_policy_change(service)

data/lib/hako/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hako
-  VERSION = '2.5.0'
+  VERSION = '2.5.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hako
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Kohei Suzuki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-22 00:00:00.000000000 Z
+date: 2018-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-applicationautoscaling
@@ -150,6 +150,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-ssm
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jsonnet
   requirement: !ruby/object:Gem::Requirement