hairtrigger 0.2.10 → 0.2.11

data/README.md

@@ -276,6 +276,22 @@ User.triggers.each(&:validate!)
 HairTrigger does not validate your SQL, so be sure to test it in all databases
 you want to support.
 
+### PostgreSQL NOTICEs
+
+When running a trigger migration, you might notice some PostgreSQL
+NOTICEs like so:
+
+```
+NOTICE:  trigger "foo_bar_baz" for table "quux" does not exist, skipping
+NOTICE:  function foo_bar_baz() does not exist, skipping
+```
+
+This happens because HairTrigger will attempt to drop the existing
+trigger/function if it already exists. These notices are safe to
+ignore. Note that this behavior [may change](https://github.com/jenseng/hair_trigger/issues/28)
+in a future release, meaning you'll first need to explicitly drop the
+existing trigger if you wish to redefine it.
+
 ## Gotchas
 
 * As is the case with ActiveRecord::Base.update_all or any direct SQL you do,
@@ -301,7 +317,7 @@ you want to support.
 
 * Ruby 1.8.7+
 * Rails 2.3+
-* Postgres 8.0+
+* PostgreSQL 8.0+
 * MySQL 5.0.10+
 * SQLite 3.3.8+
 

data/lib/hair_trigger/builder.rb

@@ -78,6 +78,7 @@ module HairTrigger
     end
 
     def of(*columns)
+      raise DeclarationError, "`of' requested, but no columns specified" unless columns.present?
       options[:of] = columns
     end
 
@@ -303,6 +304,12 @@ module HairTrigger
             "on(#{options[:table].inspect})"
           when :where
             "where(#{prepared_where.inspect})"
+          when :of
+            "of(#{options[:of].inspect[1..-2]})"
+          when :for_each
+            "for_each(#{options[:for_each].downcase.to_sym.inspect})"
+          when :declare
+            "declare(#{options[:declarations].inspect})"
           else
             "#{c}(#{options[c].inspect})"
         end

data/lib/hair_trigger/version.rb

@@ -1,5 +1,5 @@
 module HairTrigger
-  VERSION = "0.2.10"
+  VERSION = "0.2.11"
 
   def VERSION.<=>(other)
     split(/\./).map(&:to_i) <=> other.split(/\./).map(&:to_i)

data/spec/builder_spec.rb

@@ -184,6 +184,24 @@ describe "builder" do
         builder.on(:foos).after(:truncate){ "FOO" }.generate
       }.should raise_error
     end
+
+    describe "#to_ruby" do
+      it "should fully represent the builder" do
+        code = <<-CODE.strip.gsub(/^ +/, '')
+          on("foos").
+          security(:definer).
+          for_each(:row).
+          before(:update) do |t|
+            t.where("NEW.foo") do
+              "FOO;"
+            end
+          end
+        CODE
+        b = builder
+        b.instance_eval(code)
+        b.to_ruby.strip.gsub(/^ +/, '').should be_include(code)
+      end
+    end
   end
 
   context "postgresql" do
@@ -308,6 +326,25 @@ describe "builder" do
           should include("IF NEW.bar <> OLD.bar OR (NEW.bar IS NULL) <> (OLD.bar IS NULL) THEN")
       end
     end
+
+    describe "#to_ruby" do
+      it "should fully represent the builder" do
+        code = <<-CODE.strip.gsub(/^ +/, '')
+          on("foos").
+          of("bar").
+          security(:invoker).
+          for_each(:row).
+          before(:update) do |t|
+            t.where("NEW.foo").declare("row RECORD") do
+              "FOO;"
+            end
+          end
+        CODE
+        b = builder
+        b.instance_eval(code)
+        b.to_ruby.strip.gsub(/^ +/, '').should be_include(code)
+      end
+    end
   end
 
   context "sqlite" do
@@ -371,5 +408,22 @@ describe "builder" do
         builder.on(:foos).after(:truncate){ "FOO" }.generate
       }.should raise_error
     end
+
+    describe "#to_ruby" do
+      it "should fully represent the builder" do
+        code = <<-CODE.strip.gsub(/^ +/, '')
+          on("foos").
+          of("bar").
+          before(:update) do |t|
+            t.where("NEW.foo") do
+              "FOO;"
+            end
+          end
+        CODE
+        b = builder
+        b.instance_eval(code)
+        b.to_ruby.strip.gsub(/^ +/, '').should be_include(code)
+      end
+    end
   end
 end

data/spec/schema_dumper_spec.rb

@@ -46,7 +46,7 @@ describe "schema dumping" do
       end
     end
 
-    context "without schema.rb" do
+    context "with schema.rb" do
       before do
         ActiveRecord::SchemaDumper.previous_schema = dump_schema
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hairtrigger
 version: !ruby/object:Gem::Version
-  version: 0.2.10
+  version: 0.2.11
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-24 00:00:00.000000000 Z
+date: 2014-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -59,102 +59,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.0.6
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.14.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.14.0
-- !ruby/object:Gem::Dependency
-  name: mysql
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.9.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.9.1
-- !ruby/object:Gem::Dependency
-  name: mysql2
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 0.3.11
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 0.3.11
-- !ruby/object:Gem::Dependency
-  name: pg
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 0.15.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 0.15.1
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.3.7
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.3.7
 description: allows you to declare database triggers in ruby in your models, and then
   generate appropriate migrations as they change
 email: jenseng@gmail.com