hackernews 0.2.0 → 0.2.1

data/lib/hackernews.rb

@@ -4,7 +4,7 @@ require 'open-uri'
 
 class HackerNews
 
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 
   # Returns the version string for the library.
   def self.version
@@ -20,8 +20,13 @@ class HackerNews
   class LoginError < RuntimeError; end
   
   # Creates a new HackerNews object.
-  # Specify your username and password.
-  def initialize(username, password)
+  # If username and password are provided, login is called.
+  def initialize(username=nil, password=nil)
+    login(username, password) if username and password
+  end
+  
+  # Log into Hacker News with the specified username and password.
+  def login(username, password)
     login_url = get(BASE_URL).match(/href="([^"]+)">login<\/a>/)[1]
     form_html = get(BASE_URL + login_url)
     fnid = form_html.match(/<input type=hidden name="fnid" value="([^"]+)"/)[1]
@@ -38,8 +43,9 @@ class HackerNews
     user_page(username).match(/<td valign=top>karma\:<\/td><td>(\d+)<\/td>/)[1]
   end
   
-  # Retrieves the average karma per post for the logged in user.
+  # Retrieves the average karma per post for the logged in user (must be logged in).
   def average_karma
+    require_login!
     user_page.match(/<td valign=top>avg:<\/td><td>([\d\.]+)<\/td>/)[1]
   end
   
@@ -52,14 +58,16 @@ class HackerNews
     end
   end
   
-  # Up-vote on a post or on a comment by passing in the id number.
+  # Up-vote a post or a comment by passing in the id number.
   def vote(id)
+    require_login!
     url = get(ITEM_URL % id).match(/<a id=up_\d+ onclick="return vote\(this\)" href="(vote\?[^"]+)">/)[1]
     get(BASE_URL + '/' + url)
   end
   
   # Post a comment on a posted item or on another comment.
   def comment(id, text)
+    require_login!
     fnid = get(ITEM_URL % id).match(/<input type=hidden name="fnid" value="([^"]+)"/)[1]
     post(COMMENT_SUBMIT_URL, 'fnid' => fnid, 'text' => text)
   end
@@ -96,5 +104,9 @@ class HackerNews
     def build_header
       @cookie && {'Cookie' => @cookie}
     end
+    
+    def require_login!
+      raise(LoginError, "You must log in to perform this action.") unless @cookie
+    end
 
 end

data/test/hackernews_test.rb

@@ -4,30 +4,39 @@ require File.dirname(__FILE__) + '/../lib/hackernews.rb'
 class HackerNewsTest < Test::Unit::TestCase
 
   def setup
-    if ENV['HN_USERNAME'] and ENV['HN_PASSWORD']
-      @hn = HackerNews.new(ENV['HN_USERNAME'], ENV['HN_PASSWORD'])
-    else
+    unless ENV['HN_USERNAME'] and ENV['HN_PASSWORD']
       puts 'Must set HN_USERNAME and HN_PASSWORD env variables before running.'
       exit(1)
     end
+    @hn = HackerNews.new
+  end
+  
+  def login
+    @hn.login(ENV['HN_USERNAME'], ENV['HN_PASSWORD'])
   end
 
   def test_session_cookie
+    login
     assert @hn.instance_eval('@cookie') =~ /user=[a-z0-9]+;/i
   end
   
   def test_login_failure
     assert_raise HackerNews::LoginError do
-      HackerNews.new('foobar00000', 'baz')
+      @hn.login('foobar00000', 'baz')
     end
   end
   
   def test_karma
-    assert @hn.karma.to_s != ''
     assert @hn.karma('pg').to_i > 59000
+    login
+    assert @hn.karma.to_s != ''
   end
   
   def test_average_karma
+    assert_raise HackerNews::LoginError do
+      @hn.average_karma
+    end
+    login
     assert @hn.average_karma.to_s != ''
   end
 

metadata

@@ -1,12 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: hackernews
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 2
-  - 0
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Tim Morgan
@@ -14,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-03 00:00:00 -06:00
+date: 2010-03-04 00:00:00 -06:00
 default_executable: 
 dependencies: []
 
@@ -43,20 +38,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Ruby gem to login and interact with the Hacker News website.