h8 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0d9eec220ddcefcec439cacbc06a3a1aa9df74a4
-  data.tar.gz: ff56274f0e8f976ea5afe8b35ed01259032330db
+  metadata.gz: c54c93dc0687b6b01be98f4eeeebd6ea57143214
+  data.tar.gz: ecae54d59be0a790345400f28f83efa9f35e6bb4
 SHA512:
-  metadata.gz: 43eecac7e09f262bddbcb68fe49717c82f27778205bc2b6aa2bb0808b1ea6bc2131c7bdb3d808253a7a35134ff8da9c7cb5d92d190b86f6f46b5e39388782f1d
-  data.tar.gz: 9741491ec26a3698b9a431624c4726db9989afa6ece6e09773eec14a7dcc711ca1fd9163467cc27e27ce2a947daa3af74713f99e17edc6407793a956c965e0ac
+  metadata.gz: 2c8cb7c8dc08fdc48b72900b57828661a5f36ea89620bbdbc99c80d2b75eec6759ae8349ac47eee2af01e4db3d93134da8c2c111843362db5970252b0abfd3e2
+  data.tar.gz: dcb9671dc11cd23d924e27686fb653703378143c681e9a4b379ab9a176b1e8f78651eb52996f6da2b0175341707edf8d720a8a9ea45c1d26b4a84bb15b44a701

data/README.md

@@ -3,6 +3,10 @@
 _Warning_ this gem is a public beta at the moment - beta testers are welcome!It means, it is not
 yet production stable - we haven't yet tried.
 
+_Current implementation is somewhat slower than it could by the price of letting ruby threads
+and javascript codes in different H8::Context instances run in parallel in multicore hardware_.
+Let me know whether it worth degraded performance on ruby-to-js and back calls.
+
 This gem was intended to replace therubyracer for many reasons:
 
 * therubyracer has critical bugs that are not fixed for a long time, under load it produces
@@ -37,10 +41,14 @@ uncaught javascript exceptions raise ruby error in ruby code.
 
 - Integrated CoffeeScript support
 
-- H8 is thread safe (using Lockers) and releases gvl when executing js code (and reqcquires it as
-need), thus other ruby threads can work in parallel with javascript executing threads. Still,
-h8 does not releases Locker when calling ruby code from javascript - for performance considerations.
+- H8 is thread safe. It releases gvl lock while executing ruby code and unlocks v8 isolate when
+calling ruby code thus allow maximum possibile parallel execution of ruby and javascript code
+in separate threads.
 
+Due to v8 and ruby MRI limitations, only one ruby thread can access any given H8::Context (e.g.
+execute javascript code in it), and, as usual, all ruby threads are locked by a single mitex (gvl).
+Still, having multiple H8::Context in different ruby threads let you run java/coffee scripts in
+parallel - what you can not have with pure MRI ruby!
 
 ## Main difference from therubyracer/features not ready
 

data/ext/h8/h8.h

@@ -6,7 +6,7 @@
 #include <iostream>
 #include <exception>
 #include "allocated_resource.h"
-#include "JsCatcher.h"
+#include "js_catcher.h"
 
 using namespace v8;
 using namespace std;

data/ext/h8/{JsCatcher.cpp → js_catcher.cpp}

@@ -5,7 +5,7 @@
  *      Author: sergeych
  */
 
-#include "JsCatcher.h"
+#include "js_catcher.h"
 
 namespace h8 {
 

data/ext/h8/js_gate.cpp

@@ -1,5 +1,5 @@
 #include "h8.h"
-#include "JsCatcher.h"
+#include "js_catcher.h"
 #include <ruby/thread.h>
 
 using namespace h8;

data/ext/h8/ruby_gate.cpp

@@ -13,16 +13,14 @@ static void* unblock_caller(void *param) {
 	return NULL;
 }
 
-static void with_gvl(RubyGate *gate,
-		const std::function<void(void)> &block) {
+static void with_gvl(RubyGate *gate, const std::function<void(void)> &block) {
 //	v8::Unlocker unlock(gate->isolate());
 	H8 *h8 = gate->getH8();
 	if (h8->isGvlReleased()) {
 		h8->setGvlReleased(false);
 		rb_thread_call_with_gvl(unblock_caller, (void*) &block);
 		h8->setGvlReleased(true);
-	}
-	else
+	} else
 		block();
 }
 
@@ -107,10 +105,14 @@ void h8::RubyGate::throw_js() {
 
 void h8::RubyGate::rescued_call(VALUE rb_args, VALUE (*call)(VALUE),
 		const std::function<void(VALUE)> &block) {
-	last_ruby_error = Qnil;
-	VALUE me = Data_Wrap_Struct(ruby_gate_class, 0, 0, this);
-	VALUE res = rb_rescue((ruby_method) (call), rb_args,
-			(ruby_method) (rescue_callback), me);
+	VALUE res;
+	{
+		Unlocker u(context->getIsolate());
+		last_ruby_error = Qnil;
+		VALUE me = Data_Wrap_Struct(ruby_gate_class, 0, 0, this);
+		res = rb_rescue((ruby_method) (call), rb_args,
+				(ruby_method) (rescue_callback), me);
+	}
 	if (last_ruby_error == Qnil)
 		block(res);
 	else

data/lib/h8/version.rb

@@ -1,3 +1,3 @@
 module H8
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/context_spec.rb

@@ -96,28 +96,27 @@ describe 'context' do
 
   it 'should work in many threads' do
     # pending
-    sum      = 0
+    sum   = 0
     mutex = Mutex.new
-    valid    = 0
-    n        = 10
-    tt = []
+    valid = 0
+    n     = 10
+    tt    = []
     n.times { |n|
-      cxt = nil
       t = Thread.start {
         cxt = H8::Context.new
+        tt << OpenStruct.new({ thread: t, number: n, context: cxt })
         cxt[:array] = 100024.times.map { |x| x*(n+1) }
         cxt[:n]     = n+1
         mutex.synchronize {
           valid += (n+1)*100 + 10
-          sum         += cxt.eval('result = array[100] + 10')
+          sum   += cxt.eval('result = array[100] + 10')
         }
-        tt << OpenStruct.new({ thread: t, number: n, context: cxt })
       }
     }
-    tt.each{ |x| x.thread.join }
-    mutex.synchronize {
-      sum.should == valid
-    }
+    tt.each { |x| x.thread.join }
+    # mutex.synchronize {
+    sum.should == valid
+    # }
     GC.start
     # Cross-thread access
     tt.each { |x|

data/spec/threading_spec.rb

@@ -18,7 +18,7 @@ describe 'threading' do
     @context[:end] = @end_time
   end
 
-  it 'without tout: should run JS/ruby threads in parallel' do
+  it 'should run JS/ruby threads in parallel' do
     cnt2 = 0
     Thread.start {
       cnt2 += 1 while Time.now.to_i < @end_time

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: h8
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - sergeych
@@ -86,13 +86,13 @@ files:
 - ext/.DS_Store
 - ext/h8/.cproject
 - ext/h8/.project
-- ext/h8/JsCatcher.cpp
-- ext/h8/JsCatcher.h
 - ext/h8/allocated_resource.h
 - ext/h8/chain.h
 - ext/h8/extconf.rb
 - ext/h8/h8.cpp
 - ext/h8/h8.h
+- ext/h8/js_catcher.cpp
+- ext/h8/js_catcher.h
 - ext/h8/js_gate.cpp
 - ext/h8/js_gate.h
 - ext/h8/main.cpp