gxapi_rails 0.0.6 → 0.1.0

data/spec/helpers/gxapi_helper_spec.rb

@@ -5,17 +5,17 @@ describe GxapiHelper do
   context "#gxapi_variant_name" do
 
     it "returns default if the variable is not set" do
-      helper.gxapi_variant_name.should eql "default"
+      expect(helper.gxapi_variant_name).to eql "default"
     end
 
     it "returns the name of the vairant if it is set" do
       assign(:variant, stub(:value => stub(:name => "x")))
-      helper.gxapi_variant_name.should eql("x")
+      expect(helper.gxapi_variant_name).to eql("x")
     end
 
     it "handles different vairant names" do
       assign(:variantx, stub(:value => stub(:name => "x")))
-      helper.gxapi_variant_name(:variantx).should eql("x")
+      expect(helper.gxapi_variant_name(:variantx)).to eql("x")
     end
 
   end
@@ -42,22 +42,22 @@ describe GxapiHelper do
 
         ret = helper.gxapi_experiment_js + helper.gxapi_experiment_js
 
-        ret.scan(/google\-analytics\.com/).length.should eql(1)
-        ret.scan(/setChosenVariation/).length.should eql(2)
+        expect(ret.scan(/google\-analytics\.com/).length).to eql(1)
+        expect(ret.scan(/setChosenVariation/).length).to eql(2)
 
       end
 
       it "should add the domain if an option is passed" do
         ret = helper.gxapi_experiment_js(:domain => ".example.com")
-        ret.should =~ /setDomainName/
+        expect(ret).to match(/setDomainName/)
       end
 
     end
 
     it "should not do anything if the instance var is not defined" do
-      helper.gxapi_experiment_js.should eql("")
+      expect(helper.gxapi_experiment_js).to eql("")
     end
 
   end
 
-end
+end

data/spec/lib/gxapi/base_spec.rb

@@ -23,18 +23,42 @@ describe Gxapi::Base do
     "lj5s_ZvWSJSZLphnkpP-Xw"
   end
 
+  let(:stub_experiments) do
+    Gxapi::Ostruct.new({
+      id: test_experiment_id,
+      name: test_experiment_name,
+      traffic_coverage: 1.0,
+      variations: [
+        Gxapi::Ostruct.new(
+          name: 'original',
+          weight: 0.5,
+          status: 'ACTIVE'
+        ),
+        Gxapi::Ostruct.new(
+          name: 'variant1',
+          weight: 0.5,
+          status: 'ACTIVE'
+        )
+      ]
+    })
+  end
+
   context "#env" do
     it "should delegate to its class" do
-      subject.env.should eql Gxapi.env
+      expect(subject.env).to eql Gxapi.env
     end
   end
 
+  before(:each) do
+    Gxapi::GoogleAnalytics.any_instance.stubs(:get_experiment).returns(stub_experiments)
+  end
+
   context "#get_variant" do
 
     it "should make a call to Google Analytics and return a future" do
       variant = subject.get_variant(test_experiment_name)
-      valid_variants.should include variant.value.name
-      [0, 1].should include variant.value.index
+      expect(valid_variants).to include variant.value.name
+      expect([0, 1]).to include variant.value.index
     end
 
     it "should set a key in the rails cache for a given
@@ -44,7 +68,7 @@ describe Gxapi::Base do
       variant.value
 
       cache_key = "#{user_key}_untitled_experiment"
-      Gxapi.cache.read(cache_key).should have_key("index")
+      expect(Gxapi.cache.read(cache_key)).to include("index")
 
     end
 
@@ -63,17 +87,17 @@ describe Gxapi::Base do
       variant = subject.get_variant(test_experiment_name)
 
       # make sure we return the default value
-      variant.value.name.should eql("default")
-      (Time.now - start_time).should be < 2.5
+      expect(variant.value.name).to eql("default")
+      expect(Time.now - start_time).to be < 2.5
     end
 
     it "should allow a user to override the chosen variant" do
 
       variant = subject.get_variant(test_experiment_name, "fakeval")
 
-      variant.value.experiment_id.should be_nil
-      variant.value.name.should eql("fakeval")
-      variant.value.index.should eql -1
+      expect(variant.value.experiment_id).to be_nil
+      expect(variant.value.name).to eql("fakeval")
+      expect(variant.value.index).to eql -1
 
     end
 
@@ -84,8 +108,8 @@ describe Gxapi::Base do
   context "#user_key" do
 
     it "should set up its user_key" do
-      subject.user_key.should eql user_key
+      expect(subject.user_key).to eql user_key
     end
 
   end
-end
+end

data/spec/lib/gxapi/experiment_identifier_spec.rb

@@ -35,7 +35,7 @@ module GxApi
 
         it 'matches by id' do
           experiment = stub(id: id)
-          expect(subject.matches_experiment?(experiment)).to be_true
+          expect(subject.matches_experiment?(experiment)).to be_truthy
         end
 
       end
@@ -67,7 +67,7 @@ module GxApi
 
         it 'matches by name' do
           experiment = stub(name: name)
-          expect(subject.matches_experiment?(experiment)).to be_true
+          expect(subject.matches_experiment?(experiment)).to be_truthy
         end
 
       end
@@ -84,4 +84,4 @@ module GxApi
 
   end
 
-end
+end

data/spec/lib/gxapi/google_analytics_spec.rb

@@ -6,66 +6,153 @@ module Gxapi
 
     before(:each) do
       Gxapi.cache.clear
+      stub_request(:post, /.*accounts.google.com\/o\/oauth2\/token/)
+        .to_return(
+          status: 200,
+          body: JSON.unparse({ access_token: 'foo' }),
+          headers: { 'Content-Type' => 'application/json'}
+        )
+      stub_request(:get, /discovery\/v1\/apis\/analytics\/v3\/rest/)
+        .to_return(File.new("spec/fixtures/analytics_discovery.json"))
     end
 
     context "#get_experiments" do
+      before do
+        stub_request(:get, /googleapis.*experiments/)
+          .to_return(
+            status: 200,
+            body: JSON.unparse(
+              data: {
+                items: [
+                  {
+                    id: "123",
+                    name: "exp1",
+                    traffic_coverage: 1.0,
+                    variations: []
+                  },
+                  {
+                    id: "234",
+                    name: "exp2",
+                    traffic_coverage: 1.0,
+                    variations: []
+                  }
+                ]
+              }
+            ),
+            headers: { 'Content-Type' => 'application/json' }
+          )
+      end
 
       it "gets a list of experiments" do
         experiments = subject.get_experiments
-        experiments.first.should be_a(Gxapi::Ostruct)
+        expect(experiments.first).to be_a(Gxapi::Ostruct)
       end
 
     end
 
     context "#get_experiment" do
+      before do
+        stub_request(:get, /googleapis.*experiments/)
+          .to_return(
+            status: 200,
+            body: JSON.unparse(
+              data: {
+                items: [
+                  {
+                    id: "123",
+                    name: "exp1",
+                    traffic_coverage: 1.0,
+                    variations: []
+                  },
+                  {
+                    id: "234",
+                    name: "exp2",
+                    traffic_coverage: 1.0,
+                    variations: []
+                  }
+                ]
+              }
+            ),
+            headers: { 'Content-Type' => 'application/json' }
+          )
+      end
 
       it "should filter by name" do
         experiment = subject.get_experiments.first
         identifier = GxApi::ExperimentIdentifier.new(experiment.name)
-        subject.get_experiment(identifier).should eql(experiment)
+        expect(subject.get_experiment(identifier)).to eql(experiment)
       end
 
     end
 
     context "#get_variant" do
 
-      before(:each) do
-        subject.stubs(
-          get_experiment: Ostruct.new({
-            id: "123",
-            name: "X",
-            traffic_coverage: 1.0,
-            variations: [
-              Ostruct.new(
-                name: "original",
-                weight: 0.5,
-                status: "ACTIVE"
-              ),
-              Ostruct.new(
-                name: "variation1",
-                weight: 0.5,
-                status: "ACTIVE"
-              )
-            ]
-          })
-        )
+      before do
+        stub_request(:get, /googleapis.*experiments/)
+          .to_return(
+            status: 200,
+            body: JSON.unparse(
+              data: {
+                items: [
+                  {
+                    id: "234",
+                    name: "fakename",
+                    traffic_coverage: 1.0,
+                    variations: [
+                      {
+                        name: "original",
+                        weight: 0.5,
+                        status: "ACTIVE"
+                      },
+                      {
+                        name: "variation1",
+                        weight: 0.5,
+                        status: "ACTIVE"
+                      }
+                    ]
+                  },
+                  {
+                    id: "456",
+                    name: "zerocoverage",
+                    traffic_coverage: 0.0,
+                    variations: [
+                      {
+                        name: "original",
+                        weight: 0.5,
+                        status: "ACTIVE"
+                      },
+                      {
+                        name: "variation1",
+                        weight: 0.5,
+                        status: "ACTIVE"
+                      }
+                    ]
+                  }
+                ]
+              }
+            ),
+            headers: { 'Content-Type' => 'application/json' }
+          )
       end
 
-      it "should return a variant determined by weight" do
-        variant = subject.get_variant("fakename")
-        ["original", "variation1"].should include variant.name
-        [0, 1].should include variant.index
+      it "returns a variant determined by weight" do
+        variant = subject.get_variant(
+          GxApi::ExperimentIdentifier.new("fakename")
+        )
+        expect(["original", "variation1"]).to include variant.name
+        expect([0, 1]).to include variant.index
       end
 
       it "returns the default if traffic_coverage is 0" do
-        subject.get_experiment.stubs(traffic_coverage: 0)
-        variant = subject.get_variant("fakename")
-        variant.name.should eql("default")
-        variant.index.should eql(-1)
+        variant = subject.get_variant(
+          GxApi::ExperimentIdentifier.new("zerocoverage")
+        )
+        expect(variant.name).to eql("default")
+        expect(variant.index).to eql(-1)
       end
 
     end
 
   end
 
-end
+end

data/spec/lib/gxapi_spec.rb

@@ -11,19 +11,19 @@ describe Gxapi do
 
   context ".cache" do
     it "should have a cache that gets defined by default" do
-      Gxapi.cache.should be_kind_of(ActiveSupport::Cache::Store)
+      expect(Gxapi.cache).to be_kind_of(ActiveSupport::Cache::Store)
     end
 
     context "with Rails" do
 
       it "should use the Rails cache once it is available" do
-        Gxapi.cache.should be Rails.cache
+        expect(Gxapi.cache).to be Rails.cache
       end
 
       it "should still allow you to override the cache" do
         my_cache = stub()
         Gxapi.cache = my_cache
-        Gxapi.cache.should eql(my_cache)
+        expect(Gxapi.cache).to eql(my_cache)
       end
 
     end

data/spec/spec_helper.rb

@@ -4,7 +4,11 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 ENV["RAILS_ENV"] ||= 'test'
 require File.expand_path("../../spec/dummy/config/environment", __FILE__)
 
-require 'debugger'
+if RUBY_VERSION.to_i >= 2
+  require 'byebug'
+else
+  require 'debugger'
+end
 
 require 'gxapi'
 
@@ -12,6 +16,7 @@ require 'rspec/rails'
 require 'capybara/rails'
 require 'rails/engine'
 require 'mocha/setup'
+require 'webmock/rspec'
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
@@ -22,8 +27,9 @@ Mocha::Configuration.prevent(:stubbing_non_existent_method)
 RSpec.configure do |config|
   config.mock_with :mocha
 
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
+  config.include Rails.application.routes.url_helpers
+  config.infer_spec_type_from_file_location!
 
   config.filter_run focus: true
 

metadata

@@ -1,195 +1,223 @@
 --- !ruby/object:Gem::Specification
 name: gxapi_rails
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Dan Langevin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-31 00:00:00.000000000 Z
+date: 2015-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: celluloid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: google-api-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coffee-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: debugger
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sass-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: test-unit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Google Analytics and integration
@@ -198,9 +226,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- LICENSE.txt
+- README.md
+- Rakefile
 - app/helpers/gxapi_helper.rb
 - lib/generators/gxapi/install_generator.rb
 - lib/generators/gxapi/templates/gxapi.yml
+- lib/gxapi-rails.rb
+- lib/gxapi.rb
 - lib/gxapi/base.rb
 - lib/gxapi/controller_methods.rb
 - lib/gxapi/engine.rb
@@ -208,13 +241,10 @@ files:
 - lib/gxapi/google_analytics.rb
 - lib/gxapi/ostruct.rb
 - lib/gxapi/version.rb
-- lib/gxapi-rails.rb
-- lib/gxapi.rb
 - lib/gxapi_rails.rb
 - lib/tasks/gxapi.rake
-- LICENSE.txt
-- Rakefile
-- README.md
+- spec/dummy/README.rdoc
+- spec/dummy/Rakefile
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
@@ -228,6 +258,7 @@ files:
 - spec/dummy/app/views/posts/index.html.erb
 - spec/dummy/app/views/posts/new.html.erb
 - spec/dummy/app/views/posts/show.html.erb
+- spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
 - spec/dummy/config/database.yml
@@ -251,21 +282,19 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/test.p12
-- spec/dummy/config.ru
 - spec/dummy/data/log/dummy/development.log
 - spec/dummy/data/log/dummy/test.log
 - spec/dummy/db/development.sqlite3
 - spec/dummy/db/test.sqlite3
-- spec/dummy/log/development.log
 - spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
-- spec/dummy/Rakefile
-- spec/dummy/README.rdoc
 - spec/dummy/script/rails
+- spec/dummy/tmp/cache/D9A/F00/gxapi-google-analytics-experiments
 - spec/features/display_variant_js_spec.rb
+- spec/fixtures/analytics_discovery.json
 - spec/helpers/gxapi_helper_spec.rb
 - spec/lib/gxapi/base_spec.rb
 - spec/lib/gxapi/experiment_identifier_spec.rb
@@ -281,17 +310,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Google Analytics
@@ -337,7 +366,6 @@ test_files:
 - spec/dummy/data/log/dummy/test.log
 - spec/dummy/db/development.sqlite3
 - spec/dummy/db/test.sqlite3
-- spec/dummy/log/development.log
 - spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
@@ -346,7 +374,9 @@ test_files:
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
 - spec/dummy/script/rails
+- spec/dummy/tmp/cache/D9A/F00/gxapi-google-analytics-experiments
 - spec/features/display_variant_js_spec.rb
+- spec/fixtures/analytics_discovery.json
 - spec/helpers/gxapi_helper_spec.rb
 - spec/lib/gxapi/base_spec.rb
 - spec/lib/gxapi/experiment_identifier_spec.rb