gxapi_rails 0.0.4 → 0.0.5

data/spec/lib/gxapi/base_spec.rb

@@ -19,6 +19,10 @@ describe Gxapi::Base do
     "Untitled experiment"
   end
 
+  let(:test_experiment_id) do
+    "lj5s_ZvWSJSZLphnkpP-Xw"
+  end
+
   context "#env" do
     it "should delegate to its class" do
       subject.env.should eql Gxapi.env
@@ -27,7 +31,7 @@ describe Gxapi::Base do
 
   context "#get_variant" do
 
-    it "should make a call to myna and return a future" do
+    it "should make a call to Google Analytics and return a future" do
       variant = subject.get_variant(test_experiment_name)
       valid_variants.should include variant.value.name
       [0, 1].should include variant.value.index
@@ -44,6 +48,13 @@ describe Gxapi::Base do
 
     end
 
+    it "lets us search by experiment id" do
+
+      variant = subject.get_variant(id: test_experiment_id)
+      expect(variant.value.experiment_id).to eql(test_experiment_id)
+
+    end
+
     it "should time out after 2 seconds and return the default value" do
 
       Gxapi.cache.stubs(:fetch).yields{sleep(3)}

data/spec/lib/gxapi/experiment_identifier_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+
+module GxApi
+
+  describe ExperimentIdentifier do
+
+    subject {
+      ExperimentIdentifier.new("Test Test")
+    }
+
+    context "Generic Methods" do
+
+      context "#to_key" do
+
+        it "turns its value into a string for a cache key" do
+          expect(subject.to_key).to eql("test_test")
+        end
+
+      end
+
+    end
+
+
+    context "IdIdentifier" do
+
+      subject {
+        ExperimentIdentifier.new(id: id)
+      }
+
+      let(:id) {
+        "123"
+      }
+
+      context '#matches_experiment?' do
+
+        it 'matches by id' do
+          experiment = stub(id: id)
+          expect(subject.matches_experiment?(experiment)).to be_true
+        end
+
+      end
+
+      context '#value' do
+
+        it 'returns the id as its value' do
+          expect(subject.value).to eq(id)
+        end
+
+      end
+
+
+
+    end
+
+
+    context "NameIdentifier" do
+
+      subject {
+        ExperimentIdentifier.new(name)
+      }
+
+      let(:name) {
+        "123"
+      }
+
+      context '#matches_experiment?' do
+
+        it 'matches by name' do
+          experiment = stub(name: name)
+          expect(subject.matches_experiment?(experiment)).to be_true
+        end
+
+      end
+
+      context '#value' do
+
+        it 'returns the id as its value' do
+          expect(subject.value).to eq(name)
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/spec/lib/gxapi/google_analytics_spec.rb

@@ -21,7 +21,8 @@ module Gxapi
 
       it "should filter by name" do
         experiment = subject.get_experiments.first
-        subject.get_experiment(experiment.name).should eql(experiment)
+        identifier = GxApi::ExperimentIdentifier.new(experiment.name)
+        subject.get_experiment(identifier).should eql(experiment)
       end
 
     end

data/spec/spec_helper.rb

@@ -4,6 +4,8 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 ENV["RAILS_ENV"] ||= 'test'
 require File.expand_path("../../spec/dummy/config/environment", __FILE__)
 
+require 'debugger'
+
 require 'gxapi'
 
 require 'rspec/rails'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gxapi_rails
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Dan Langevin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-03 00:00:00.000000000 Z
+date: 2014-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -80,6 +80,118 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coffee-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: debugger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sass-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Google Analytics and integration
 email: dan.langevin@lifebooker.com
 executables: []
@@ -92,10 +204,13 @@ files:
 - lib/gxapi/base.rb
 - lib/gxapi/controller_methods.rb
 - lib/gxapi/engine.rb
+- lib/gxapi/experiment_identifier.rb
 - lib/gxapi/google_analytics.rb
 - lib/gxapi/ostruct.rb
 - lib/gxapi/version.rb
+- lib/gxapi-rails.rb
 - lib/gxapi.rb
+- lib/gxapi_rails.rb
 - lib/tasks/gxapi.rake
 - LICENSE.txt
 - Rakefile
@@ -153,6 +268,7 @@ files:
 - spec/features/display_variant_js_spec.rb
 - spec/helpers/gxapi_helper_spec.rb
 - spec/lib/gxapi/base_spec.rb
+- spec/lib/gxapi/experiment_identifier_spec.rb
 - spec/lib/gxapi/google_analytics_spec.rb
 - spec/lib/gxapi_spec.rb
 - spec/spec_helper.rb
@@ -233,6 +349,7 @@ test_files:
 - spec/features/display_variant_js_spec.rb
 - spec/helpers/gxapi_helper_spec.rb
 - spec/lib/gxapi/base_spec.rb
+- spec/lib/gxapi/experiment_identifier_spec.rb
 - spec/lib/gxapi/google_analytics_spec.rb
 - spec/lib/gxapi_spec.rb
 - spec/spec_helper.rb